X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fdbus-common.c;h=69593cd183312cf123167f56d8e67dac0cc55e61;hp=504eefbbb0b3e00fc6a917dd4de75fd413268839;hb=415dbd2e542e7a0f6b15350e1c5fd00dca54b91d;hpb=9a1ac7b9ae2fb218170d1bd106d5351a76d03a95 diff --git a/src/dbus-common.c b/src/dbus-common.c index 504eefbbb..69593cd18 100644 --- a/src/dbus-common.c +++ b/src/dbus-common.c @@ -1,4 +1,4 @@ -/*-*- Mode: C; c-basic-offset: 8 -*-*/ +/*-*- Mode: C; c-basic-offset: 8; indent-tabs-mode: nil -*-*/ /*** This file is part of systemd. @@ -54,7 +54,7 @@ int bus_check_peercred(DBusConnection *c) { return 1; } -int bus_connect(DBusBusType t, DBusConnection **_bus, DBusError *error) { +int bus_connect(DBusBusType t, DBusConnection **_bus, bool *private, DBusError *error) { DBusConnection *bus; assert(_bus); @@ -62,7 +62,7 @@ int bus_connect(DBusBusType t, DBusConnection **_bus, DBusError *error) { /* If we are root, then let's not go via the bus */ if (geteuid() == 0 && t == DBUS_BUS_SYSTEM) { - if (!(bus = dbus_connection_open("unix:abstract=/org/freedesktop/systemd1/private", error))) + if (!(bus = dbus_connection_open_private("unix:abstract=/org/freedesktop/systemd1/private", error))) return -EIO; if (bus_check_peercred(bus) < 0) { @@ -71,9 +71,16 @@ int bus_connect(DBusBusType t, DBusConnection **_bus, DBusError *error) { dbus_set_error_const(error, DBUS_ERROR_ACCESS_DENIED, "Failed to verify owner of bus."); return -EACCES; } + + if (private) + *private = true; + } else { - if (!(bus = dbus_bus_get(t, error))) + if (!(bus = dbus_bus_get_private(t, error))) return -EIO; + + if (private) + *private = false; } dbus_connection_set_exit_on_disconnect(bus, FALSE); @@ -81,3 +88,14 @@ int bus_connect(DBusBusType t, DBusConnection **_bus, DBusError *error) { *_bus = bus; return 0; } + +const char *bus_error_message(const DBusError *error) { + assert(error); + + /* Sometimes the D-Bus server is a little bit too verbose with + * its error messages, so let's override them here */ + if (dbus_error_has_name(error, DBUS_ERROR_ACCESS_DENIED)) + return "Access denied"; + + return error->message; +}