X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fcgroups-agent.c;h=3fd0de698fb0719697570fddd5b709e4c3d78b9d;hp=30aeede943d553491422fadaed7752d755209b95;hb=e04aad61bb5eff117e51631727a3ef2807c75d6b;hpb=5d452f9ceceabf2bf69acb58e69a41fb41011e37 diff --git a/src/cgroups-agent.c b/src/cgroups-agent.c index 30aeede94..3fd0de698 100644 --- a/src/cgroups-agent.c +++ b/src/cgroups-agent.c @@ -43,22 +43,20 @@ int main(int argc, char *argv[]) { log_parse_environment(); log_open(); - /* If possible we go via the system bus, to make sure that - * session instances get the messages. If not possible we talk - * to the system instance directly. */ - if (!(bus = dbus_bus_get_private(DBUS_BUS_SYSTEM, &error))) { - - dbus_error_free(&error); - - if (!(bus = dbus_connection_open_private("unix:abstract=/org/freedesktop/systemd1/private", &error))) { - log_error("Failed to get D-Bus connection: %s", bus_error_message(&error)); - goto finish; - } - - if (bus_check_peercred(bus) < 0) { - log_error("Bus owner not root."); - goto finish; - } + + /* We send this event to the private D-Bus socket and then the + * system instance will forward this to the system bus. We do + * this to avoid an actviation loop when we start dbus when we + * are called when the dbus service is shut down. */ + + if (!(bus = dbus_connection_open_private("unix:abstract=/org/freedesktop/systemd1/private", &error))) { + log_error("Failed to get D-Bus connection: %s", bus_error_message(&error)); + goto finish; + } + + if (bus_check_peercred(bus) < 0) { + log_error("Bus owner not root."); + goto finish; } if (!(m = dbus_message_new_signal("/org/freedesktop/systemd1/agent", "org.freedesktop.systemd1.Agent", "Released"))) { @@ -74,7 +72,7 @@ int main(int argc, char *argv[]) { } if (!dbus_connection_send(bus, m, NULL)) { - log_error("Failed to send signal message."); + log_error("Failed to send signal message on private connection."); goto finish; } @@ -87,6 +85,7 @@ finish: dbus_connection_unref(bus); } + if (m) dbus_message_unref(m);