X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fcgroup.c;h=4bbb54fd7e41a17f96ea8f3b651cc43aa8e5f089;hp=0005a4fb67cae9bef98466a9c4234d598a4db305;hb=bf96736674b8d898e2262a9f429e93b3bb153fa2;hpb=ab1f063390f55e14a8de87f21c4fad199eb908a6 diff --git a/src/cgroup.c b/src/cgroup.c index 0005a4fb6..4bbb54fd7 100644 --- a/src/cgroup.c +++ b/src/cgroup.c @@ -38,9 +38,6 @@ int cgroup_bonding_realize(CGroupBonding *b) { assert(b->path); assert(b->controller); - if (b->realized) - return 0; - r = cg_create(b->controller, b->path); if (r < 0) { log_warning("Failed to create cgroup %s:%s: %s", b->controller, b->path, strerror(-r)); @@ -270,7 +267,7 @@ int manager_setup_cgroup(Manager *m) { assert(m); /* 0. Be nice to Ingo Molnar #628004 */ - if (path_is_mount_point("/sys/fs/cgroup/systemd") <= 0) { + if (path_is_mount_point("/sys/fs/cgroup/systemd", false) <= 0) { log_warning("No control group support available, not creating root group."); return 0; } @@ -366,7 +363,8 @@ int cgroup_notify_empty(Manager *m, const char *group) { assert(m); assert(group); - if (!(l = hashmap_get(m->cgroup_bondings, group))) + l = hashmap_get(m->cgroup_bondings, group); + if (!l) return 0; LIST_FOREACH(by_path, b, l) { @@ -375,7 +373,8 @@ int cgroup_notify_empty(Manager *m, const char *group) { if (!b->unit) continue; - if ((t = cgroup_bonding_is_empty_list(b)) < 0) { + t = cgroup_bonding_is_empty_list(b); + if (t < 0) { /* If we don't know, we don't know */ if (t != -EAGAIN) @@ -384,9 +383,13 @@ int cgroup_notify_empty(Manager *m, const char *group) { continue; } - if (t > 0) + if (t > 0) { + /* If it is empty, let's delete it */ + cgroup_bonding_trim_list(b->unit->meta.cgroup_bondings, true); + if (UNIT_VTABLE(b->unit)->cgroup_notify_empty) UNIT_VTABLE(b->unit)->cgroup_notify_empty(b->unit); + } } return 0;