X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=src%2Fask-password-api.c;h=04d5623d9ee19597bf849de6a13c7c018d5b5dcf;hp=cb0559065d8ed4808ede95a3fd3d7e07d896823a;hb=ec2002f84928c0b5921a961cb2b8637563f29daa;hpb=58fc840b8325395d24ab70e84cb69880c6daa9ee

diff --git a/src/ask-password-api.c b/src/ask-password-api.c
index cb0559065..04d5623d9 100644
--- a/src/ask-password-api.c
+++ b/src/ask-password-api.c
@@ -61,6 +61,7 @@ int ask_password_tty(
         struct pollfd pollfd[2];
         bool reset_tty = false;
         bool silent_mode = false;
+        bool dirty = false;
         enum {
                 POLL_TTY,
                 POLL_INOTIFY
@@ -182,6 +183,17 @@ int ask_password_tty(
                                         backspace_chars(ttyfd, 1);
 
                                 p--;
+                        } else if (!dirty && !silent_mode) {
+
+                                silent_mode = true;
+
+                                /* There are two ways to enter silent
+                                 * mode. Either by pressing backspace
+                                 * as first key (and only as first key),
+                                 * or ... */
+                                if (ttyfd >= 0)
+                                        loop_write(ttyfd, "(no echo) ", 10, false);
+
                         } else if (ttyfd >= 0)
                                 loop_write(ttyfd, "\a", 1, false);
 
@@ -190,6 +202,8 @@ int ask_password_tty(
                         backspace_chars(ttyfd, p);
                         silent_mode = true;
 
+                        /* ... or by pressing TAB at any time. */
+
                         if (ttyfd >= 0)
                                 loop_write(ttyfd, "(no echo) ", 10, false);
                 } else {
@@ -197,6 +211,8 @@ int ask_password_tty(
 
                         if (!silent_mode && ttyfd >= 0)
                                 loop_write(ttyfd, "*", 1, false);
+
+                        dirty = true;
                 }
         }
 
@@ -388,13 +404,13 @@ int ask_password_agent(
 
                 t = now(CLOCK_MONOTONIC);
 
-                if (until <= t) {
+                if (until > 0 && until <= t) {
                         log_notice("Timed out");
                         r = -ETIME;
                         goto finish;
                 }
 
-                if ((k = poll(pollfd, _FD_MAX, (until-t)/USEC_PER_MSEC)) < 0) {
+                if ((k = poll(pollfd, _FD_MAX, until > 0 ? (int) ((until-t)/USEC_PER_MSEC) : -1)) < 0) {
 
                         if (errno == EINTR)
                                 continue;
@@ -465,7 +481,13 @@ int ask_password_agent(
                 if (passphrase[0] == '+') {
                         char **l;
 
-                        if (!(l = strv_parse_nulstr(passphrase+1, n-1))) {
+                        if (n == 1)
+                                l = strv_new("", NULL);
+                        else
+                                l = strv_parse_nulstr(passphrase+1, n-1);
+                                /* An empty message refers to the empty password */
+
+                        if (!l) {
                                 r = -ENOMEM;
                                 goto finish;
                         }