X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=load-dropin.c;h=2101e330046711706971155ec6d580ac18ababec;hp=a57bfc455be3d45b5a30f5b9e0c3b08ec214271b;hb=aa4112670b37f2ca1cd64a63337575d45e0d7f36;hpb=b952f2e17587167867f3564e06a6548dbd5c3d5a

diff --git a/load-dropin.c b/load-dropin.c
index a57bfc455..2101e3300 100644
--- a/load-dropin.c
+++ b/load-dropin.c
@@ -1,11 +1,70 @@
 /*-*- Mode: C; c-basic-offset: 8 -*-*/
 
+/***
+  This file is part of systemd.
+
+  Copyright 2010 Lennart Poettering
+
+  systemd is free software; you can redistribute it and/or modify it
+  under the terms of the GNU General Public License as published by
+  the Free Software Foundation; either version 2 of the License, or
+  (at your option) any later version.
+
+  systemd is distributed in the hope that it will be useful, but
+  WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+  General Public License for more details.
+
+  You should have received a copy of the GNU General Public License
+  along with systemd; If not, see <http://www.gnu.org/licenses/>.
+***/
+
 #include <dirent.h>
 #include <errno.h>
 
 #include "unit.h"
 #include "load-dropin.h"
 #include "log.h"
+#include "strv.h"
+#include "unit-name.h"
+
+static int iterate_dir(Unit *u, const char *path) {
+        DIR *d;
+        struct dirent *de;
+        int r;
+
+        if (!(d = opendir(path))) {
+
+                if (errno == ENOENT)
+                        return 0;
+
+                return -errno;
+        }
+
+        while ((de = readdir(d))) {
+                char *f;
+
+                if (ignore_file(de->d_name))
+                        continue;
+
+                if (asprintf(&f, "%s/%s", path, de->d_name) < 0) {
+                        r = -ENOMEM;
+                        goto finish;
+                }
+
+                r = unit_add_dependency_by_name(u, UNIT_WANTS, de->d_name, f, true);
+                free(f);
+
+                if (r < 0)
+                        goto finish;
+        }
+
+        r = 0;
+
+finish:
+        closedir(d);
+        return r;
+}
 
 int unit_load_dropin(Unit *u) {
         Iterator i;
@@ -18,61 +77,40 @@ int unit_load_dropin(Unit *u) {
 
         SET_FOREACH(t, u->meta.names, i) {
                 char *path;
-                DIR *d;
-                struct dirent *de;
-
-                if (asprintf(&path, "%s/%s.wants", unit_path(), t) < 0)
-                        return -ENOMEM;
-
-                if (!(d = opendir(path))) {
-                        r = -errno;
-                        free(path);
+                char **p;
 
-                        if (r == -ENOENT)
-                                continue;
+                STRV_FOREACH(p, u->meta.manager->unit_path) {
 
-                        return r;
-                }
+                        if (asprintf(&path, "%s/%s.wants", *p, t) < 0)
+                                return -ENOMEM;
 
-                free(path);
+                        r = iterate_dir(u, path);
+                        free(path);
 
-                while ((de = readdir(d))) {
-                        Unit *other;
+                        if (r < 0)
+                                return r;
 
-                        if (de->d_name[0] == '.')
-                                continue;
+                        if (u->meta.instance) {
+                                char *template;
+                                /* Also try the template dir */
 
-                        assert(de->d_name[0]);
+                                if (!(template = unit_name_template(t)))
+                                        return -ENOMEM;
 
-                        if (de->d_name[strlen(de->d_name)-1] == '~')
-                                continue;
+                                r = asprintf(&path, "%s/%s.wants", *p, template);
+                                free(template);
 
-                        if (asprintf(&path, "%s/%s.wants/%s", unit_path(), t, de->d_name) < 0) {
-                                closedir(d);
-                                return -ENOMEM;
-                        }
+                                if (r < 0)
+                                        return -ENOMEM;
 
-                        if (!unit_name_is_valid(de->d_name)) {
-                                log_info("Name of %s is not a valid unit name. Ignoring.", path);
+                                r = iterate_dir(u, path);
                                 free(path);
-                                continue;
-                        }
-
-                        r = manager_load_unit(u->meta.manager, path, &other);
-                        free(path);
 
-                        if (r < 0) {
-                                closedir(d);
-                                return r;
+                                if (r < 0)
+                                        return r;
                         }
 
-                        if ((r = unit_add_dependency(u, UNIT_WANTS, other)) < 0) {
-                                closedir(d);
-                                return r;
-                        }
                 }
-
-                closedir(d);
         }
 
         return 0;