X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=elogind.git;a=blobdiff_plain;f=CODING_STYLE;h=93f54f6edca9f66d675dd5f1a7e23804409bd185;hp=1b8c8cf3c6a3109bf63a36db123b7e824248c263;hb=967072694d4ebb1b7c5989b92aa71af48954a975;hpb=6091827530d6dd43479d6709fb6e9f745c11e900 diff --git a/CODING_STYLE b/CODING_STYLE index 1b8c8cf3c..93f54f6ed 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -11,6 +11,17 @@ - for robustness reasons destructors should be able to destruct half-initialized objects, too -- error codes are returned as negative Exxx. i.e. return EINVAL. There +- error codes are returned as negative Exxx. i.e. return -EINVAL. There are some exceptions: for constructors its is OK to return NULL on OOM. For lookup functions NULL is fine too for "not found". + +- Do not issue NSS requests (that includes user name and host name + lookups) from the main daemon as this might trigger deadlocks when + we those lookups involve synchronously talking to services that we + would need to start up. + +- Do not acccess any directories outside of /etc/, /dev, /lib from the + init daemon to avoid deadlocks with the automounter. + +- Don't synchronously talk to any other service, due to risk of + deadlocks.