chiark / gitweb /
Fix udevinfo for empty sysfs directories
[elogind.git] / udevinfo.c
index 08c25d3a047883029f25821759b166cca100ff73..69e5335b7cef9d26d099c72c8bf45adadac0c483 100644 (file)
@@ -3,7 +3,6 @@
  *
  * Copyright (C) 2004 Kay Sievers <kay.sievers@vrfy.org>
  *
- *
  *     This program is free software; you can redistribute it and/or modify it
  *     under the terms of the GNU General Public License as published by the
  *     Free Software Foundation version 2 of the License.
 #include <errno.h>
 
 #include "libsysfs/sysfs/libsysfs.h"
-#include "libsysfs/dlist.h"
+#include "udev_libc_wrapper.h"
 #include "udev.h"
-#include "udev_lib.h"
+#include "udev_utils.h"
 #include "udev_version.h"
 #include "udev_db.h"
 #include "logging.h"
 
 
-#define SYSFS_VALUE_SIZE               256
-
-#ifdef LOG
-unsigned char logname[LOGNAME_SIZE];
-void log_message (int level, const char *format, ...)
+#ifdef USE_LOG
+void log_message (int priority, const char *format, ...)
 {
        va_list args;
 
+       if (priority > udev_log_priority)
+               return;
+
        va_start(args, format);
-       vsyslog(level, format, args);
+       vsyslog(priority, format, args);
        va_end(args);
 }
 #endif
 
-static int print_all_attributes(const char *path)
+static void print_all_attributes(struct dlist *attr_list)
 {
-       struct dlist *attributes;
        struct sysfs_attribute *attr;
-       struct sysfs_directory *sysfs_dir;
-       char value[SYSFS_VALUE_SIZE];
-       int len;
-       int retval = 0;
+       char value[VALUE_SIZE];
+       size_t len;
 
-       sysfs_dir = sysfs_open_directory(path);
-       if (sysfs_dir == NULL)
-               return -1;
-
-       attributes = sysfs_get_dir_attributes(sysfs_dir);
-       if (attributes == NULL) {
-               retval = -1;
-               goto exit;
-       }
-
-       dlist_for_each_data(attributes, attr, struct sysfs_attribute) {
-               if (attr->value != NULL) {
-                       strfieldcpy(value, attr->value);
-                       len = strlen(value);
-                       if (len == 0)
-                               continue;
-
-                       /* remove trailing newline */
-                       if (value[len-1] == '\n') {
-                               value[len-1] = '\0';
-                               len--;
-                       }
+       dlist_for_each_data(attr_list, attr, struct sysfs_attribute) {
+               if (attr->value == NULL)
+                       continue;
+               len = strlcpy(value, attr->value, sizeof(value));
+               if (len >= sizeof(value)) {
+                       dbg("attribute value of '%s' too long, skip", attr->name);
+                       continue;
+               }
 
-                       /* skip nonprintable values */
-                       while (len) {
-                               if (isprint(value[len-1]) == 0)
-                                       break;
-                               len--;
-                       }
-                       if (len == 0)
-                               printf("    SYSFS{%s}=\"%s\"\n", attr->name, value);
+               /* remove trailing newlines */
+               while (len && value[len-1] == '\n')
+                       value[--len] = '\0';
+               /* skip nonprintable attributes */
+               while (len && isprint(value[len-1]))
+                       len--;
+               if (len) {
+                       dbg("attribute value of '%s' non-printable, skip", attr->name);
+                       continue;
                }
+               replace_untrusted_chars(value);
+               printf("    SYSFS{%s}==\"%s\"\n", attr->name, value);
        }
        printf("\n");
-
-exit:
-       sysfs_close_directory(sysfs_dir);
-
-       return retval;
 }
 
 static int print_record(struct udevice *udev)
 {
+       struct name_entry *name_loop;
+
        printf("P: %s\n", udev->devpath);
        printf("N: %s\n", udev->name);
-       printf("S: %s\n", udev->symlink);
-       printf("\n");
+       list_for_each_entry(name_loop, &udev->symlink_list, node)
+               printf("S: %s\n", name_loop->name);
+
        return 0;
 }
 
@@ -114,7 +97,7 @@ enum query_type {
        NAME,
        PATH,
        SYMLINK,
-       ALL
+       ALL,
 };
 
 static int print_device_chain(const char *path)
@@ -123,17 +106,13 @@ static int print_device_chain(const char *path)
        struct sysfs_class_device *class_dev_parent;
        struct sysfs_attribute *attr;
        struct sysfs_device *sysfs_dev;
-       struct sysfs_device *sysfs_dev_parent;
+       struct dlist *attr_list;
        int retval = 0;
-       char type;
-
-       type = get_device_type(path, "");
-       dbg("device type is %c", type);
 
        /*  get the class dev */
        class_dev = sysfs_open_class_device_path(path);
        if (class_dev == NULL) {
-               printf("couldn't get the class device\n");
+               fprintf(stderr, "couldn't get the class device\n");
                return -1;
        }
 
@@ -144,49 +123,49 @@ static int print_device_chain(const char *path)
               "to match the device for which the node will be created.\n"
               "\n");
 
-       if (type == 'b' || type =='c') {
-               /* read the 'dev' file for major/minor*/
-               attr = sysfs_get_classdev_attr(class_dev, "dev");
-               if (attr == NULL) {
-                       printf("couldn't get the \"dev\" file\n");
-                       retval = -1;
-                       goto exit;
-               }
+       /* look for the 'dev' file */
+       attr = sysfs_get_classdev_attr(class_dev, "dev");
+       if (attr != NULL)
                printf("device '%s' has major:minor %s", class_dev->path, attr->value);
-       }
 
        /* open sysfs class device directory and print all attributes */
        printf("  looking at class device '%s':\n", class_dev->path);
-       if (print_all_attributes(class_dev->path) != 0) {
-               printf("couldn't open class device directory\n");
+       printf("    SUBSYSTEM==\"%s\"\n", class_dev->classname);
+
+       attr_list = sysfs_get_classdev_attributes(class_dev);
+       if (attr_list == NULL) {
+               fprintf(stderr, "couldn't open class device directory\n");
                retval = -1;
                goto exit;
        }
+       print_all_attributes(attr_list);
 
        /* get the device link (if parent exists look here) */
        class_dev_parent = sysfs_get_classdev_parent(class_dev);
-       if (class_dev_parent != NULL) 
+       if (class_dev_parent != NULL)
                sysfs_dev = sysfs_get_classdev_device(class_dev_parent);
        else 
                sysfs_dev = sysfs_get_classdev_device(class_dev);
        
        if (sysfs_dev != NULL)
-               printf("follow the class device's \"device\"\n");
+               printf("follow the \"device\"-link to the physical device:\n");
 
        /* look the device chain upwards */
        while (sysfs_dev != NULL) {
                printf("  looking at the device chain at '%s':\n", sysfs_dev->path);
-               printf("    BUS=\"%s\"\n", sysfs_dev->bus);
-               printf("    ID=\"%s\"\n", sysfs_dev->bus_id);
-
-               /* open sysfs device directory and print all attributes */
-               print_all_attributes(sysfs_dev->path);
+               printf("    BUS==\"%s\"\n", sysfs_dev->bus);
+               printf("    ID==\"%s\"\n", sysfs_dev->bus_id);
+               printf("    DRIVER==\"%s\"\n", sysfs_dev->driver_name);
+
+               attr_list = sysfs_get_device_attributes(sysfs_dev);
+               if (attr_list != NULL)
+                       print_all_attributes(attr_list);
+               else
+                       printf("\n");
 
-               sysfs_dev_parent = sysfs_get_device_parent(sysfs_dev);
-               if (sysfs_dev_parent == NULL)
+               sysfs_dev = sysfs_get_device_parent(sysfs_dev);
+               if (sysfs_dev == NULL)
                        break;
-
-               sysfs_dev = sysfs_dev_parent;
        }
 
 exit:
@@ -194,80 +173,30 @@ exit:
        return retval;
 }
 
-/* print all class/main block devices with major/minor, physical device, driver and bus */
-static int print_sysfs_devices(void)
-{
-       struct dlist *subsyslist;
-       char *class;
-
-       subsyslist = sysfs_open_subsystem_list("class");
-       if (!subsyslist)
-               return -1;
-
-       dlist_for_each_data(subsyslist, class, char) {
-               struct sysfs_class *cls;
-               struct dlist *class_devices;
-               struct sysfs_class_device *class_dev;
-               struct sysfs_device *phys_dev;
-               struct sysfs_driver *driver;
-
-               cls = sysfs_open_class(class);
-               if (!cls)
-                       continue;
-
-               class_devices = sysfs_get_class_devices(cls);
-               if (!class_devices)
-                       continue;
-
-               dlist_for_each_data(class_devices, class_dev, struct sysfs_class_device) {
-                       struct sysfs_attribute *attr;
-
-                       printf("\n");
-                       printf("DEVPATH        '%s'\n", class_dev->path);
-                       printf("SUBSYSTEM      '%s'\n", class_dev->classname);
-
-                       attr = sysfs_get_classdev_attr(class_dev, "dev");
-                       if (attr) {
-                               char *pos = &(attr->value[strlen(attr->value)-1]);
-
-                               if  (pos[0] == '\n')
-                                       pos[0] = '\0';
-
-                               printf("DEVMAJORMINOR  '%s'\n", attr->value);
-                       }
-
-                       driver = sysfs_get_classdev_driver(class_dev);
-                       if (driver)
-                               printf("DEVDRIVER      '%s'\n", driver->name);
-
-                       phys_dev = sysfs_get_classdev_device(class_dev);
-                       if (phys_dev) {
-                               printf("PHYSDEVPATH    '%s'\n", phys_dev->path);
-                               if (phys_dev->bus[0] != '\0')
-                                       printf("PHYSDEVBUS     '%s'\n", phys_dev->bus);
-                       }
-               }
-               sysfs_close_class(cls);
-       }
-       sysfs_close_list(subsyslist);
-
+static int print_dump(const char *devpath, const char *name) {
+       printf("%s=%s/%s\n", devpath, udev_root, name);
        return 0;
 }
 
-static int process_options(int argc, char *argv[])
+int main(int argc, char *argv[], char *envp[])
 {
-       static const char short_options[] = "adn:p:q:rsVh";
+       static const char short_options[] = "adn:p:q:rVh";
        int option;
-       int retval = 1;
        struct udevice udev;
        int root = 0;
        int attributes = 0;
        enum query_type query = NONE;
-       char result[1024] = "";
-       char path[NAME_SIZE] = "";
-       char name[NAME_SIZE] = "";
-       char temp[NAME_SIZE];
+       char path[PATH_SIZE] = "";
+       char name[PATH_SIZE] = "";
+       char temp[PATH_SIZE];
+       struct name_entry *name_loop;
        char *pos;
+       int retval = 0;
+
+       logging_init("udevinfo");
+
+       udev_init_config();
+       udev_init_device(&udev, NULL, NULL, NULL);
 
        /* get command line options */
        while (1) {
@@ -279,12 +208,12 @@ static int process_options(int argc, char *argv[])
                switch (option) {
                case 'n':
                        dbg("udev name: %s\n", optarg);
-                       strfieldcpy(name, optarg);
+                       strlcpy(name, optarg, sizeof(name));
                        break;
 
                case 'p':
                        dbg("udev path: %s\n", optarg);
-                       strfieldcpy(path, optarg);
+                       strlcpy(path, optarg, sizeof(path));
                        break;
 
                case 'q':
@@ -310,27 +239,28 @@ static int process_options(int argc, char *argv[])
                                break;
                        }
 
-                       printf("unknown query type\n");
-                       exit(1);
+                       fprintf(stderr, "unknown query type\n");
+                       retval = 1;
+                       goto exit;
 
                case 'r':
                        root = 1;
                        break;
 
-               case 's':
-                       print_sysfs_devices();
-                       exit(0);
-
                case 'a':
                        attributes = 1;
                        break;
 
+               case 'd':
+                       udev_db_dump_names(print_dump);
+                       goto exit;
+
                case 'V':
                        printf("udevinfo, version %s\n", UDEV_VERSION);
-                       exit(0);
+                       goto exit;
 
                case 'h':
-                       retval = 0;
+                       retval = 2;
                case '?':
                default:
                        goto help;
@@ -346,114 +276,99 @@ static int process_options(int argc, char *argv[])
                        } else {
                                if (path[0] != '/') {
                                        /* prepend '/' if missing */
-                                       strfieldcat(temp, "/");
-                                       strfieldcat(temp, path);
+                                       strcpy(temp, "/");
+                                       strlcpy(temp, path, sizeof(temp));
                                        pos = temp;
                                } else {
                                        pos = path;
                                }
                        }
-                       memset(&udev, 0x00, sizeof(struct udevice));
-                       strfieldcpy(udev.devpath, pos);
-                       retval = udev_db_get_device(&udev);
+                       retval = udev_db_get_device(&udev, pos);
                        if (retval != 0) {
-                               printf("device not found in database\n");
+                               fprintf(stderr, "device not found in database\n");
                                goto exit;
                        }
                        goto print;
                }
 
                if (name[0] != '\0') {
-                       /* remove udev_root if given */
-                       int len = strlen(udev_root);
+                       char devpath[PATH_SIZE];
+                       int len;
 
+                       /* remove udev_root if given */
+                       len = strlen(udev_root);
                        if (strncmp(name, udev_root, len) == 0) {
                                pos = &name[len+1];
                        } else
                                pos = name;
 
-                       memset(&udev, 0x00, sizeof(struct udevice));
-                       strfieldcpy(udev.name, pos);
-                       retval = udev_db_get_device_byname(&udev, pos);
+                       retval = udev_db_search_name(devpath, sizeof(devpath), pos);
                        if (retval != 0) {
-                               printf("device not found in database\n");
+                               fprintf(stderr, "device not found in database\n");
                                goto exit;
                        }
-
+                       udev_db_get_device(&udev, devpath);
                        goto print;
                }
 
-               printf("query needs device path(-p) or node name(-n) specified\n");
+               fprintf(stderr, "query needs device path(-p) or node name(-n) specified\n");
+               retval = 3;
                goto exit;
 
 print:
                switch(query) {
                case NAME:
-                       if (root) {
-                               snprintf(result, NAME_SIZE-1, "%s/%s", udev_root, udev.name);
-                               result[NAME_SIZE-1] = '\0';
-                       } else {
-                               strfieldcpy(result, udev.name);
-                       }
-                       break;
-
+                       if (root)
+                               printf("%s/%s\n", udev_root, udev.name);
+                       else
+                               printf("%s\n", udev.name);
+                       goto exit;
                case SYMLINK:
-                       if (root) {
-                               int slen;
-                               char *spos;
-                               char slink[NAME_SIZE];
-
-                               pos = result;
-                               foreach_strpart(udev.symlink, " \n\r", spos, slen) {
-                                       strncpy(slink, spos, slen);
-                                       slink[slen] = '\0';
-                                       pos += sprintf(pos, "%s/%s ", udev_root, slink);
-                               }
-                       } else {
-                               strfieldcpy(result, udev.symlink);
-                       }
-                       break;
-
+                       if (list_empty(&udev.symlink_list))
+                               break;
+                       if (root)
+                               list_for_each_entry(name_loop, &udev.symlink_list, node)
+                                       printf("%s/%s ", udev_root, name_loop->name);
+                       else
+                               list_for_each_entry(name_loop, &udev.symlink_list, node)
+                                       printf("%s ", name_loop->name);
+                       printf("\n");
+                       goto exit;
                case PATH:
-                       strfieldcpy(result, path);
-                       break;
-
+                       printf("%s\n", udev.devpath);
+                       goto exit;
                case ALL:
                        print_record(&udev);
                        goto exit;
-
                default:
-                       goto exit;
+                       goto help;
                }
-               printf("%s\n", result);
-
-exit:
-               return retval;
        }
 
        if (attributes) {
                if (path[0] == '\0') {
-                       printf("attribute walk on device chain needs path(-p) specified\n");
-                       return -EINVAL;
+                       fprintf(stderr, "attribute walk on device chain needs path(-p) specified\n");
+                       retval = 4;
+                       goto exit;
                } else {
                        if (strncmp(path, sysfs_path, strlen(sysfs_path)) != 0) {
                                /* prepend sysfs mountpoint if not given */
-                               strfieldcpy(temp, path);
-                               strfieldcpy(path, sysfs_path);
-                               strfieldcat(path, temp);
+                               snprintf(temp, sizeof(temp), "%s%s", sysfs_path, path);
+                               temp[sizeof(temp)-1] = '\0';
+                               strlcpy(path, temp, sizeof(temp));
                        }
                        print_device_chain(path);
-                       return 0;
+                       goto exit;
                }
        }
 
        if (root) {
                printf("%s\n", udev_root);
-               return 0;
+               goto exit;
        }
 
 help:
-       printf("Usage: [-anpqrdVh]\n"
+       fprintf(stderr, "Usage: udevinfo [-anpqrVh]\n"
               "  -q TYPE  query database for the specified value:\n"
               "             'name'    name of device node\n"
               "             'symlink' pointing to node\n"
@@ -465,24 +380,14 @@ help:
               "\n"
               "  -r       print udev root\n"
               "  -a       print all SYSFS_attributes along the device chain\n"
-              "  -s       print all sysfs devices with major/minor, physical device and bus\n"
+              "  -d       print the relationship of devpath and the node name for all\n"
+              "           devices available in the database\n"
               "  -V       print udev version\n"
               "  -h       print this help text\n"
               "\n");
-       return retval;
-}
-
-int main(int argc, char *argv[], char *envp[])
-{
-       int rc = 0;
-
-       logging_init("udevinfo");
-
-       /* initialize our configuration */
-       udev_init_config();
-
-       rc = process_options(argc, argv);
 
+exit:
+       udev_cleanup_device(&udev);
        logging_close();
-       exit(rc);
+       return retval;
 }