chiark / gitweb /
udevd: do not use syslog if --verbose (debugging) is used
[elogind.git] / udevd.c
diff --git a/udevd.c b/udevd.c
index 2c92590dcd2e46e30cf4969db672335bca164d2c..0999b5fa756bfc7b553dd413fa9672ca388dc9be 100644 (file)
--- a/udevd.c
+++ b/udevd.c
@@ -76,15 +76,16 @@ void log_message(int priority, const char *format, ...)
        if (priority > udev_log_priority)
                return;
 
-       va_start(args, format);
-       vsyslog(priority, format, args);
-       va_end(args);
-
        if (verbose) {
+               printf("[%d] ", (int) getpid());
                va_start(args, format);
                vprintf(format, args);
                va_end(args);
                printf("\n");
+       } else {
+               va_start(args, format);
+               vsyslog(priority, format, args);
+               va_end(args);
        }
 }
 
@@ -124,7 +125,7 @@ static int udev_event_process(struct udevd_uevent_msg *msg)
        for (i = 0; msg->envp[i]; i++)
                putenv(msg->envp[i]);
 
-       udev = udev_device_init();
+       udev = udev_device_init(NULL);
        if (udev == NULL)
                return -1;
        strlcpy(udev->action, msg->action, sizeof(udev->action));
@@ -318,61 +319,43 @@ static void msg_queue_insert(struct udevd_uevent_msg *msg)
 
 static int mem_size_mb(void)
 {
-       int f;
-       char buf[8192];
-       long int len;
-       const char *pos;
-       long int memsize;
-
-       f = open("/proc/meminfo", O_RDONLY);
-       if (f == -1)
-               return -1;
-
-       len = read(f, buf, sizeof(buf)-1);
-       close(f);
+       FILE* f;
+       char buf[4096];
+       long int memsize = -1;
 
-       if (len <= 0)
+       f = fopen("/proc/meminfo", "r");
+       if (f == NULL)
                return -1;
-       buf[len] = '\0';
 
-       pos = strstr(buf, "MemTotal: ");
-       if (pos == NULL)
-               return -1;
+       while (fgets(buf, sizeof(buf), f) != NULL) {
+               long int value;
 
-       if (sscanf(pos, "MemTotal: %ld kB", &memsize) != 1)
-               return -1;
+               if (sscanf(buf, "MemTotal: %ld kB", &value) == 1) {
+                       memsize = value / 1024;
+                       break;
+               }
+       }
 
-       return memsize / 1024;
+       fclose(f);
+       return memsize;
 }
 
 static int cpu_count(void)
 {
-       int f;
-       char buf[65536];
-       int len;
-       const char *pos;
+       FILE* f;
+       char buf[4096];
        int count = 0;
 
-       f = open("/proc/stat", O_RDONLY);
-       if (f == -1)
-               return -1;
-
-       len = read(f, buf, sizeof(buf)-1);
-       close(f);
-       if (len <= 0)
-               return -1;
-       buf[len] = '\0';
-
-       pos = strstr(buf, "cpu");
-       if (pos == NULL)
+       f = fopen("/proc/stat", "r");
+       if (f == NULL)
                return -1;
 
-       while (pos != NULL) {
-               if (strncmp(pos, "cpu", 3) == 0 &&isdigit(pos[3]))
+       while (fgets(buf, sizeof(buf), f) != NULL) {
+               if (strncmp(buf, "cpu", 3) == 0 && isdigit(buf[3]))
                        count++;
-               pos = strstr(&pos[3], "cpu");
        }
 
+       fclose(f);
        if (count == 0)
                return -1;
        return count;
@@ -380,29 +363,24 @@ static int cpu_count(void)
 
 static int running_processes(void)
 {
-       int f;
-       char buf[32768];
-       int len;
-       int running;
-       const char *pos;
+       FILE* f;
+       char buf[4096];
+       int running = -1;
 
-       f = open("/proc/stat", O_RDONLY);
-       if (f == -1)
+       f = fopen("/proc/stat", "r");
+       if (f == NULL)
                return -1;
 
-       len = read(f, buf, sizeof(buf)-1);
-       close(f);
-       if (len <= 0)
-               return -1;
-       buf[len] = '\0';
+       while (fgets(buf, sizeof(buf), f) != NULL) {
+               int value;
 
-       pos = strstr(buf, "procs_running ");
-       if (pos == NULL)
-               return -1;
-
-       if (sscanf(pos, "procs_running %u", &running) != 1)
-               return -1;
+               if (sscanf(buf, "procs_running %u", &value) == 1) {
+                       running = value;
+                       break;
+               }
+       }
 
+       fclose(f);
        return running;
 }
 
@@ -495,26 +473,49 @@ static int compare_devpath(const char *running, const char *waiting)
        return 0;
 }
 
-/* returns still running task for the same device, its parent or its physical device */
-static int running_with_devpath(struct udevd_uevent_msg *msg, int limit)
+/* lookup event for identical, parent, child, or physical device */
+static int devpath_busy(struct udevd_uevent_msg *msg, int limit)
 {
        struct udevd_uevent_msg *loop_msg;
        int childs_count = 0;
 
+       /* check exec-queue which may still contain delayed events we depend on */
+       list_for_each_entry(loop_msg, &exec_list, node) {
+               /* skip ourself and all later events */
+               if (loop_msg->seqnum >= msg->seqnum)
+                       break;
+
+               /* check identical, parent, or child device event */
+               if (compare_devpath(loop_msg->devpath, msg->devpath) != 0) {
+                       dbg("%llu, device event still pending %llu (%s)",
+                           msg->seqnum, loop_msg->seqnum, loop_msg->devpath);
+                       return 2;
+               }
+
+               /* check physical device event (special case of parent) */
+               if (msg->physdevpath && msg->action && strcmp(msg->action, "add") == 0)
+                       if (compare_devpath(loop_msg->devpath, msg->physdevpath) != 0) {
+                               dbg("%llu, physical device event still pending %llu (%s)",
+                                   msg->seqnum, loop_msg->seqnum, loop_msg->devpath);
+                               return 3;
+                       }
+       }
+
+       /* check runing-queue for still running events */
        list_for_each_entry(loop_msg, &running_list, node) {
                if (limit && childs_count++ > limit) {
-                       dbg("%llu, maximum number (%i) of child reached", msg->seqnum, childs_count);
+                       dbg("%llu, maximum number (%i) of childs reached", msg->seqnum, childs_count);
                        return 1;
                }
 
-               /* return running parent/child device event */
+               /* check identical, parent, or child device event */
                if (compare_devpath(loop_msg->devpath, msg->devpath) != 0) {
-                       dbg("%llu, child device event still running %llu (%s)",
+                       dbg("%llu, device event still running %llu (%s)",
                            msg->seqnum, loop_msg->seqnum, loop_msg->devpath);
                        return 2;
                }
 
-               /* return running physical device event */
+               /* check physical device event (special case of parent) */
                if (msg->physdevpath && msg->action && strcmp(msg->action, "add") == 0)
                        if (compare_devpath(loop_msg->devpath, msg->physdevpath) != 0) {
                                dbg("%llu, physical device event still running %llu (%s)",
@@ -522,11 +523,10 @@ static int running_with_devpath(struct udevd_uevent_msg *msg, int limit)
                                return 3;
                        }
        }
-
        return 0;
 }
 
-/* exec queue management routine executes the events and serializes events in the same sequence */
+/* serializes events for the identical and parent and child devices */
 static void msg_queue_manager(void)
 {
        struct udevd_uevent_msg *loop_msg;
@@ -552,8 +552,8 @@ static void msg_queue_manager(void)
                        }
                }
 
-               /* don't run two processes for the same devpath and wait for the parent*/
-               if (running_with_devpath(loop_msg, max_childs)) {
+               /* serialize and wait for parent or child events */
+               if (devpath_busy(loop_msg, max_childs) != 0) {
                        dbg("delay seq %llu (%s)", loop_msg->seqnum, loop_msg->devpath);
                        continue;
                }
@@ -645,6 +645,7 @@ static void get_ctrl_msg(void)
        struct ucred *cred;
        char cred_msg[CMSG_SPACE(sizeof(struct ucred))];
        int *intval;
+       char *pos;
 
        memset(&ctrl_msg, 0x00, sizeof(struct udevd_ctrl_msg));
        iov.iov_base = &ctrl_msg;
@@ -681,6 +682,21 @@ static void get_ctrl_msg(void)
        }
 
        switch (ctrl_msg.type) {
+       case UDEVD_CTRL_ENV:
+               pos = strchr(ctrl_msg.buf, '=');
+               if (pos == NULL) {
+                       err("wrong key format '%s'", ctrl_msg.buf);
+                       break;
+               }
+               pos[0] = '\0';
+               if (pos[1] == '\0') {
+                       info("udevd message (ENV) received, unset '%s'", ctrl_msg.buf);
+                       unsetenv(ctrl_msg.buf);
+               } else {
+                       info("udevd message (ENV) received, set '%s=%s'", ctrl_msg.buf, &pos[1]);
+                       setenv(ctrl_msg.buf, &pos[1], 1);
+               }
+               break;
        case UDEVD_CTRL_STOP_EXEC_QUEUE:
                info("udevd message (STOP_EXEC_QUEUE) received");
                stop_exec_q = 1;
@@ -942,7 +958,6 @@ int main(int argc, char *argv[], char *envp[])
        selinux_init();
        dbg("version %s", UDEV_VERSION);
 
-       /* parse commandline options */
        while (1) {
                option = getopt_long(argc, argv, "dtvhV", options, NULL);
                if (option == -1)
@@ -1230,6 +1245,7 @@ int main(int argc, char *argv[], char *envp[])
 exit:
        udev_rules_cleanup(&rules);
        sysfs_cleanup();
+       selinux_exit();
 
        if (signal_pipe[READ_END] >= 0)
                close(signal_pipe[READ_END]);