chiark / gitweb /
udevd: replace --debug-trace with --children-max
[elogind.git] / udev / udevd.c
index fe3352ceb513519afa20cbb8f976d44ad00fe633..189ab007a491e8da5f23cdcc9a629b509f750271 100644 (file)
@@ -41,6 +41,7 @@
 #include <sys/stat.h>
 #include <sys/ioctl.h>
 #include <sys/inotify.h>
+#include <sys/utsname.h>
 
 #include "udev.h"
 
@@ -68,7 +69,6 @@ static void log_fn(struct udev *udev, int priority,
        }
 }
 
-static bool debug_trace;
 static struct udev_rules *rules;
 static struct udev_queue_export *udev_queue_export;
 static struct udev_ctrl *udev_ctrl;
@@ -77,8 +77,8 @@ static int worker_watch[2];
 static pid_t settle_pid;
 static bool stop_exec_queue;
 static bool reload_config;
-static int max_childs;
-static int childs;
+static int children;
+static int children_max;
 static sigset_t orig_sigmask;
 static struct udev_list_node event_list;
 static struct udev_list_node worker_list;
@@ -168,7 +168,7 @@ static void event_queue_delete(struct event *event)
        udev_list_node_remove(&event->node);
 
        /* mark as failed, if "add" event returns non-zero */
-       if (event->exitcode != 0 && strcmp(udev_device_get_action(event->dev), "add") == 0)
+       if (event->exitcode != 0 && strcmp(udev_device_get_action(event->dev), "remove") != 0)
                udev_queue_export_device_failed(udev_queue_export, event->dev);
        else
                udev_queue_export_device_finished(udev_queue_export, event->dev);
@@ -204,7 +204,7 @@ static void worker_unref(struct worker *worker)
 
        udev_list_node_remove(&worker->node);
        udev_monitor_unref(worker->monitor);
-       childs--;
+       children--;
        info(worker->udev, "worker [%u] cleaned up\n", worker->pid);
        free(worker);
 }
@@ -354,13 +354,13 @@ static void worker_new(struct event *event)
                worker->event = event;
                event->state = EVENT_RUNNING;
                udev_list_node_append(&worker->node, &worker_list);
-               childs++;
+               children++;
                info(event->udev, "seq %llu forked new worker [%u]\n", udev_device_get_seqnum(event->dev), pid);
                break;
        }
 }
 
-static void event_run(struct event *event)
+static void event_run(struct event *event, bool force)
 {
        struct udev_list_node *loop;
 
@@ -385,8 +385,8 @@ static void event_run(struct event *event)
                return;
        }
 
-       if (childs >= max_childs) {
-               info(event->udev, "maximum number (%i) of childs reached\n", childs);
+       if (!force && children >= children_max) {
+               info(event->udev, "maximum number (%i) of children reached\n", children);
                return;
        }
 
@@ -420,7 +420,7 @@ static void event_queue_insert(struct udev_device *dev)
 
        /* run all events with a timeout set immediately */
        if (udev_device_get_timeout(dev) > 0) {
-               worker_new(event);
+               event_run(event, true);
                return;
        }
 }
@@ -430,10 +430,10 @@ static void worker_kill(struct udev *udev, int retain)
        struct udev_list_node *loop;
        int max;
 
-       if (childs <= retain)
+       if (children <= retain)
                return;
 
-       max = childs - retain;
+       max = children - retain;
 
        udev_list_node_foreach(loop, &worker_list) {
                struct worker *worker = node_to_worker(loop);
@@ -449,29 +449,6 @@ static void worker_kill(struct udev *udev, int retain)
        }
 }
 
-static int mem_size_mb(void)
-{
-       FILE *f;
-       char buf[4096];
-       long int memsize = -1;
-
-       f = fopen("/proc/meminfo", "r");
-       if (f == NULL)
-               return -1;
-
-       while (fgets(buf, sizeof(buf), f) != NULL) {
-               long int value;
-
-               if (sscanf(buf, "MemTotal: %ld kB", &value) == 1) {
-                       memsize = value / 1024;
-                       break;
-               }
-       }
-
-       fclose(f);
-       return memsize;
-}
-
 /* lookup event for identical, parent, child device */
 static bool is_devpath_busy(struct event *event)
 {
@@ -552,13 +529,13 @@ static void events_start(struct udev *udev)
                        continue;
                }
 
-               event_run(event);
+               event_run(event, false);
        }
 }
 
 static void worker_returned(void)
 {
-       while (1) {
+       for (;;) {
                struct worker_message msg;
                ssize_t size;
                struct udev_list_node *loop;
@@ -647,10 +624,10 @@ static void handle_ctrl_msg(struct udev_ctrl *uctrl)
                worker_kill(udev, 0);
        }
 
-       i = udev_ctrl_get_set_max_childs(ctrl_msg);
+       i = udev_ctrl_get_set_children_max(ctrl_msg);
        if (i >= 0) {
-               info(udev, "udevd message (SET_MAX_CHILDS) received, max_childs=%i\n", i);
-               max_childs = i;
+               info(udev, "udevd message (SET_MAX_CHILDREN) received, children_max=%i\n", i);
+               children_max = i;
        }
 
        settle_pid = udev_ctrl_get_settle(ctrl_msg);
@@ -685,14 +662,21 @@ static int handle_inotify(struct udev *udev)
 
                ev = (struct inotify_event *)(buf + pos);
                if (ev->len) {
-                       dbg(udev, "inotify event: %x for %s\n", ev->mask, ev->name);
+                       const char *s;
+
+                       info(udev, "inotify event: %x for %s\n", ev->mask, ev->name);
+                       s = strstr(ev->name, ".rules");
+                       if (s == NULL)
+                               continue;
+                       if (strlen(s) != strlen(".rules"))
+                               continue;
                        reload_config = true;
                        continue;
                }
 
                dev = udev_watch_lookup(udev, ev->wd);
                if (dev != NULL) {
-                       dbg(udev, "inotify event: %x for %s\n", ev->mask, udev_device_get_devnode(dev));
+                       info(udev, "inotify event: %x for %s\n", ev->mask, udev_device_get_devnode(dev));
                        if (ev->mask & IN_CLOSE_WRITE) {
                                char filename[UTIL_PATH_SIZE];
                                int fd;
@@ -724,7 +708,7 @@ static void handle_signal(struct udev *udev, int signo)
                udev_exit = true;
                break;
        case SIGCHLD:
-               while (1) {
+               for (;;) {
                        pid_t pid;
                        int status;
                        struct udev_list_node *loop, *tmp;
@@ -761,22 +745,221 @@ static void handle_signal(struct udev *udev, int signo)
        }
 }
 
+static void static_dev_create_from_modules(struct udev *udev)
+{
+       struct utsname kernel;
+       char modules[UTIL_PATH_SIZE];
+       char buf[4096];
+       FILE *f;
+
+       uname(&kernel);
+       util_strscpyl(modules, sizeof(modules), "/lib/modules/", kernel.release, "/modules.devname", NULL);
+       f = fopen(modules, "r");
+       if (f == NULL)
+               return;
+
+       while (fgets(buf, sizeof(buf), f) != NULL) {
+               char *s;
+               const char *modname;
+               const char *devname;
+               const char *devno;
+               int maj, min;
+               char type;
+               mode_t mode;
+               char filename[UTIL_PATH_SIZE];
+
+               if (buf[0] == '#')
+                       continue;
+
+               modname = buf;
+               s = strchr(modname, ' ');
+               if (s == NULL)
+                       continue;
+               s[0] = '\0';
+
+               devname = &s[1];
+               s = strchr(devname, ' ');
+               if (s == NULL)
+                       continue;
+               s[0] = '\0';
+
+               devno = &s[1];
+               s = strchr(devno, ' ');
+               if (s == NULL)
+                       s = strchr(devno, '\n');
+               if (s != NULL)
+                       s[0] = '\0';
+               if (sscanf(devno, "%c%u:%u", &type, &maj, &min) != 3)
+                       continue;
+
+               if (type == 'c')
+                       mode = 0600 | S_IFCHR;
+               else if (type == 'b')
+                       mode = 0600 | S_IFBLK;
+               else
+                       continue;
+
+               util_strscpyl(filename, sizeof(filename), udev_get_dev_path(udev), "/", devname, NULL);
+               util_create_path(udev, filename);
+               udev_selinux_setfscreatecon(udev, filename, mode);
+               info(udev, "mknod '%s' %c%u:%u\n", filename, type, maj, min);
+               if (mknod(filename, mode, makedev(maj, min)) < 0 && errno == EEXIST)
+                       utimensat(AT_FDCWD, filename, NULL, 0);
+               udev_selinux_resetfscreatecon(udev);
+       }
+
+       fclose(f);
+}
+
+static int copy_dir(struct udev *udev, DIR *dir_from, DIR *dir_to, int maxdepth)
+{
+       struct dirent *dent;
+
+       for (dent = readdir(dir_from); dent != NULL; dent = readdir(dir_from)) {
+               struct stat stats;
+
+               if (dent->d_name[0] == '.')
+                       continue;
+               if (fstatat(dirfd(dir_from), dent->d_name, &stats, AT_SYMLINK_NOFOLLOW) != 0)
+                       continue;
+
+               if (S_ISBLK(stats.st_mode) || S_ISCHR(stats.st_mode)) {
+                       udev_selinux_setfscreateconat(udev, dirfd(dir_to), dent->d_name, stats.st_mode & 0777);
+                       if (mknodat(dirfd(dir_to), dent->d_name, stats.st_mode, stats.st_rdev) == 0) {
+                               fchmodat(dirfd(dir_to), dent->d_name, stats.st_mode & 0777, 0);
+                               fchownat(dirfd(dir_to), dent->d_name, stats.st_uid, stats.st_gid, 0);
+                       } else {
+                               utimensat(dirfd(dir_to), dent->d_name, NULL, 0);
+                       }
+                       udev_selinux_resetfscreatecon(udev);
+               } else if (S_ISLNK(stats.st_mode)) {
+                       char target[UTIL_PATH_SIZE];
+                       ssize_t len;
+
+                       len = readlinkat(dirfd(dir_from), dent->d_name, target, sizeof(target));
+                       if (len <= 0 || len == (ssize_t)sizeof(target))
+                               continue;
+                       target[len] = '\0';
+                       udev_selinux_setfscreateconat(udev, dirfd(dir_to), dent->d_name, S_IFLNK);
+                       if (symlinkat(target, dirfd(dir_to), dent->d_name) < 0 && errno == EEXIST)
+                               utimensat(dirfd(dir_to), dent->d_name, NULL, AT_SYMLINK_NOFOLLOW);
+                       udev_selinux_resetfscreatecon(udev);
+               } else if (S_ISDIR(stats.st_mode)) {
+                       DIR *dir2_from, *dir2_to;
+
+                       if (maxdepth == 0)
+                               continue;
+
+                       udev_selinux_setfscreateconat(udev, dirfd(dir_to), dent->d_name, S_IFDIR|0755);
+                       mkdirat(dirfd(dir_to), dent->d_name, 0755);
+                       udev_selinux_resetfscreatecon(udev);
+
+                       dir2_to = fdopendir(openat(dirfd(dir_to), dent->d_name, O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC));
+                       if (dir2_to == NULL)
+                               continue;
+
+                       dir2_from = fdopendir(openat(dirfd(dir_from), dent->d_name, O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC));
+                       if (dir2_from == NULL) {
+                               closedir(dir2_to);
+                               continue;
+                       }
+
+                       copy_dir(udev, dir2_from, dir2_to, maxdepth-1);
+
+                       closedir(dir2_to);
+                       closedir(dir2_from);
+               }
+       }
+
+       return 0;
+}
+
+static void static_dev_create_links(struct udev *udev, DIR *dir)
+{
+       struct stdlinks {
+               const char *link;
+               const char *target;
+       };
+       static const struct stdlinks stdlinks[] = {
+               { "core", "/proc/kcore" },
+               { "fd", "/proc/self/fd" },
+               { "stdin", "/proc/self/fd/0" },
+               { "stdout", "/proc/self/fd/1" },
+               { "stderr", "/proc/self/fd/2" },
+       };
+       unsigned int i;
+
+       for (i = 0; i < ARRAY_SIZE(stdlinks); i++) {
+               udev_selinux_setfscreateconat(udev, dirfd(dir), stdlinks[i].link, S_IFLNK);
+               if (symlinkat(stdlinks[i].target, dirfd(dir), stdlinks[i].link) < 0 && errno == EEXIST)
+                       utimensat(dirfd(dir), stdlinks[i].link, NULL, AT_SYMLINK_NOFOLLOW);
+               udev_selinux_resetfscreatecon(udev);
+       }
+}
+
+static void static_dev_create_from_devices(struct udev *udev, DIR *dir)
+{
+       DIR *dir_from;
+
+       dir_from = opendir(LIBEXECDIR "/devices");
+       if (dir_from == NULL)
+               return;
+       copy_dir(udev, dir_from, dir, 8);
+       closedir(dir_from);
+}
+
+static void static_dev_create(struct udev *udev)
+{
+       DIR *dir;
+
+       dir = opendir(udev_get_dev_path(udev));
+       if (dir == NULL)
+               return;
+
+       static_dev_create_links(udev, dir);
+       static_dev_create_from_devices(udev, dir);
+
+       closedir(dir);
+}
+
+static int mem_size_mb(void)
+{
+       FILE *f;
+       char buf[4096];
+       long int memsize = -1;
+
+       f = fopen("/proc/meminfo", "r");
+       if (f == NULL)
+               return -1;
+
+       while (fgets(buf, sizeof(buf), f) != NULL) {
+               long int value;
+
+               if (sscanf(buf, "MemTotal: %ld kB", &value) == 1) {
+                       memsize = value / 1024;
+                       break;
+               }
+       }
+
+       fclose(f);
+       return memsize;
+}
+
 int main(int argc, char *argv[])
 {
        struct udev *udev;
        int fd;
        FILE *f;
        sigset_t mask;
-       const char *value;
        int daemonize = false;
        int resolve_names = 1;
        static const struct option options[] = {
                { "daemon", no_argument, NULL, 'd' },
-               { "debug-trace", no_argument, NULL, 't' },
                { "debug", no_argument, NULL, 'D' },
+               { "children-max", required_argument, NULL, 'c' },
+               { "resolve-names", required_argument, NULL, 'N' },
                { "help", no_argument, NULL, 'h' },
                { "version", no_argument, NULL, 'V' },
-               { "resolve-names", required_argument, NULL, 'N' },
                {}
        };
        int rc = 1;
@@ -790,7 +973,7 @@ int main(int argc, char *argv[])
        info(udev, "version %s\n", VERSION);
        udev_selinux_init(udev);
 
-       while (1) {
+       for (;;) {
                int option;
 
                option = getopt_long(argc, argv, "dDthV", options, NULL);
@@ -801,8 +984,8 @@ int main(int argc, char *argv[])
                case 'd':
                        daemonize = true;
                        break;
-               case 't':
-                       debug_trace = true;
+               case 'c':
+                       children_max = strtoul(optarg, NULL, 10);
                        break;
                case 'D':
                        debug = true;
@@ -823,7 +1006,7 @@ int main(int argc, char *argv[])
                        }
                        break;
                case 'h':
-                       printf("Usage: udevd [--help] [--daemon] [--debug-trace] [--debug] "
+                       printf("Usage: udevd [--help] [--daemon] [--children-max] [--debug] "
                               "[--resolve-names=early|late|never] [--version]\n");
                        goto exit;
                case 'V':
@@ -966,7 +1149,7 @@ int main(int argc, char *argv[])
        }
 
        /* redirect std{out,err} */
-       if (!debug && !debug_trace) {
+       if (!debug) {
                dup2(fd, STDIN_FILENO);
                dup2(fd, STDOUT_FILENO);
                dup2(fd, STDERR_FILENO);
@@ -990,23 +1173,26 @@ int main(int argc, char *argv[])
                close(fd);
        }
 
-       /* in trace mode run one event after the other */
-       if (debug_trace) {
-               max_childs = 1;
-       } else {
-               int memsize = mem_size_mb();
+       if (children_max <= 0) {
+               const char *value = getenv("UDEVD_CHILDREN_MAX");
 
-               if (memsize > 0)
-                       max_childs = 128 + (memsize / 8);
-               else
-                       max_childs = 128;
+               if (value) {
+                       children_max = strtoul(value, NULL, 10);
+               } else {
+                       int memsize = mem_size_mb();
+
+                       /* set value depending on the amount of RAM */
+                       if (memsize > 0)
+                               children_max = 128 + (memsize / 8);
+                       else
+                               children_max = 128;
+               }
        }
+       info(udev, "set children_max to %u\n", children_max);
 
-       /* possibly overwrite maximum limit of executed events */
-       value = getenv("UDEVD_MAX_CHILDS");
-       if (value)
-               max_childs = strtoul(value, NULL, 10);
-       info(udev, "initialize max_childs to %u\n", max_childs);
+       static_dev_create(udev);
+       static_dev_create_from_modules(udev);
+       udev_rules_apply_static_dev_perms(rules);
 
        udev_list_init(&event_list);
        udev_list_init(&worker_list);
@@ -1016,7 +1202,7 @@ int main(int argc, char *argv[])
                int timeout;
 
                /* set timeout to kill idle workers */
-               if (udev_list_is_empty(&event_list) && childs > 2)
+               if (udev_list_is_empty(&event_list) && children > 2)
                        timeout = 3 * 1000;
                else
                        timeout = -1;