chiark / gitweb /
remove len == 0 check, the index root is always '\0'
[elogind.git] / udev / udev-rules.c
index 4df9eb35c859eba383b72a4602227f54fae6e905..df9fc7877da2c2d7bfa46f0ebb81e5a7b9d0f5da 100644 (file)
@@ -1,5 +1,6 @@
 /*
  * Copyright (C) 2008 Kay Sievers <kay.sievers@vrfy.org>
+ * Copyright (C) 2008 Alan Jenkins <alan-jenkins@tuffmail.co.uk>
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -16,6 +17,7 @@
  */
 
 #include <stddef.h>
+#include <limits.h>
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>
 
 #define PREALLOC_TOKEN                 2048
 #define PREALLOC_STRBUF                        32 * 1024
+#define PREALLOC_TRIE                  256
+
+struct uid_gid {
+       unsigned int name_off;
+       union {
+               uid_t   uid;
+               gid_t   gid;
+       };
+};
+
+struct trie_node {
+       /* this node's first child */
+       unsigned int child_idx;
+       /* the next child of our parent node's child list */
+       unsigned int next_child_idx;
+       /* this node's last child (shortcut for append) */
+       unsigned int last_child_idx;
+       unsigned int value_off;
+       unsigned short value_len;
+       unsigned char key;
+};
+
+struct udev_rules {
+       struct udev *udev;
+       int resolve_names;
+
+       /* every key in the rules file becomes a token */
+       struct token *tokens;
+       unsigned int token_cur;
+       unsigned int token_max;
+
+       /* all key strings are copied to a single string buffer */
+       char *buf;
+       size_t buf_cur;
+       size_t buf_max;
+       unsigned int buf_count;
+
+       /* during rule parsing, strings are indexed to find duplicates */
+       struct trie_node *trie_nodes;
+       unsigned int trie_nodes_cur;
+       unsigned int trie_nodes_max;
+
+       /* during rule parsing, uid/gid lookup results are cached */
+       struct uid_gid *uids;
+       unsigned int uids_cur;
+       unsigned int uids_max;
+       struct uid_gid *gids;
+       unsigned int gids_cur;
+       unsigned int gids_max;
+};
 
 /* KEY=="", KEY!="", KEY+="", KEY="", KEY:="" */
 enum operation_type {
@@ -44,17 +96,6 @@ enum operation_type {
        OP_ASSIGN_FINAL,
 };
 
-static const char *operation_str[] = {
-       [OP_UNSET] =            "UNSET",
-       [OP_MATCH] =            "match",
-       [OP_NOMATCH] =          "nomatch",
-       [OP_MATCH_MAX] =        "MATCH_MAX",
-
-       [OP_ADD] =              "add",
-       [OP_ASSIGN] =           "assign",
-       [OP_ASSIGN_FINAL] =     "assign-final",
-};
-
 enum string_glob_type {
        GL_UNSET,
        GL_PLAIN,                       /* no special chars */
@@ -65,18 +106,6 @@ enum string_glob_type {
        GL_FORMAT,
 };
 
-#ifdef DEBUG
-static const char *string_glob_str[] = {
-       [GL_UNSET] =            "UNSET",
-       [GL_PLAIN] =            "plain",
-       [GL_GLOB] =             "glob",
-       [GL_SPLIT] =            "split",
-       [GL_SPLIT_GLOB] =       "split-glob",
-       [GL_SOMETHING] =        "split-glob",
-       [GL_FORMAT] =           "format",
-};
-#endif
-
 /* tokens of a rule are sorted/handled in this order */
 enum token_type {
        TK_UNSET,
@@ -93,6 +122,7 @@ enum token_type {
        TK_M_WAITFOR,                   /* val */
        TK_M_ATTR,                      /* val, attr */
 
+       TK_M_PARENTS_MIN,
        TK_M_KERNELS,                   /* val */
        TK_M_SUBSYSTEMS,                /* val */
        TK_M_DRIVERS,                   /* val */
@@ -131,70 +161,23 @@ enum token_type {
        TK_END,
 };
 
-static const char *token_str[] = {
-       [TK_UNSET] =                    "UNSET",
-       [TK_RULE] =                     "RULE",
-
-       [TK_M_ACTION] =                 "M ACTION",
-       [TK_M_DEVPATH] =                "M DEVPATH",
-       [TK_M_KERNEL] =                 "M KERNEL",
-       [TK_M_DEVLINK] =                "M DEVLINK",
-       [TK_M_NAME] =                   "M NAME",
-       [TK_M_ENV] =                    "M ENV",
-       [TK_M_SUBSYSTEM] =              "M SUBSYSTEM",
-       [TK_M_DRIVER] =                 "M DRIVER",
-       [TK_M_WAITFOR] =                "M WAITFOR",
-       [TK_M_ATTR] =                   "M ATTR",
-
-       [TK_M_KERNELS] =                "M KERNELS",
-       [TK_M_SUBSYSTEMS] =             "M SUBSYSTEMS",
-       [TK_M_DRIVERS] =                "M DRIVERS",
-       [TK_M_ATTRS] =                  "M ATTRS",
-       [TK_M_PARENTS_MAX] =            "M PARENTS_MAX",
-
-       [TK_M_TEST] =                   "M TEST",
-       [TK_M_PROGRAM] =                "M PROGRAM",
-       [TK_M_IMPORT_FILE] =            "M IMPORT_FILE",
-       [TK_M_IMPORT_PROG] =            "M IMPORT_PROG",
-       [TK_M_IMPORT_PARENT] =          "M MPORT_PARENT",
-       [TK_M_RESULT] =                 "M RESULT",
-       [TK_M_MAX] =                    "M MAX",
-
-       [TK_A_IGNORE_DEVICE] =          "A IGNORE_DEVICE",
-       [TK_A_STRING_ESCAPE_NONE] =     "A STRING_ESCAPE_NONE",
-       [TK_A_STRING_ESCAPE_REPLACE] =  "A STRING_ESCAPE_REPLACE",
-       [TK_A_NUM_FAKE_PART] =          "A NUM_FAKE_PART",
-       [TK_A_DEVLINK_PRIO] =           "A DEVLINK_PRIO",
-       [TK_A_OWNER] =                  "A OWNER",
-       [TK_A_GROUP] =                  "A GROUP",
-       [TK_A_MODE] =                   "A MODE",
-       [TK_A_OWNER_ID] =               "A OWNER_ID",
-       [TK_A_GROUP_ID] =               "A GROUP_ID",
-       [TK_A_MODE_ID] =                "A MODE_ID",
-       [TK_A_ENV] =                    "A ENV",
-       [TK_A_NAME] =                   "A NAME",
-       [TK_A_DEVLINK] =                "A DEVLINK",
-       [TK_A_EVENT_TIMEOUT] =          "A EVENT_TIMEOUT",
-       [TK_A_IGNORE_REMOVE] =          "A IGNORE_REMOVE",
-       [TK_A_ATTR] =                   "A ATTR",
-       [TK_A_RUN] =                    "A RUN",
-       [TK_A_GOTO] =                   "A GOTO",
-       [TK_A_LAST_RULE] =              "A LAST_RULE",
-
-       [TK_END] =                      "END",
-};
-
+/* we try to pack stuff in a way that we take only 12 bytes per token */
 struct token {
-       enum token_type type;
        union {
+               unsigned char type;             /* same as in rule and key */
                struct {
-                       unsigned int next_rule;
+                       unsigned char type;
+                       unsigned char flags;
+                       unsigned short token_count;
                        unsigned int label_off;
-                       unsigned int filename_off;
+                       unsigned short filename_off;
+                       unsigned short filename_line;
                } rule;
                struct {
-                       unsigned short op;
-                       unsigned short glob;
+                       unsigned char type;
+                       unsigned char flags;
+                       unsigned char op;
+                       unsigned char glob;
                        unsigned int value_off;
                        union {
                                unsigned int attr_off;
@@ -220,75 +203,332 @@ struct rule_tmp {
        unsigned int token_cur;
 };
 
-struct uid_gid {
-       unsigned int name_off;
-       union {
-               uid_t   uid;
-               gid_t   gid;
+#ifdef DEBUG
+static const char *operation_str(enum operation_type type)
+{
+       static const char *operation_strs[] = {
+               [OP_UNSET] =            "UNSET",
+               [OP_MATCH] =            "match",
+               [OP_NOMATCH] =          "nomatch",
+               [OP_MATCH_MAX] =        "MATCH_MAX",
+
+               [OP_ADD] =              "add",
+               [OP_ASSIGN] =           "assign",
+               [OP_ASSIGN_FINAL] =     "assign-final",
+}      ;
+
+       return operation_strs[type];
+}
+
+static const char *string_glob_str(enum string_glob_type type)
+{
+       static const char *string_glob_strs[] = {
+               [GL_UNSET] =            "UNSET",
+               [GL_PLAIN] =            "plain",
+               [GL_GLOB] =             "glob",
+               [GL_SPLIT] =            "split",
+               [GL_SPLIT_GLOB] =       "split-glob",
+               [GL_SOMETHING] =        "split-glob",
+               [GL_FORMAT] =           "format",
        };
-};
 
-struct udev_rules {
-       struct udev *udev;
-       int resolve_names;
+       return string_glob_strs[type];
+}
 
-       /* every key in the rules file becomes a token */
-       struct token *tokens;
-       unsigned int token_cur;
-       unsigned int token_max;
+static const char *token_str(enum token_type type)
+{
+       static const char *token_strs[] = {
+               [TK_UNSET] =                    "UNSET",
+               [TK_RULE] =                     "RULE",
+
+               [TK_M_ACTION] =                 "M ACTION",
+               [TK_M_DEVPATH] =                "M DEVPATH",
+               [TK_M_KERNEL] =                 "M KERNEL",
+               [TK_M_DEVLINK] =                "M DEVLINK",
+               [TK_M_NAME] =                   "M NAME",
+               [TK_M_ENV] =                    "M ENV",
+               [TK_M_SUBSYSTEM] =              "M SUBSYSTEM",
+               [TK_M_DRIVER] =                 "M DRIVER",
+               [TK_M_WAITFOR] =                "M WAITFOR",
+               [TK_M_ATTR] =                   "M ATTR",
+
+               [TK_M_PARENTS_MIN] =            "M PARENTS_MIN",
+               [TK_M_KERNELS] =                "M KERNELS",
+               [TK_M_SUBSYSTEMS] =             "M SUBSYSTEMS",
+               [TK_M_DRIVERS] =                "M DRIVERS",
+               [TK_M_ATTRS] =                  "M ATTRS",
+               [TK_M_PARENTS_MAX] =            "M PARENTS_MAX",
+
+               [TK_M_TEST] =                   "M TEST",
+               [TK_M_PROGRAM] =                "M PROGRAM",
+               [TK_M_IMPORT_FILE] =            "M IMPORT_FILE",
+               [TK_M_IMPORT_PROG] =            "M IMPORT_PROG",
+               [TK_M_IMPORT_PARENT] =          "M MPORT_PARENT",
+               [TK_M_RESULT] =                 "M RESULT",
+               [TK_M_MAX] =                    "M MAX",
+
+               [TK_A_IGNORE_DEVICE] =          "A IGNORE_DEVICE",
+               [TK_A_STRING_ESCAPE_NONE] =     "A STRING_ESCAPE_NONE",
+               [TK_A_STRING_ESCAPE_REPLACE] =  "A STRING_ESCAPE_REPLACE",
+               [TK_A_NUM_FAKE_PART] =          "A NUM_FAKE_PART",
+               [TK_A_DEVLINK_PRIO] =           "A DEVLINK_PRIO",
+               [TK_A_OWNER] =                  "A OWNER",
+               [TK_A_GROUP] =                  "A GROUP",
+               [TK_A_MODE] =                   "A MODE",
+               [TK_A_OWNER_ID] =               "A OWNER_ID",
+               [TK_A_GROUP_ID] =               "A GROUP_ID",
+               [TK_A_MODE_ID] =                "A MODE_ID",
+               [TK_A_ENV] =                    "A ENV",
+               [TK_A_NAME] =                   "A NAME",
+               [TK_A_DEVLINK] =                "A DEVLINK",
+               [TK_A_EVENT_TIMEOUT] =          "A EVENT_TIMEOUT",
+               [TK_A_IGNORE_REMOVE] =          "A IGNORE_REMOVE",
+               [TK_A_ATTR] =                   "A ATTR",
+               [TK_A_RUN] =                    "A RUN",
+               [TK_A_GOTO] =                   "A GOTO",
+               [TK_A_LAST_RULE] =              "A LAST_RULE",
+
+               [TK_END] =                      "END",
+       };
 
-       /* all key strings are copied to a single string buffer */
-       char *buf;
-       size_t buf_cur;
-       size_t buf_max;
-       unsigned int buf_count;
+       return token_strs[type];
+}
 
-       /* during rule parsing, we cache uid/gid lookup results */
-       struct uid_gid *uids;
-       unsigned int uids_cur;
-       unsigned int uids_max;
-       struct uid_gid *gids;
-       unsigned int gids_cur;
-       unsigned int gids_max;
-};
+static void dump_token(struct udev_rules *rules, struct token *token)
+{
+       enum token_type type = token->type;
+       enum operation_type op = token->key.op;
+       enum string_glob_type glob = token->key.glob;
+       const char *value = &rules->buf[token->key.value_off];
+       const char *attr = &rules->buf[token->key.attr_off];
 
-/* NOTE: we could lookup and return existing strings, or tails of strings */
-static int add_string(struct udev_rules *rules, const char *str)
+       switch (type) {
+       case TK_RULE:
+               {
+                       const char *tks_ptr = (char *)rules->tokens;
+                       const char *tk_ptr = (char *)token;
+                       unsigned int idx = (tk_ptr - tks_ptr) / sizeof(struct token);
+
+                       dbg(rules->udev, "* RULE %s:%u, token: %u, count: %u, label: '%s', flags: 0x%02x\n",
+                           &rules->buf[token->rule.filename_off], token->rule.filename_line,
+                           idx, token->rule.token_count,
+                           &rules->buf[token->rule.label_off],
+                           token->rule.flags);
+                       break;
+               }
+       case TK_M_ACTION:
+       case TK_M_DEVPATH:
+       case TK_M_KERNEL:
+       case TK_M_SUBSYSTEM:
+       case TK_M_DRIVER:
+       case TK_M_WAITFOR:
+       case TK_M_DEVLINK:
+       case TK_M_NAME:
+       case TK_M_KERNELS:
+       case TK_M_SUBSYSTEMS:
+       case TK_M_DRIVERS:
+       case TK_M_PROGRAM:
+       case TK_M_IMPORT_FILE:
+       case TK_M_IMPORT_PROG:
+       case TK_M_IMPORT_PARENT:
+       case TK_M_RESULT:
+       case TK_A_NAME:
+       case TK_A_DEVLINK:
+       case TK_A_OWNER:
+       case TK_A_GROUP:
+       case TK_A_MODE:
+       case TK_A_RUN:
+               dbg(rules->udev, "%s %s '%s'(%s)\n",
+                   token_str(type), operation_str(op), value, string_glob_str(glob));
+               break;
+       case TK_M_ATTR:
+       case TK_M_ATTRS:
+       case TK_M_ENV:
+       case TK_A_ATTR:
+       case TK_A_ENV:
+               dbg(rules->udev, "%s %s '%s' '%s'(%s)\n",
+                   token_str(type), operation_str(op), attr, value, string_glob_str(glob));
+               break;
+       case TK_A_IGNORE_DEVICE:
+       case TK_A_STRING_ESCAPE_NONE:
+       case TK_A_STRING_ESCAPE_REPLACE:
+       case TK_A_LAST_RULE:
+       case TK_A_IGNORE_REMOVE:
+               dbg(rules->udev, "%s\n", token_str(type));
+               break;
+       case TK_M_TEST:
+               dbg(rules->udev, "%s %s '%s'(%s) %#o\n",
+                   token_str(type), operation_str(op), value, string_glob_str(glob), token->key.mode);
+               break;
+       case TK_A_NUM_FAKE_PART:
+               dbg(rules->udev, "%s %u\n", token_str(type), token->key.num_fake_part);
+               break;
+       case TK_A_DEVLINK_PRIO:
+               dbg(rules->udev, "%s %s %u\n", token_str(type), operation_str(op), token->key.devlink_prio);
+               break;
+       case TK_A_OWNER_ID:
+               dbg(rules->udev, "%s %s %u\n", token_str(type), operation_str(op), token->key.uid);
+               break;
+       case TK_A_GROUP_ID:
+               dbg(rules->udev, "%s %s %u\n", token_str(type), operation_str(op), token->key.gid);
+               break;
+       case TK_A_MODE_ID:
+               dbg(rules->udev, "%s %s %#o\n", token_str(type), operation_str(op), token->key.mode);
+               break;
+       case TK_A_EVENT_TIMEOUT:
+               dbg(rules->udev, "%s %s %u\n", token_str(type), operation_str(op), token->key.event_timeout);
+               break;
+       case TK_A_GOTO:
+               dbg(rules->udev, "%s '%s' %u\n", token_str(type), value, token->key.rule_goto);
+               break;
+       case TK_END:
+               dbg(rules->udev, "* %s\n", token_str(type));
+               break;
+       case TK_M_PARENTS_MIN:
+       case TK_M_PARENTS_MAX:
+       case TK_M_MAX:
+       case TK_UNSET:
+               dbg(rules->udev, "unknown type %u\n", type);
+               break;
+       }
+}
+
+static void dump_rules(struct udev_rules *rules)
 {
-       size_t len = strlen(str)+1;
-       int off;
+       unsigned int i;
 
-       /* offset 0 is always '\0' */
-       if (str[0] == '\0')
-               return 0;
+       dbg(rules->udev, "dumping %u (%zu bytes) tokens, %u (%zu bytes) strings\n",
+           rules->token_cur,
+           rules->token_cur * sizeof(struct token),
+           rules->buf_count,
+           rules->buf_cur);
+       for(i = 0; i < rules->token_cur; i++)
+               dump_token(rules, &rules->tokens[i]);
+}
+#else
+static inline const char *operation_str(enum operation_type type) { return NULL; }
+static inline const char *token_str(enum token_type type) { return NULL; }
+static inline void dump_token(struct udev_rules *rules, struct token *token) {}
+static inline void dump_rules(struct udev_rules *rules) {}
+#endif /* DEBUG */
+
+static int add_new_string(struct udev_rules *rules, const char *str, size_t bytes)
+{
+       int off;
 
        /* grow buffer if needed */
-       if (rules->buf_cur + len+1 >= rules->buf_max) {
+       if (rules->buf_cur + bytes+1 >= rules->buf_max) {
                char *buf;
                unsigned int add;
 
                /* double the buffer size */
                add = rules->buf_max;
-               if (add < len * 8)
-                       add = len * 8;
+               if (add < bytes * 8)
+                       add = bytes * 8;
 
                buf = realloc(rules->buf, rules->buf_max + add);
                if (buf == NULL)
                        return -1;
-               info(rules->udev, "extend buffer from %zu to %zu\n", rules->buf_max, rules->buf_max + add);
+               dbg(rules->udev, "extend buffer from %zu to %zu\n", rules->buf_max, rules->buf_max + add);
                rules->buf = buf;
                rules->buf_max += add;
        }
        off = rules->buf_cur;
-       memcpy(&rules->buf[rules->buf_cur], str, len);
-       rules->buf_cur += len;
+       memcpy(&rules->buf[rules->buf_cur], str, bytes);
+       rules->buf_cur += bytes;
        rules->buf_count++;
        return off;
 }
 
-static int add_token(struct udev_rules *rules, struct token *token)
+static int add_string(struct udev_rules *rules, const char *str)
 {
+       unsigned int node_idx;
+       struct trie_node *new_node;
+       unsigned int new_node_idx;
+       unsigned char key;
+       unsigned short len;
+       unsigned int depth;
+       unsigned int off;
+       struct trie_node *parent;
+
+       /* walk trie, start from last character of str to find matching tails */
+       len = strlen(str);
+       key = str[len-1];
+       node_idx = 0;
+       for (depth = 0; depth <= len; depth++) {
+               struct trie_node *node;
+               unsigned int child_idx;
+
+               node = &rules->trie_nodes[node_idx];
+               off = node->value_off + node->value_len - len;
+
+               /* match against current node */
+               if (depth == len || (node->value_len >= len && memcmp(&rules->buf[off], str, len) == 0))
+                       return off;
+
+               /* lookup child node */
+               key = str[len - 1 - depth];
+               child_idx = node->child_idx;
+               while (child_idx > 0) {
+                       struct trie_node *child;
+
+                       child = &rules->trie_nodes[child_idx];
+                       if (child->key == key)
+                               break;
+                       child_idx = child->next_child_idx;
+               }
+               if (child_idx == 0)
+                       break;
+               node_idx = child_idx;
+       }
+
+       /* string not found, add it */
+       off = add_new_string(rules, str, len + 1);
+
+       /* grow trie nodes if needed */
+       if (rules->trie_nodes_cur >= rules->trie_nodes_max) {
+               struct trie_node *nodes;
+               unsigned int add;
+
+               /* double the buffer size */
+               add = rules->trie_nodes_max;
+               if (add < 8)
+                       add = 8;
+
+               nodes = realloc(rules->trie_nodes, (rules->trie_nodes_max + add) * sizeof(struct trie_node));
+               if (nodes == NULL)
+                       return -1;
+               dbg(rules->udev, "extend trie nodes from %u to %u\n",
+                   rules->trie_nodes_max, rules->trie_nodes_max + add);
+               rules->trie_nodes = nodes;
+               rules->trie_nodes_max += add;
+       }
 
+       /* get a new node */
+       new_node_idx = rules->trie_nodes_cur;
+       rules->trie_nodes_cur++;
+       new_node = &rules->trie_nodes[new_node_idx];
+       memset(new_node, 0x00, sizeof(struct trie_node));
+       new_node->value_off = off;
+       new_node->value_len = len;
+       new_node->key = key;
+
+       /* join the parent's child list */
+       parent = &rules->trie_nodes[node_idx];
+       if (parent->child_idx == 0) {
+               parent->child_idx = new_node_idx;
+       } else {
+               struct trie_node *last_child;
+
+               last_child = &rules->trie_nodes[parent->last_child_idx];
+               last_child->next_child_idx = new_node_idx;
+       }
+       parent->last_child_idx = new_node_idx;
+       return off;
+}
+
+static int add_token(struct udev_rules *rules, struct token *token)
+{
        /* grow buffer if needed */
        if (rules->token_cur+1 >= rules->token_max) {
                struct token *tokens;
@@ -302,7 +542,7 @@ static int add_token(struct udev_rules *rules, struct token *token)
                tokens = realloc(rules->tokens, (rules->token_max + add ) * sizeof(struct token));
                if (tokens == NULL)
                        return -1;
-               info(rules->udev, "extend tokens from %u to %u\n", rules->token_max, rules->token_max + add);
+               dbg(rules->udev, "extend tokens from %u to %u\n", rules->token_max, rules->token_max + add);
                rules->tokens = tokens;
                rules->token_max += add;
        }
@@ -341,7 +581,7 @@ static uid_t add_uid(struct udev_rules *rules, const char *owner)
                uids = realloc(rules->uids, (rules->uids_max + add ) * sizeof(struct uid_gid));
                if (uids == NULL)
                        return uid;
-               info(rules->udev, "extend uids from %u to %u\n", rules->uids_max, rules->uids_max + add);
+               dbg(rules->udev, "extend uids from %u to %u\n", rules->uids_max, rules->uids_max + add);
                rules->uids = uids;
                rules->uids_max += add;
        }
@@ -384,7 +624,7 @@ static gid_t add_gid(struct udev_rules *rules, const char *group)
                gids = realloc(rules->gids, (rules->gids_max + add ) * sizeof(struct uid_gid));
                if (gids == NULL)
                        return gid;
-               info(rules->udev, "extend gids from %u to %u\n", rules->gids_max, rules->gids_max + add);
+               dbg(rules->udev, "extend gids from %u to %u\n", rules->gids_max, rules->gids_max + add);
                rules->gids = gids;
                rules->gids_max += add;
        }
@@ -453,7 +693,7 @@ static int import_property_from_string(struct udev_device *dev, char *line)
                val++;
        }
 
-       info(udev, "adding '%s'='%s'\n", key, val);
+       dbg(udev, "adding '%s'='%s'\n", key, val);
 
        /* handle device, renamed by external tool, returning new path */
        if (strcmp(key, "DEVPATH") == 0) {
@@ -547,11 +787,12 @@ static int wait_for_file(struct udev_device *dev, const char *file, int timeout)
 {
        struct udev *udev = udev_device_get_udev(dev);
        char filepath[UTIL_PATH_SIZE];
-       char devicepath[UTIL_PATH_SIZE] = "";
+       char devicepath[UTIL_PATH_SIZE];
        struct stat stats;
        int loop = timeout * WAIT_LOOP_PER_SECOND;
 
        /* a relative path is a device attribute */
+       devicepath[0] = '\0';
        if (file[0] != '/') {
                util_strlcpy(devicepath, udev_get_sys_path(udev), sizeof(devicepath));
                util_strlcat(devicepath, udev_device_get_devpath(dev), sizeof(devicepath));
@@ -700,7 +941,7 @@ static int get_key(struct udev *udev, char **line, char **key, enum operation_ty
                return -1;
        temp[0] = '\0';
        temp++;
-       dbg(udev, "%s '%s'-'%s'\n", operation_str[*op], *key, *value);
+       dbg(udev, "%s '%s'-'%s'\n", operation_str(*op), *key, *value);
 
        /* move line to next key */
        *line = temp;
@@ -728,9 +969,9 @@ static char *get_key_attribute(struct udev *udev, char *str)
        return NULL;
 }
 
-static int rule_add_token(struct rule_tmp *rule_tmp, enum token_type type,
-                         enum operation_type op,
-                         const char *value, const void *data)
+static int rule_add_key(struct rule_tmp *rule_tmp, enum token_type type,
+                       enum operation_type op,
+                       const char *value, const void *data)
 {
        struct token *token = &rule_tmp->token[rule_tmp->token_cur];
        const char *attr = data;
@@ -805,6 +1046,7 @@ static int rule_add_token(struct rule_tmp *rule_tmp, enum token_type type,
                token->key.event_timeout = *(int *)data;
                break;
        case TK_RULE:
+       case TK_M_PARENTS_MIN:
        case TK_M_PARENTS_MAX:
        case TK_M_MAX:
        case TK_END:
@@ -840,7 +1082,7 @@ static int rule_add_token(struct rule_tmp *rule_tmp, enum token_type type,
                }
        }
 
-       token->type = type;
+       token->key.type = type;
        token->key.op = op;
        token->key.glob = glob;
        rule_tmp->token_cur++;
@@ -851,122 +1093,6 @@ static int rule_add_token(struct rule_tmp *rule_tmp, enum token_type type,
        return 0;
 }
 
-#ifdef DEBUG
-static void dump_token(struct udev_rules *rules, struct token *token)
-{
-       enum token_type type = token->type;
-       enum operation_type op = token->key.op;
-       enum string_glob_type glob = token->key.glob;
-       const char *value = &rules->buf[token->key.value_off];
-       const char *attr = &rules->buf[token->key.attr_off];
-
-       switch (type) {
-       case TK_RULE:
-               {
-                       const char *tks_ptr = (char *)rules->tokens;
-                       const char *tk_ptr = (char *)token;
-                       unsigned int off = tk_ptr - tks_ptr;
-
-                       dbg(rules->udev, "* RULE '%s', off: %u(%u), next: %u, label: '%s'\n",
-                           &rules->buf[token->rule.filename_off],
-                           off / (unsigned int) sizeof(struct token), off,
-                           token->rule.next_rule,
-                           &rules->buf[token->rule.label_off]);
-                       break;
-               }
-       case TK_M_ACTION:
-       case TK_M_DEVPATH:
-       case TK_M_KERNEL:
-       case TK_M_SUBSYSTEM:
-       case TK_M_DRIVER:
-       case TK_M_WAITFOR:
-       case TK_M_DEVLINK:
-       case TK_M_NAME:
-       case TK_M_KERNELS:
-       case TK_M_SUBSYSTEMS:
-       case TK_M_DRIVERS:
-       case TK_M_PROGRAM:
-       case TK_M_IMPORT_FILE:
-       case TK_M_IMPORT_PROG:
-       case TK_M_IMPORT_PARENT:
-       case TK_M_RESULT:
-       case TK_A_NAME:
-       case TK_A_DEVLINK:
-       case TK_A_OWNER:
-       case TK_A_GROUP:
-       case TK_A_MODE:
-       case TK_A_RUN:
-               dbg(rules->udev, "%s %s '%s'(%s)\n",
-                   token_str[type], operation_str[op], value, string_glob_str[glob]);
-               break;
-       case TK_M_ATTR:
-       case TK_M_ATTRS:
-       case TK_M_ENV:
-       case TK_A_ATTR:
-       case TK_A_ENV:
-               dbg(rules->udev, "%s %s '%s' '%s'(%s)\n",
-                   token_str[type], operation_str[op], attr, value, string_glob_str[glob]);
-               break;
-       case TK_A_IGNORE_DEVICE:
-       case TK_A_STRING_ESCAPE_NONE:
-       case TK_A_STRING_ESCAPE_REPLACE:
-       case TK_A_LAST_RULE:
-       case TK_A_IGNORE_REMOVE:
-               dbg(rules->udev, "%s\n", token_str[type]);
-               break;
-       case TK_M_TEST:
-               dbg(rules->udev, "%s %s '%s'(%s) %#o\n",
-                   token_str[type], operation_str[op], value, string_glob_str[glob], token->key.mode);
-               break;
-       case TK_A_NUM_FAKE_PART:
-               dbg(rules->udev, "%s %u\n", token_str[type], token->key.num_fake_part);
-               break;
-       case TK_A_DEVLINK_PRIO:
-               dbg(rules->udev, "%s %s %u\n", token_str[type], operation_str[op], token->key.devlink_prio);
-               break;
-       case TK_A_OWNER_ID:
-               dbg(rules->udev, "%s %s %u\n", token_str[type], operation_str[op], token->key.uid);
-               break;
-       case TK_A_GROUP_ID:
-               dbg(rules->udev, "%s %s %u\n", token_str[type], operation_str[op], token->key.gid);
-               break;
-       case TK_A_MODE_ID:
-               dbg(rules->udev, "%s %s %#o\n", token_str[type], operation_str[op], token->key.mode);
-               break;
-       case TK_A_EVENT_TIMEOUT:
-               dbg(rules->udev, "%s %s %u\n", token_str[type], operation_str[op], token->key.event_timeout);
-               break;
-       case TK_A_GOTO:
-               dbg(rules->udev, "%s '%s' %u\n", token_str[type], value, token->key.rule_goto);
-               break;
-       case TK_END:
-               dbg(rules->udev, "* %s\n", token_str[type]);
-               break;
-       case TK_M_PARENTS_MAX:
-       case TK_M_MAX:
-       case TK_UNSET:
-               dbg(rules->udev, "unknown type %u\n", type);
-               break;
-       }
-}
-
-static void dump_rules(struct udev_rules *rules)
-{
-       unsigned int i;
-
-       dbg(rules->udev, "dumping %u (%zu bytes) tokens, %u (%zu bytes) strings\n",
-           rules->token_cur,
-           rules->token_cur * sizeof(struct token),
-           rules->buf_count,
-           rules->buf_cur);
-       for(i = 0; i < rules->token_cur; i++)
-               dump_token(rules, &rules->tokens[i]);
-}
-#else
-static inline void dump_token(struct udev_rules *rules, struct token *token) {}
-static inline void dump_rules(struct udev_rules *rules) {}
-#endif /* DEBUG */
-
 static int sort_token(struct udev_rules *rules, struct rule_tmp *rule_tmp)
 {
        unsigned int i;
@@ -1015,6 +1141,7 @@ static int add_rule(struct udev_rules *rules, char *line,
        rule_tmp.rules = rules;
        rule_tmp.rule.type = TK_RULE;
        rule_tmp.rule.rule.filename_off = filename_off;
+       rule_tmp.rule.rule.filename_line = lineno;
 
        linepos = line;
        while (1) {
@@ -1030,7 +1157,7 @@ static int add_rule(struct udev_rules *rules, char *line,
                                err(rules->udev, "invalid ACTION operation\n");
                                goto invalid;
                        }
-                       rule_add_token(&rule_tmp, TK_M_ACTION, op, value, NULL);
+                       rule_add_key(&rule_tmp, TK_M_ACTION, op, value, NULL);
                        valid = 1;
                        continue;
                }
@@ -1040,7 +1167,7 @@ static int add_rule(struct udev_rules *rules, char *line,
                                err(rules->udev, "invalid DEVPATH operation\n");
                                goto invalid;
                        }
-                       rule_add_token(&rule_tmp, TK_M_DEVPATH, op, value, NULL);
+                       rule_add_key(&rule_tmp, TK_M_DEVPATH, op, value, NULL);
                        valid = 1;
                        continue;
                }
@@ -1050,7 +1177,7 @@ static int add_rule(struct udev_rules *rules, char *line,
                                err(rules->udev, "invalid KERNEL operation\n");
                                goto invalid;
                        }
-                       rule_add_token(&rule_tmp, TK_M_KERNEL, op, value, NULL);
+                       rule_add_key(&rule_tmp, TK_M_KERNEL, op, value, NULL);
                        valid = 1;
                        continue;
                }
@@ -1067,9 +1194,9 @@ static int add_rule(struct udev_rules *rules, char *line,
                                if (strcmp(value, "bus") == 0 || strcmp(value, "class") == 0)
                                        err(rules->udev, "'%s' must be specified as 'subsystem' \n"
                                            "please fix it in %s:%u", value, filename, lineno);
-                               rule_add_token(&rule_tmp, TK_M_SUBSYSTEM, op, "subsystem|class|bus", NULL);
+                               rule_add_key(&rule_tmp, TK_M_SUBSYSTEM, op, "subsystem|class|bus", NULL);
                        } else
-                               rule_add_token(&rule_tmp, TK_M_SUBSYSTEM, op, value, NULL);
+                               rule_add_key(&rule_tmp, TK_M_SUBSYSTEM, op, value, NULL);
                        valid = 1;
                        continue;
                }
@@ -1079,7 +1206,7 @@ static int add_rule(struct udev_rules *rules, char *line,
                                err(rules->udev, "invalid DRIVER operation\n");
                                goto invalid;
                        }
-                       rule_add_token(&rule_tmp, TK_M_DRIVER, op, value, NULL);
+                       rule_add_key(&rule_tmp, TK_M_DRIVER, op, value, NULL);
                        valid = 1;
                        continue;
                }
@@ -1091,9 +1218,9 @@ static int add_rule(struct udev_rules *rules, char *line,
                                goto invalid;
                        }
                        if (op < OP_MATCH_MAX) {
-                               rule_add_token(&rule_tmp, TK_M_ATTR, op, value, attr);
+                               rule_add_key(&rule_tmp, TK_M_ATTR, op, value, attr);
                        } else {
-                               rule_add_token(&rule_tmp, TK_A_ATTR, op, value, attr);
+                               rule_add_key(&rule_tmp, TK_A_ATTR, op, value, attr);
                        }
                        valid = 1;
                        continue;
@@ -1105,7 +1232,7 @@ static int add_rule(struct udev_rules *rules, char *line,
                                err(rules->udev, "invalid KERNELS operation\n");
                                goto invalid;
                        }
-                       rule_add_token(&rule_tmp, TK_M_KERNELS, op, value, NULL);
+                       rule_add_key(&rule_tmp, TK_M_KERNELS, op, value, NULL);
                        valid = 1;
                        continue;
                }
@@ -1116,7 +1243,7 @@ static int add_rule(struct udev_rules *rules, char *line,
                                err(rules->udev, "invalid SUBSYSTEMS operation\n");
                                goto invalid;
                        }
-                       rule_add_token(&rule_tmp, TK_M_SUBSYSTEMS, op, value, NULL);
+                       rule_add_key(&rule_tmp, TK_M_SUBSYSTEMS, op, value, NULL);
                        valid = 1;
                        continue;
                }
@@ -1126,7 +1253,7 @@ static int add_rule(struct udev_rules *rules, char *line,
                                err(rules->udev, "invalid DRIVERS operation\n");
                                goto invalid;
                        }
-                       rule_add_token(&rule_tmp, TK_M_DRIVERS, op, value, NULL);
+                       rule_add_key(&rule_tmp, TK_M_DRIVERS, op, value, NULL);
                        valid = 1;
                        continue;
                }
@@ -1148,7 +1275,7 @@ static int add_rule(struct udev_rules *rules, char *line,
                        else if (strstr(attr, "../") != NULL)
                                err(rules->udev, "do not reference parent sysfs directories directly, "
                                    "it may break with a future kernel, please fix it in %s:%u", filename, lineno);
-                       rule_add_token(&rule_tmp, TK_M_ATTRS, op, value, attr);
+                       rule_add_key(&rule_tmp, TK_M_ATTRS, op, value, attr);
                        valid = 1;
                        continue;
                }
@@ -1162,10 +1289,10 @@ static int add_rule(struct udev_rules *rules, char *line,
                        if (strncmp(attr, "PHYSDEV", 7) == 0)
                                physdev = 1;
                        if (op < OP_MATCH_MAX) {
-                               if (rule_add_token(&rule_tmp, TK_M_ENV, op, value, attr) != 0)
+                               if (rule_add_key(&rule_tmp, TK_M_ENV, op, value, attr) != 0)
                                        goto invalid;
                        } else {
-                               if (rule_add_token(&rule_tmp, TK_A_ENV, op, value, attr) != 0)
+                               if (rule_add_key(&rule_tmp, TK_A_ENV, op, value, attr) != 0)
                                        goto invalid;
                        }
                        valid = 1;
@@ -1173,7 +1300,7 @@ static int add_rule(struct udev_rules *rules, char *line,
                }
 
                if (strcasecmp(key, "PROGRAM") == 0) {
-                       rule_add_token(&rule_tmp, TK_M_PROGRAM, op, value, NULL);
+                       rule_add_key(&rule_tmp, TK_M_PROGRAM, op, value, NULL);
                        valid = 1;
                        continue;
                }
@@ -1183,7 +1310,7 @@ static int add_rule(struct udev_rules *rules, char *line,
                                err(rules->udev, "invalid RESULT operation\n");
                                goto invalid;
                        }
-                       rule_add_token(&rule_tmp, TK_M_RESULT, op, value, NULL);
+                       rule_add_key(&rule_tmp, TK_M_RESULT, op, value, NULL);
                        valid = 1;
                        continue;
                }
@@ -1192,15 +1319,15 @@ static int add_rule(struct udev_rules *rules, char *line,
                        attr = get_key_attribute(rules->udev, key + sizeof("IMPORT")-1);
                        if (attr != NULL && strstr(attr, "program")) {
                                dbg(rules->udev, "IMPORT will be executed\n");
-                               rule_add_token(&rule_tmp, TK_M_IMPORT_PROG, op, value, NULL);
+                               rule_add_key(&rule_tmp, TK_M_IMPORT_PROG, op, value, NULL);
                                valid = 1;
                        } else if (attr != NULL && strstr(attr, "file")) {
                                dbg(rules->udev, "IMPORT will be included as file\n");
-                               rule_add_token(&rule_tmp, TK_M_IMPORT_FILE, op, value, NULL);
+                               rule_add_key(&rule_tmp, TK_M_IMPORT_FILE, op, value, NULL);
                                valid = 1;
                        } else if (attr != NULL && strstr(attr, "parent")) {
                                dbg(rules->udev, "IMPORT will include the parent values\n");
-                               rule_add_token(&rule_tmp, TK_M_IMPORT_PARENT, op, value, NULL);
+                               rule_add_key(&rule_tmp, TK_M_IMPORT_PARENT, op, value, NULL);
                                valid = 1;
                        } else {
                                /* figure it out if it is executable */
@@ -1225,11 +1352,11 @@ static int add_rule(struct udev_rules *rules, char *line,
                                dbg(rules->udev, "IMPORT auto mode for '%s'\n", file);
                                if (!lstat(file, &statbuf) && (statbuf.st_mode & S_IXUSR)) {
                                        dbg(rules->udev, "IMPORT will be executed (autotype)\n");
-                                       rule_add_token(&rule_tmp, TK_M_IMPORT_PROG, op, value, NULL);
+                                       rule_add_key(&rule_tmp, TK_M_IMPORT_PROG, op, value, NULL);
                                        valid = 1;
                                } else {
                                        dbg(rules->udev, "IMPORT will be included as file (autotype)\n");
-                                       rule_add_token(&rule_tmp, TK_M_IMPORT_FILE, op, value, NULL);
+                                       rule_add_key(&rule_tmp, TK_M_IMPORT_FILE, op, value, NULL);
                                        valid = 1;
                                }
                        }
@@ -1246,9 +1373,9 @@ static int add_rule(struct udev_rules *rules, char *line,
                        attr = get_key_attribute(rules->udev, key + sizeof("TEST")-1);
                        if (attr != NULL) {
                                mode = strtol(attr, NULL, 8);
-                               rule_add_token(&rule_tmp, TK_M_TEST, op, value, &mode);
+                               rule_add_key(&rule_tmp, TK_M_TEST, op, value, &mode);
                        } else {
-                               rule_add_token(&rule_tmp, TK_M_TEST, op, value, NULL);
+                               rule_add_key(&rule_tmp, TK_M_TEST, op, value, NULL);
                        }
                        valid = 1;
                        continue;
@@ -1260,13 +1387,13 @@ static int add_rule(struct udev_rules *rules, char *line,
                        attr = get_key_attribute(rules->udev, key + sizeof("RUN")-1);
                        if (attr != NULL && strstr(attr, "ignore_error"))
                                flag = 1;
-                       rule_add_token(&rule_tmp, TK_A_RUN, op, value, &flag);
+                       rule_add_key(&rule_tmp, TK_A_RUN, op, value, &flag);
                        valid = 1;
                        continue;
                }
 
                if (strcasecmp(key, "WAIT_FOR") == 0 || strcasecmp(key, "WAIT_FOR_SYSFS") == 0) {
-                       rule_add_token(&rule_tmp, TK_M_WAITFOR, 0, value, NULL);
+                       rule_add_key(&rule_tmp, TK_M_WAITFOR, 0, value, NULL);
                        valid = 1;
                        continue;
                }
@@ -1278,40 +1405,42 @@ static int add_rule(struct udev_rules *rules, char *line,
                }
 
                if (strcasecmp(key, "GOTO") == 0) {
-                       rule_add_token(&rule_tmp, TK_A_GOTO, 0, value, NULL);
+                       rule_add_key(&rule_tmp, TK_A_GOTO, 0, value, NULL);
                        valid = 1;
                        continue;
                }
 
                if (strncasecmp(key, "NAME", sizeof("NAME")-1) == 0) {
                        if (op < OP_MATCH_MAX) {
-                               rule_add_token(&rule_tmp, TK_M_NAME, op, value, NULL);
+                               rule_add_key(&rule_tmp, TK_M_NAME, op, value, NULL);
                        } else {
                                if (value[0] == '\0')
                                        dbg(rules->udev, "name empty, node creation suppressed\n");
-                               rule_add_token(&rule_tmp, TK_A_NAME, op, value, NULL);
+                               rule_add_key(&rule_tmp, TK_A_NAME, op, value, NULL);
                                attr = get_key_attribute(rules->udev, key + sizeof("NAME")-1);
                                if (attr != NULL) {
                                        if (strstr(attr, "all_partitions") != NULL) {
                                                int num = DEFAULT_FAKE_PARTITIONS_COUNT;
 
                                                dbg(rules->udev, "creation of partition nodes requested\n");
-                                               rule_add_token(&rule_tmp, TK_A_NUM_FAKE_PART, 0, NULL, &num);
+                                               rule_add_key(&rule_tmp, TK_A_NUM_FAKE_PART, 0, NULL, &num);
                                        }
                                        if (strstr(attr, "ignore_remove") != NULL) {
                                                dbg(rules->udev, "remove event should be ignored\n");
-                                               rule_add_token(&rule_tmp, TK_A_IGNORE_REMOVE, 0, NULL, NULL);
+                                               rule_add_key(&rule_tmp, TK_A_IGNORE_REMOVE, 0, NULL, NULL);
                                        }
                                }
                        }
+                       rule_tmp.rule.rule.flags = 1;
                        continue;
                }
 
                if (strcasecmp(key, "SYMLINK") == 0) {
                        if (op < OP_MATCH_MAX)
-                               rule_add_token(&rule_tmp, TK_M_DEVLINK, op, value, NULL);
+                               rule_add_key(&rule_tmp, TK_M_DEVLINK, op, value, NULL);
                        else
-                               rule_add_token(&rule_tmp, TK_A_DEVLINK, op, value, NULL);
+                               rule_add_key(&rule_tmp, TK_A_DEVLINK, op, value, NULL);
+                       rule_tmp.rule.rule.flags = 1;
                        valid = 1;
                        continue;
                }
@@ -1322,13 +1451,14 @@ static int add_rule(struct udev_rules *rules, char *line,
 
                        uid = strtoul(value, &endptr, 10);
                        if (endptr[0] == '\0') {
-                               rule_add_token(&rule_tmp, TK_A_OWNER_ID, op, NULL, &uid);
+                               rule_add_key(&rule_tmp, TK_A_OWNER_ID, op, NULL, &uid);
                        } else if (rules->resolve_names && strchr("$%", value[0]) == NULL) {
                                uid = add_uid(rules, value);
-                               rule_add_token(&rule_tmp, TK_A_OWNER_ID, op, NULL, &uid);
+                               rule_add_key(&rule_tmp, TK_A_OWNER_ID, op, NULL, &uid);
                        } else {
-                               rule_add_token(&rule_tmp, TK_A_OWNER, op, value, NULL);
+                               rule_add_key(&rule_tmp, TK_A_OWNER, op, value, NULL);
                        }
+                       rule_tmp.rule.rule.flags = 1;
                        valid = 1;
                        continue;
                }
@@ -1339,13 +1469,14 @@ static int add_rule(struct udev_rules *rules, char *line,
 
                        gid = strtoul(value, &endptr, 10);
                        if (endptr[0] == '\0') {
-                               rule_add_token(&rule_tmp, TK_A_GROUP_ID, op, NULL, &gid);
+                               rule_add_key(&rule_tmp, TK_A_GROUP_ID, op, NULL, &gid);
                        } else if (rules->resolve_names && strchr("$%", value[0]) == NULL) {
                                gid = add_gid(rules, value);
-                               rule_add_token(&rule_tmp, TK_A_GROUP_ID, op, NULL, &gid);
+                               rule_add_key(&rule_tmp, TK_A_GROUP_ID, op, NULL, &gid);
                        } else {
-                               rule_add_token(&rule_tmp, TK_A_GROUP, op, value, NULL);
+                               rule_add_key(&rule_tmp, TK_A_GROUP, op, value, NULL);
                        }
+                       rule_tmp.rule.rule.flags = 1;
                        valid = 1;
                        continue;
                }
@@ -1356,9 +1487,10 @@ static int add_rule(struct udev_rules *rules, char *line,
 
                        mode = strtol(value, &endptr, 8);
                        if (endptr[0] == '\0')
-                               rule_add_token(&rule_tmp, TK_A_MODE_ID, op, NULL, &mode);
+                               rule_add_key(&rule_tmp, TK_A_MODE_ID, op, NULL, &mode);
                        else
-                               rule_add_token(&rule_tmp, TK_A_MODE, op, value, NULL);
+                               rule_add_key(&rule_tmp, TK_A_MODE, op, value, NULL);
+                       rule_tmp.rule.rule.flags = 1;
                        valid = 1;
                        continue;
                }
@@ -1368,42 +1500,42 @@ static int add_rule(struct udev_rules *rules, char *line,
 
                        if (strstr(value, "last_rule") != NULL) {
                                dbg(rules->udev, "last rule to be applied\n");
-                               rule_add_token(&rule_tmp, TK_A_LAST_RULE, 0, NULL, NULL);
+                               rule_add_key(&rule_tmp, TK_A_LAST_RULE, 0, NULL, NULL);
                        }
                        if (strstr(value, "ignore_device") != NULL) {
                                dbg(rules->udev, "device should be ignored\n");
-                               rule_add_token(&rule_tmp, TK_A_IGNORE_DEVICE, 0, NULL, NULL);
+                               rule_add_key(&rule_tmp, TK_A_IGNORE_DEVICE, 0, NULL, NULL);
                        }
                        if (strstr(value, "ignore_remove") != NULL) {
                                dbg(rules->udev, "remove event should be ignored\n");
-                               rule_add_token(&rule_tmp, TK_A_IGNORE_REMOVE, 0, NULL, NULL);
+                               rule_add_key(&rule_tmp, TK_A_IGNORE_REMOVE, 0, NULL, NULL);
                        }
                        pos = strstr(value, "link_priority=");
                        if (pos != NULL) {
                                int prio = atoi(&pos[strlen("link_priority=")]);
 
-                               rule_add_token(&rule_tmp, TK_A_DEVLINK_PRIO, 0, NULL, &prio);
+                               rule_add_key(&rule_tmp, TK_A_DEVLINK_PRIO, 0, NULL, &prio);
                                dbg(rules->udev, "link priority=%i\n", prio);
                        }
                        pos = strstr(value, "event_timeout=");
                        if (pos != NULL) {
                                int tout = atoi(&pos[strlen("event_timeout=")]);
 
-                               rule_add_token(&rule_tmp, TK_A_EVENT_TIMEOUT, 0, NULL, &tout);
+                               rule_add_key(&rule_tmp, TK_A_EVENT_TIMEOUT, 0, NULL, &tout);
                                dbg(rules->udev, "event timout=%i\n", tout);
                        }
                        pos = strstr(value, "string_escape=");
                        if (pos != NULL) {
                                pos = &pos[strlen("string_escape=")];
                                if (strncmp(pos, "none", strlen("none")) == 0)
-                                       rule_add_token(&rule_tmp, TK_A_STRING_ESCAPE_NONE, 0, NULL, NULL);
+                                       rule_add_key(&rule_tmp, TK_A_STRING_ESCAPE_NONE, 0, NULL, NULL);
                                else if (strncmp(pos, "replace", strlen("replace")) == 0)
-                                       rule_add_token(&rule_tmp, TK_A_STRING_ESCAPE_REPLACE, 0, NULL, NULL);
+                                       rule_add_key(&rule_tmp, TK_A_STRING_ESCAPE_REPLACE, 0, NULL, NULL);
                        }
                        if (strstr(value, "all_partitions") != NULL) {
                                int num = DEFAULT_FAKE_PARTITIONS_COUNT;
 
-                               rule_add_token(&rule_tmp, TK_A_NUM_FAKE_PART, 0, NULL, &num);
+                               rule_add_key(&rule_tmp, TK_A_NUM_FAKE_PART, 0, NULL, &num);
                                dbg(rules->udev, "creation of partition nodes requested\n");
                        }
                        valid = 1;
@@ -1421,22 +1553,23 @@ static int add_rule(struct udev_rules *rules, char *line,
                goto invalid;
 
        /* add rule token */
+       rule_tmp.rule.rule.token_count = 1 + rule_tmp.token_cur;
        if (add_token(rules, &rule_tmp.rule) != 0)
                goto invalid;
 
        /* add tokens to list, sorted by type */
        if (sort_token(rules, &rule_tmp) != 0)
                goto invalid;
+
        return 0;
 invalid:
        err(rules->udev, "invalid rule '%s:%u'\n", filename, lineno);
        return -1;
 }
 
-static int parse_file(struct udev_rules *rules, const char *filename)
+static int parse_file(struct udev_rules *rules, const char *filename, unsigned short filename_off)
 {
        FILE *f;
-       unsigned int filename_off;
        unsigned int first_token;
        char line[UTIL_LINE_SIZE];
        int line_nr = 0;
@@ -1448,7 +1581,6 @@ static int parse_file(struct udev_rules *rules, const char *filename)
        if (f == NULL)
                return -1;
 
-       filename_off = add_string(rules, filename);
        first_token = rules->token_cur;
 
        while(fgets(line, sizeof(line), f) != NULL) {
@@ -1509,7 +1641,6 @@ static int parse_file(struct udev_rules *rules, const char *filename)
 
 static int add_matching_files(struct udev *udev, struct udev_list_node *file_list, const char *dirname, const char *suffix)
 {
-       struct dirent *ent;
        DIR *dir;
        char filename[UTIL_PATH_SIZE];
 
@@ -1521,26 +1652,28 @@ static int add_matching_files(struct udev *udev, struct udev_list_node *file_lis
        }
 
        while (1) {
-               ent = readdir(dir);
-               if (ent == NULL || ent->d_name[0] == '\0')
+               struct dirent *dent;
+
+               dent = readdir(dir);
+               if (dent == NULL || dent->d_name[0] == '\0')
                        break;
 
-               if ((ent->d_name[0] == '.') || (ent->d_name[0] == '#'))
+               if (dent->d_name[0] == '.')
                        continue;
 
                /* look for file matching with specified suffix */
                if (suffix != NULL) {
                        const char *ext;
 
-                       ext = strrchr(ent->d_name, '.');
+                       ext = strrchr(dent->d_name, '.');
                        if (ext == NULL)
                                continue;
                        if (strcmp(ext, suffix) != 0)
                                continue;
                }
-               dbg(udev, "put file '%s/%s' into list\n", dirname, ent->d_name);
+               dbg(udev, "put file '%s/%s' into list\n", dirname, dent->d_name);
 
-               snprintf(filename, sizeof(filename), "%s/%s", dirname, ent->d_name);
+               snprintf(filename, sizeof(filename), "%s/%s", dirname, dent->d_name);
                filename[sizeof(filename)-1] = '\0';
                udev_list_entry_add(udev, file_list, filename, NULL, 1, 1);
        }
@@ -1553,12 +1686,9 @@ struct udev_rules *udev_rules_new(struct udev *udev, int resolve_names)
 {
        struct udev_rules *rules;
        struct stat statbuf;
-       char filename[PATH_MAX];
        struct udev_list_node file_list;
        struct udev_list_entry *file_loop, *file_tmp;
-       unsigned int prev_rule;
        struct token end_token;
-       unsigned int i;
 
        rules = malloc(sizeof(struct udev_rules));
        if (rules == NULL)
@@ -1573,6 +1703,7 @@ struct udev_rules *udev_rules_new(struct udev *udev, int resolve_names)
        if (rules->tokens == NULL)
                return NULL;
        rules->token_max = PREALLOC_TOKEN;
+
        rules->buf = malloc(PREALLOC_STRBUF);
        if (rules->buf == NULL)
                return NULL;
@@ -1580,13 +1711,22 @@ struct udev_rules *udev_rules_new(struct udev *udev, int resolve_names)
        /* offset 0 is always '\0' */
        rules->buf[0] = '\0';
        rules->buf_cur = 1;
-       info(udev, "prealloc %zu bytes tokens (%u * %zu bytes), %zu bytes buffer\n",
-            rules->token_max * sizeof(struct token), rules->token_max, sizeof(struct token), rules->buf_max);
+       dbg(udev, "prealloc %zu bytes tokens (%u * %zu bytes), %zu bytes buffer\n",
+           rules->token_max * sizeof(struct token), rules->token_max, sizeof(struct token), rules->buf_max);
+
+       rules->trie_nodes = malloc(PREALLOC_TRIE * sizeof(struct trie_node));
+       if (rules->trie_nodes == NULL)
+               return NULL;
+       rules->trie_nodes_max = PREALLOC_TRIE;
+       /* offset 0 is the trie root, with an empty string */
+       memset(rules->trie_nodes, 0x00, sizeof(struct trie_node));
+       rules->trie_nodes_cur = 1;
 
        if (udev_get_rules_path(udev) != NULL) {
                /* custom rules location for testing */
                add_matching_files(udev, &file_list, udev_get_rules_path(udev), ".rules");
        } else {
+               char filename[PATH_MAX];
                struct udev_list_node sort_list;
                struct udev_list_entry *sort_loop, *sort_tmp;
 
@@ -1615,7 +1755,7 @@ struct udev_rules *udev_rules_new(struct udev *udev, int resolve_names)
 
                        if (sort_base == NULL)
                                continue;
-
+                       /* sort entry into existing list */
                        udev_list_entry_foreach_safe(file_loop, file_tmp, udev_list_get_entry(&file_list)) {
                                const char *file_name = udev_list_entry_get_name(file_loop);
                                const char *file_base = strrchr(file_name, '/');
@@ -1625,42 +1765,54 @@ struct udev_rules *udev_rules_new(struct udev *udev, int resolve_names)
                                if (strcmp(file_base, sort_base) == 0) {
                                        info(udev, "rule file basename '%s' already added, ignoring '%s'\n",
                                             file_name, sort_name);
-                                       udev_list_entry_remove(sort_loop);
+                                       udev_list_entry_delete(sort_loop);
                                        sort_loop = NULL;
                                        break;
                                }
-                               if (strcmp(file_base, sort_base) > 0)
+                               if (strcmp(file_base, sort_base) > 0) {
+                                       /* found later file, insert before */
+                                       udev_list_entry_remove(sort_loop);
+                                       udev_list_entry_insert_before(sort_loop, file_loop);
+                                       sort_loop = NULL;
                                        break;
+                               }
                        }
-                       if (sort_loop != NULL)
-                               udev_list_entry_move_before(sort_loop, file_loop);
+                       /* current file already handled */
+                       if (sort_loop == NULL)
+                               continue;
+                       /* no later file, append to end of list */
+                       udev_list_entry_remove(sort_loop);
+                       udev_list_entry_append(sort_loop, &file_list);
                }
        }
 
+       /* add all filenames to the string buffer */
+       udev_list_entry_foreach(file_loop, udev_list_get_entry(&file_list)) {
+               const char *filename = udev_list_entry_get_name(file_loop);
+               unsigned int filename_off;
+
+               filename_off = add_string(rules, filename);
+               /* the offset in the rule is limited to unsigned short */
+               if (filename_off < USHRT_MAX)
+                       udev_list_entry_set_flag(file_loop, filename_off);
+       }
+
        /* parse list of files */
        udev_list_entry_foreach_safe(file_loop, file_tmp, udev_list_get_entry(&file_list)) {
-               const char *file_name = udev_list_entry_get_name(file_loop);
+               const char *filename = udev_list_entry_get_name(file_loop);
+               unsigned int filename_off = udev_list_entry_get_flag(file_loop);
 
-               if (stat(file_name, &statbuf) == 0 && statbuf.st_size > 0)
-                       parse_file(rules, file_name);
+               if (stat(filename, &statbuf) == 0 && statbuf.st_size > 0)
+                       parse_file(rules, filename, filename_off);
                else
-                       info(udev, "can not read '%s'\n", file_name);
-               udev_list_entry_remove(file_loop);
+                       info(udev, "can not read '%s'\n", filename);
+               udev_list_entry_delete(file_loop);
        }
 
        memset(&end_token, 0x00, sizeof(struct token));
        end_token.type = TK_END;
        add_token(rules, &end_token);
 
-       /* link all TK_RULE tokens to be able to fast-forward to next TK_RULE */
-       prev_rule = 0;
-       for (i = 1; i < rules->token_cur; i++) {
-               if (rules->tokens[i].type == TK_RULE) {
-                       rules->tokens[prev_rule].rule.next_rule = i;
-                       prev_rule = i;
-               }
-       }
-
        /* shrink allocated token and string buffer */
        if (rules->token_cur < rules->token_max) {
                struct token *tokens;
@@ -1680,8 +1832,17 @@ struct udev_rules *udev_rules_new(struct udev *udev, int resolve_names)
                        rules->buf_max = rules->buf_cur;
                }
        }
-       info(udev, "shrunk to %lu bytes tokens (%u * %zu bytes), %zu bytes buffer\n",
+       info(udev, "rules use %zu bytes tokens (%u * %zu bytes), %zu bytes buffer\n",
             rules->token_max * sizeof(struct token), rules->token_max, sizeof(struct token), rules->buf_max);
+       info(udev, "temporary index used %zu bytes (%u * %zu bytes)\n",
+            rules->trie_nodes_cur * sizeof(struct trie_node),
+            rules->trie_nodes_cur, sizeof(struct trie_node));
+
+       /* cleanup trie */
+       free(rules->trie_nodes);
+       rules->trie_nodes = NULL;
+       rules->trie_nodes_cur = 0;
+       rules->trie_nodes_max = 0;
 
        /* cleanup uid/gid cache */
        free(rules->uids);
@@ -1703,6 +1864,7 @@ void udev_rules_unref(struct udev_rules *rules)
                return;
        free(rules->tokens);
        free(rules->buf);
+       free(rules->trie_nodes);
        free(rules->uids);
        free(rules->gids);
        free(rules);
@@ -1761,7 +1923,7 @@ static int match_key(struct udev_rules *rules, struct token *token, const char *
                                        pos[0] = '\0';
                                        pos = &pos[1];
                                }
-                               dbg(rules->udev, "match %s '%s' <-> '%s'\n", token_str[token->type], key_value, val);
+                               dbg(rules->udev, "match %s '%s' <-> '%s'\n", token_str(token->type), key_value, val);
                                match = (fnmatch(key_value, val, 0) == 0);
                                if (match)
                                        break;
@@ -1778,36 +1940,39 @@ static int match_key(struct udev_rules *rules, struct token *token, const char *
        }
 
        if (match && (token->key.op == OP_MATCH)) {
-               dbg(rules->udev, "%s is true (matching value)\n", token_str[token->type]);
+               dbg(rules->udev, "%s is true (matching value)\n", token_str(token->type));
                return 0;
        }
        if (!match && (token->key.op == OP_NOMATCH)) {
-               dbg(rules->udev, "%s is true (non-matching value)\n", token_str[token->type]);
+               dbg(rules->udev, "%s is true (non-matching value)\n", token_str(token->type));
                return 0;
        }
-       dbg(rules->udev, "%s is not true\n", token_str[token->type]);
+       dbg(rules->udev, "%s is not true\n", token_str(token->type));
        return -1;
 }
 
 static int match_attr(struct udev_rules *rules, struct udev_device *dev, struct udev_event *event, struct token *cur)
 {
-       char attr[UTIL_PATH_SIZE];
        const char *key_name = &rules->buf[cur->key.attr_off];
        const char *key_value = &rules->buf[cur->key.value_off];
-       char value[UTIL_NAME_SIZE] = "";
+       char value[UTIL_NAME_SIZE];
        size_t len;
 
-       util_strlcpy(attr, key_name, sizeof(attr));
-       util_resolve_subsys_kernel(event->udev, attr, value, sizeof(value), 1);
+       value[0] = '\0';
+       if (key_name[0] == '[') {
+               char attr[UTIL_PATH_SIZE];
+
+               util_strlcpy(attr, key_name, sizeof(attr));
+               util_resolve_subsys_kernel(event->udev, attr, value, sizeof(value), 1);
+       }
        if (value[0] == '\0') {
                const char *val;
 
                val = udev_device_get_sysattr_value(dev, key_name);
-               if (val != NULL)
-                       util_strlcpy(value, val, sizeof(value));
+               if (val == NULL)
+                       return -1;
+               util_strlcpy(value, val, sizeof(value));
        }
-       if (value[0]=='\0')
-               return -1;
 
        /* strip trailing whitespace of value, if not asked to match for it */
        len = strlen(key_value);
@@ -1831,21 +1996,28 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
        struct token *cur;
        struct token *rule;
        enum escape_type esc = ESCAPE_UNSET;
+       int can_set_name;
 
        if (rules->tokens == NULL)
                return -1;
 
+       can_set_name = ((strcmp(udev_device_get_action(event->dev), "add") == 0 ||
+                        strcmp(udev_device_get_action(event->dev), "change") == 0) &&
+                       (major(udev_device_get_devnum(event->dev)) > 0 ||
+                        strcmp(udev_device_get_subsystem(event->dev), "net") == 0));
+
        /* loop through token list, match, run actions or forward to next rule */
        cur = &rules->tokens[0];
        rule = cur;
-       while (cur != NULL && cur->type != TK_END) {
-               unsigned int idx;
-
+       while (1) {
                dump_token(rules, cur);
                switch (cur->type) {
                case TK_RULE:
                        /* current rule */
                        rule = cur;
+                       /* possibly skip rules which want to set NAME, SYMLINK, OWNER, GROUP, MODE */
+                       if (!can_set_name && rule->rule.flags)
+                               ;//goto nomatch;
                        esc = ESCAPE_UNSET;
                        break;
                case TK_M_ACTION:
@@ -1933,7 +2105,7 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
 
                                /* get whole sequence of parent matches */
                                next = cur;
-                               while (next->type < TK_M_PARENTS_MAX)
+                               while (next->type > TK_M_PARENTS_MIN && next->type < TK_M_PARENTS_MAX)
                                        next++;
 
                                /* loop over parents */
@@ -2001,11 +2173,11 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
                                attr_subst_subdir(filename, sizeof(filename));
 
                                match = (stat(filename, &statbuf) == 0);
-                               info(event->udev, "'%s' %s", filename, match ? "exists\n" : "does not exist\n");
+                               dbg(event->udev, "'%s' %s", filename, match ? "exists\n" : "does not exist\n");
                                if (match && cur->key.mode > 0) {
                                        match = ((statbuf.st_mode & cur->key.mode) > 0);
-                                       info(event->udev, "'%s' has mode=%#o and %s %#o\n", filename, statbuf.st_mode,
-                                            match ? "matches" : "does not match", cur->key.mode);
+                                       dbg(event->udev, "'%s' has mode=%#o and %s %#o\n", filename, statbuf.st_mode,
+                                           match ? "matches" : "does not match", cur->key.mode);
                                }
                                if (match && cur->key.op == OP_NOMATCH)
                                        goto nomatch;
@@ -2024,6 +2196,10 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
                                util_strlcpy(program, &rules->buf[cur->key.value_off], sizeof(program));
                                udev_event_apply_format(event, program, sizeof(program));
                                envp = udev_device_get_properties_envp(event->dev);
+                               info(event->udev, "PROGRAM '%s' %s:%u\n",
+                                    program,
+                                    &rules->buf[rule->rule.filename_off],
+                                    rule->rule.filename_line);
                                if (util_run_program(event->udev, program, envp, result, sizeof(result), NULL) != 0) {
                                        if (cur->key.op != OP_NOMATCH)
                                                goto nomatch;
@@ -2032,7 +2208,7 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
 
                                        util_remove_trailing_chars(result, '\n');
                                        if (esc == ESCAPE_UNSET || esc == ESCAPE_REPLACE) {
-                                               count = util_replace_chars(result, ALLOWED_CHARS_INPUT);
+                                               count = udev_util_replace_chars(result, UDEV_ALLOWED_CHARS_INPUT);
                                                if (count > 0)
                                                        info(event->udev, "%i character(s) replaced\n" , count);
                                        }
@@ -2060,6 +2236,10 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
 
                                util_strlcpy(import, &rules->buf[cur->key.value_off], sizeof(import));
                                udev_event_apply_format(event, import, sizeof(import));
+                               info(event->udev, "IMPORT '%s' %s:%u\n",
+                                    import,
+                                    &rules->buf[rule->rule.filename_off],
+                                    rule->rule.filename_line);
                                if (import_program_into_properties(event->dev, import) != 0)
                                        if (cur->key.op != OP_NOMATCH)
                                                goto nomatch;
@@ -2112,6 +2292,10 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
                                util_strlcpy(owner,  &rules->buf[cur->key.value_off], sizeof(owner));
                                udev_event_apply_format(event, owner, sizeof(owner));
                                event->uid = util_lookup_user(event->udev, owner);
+                               info(event->udev, "OWNER %u %s:%u\n",
+                                    event->uid,
+                                    &rules->buf[rule->rule.filename_off],
+                                    rule->rule.filename_line);
                                break;
                        }
                case TK_A_GROUP:
@@ -2125,6 +2309,10 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
                                util_strlcpy(group, &rules->buf[cur->key.value_off], sizeof(group));
                                udev_event_apply_format(event, group, sizeof(group));
                                event->gid = util_lookup_group(event->udev, group);
+                               info(event->udev, "GROUP %u %s:%u\n",
+                                    event->gid,
+                                    &rules->buf[rule->rule.filename_off],
+                                    rule->rule.filename_line);
                                break;
                        }
                case TK_A_MODE:
@@ -2143,6 +2331,10 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
                                        err(event->udev, "invalide mode '%s' set default mode 0660\n", mode);
                                        event->mode = 0660;
                                }
+                               info(event->udev, "MODE %#o %s:%u\n",
+                                    event->mode,
+                                    &rules->buf[rule->rule.filename_off],
+                                    rule->rule.filename_line);
                                break;
                        }
                case TK_A_OWNER_ID:
@@ -2151,6 +2343,10 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
                        if (cur->key.op == OP_ASSIGN_FINAL)
                                event->owner_final = 1;
                        event->uid = cur->key.uid;
+                       info(event->udev, "OWNER %u %s:%u\n",
+                            event->uid,
+                            &rules->buf[rule->rule.filename_off],
+                            rule->rule.filename_line);
                        break;
                case TK_A_GROUP_ID:
                        if (event->group_final)
@@ -2158,6 +2354,10 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
                        if (cur->key.op == OP_ASSIGN_FINAL)
                                event->group_final = 1;
                        event->gid = cur->key.gid;
+                       info(event->udev, "GROUP %u %s:%u\n",
+                            event->gid,
+                            &rules->buf[rule->rule.filename_off],
+                            rule->rule.filename_line);
                        break;
                case TK_A_MODE_ID:
                        if (event->mode_final)
@@ -2165,6 +2365,10 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
                        if (cur->key.op == OP_ASSIGN_FINAL)
                                event->mode_final = 1;
                        event->mode = cur->key.mode;
+                       info(event->udev, "MODE %#o %s:%u\n",
+                            event->mode,
+                            &rules->buf[rule->rule.filename_off],
+                            rule->rule.filename_line);
                        break;
                case TK_A_ENV:
                        {
@@ -2203,11 +2407,15 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
                                util_strlcpy(name_str, name, sizeof(name_str));
                                udev_event_apply_format(event, name_str, sizeof(name_str));
                                if (esc == ESCAPE_UNSET || esc == ESCAPE_REPLACE) {
-                                       count = util_replace_chars(name_str, ALLOWED_CHARS_FILE);
+                                       count = udev_util_replace_chars(name_str, "/");
                                        if (count > 0)
                                                info(event->udev, "%i character(s) replaced\n", count);
                                        free(event->name);
                                        event->name = strdup(name_str);
+                                       info(event->udev, "NAME '%s' %s:%u\n",
+                                            event->name,
+                                            &rules->buf[rule->rule.filename_off],
+                                            rule->rule.filename_line);
                                }
                                break;
                        }
@@ -2231,9 +2439,9 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
                                util_strlcpy(temp, &rules->buf[cur->key.value_off], sizeof(temp));
                                udev_event_apply_format(event, temp, sizeof(temp));
                                if (esc == ESCAPE_UNSET)
-                                       count = util_replace_chars(temp, ALLOWED_CHARS_FILE " ");
+                                       count = udev_util_replace_chars(temp, "/ ");
                                else if (esc == ESCAPE_REPLACE)
-                                       count = util_replace_chars(temp, ALLOWED_CHARS_FILE);
+                                       count = udev_util_replace_chars(temp, "/");
                                if (count > 0)
                                        info(event->udev, "%i character(s) replaced\n" , count);
                                dbg(event->udev, "rule applied, added symlink(s) '%s'\n", temp);
@@ -2243,7 +2451,10 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
                                next = strchr(pos, ' ');
                                while (next) {
                                        next[0] = '\0';
-                                       info(event->udev, "add symlink '%s'\n", pos);
+                                       info(event->udev, "LINK '%s' %s:%u\n",
+                                            pos,
+                                            &rules->buf[rule->rule.filename_off],
+                                            rule->rule.filename_line);
                                        util_strlcpy(filename, udev_get_dev_path(event->udev), sizeof(filename));
                                        util_strlcat(filename, "/", sizeof(filename));
                                        util_strlcat(filename, pos, sizeof(filename));
@@ -2254,7 +2465,10 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
                                        next = strchr(pos, ' ');
                                }
                                if (pos[0] != '\0') {
-                                       info(event->udev, "add symlink '%s'\n", pos);
+                                       info(event->udev, "LINK '%s' %s:%u\n",
+                                            pos,
+                                            &rules->buf[rule->rule.filename_off],
+                                            rule->rule.filename_line);
                                        util_strlcpy(filename, udev_get_dev_path(event->udev), sizeof(filename));
                                        util_strlcat(filename, "/", sizeof(filename));
                                        util_strlcat(filename, pos, sizeof(filename));
@@ -2286,7 +2500,9 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
 
                                util_strlcpy(value, &rules->buf[cur->key.value_off], sizeof(value));
                                udev_event_apply_format(event, value, sizeof(value));
-                               info(event->udev, "writing '%s' to sysfs file '%s'\n", value, attr);
+                               info(event->udev, "ATTR '%s' writing '%s' %s:%u\n", attr, value,
+                                    &rules->buf[rule->rule.filename_off],
+                                    rule->rule.filename_line);
                                f = fopen(attr, "w");
                                if (f != NULL) {
                                        if (!event->test)
@@ -2304,6 +2520,10 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
 
                                if (cur->key.op == OP_ASSIGN || cur->key.op == OP_ASSIGN_FINAL)
                                        udev_list_cleanup_entries(event->udev, &event->run_list);
+                               info(event->udev, "RUN '%s' %s:%u\n",
+                                    &rules->buf[cur->key.value_off],
+                                    &rules->buf[rule->rule.filename_off],
+                                    rule->rule.filename_line);
                                list_entry = udev_list_entry_add(event->udev, &event->run_list,
                                                                 &rules->buf[cur->key.value_off], NULL, 1, 0);
                                if (cur->key.ignore_error)
@@ -2314,11 +2534,12 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
                        cur = &rules->tokens[cur->key.rule_goto];
                        continue;
                case TK_A_LAST_RULE:
-                       break;
+               case TK_END:
+                       return 0;
 
+               case TK_M_PARENTS_MIN:
                case TK_M_PARENTS_MAX:
                case TK_M_MAX:
-               case TK_END:
                case TK_UNSET:
                        err(rules->udev, "wrong type %u\n", cur->type);
                        goto nomatch;
@@ -2328,11 +2549,8 @@ int udev_rules_apply_to_event(struct udev_rules *rules, struct udev_event *event
                continue;
        nomatch:
                /* fast-forward to next rule */
-               idx = rule->rule.next_rule;
-               if (idx == 0)
-                       break;
-               dbg(rules->udev, "forward to rule: %u\n", idx);
-               cur = &rules->tokens[idx];
+               cur = rule + rule->rule.token_count;
+               dbg(rules->udev, "forward to rule: %u\n",
+                                (unsigned int) (cur - rules->tokens));
        }
-       return 0;
 }