chiark / gitweb /
libudev: subsytem -> subsystem
[elogind.git] / udev / udev-event.c
index 27bb5eb79ac545e6f60fdc29bf2f83752f3e436e..93a65e7352602b27d3a993a1e62d3516ffb9f40a 100644 (file)
@@ -231,8 +231,9 @@ found:
                        break;
                case SUBST_DRIVER:
                        if (event->dev_parent != NULL) {
-                               const char *driver = udev_device_get_driver(event->dev_parent);
+                               const char *driver;
 
+                               driver = udev_device_get_driver(event->dev_parent);
                                if (driver == NULL)
                                        break;
                                util_strlcat(string, driver, maxsize);
@@ -398,6 +399,8 @@ found:
                                struct udev_list_entry *list_entry;
 
                                list_entry = udev_device_get_devlinks_list_entry(dev);
+                               if (list_entry == NULL)
+                                       break;
                                util_strlcat(string, &udev_list_entry_get_name(list_entry)[devlen], maxsize);
                                udev_list_entry_foreach(list_entry, udev_list_entry_get_next(list_entry)) {
                                        util_strlcat(string, " ", maxsize);
@@ -426,6 +429,8 @@ found:
                                if (list_entry == NULL)
                                        break;
                                value = udev_list_entry_get_value(list_entry);
+                               if (value == NULL)
+                                       break;
                                dbg(event->udev, "substitute env '%s=%s'\n", attr, value);
                                util_strlcat(string, value, maxsize);
                                break;
@@ -509,7 +514,7 @@ static int rename_netif(struct udev_event *event)
 
                /* wait 30 seconds for our target to become available */
                util_strlcpy(ifr.ifr_name, ifr.ifr_newname, IFNAMSIZ);
-               util_strlcpy(ifr.ifr_newname, udev_device_get_devnode(dev), IFNAMSIZ);
+               util_strlcpy(ifr.ifr_newname, event->name, IFNAMSIZ);
                loop = 30 * 20;
                while (loop--) {
                        err = ioctl(sk, SIOCSIFNAME, &ifr);
@@ -524,7 +529,7 @@ static int rename_netif(struct udev_event *event)
                                break;
                        }
                        dbg(event->udev, "wait for netif '%s' to become free, loop=%i\n",
-                           udev_device_get_devnode(dev), (30 * 20) - loop);
+                           event->name, (30 * 20) - loop);
                        usleep(1000 * 1000 / 20);
                }
        }
@@ -606,6 +611,7 @@ int udev_event_execute_rules(struct udev_event *event, struct udev_rules *rules)
        /* add netif */
        if (strcmp(udev_device_get_subsystem(dev), "net") == 0 && strcmp(udev_device_get_action(dev), "add") == 0) {
                dbg(event->udev, "netif add '%s'\n", udev_device_get_devpath(dev));
+               udev_device_delete_db(dev);
 
                udev_rules_apply_to_event(rules, event);
                if (event->ignore_device) {
@@ -639,6 +645,7 @@ int udev_event_execute_rules(struct udev_event *event, struct udev_rules *rules)
                                info(event->udev, "changed devpath to '%s'\n", udev_device_get_devpath(dev));
                        }
                }
+               udev_device_update_db(dev);
                goto exit;
        }
 
@@ -679,6 +686,11 @@ int udev_event_execute_rules(struct udev_event *event, struct udev_rules *rules)
        udev_rules_apply_to_event(rules, event);
        if (event->ignore_device)
                info(event->udev, "device event will be ignored\n");
+
+       if (strcmp(udev_device_get_action(dev), "remove") != 0)
+               udev_device_update_db(dev);
+       else
+               udev_device_delete_db(dev);
 exit:
        return err;
 }