chiark / gitweb /
libudev: fix typo in "multiple entries in symlink" handling
[elogind.git] / udev / lib / libudev-device.c
index b3731412b4de2b94d5dd4db1e63e8ab176193a05..55fcad655e2ba092d53d0e1a6288d13ff2de65da 100644 (file)
@@ -77,29 +77,51 @@ static int device_read_db(struct udev_device *udev_device)
        syspath_to_db_path(udev_device, filename, sizeof(filename));
 
        if (lstat(filename, &stats) != 0) {
-               info(udev_device->udev, "no db file to read %s: %s\n", filename, strerror(errno));
+               info(udev_device->udev, "no db file to read %s: %m\n", filename);
                return -1;
        }
        if ((stats.st_mode & S_IFMT) == S_IFLNK) {
                char target[UTIL_PATH_SIZE];
                int target_len;
+               char *next;
 
                target_len = readlink(filename, target, sizeof(target));
                if (target_len > 0)
                        target[target_len] = '\0';
                else {
-                       info(udev_device->udev, "error reading db link %s: %s\n", filename, strerror(errno));
+                       info(udev_device->udev, "error reading db link %s: %m\n", filename);
                        return -1;
                }
+
+               next = strchr(target, ' ');
+               if (next != NULL) {
+                       next[0] = '\0';
+                       next = &next[1];
+               }
                if (asprintf(&udev_device->devnode, "%s/%s", udev_get_dev_path(udev_device->udev), target) < 0)
                        return -ENOMEM;
+               while (next != NULL) {
+                       char linkname[UTIL_PATH_SIZE];
+                       const char *lnk;
+
+                       lnk = next;
+                       next = strchr(next, ' ');
+                       if (next != NULL) {
+                               next[0] = '\0';
+                               next = &next[1];
+                       }
+                       util_strlcpy(linkname, udev_get_dev_path(udev_device->udev), sizeof(linkname));
+                       util_strlcat(linkname, "/", sizeof(linkname));
+                       util_strlcat(linkname, lnk, sizeof(linkname));
+                       device_add_devlink(udev_device, linkname);
+               }
                info(udev_device->udev, "device %p filled with db symlink data '%s'\n", udev_device, udev_device->devnode);
                return 0;
        }
 
        f = fopen(filename, "r");
        if (f == NULL) {
-               info(udev_device->udev, "error reading db file %s: %s\n", filename, strerror(errno));
+               info(udev_device->udev, "error reading db file %s: %m\n", filename);
                return -1;
        }
        while (fgets(line, sizeof(line), f)) {
@@ -193,7 +215,7 @@ void device_set_info_loaded(struct udev_device *device)
        device->info_loaded = 1;
 }
 
-struct udev_device *device_init(struct udev *udev)
+struct udev_device *device_new(struct udev *udev)
 {
        struct udev_device *udev_device;
 
@@ -229,7 +251,10 @@ struct udev_device *device_init(struct udev *udev)
  **/
 struct udev_device *udev_device_new_from_syspath(struct udev *udev, const char *syspath)
 {
+       size_t len;
+       const char *subdir;
        char path[UTIL_PATH_SIZE];
+       char *pos;
        struct stat statbuf;
        struct udev_device *udev_device;
 
@@ -238,20 +263,67 @@ struct udev_device *udev_device_new_from_syspath(struct udev *udev, const char *
        if (syspath == NULL)
                return NULL;
 
-       util_strlcpy(path, syspath, sizeof(path));
-       util_strlcat(path, "/uevent", sizeof(path));
-       if (stat(path, &statbuf) != 0) {
-               info(udev, "not a device :%s\n", syspath);
+       /* path starts in sys */
+       len = strlen(udev_get_sys_path(udev));
+       if (strncmp(syspath, udev_get_sys_path(udev), len) != 0) {
+               info(udev, "not in sys :%s\n", syspath);
                return NULL;
        }
 
-       udev_device = device_init(udev);
-       if (udev_device == NULL)
+       /* path is not a root directory */
+       subdir = &syspath[len+1];
+       pos = strrchr(subdir, '/');
+       if (pos == NULL || pos < &subdir[2]) {
+               info(udev, "not a subdir :%s\n", syspath);
                return NULL;
+       }
 
        /* resolve possible symlink to real path */
        util_strlcpy(path, syspath, sizeof(path));
        util_resolve_sys_link(udev, path, sizeof(path));
+
+       /* try to resolve the silly block layout if needed */
+       if (strncmp(&path[len], "/block/", 7) == 0) {
+               char block[UTIL_PATH_SIZE];
+               char part[UTIL_PATH_SIZE];
+
+               util_strlcpy(block, path, sizeof(block));
+               pos = strrchr(block, '/');
+               if (pos == NULL)
+                       return NULL;
+               util_strlcpy(part, pos, sizeof(part));
+               pos[0] = '\0';
+               if (util_resolve_sys_link(udev, block, sizeof(block)) == 0) {
+                       util_strlcpy(path, block, sizeof(path));
+                       util_strlcat(path, part, sizeof(path));
+               }
+       }
+
+       /* path exists in sys */
+       if (strncmp(&syspath[len], "/devices/", 9) == 0 ||
+           strncmp(&syspath[len], "/class/", 7) == 0 ||
+           strncmp(&syspath[len], "/block/", 7) == 0) {
+               char file[UTIL_PATH_SIZE];
+
+               /* all "devices" require a "uevent" file */
+               util_strlcpy(file, path, sizeof(file));
+               util_strlcat(file, "/uevent", sizeof(file));
+               if (stat(file, &statbuf) != 0) {
+                       info(udev, "not a device: %s\n", syspath);
+                       return NULL;
+               }
+       } else {
+               /* everything else just needs to be a directory */
+               if (stat(path, &statbuf) != 0 || !S_ISDIR(statbuf.st_mode)) {
+                       info(udev, "directory not found: %s\n", syspath);
+                       return NULL;
+               }
+       }
+
+       udev_device = device_new(udev);
+       if (udev_device == NULL)
+               return NULL;
+
        device_set_syspath(udev_device, path);
        info(udev, "device %p has devpath '%s'\n", udev_device, udev_device_get_devpath(udev_device));
 
@@ -262,7 +334,7 @@ struct udev_device *udev_device_new_from_devnum(struct udev *udev, char type, de
 {
        char path[UTIL_PATH_SIZE];
        const char *type_str;
-       struct udev_enumerate *enumerate;
+       struct udev_enumerate *udev_enumerate;
        struct udev_list_entry *list_entry;
        struct udev_device *device = NULL;
 
@@ -273,29 +345,39 @@ struct udev_device *udev_device_new_from_devnum(struct udev *udev, char type, de
        else
                return NULL;
 
-       /* /sys/dev/{block,char}/<maj>:<min> links */
+       /* /sys/dev/{block,char}/<maj>:<min> link */
        snprintf(path, sizeof(path), "%s/dev/%s/%u:%u", udev_get_sys_path(udev),
                 type_str, major(devnum), minor(devnum));
        if (util_resolve_sys_link(udev, path, sizeof(path)) == 0)
                return udev_device_new_from_syspath(udev, path);
 
-       /* fallback to search all sys devices for the major/minor */
-       enumerate = udev_enumerate_new_from_subsystems(udev, NULL);
-       if (enumerate == NULL)
+       udev_enumerate = udev_enumerate_new(udev);
+       if (udev_enumerate == NULL)
                return NULL;
-       udev_list_entry_foreach(list_entry, udev_enumerate_get_list_entry(enumerate)) {
+
+       /* fallback to search sys devices for the major/minor */
+       if (type == 'b')
+               udev_enumerate_add_match_subsystem(udev_enumerate, "block");
+       else if (type == 'c')
+               udev_enumerate_add_nomatch_subsystem(udev_enumerate, "block");
+       udev_enumerate_scan_devices(udev_enumerate);
+       udev_list_entry_foreach(list_entry, udev_enumerate_get_list_entry(udev_enumerate)) {
                struct udev_device *device_loop;
 
                device_loop = udev_device_new_from_syspath(udev, udev_list_entry_get_name(list_entry));
                if (device_loop != NULL) {
                        if (udev_device_get_devnum(device_loop) == devnum) {
+                               if (type == 'b' && strcmp(udev_device_get_subsystem(device_loop), "block") != 0)
+                                       continue;
+                               if (type == 'c' && strcmp(udev_device_get_subsystem(device_loop), "block") == 0)
+                                       continue;
                                device = device_loop;
                                break;
                        }
                        udev_device_unref(device_loop);
                }
        }
-       udev_enumerate_unref(enumerate);
+       udev_enumerate_unref(udev_enumerate);
        return device;
 }
 
@@ -303,37 +385,39 @@ static struct udev_device *device_new_from_parent(struct udev_device *udev_devic
 {
        struct udev_device *udev_device_parent = NULL;
        char path[UTIL_PATH_SIZE];
-       char *pos;
+       const char *subdir;
 
-       if (udev_device == NULL)
-               return NULL;
+       /* follow "device" link in deprecated sys layout */
+       if (strncmp(udev_device->devpath, "/class/", 7) == 0 ||
+           strncmp(udev_device->devpath, "/block/", 7) == 0) {
+               util_strlcpy(path, udev_device->syspath, sizeof(path));
+               util_strlcat(path, "/device", sizeof(path));
+               if (util_resolve_sys_link(udev_device->udev, path, sizeof(path)) == 0)
+                       udev_device_parent = udev_device_new_from_syspath(udev_device->udev, path);
+               return udev_device_parent;
+       }
 
        util_strlcpy(path, udev_device->syspath, sizeof(path));
+       subdir = &path[strlen(udev_get_sys_path(udev_device->udev))+1];
        while (1) {
-               pos = strrchr(path, '/');
-               if (pos == path || pos == NULL)
+               char *pos;
+
+               pos = strrchr(subdir, '/');
+               if (pos == NULL || pos < &subdir[2])
                        break;
                pos[0] = '\0';
                udev_device_parent = udev_device_new_from_syspath(udev_device->udev, path);
                if (udev_device_parent != NULL)
                        return udev_device_parent;
        }
-
-       /* follow "device" link in deprecated sys /sys/class/ layout */
-       if (strncmp(udev_device->devpath, "/class/", 7) == 0) {
-               util_strlcpy(path, udev_device->syspath, sizeof(path));
-               util_strlcat(path, "/device", sizeof(path));
-               if (util_resolve_sys_link(udev_device->udev, path, sizeof(path)) == 0) {
-                       udev_device_parent = udev_device_new_from_syspath(udev_device->udev, path);
-                       if (udev_device_parent != NULL)
-                               return udev_device_parent;
-               }
-       }
        return NULL;
 }
 
 struct udev_device *udev_device_get_parent(struct udev_device *udev_device)
 {
+       if (udev_device == NULL)
+               return NULL;
+
        if (udev_device->parent_device != NULL) {
                info(udev_device->udev, "returning existing parent %p\n", udev_device->parent_device);
                return udev_device->parent_device;
@@ -342,6 +426,22 @@ struct udev_device *udev_device_get_parent(struct udev_device *udev_device)
        return udev_device->parent_device;
 }
 
+struct udev_device *udev_device_get_parent_with_subsystem(struct udev_device *udev_device, const char *subsystem)
+{
+       struct udev_device *parent;
+
+       parent = udev_device_get_parent(udev_device);
+       while (parent != NULL) {
+               const char *parent_subsystem;
+
+               parent_subsystem = udev_device_get_subsystem(parent);
+               if (parent_subsystem != NULL && strcmp(parent_subsystem, subsystem) == 0)
+                       break;
+               parent = udev_device_get_parent(parent);
+       }
+       return parent;
+}
+
 /**
  * udev_device_get_udev:
  * @udev_device: udev device
@@ -606,7 +706,7 @@ const char *udev_device_get_attr_value(struct udev_device *udev_device, const ch
        util_strlcat(path, attr, sizeof(path));
 
        if (lstat(path, &statbuf) != 0) {
-               info(udev_device->udev, "stat '%s' failed: %s\n", path, strerror(errno));
+               info(udev_device->udev, "stat '%s' failed: %m\n", path);
                goto out;
        }