chiark / gitweb /
[PATCH] implement printf-like placeholder support for NAME
[elogind.git] / udev-add.c
index 54af7e4d77bd0494dbbbf671a8495664ae354975..6f0e3bf10521d6e3f480262c24acb3b93ec90f29 100644 (file)
 #include <fcntl.h>
 #include <unistd.h>
 #include <errno.h>
+#include <sys/stat.h>
 
 #include "udev.h"
 #include "udev_version.h"
 #include "namedev.h"
+#include "udevdb.h"
 #include "libsysfs/libsysfs.h"
 
-
-static char sysfs_path[SYSFS_PATH_MAX];
-
 /* 
  * Right now the major/minor of a device is stored in a file called
  * "dev" in sysfs.
  * The number is stored as:
- *     MMmm
+ *     MM:mm
  *             MM is the major
  *             mm is the minor
- *             The value is in hex.
- * Yes, this will probably change when we go to a bigger major/minor
- * range, and will have to be changed at that time.
+ *             The value is in decimal.
  */
-static int get_major_minor(struct sysfs_class_device *class_dev, int *major, int *minor)
+static int get_major_minor(struct sysfs_class_device *class_dev, struct udevice *udev)
 {
        int retval = -ENODEV;
 
@@ -59,10 +56,10 @@ static int get_major_minor(struct sysfs_class_device *class_dev, int *major, int
 
        dbg("dev = %s", dev);
 
-       if (sscanf(dev, "%u:%u", major, minor) != 2)
+       if (sscanf(dev, "%u:%u", &udev->major, &udev->minor) != 2)
                goto exit;
 
-       dbg("found major = %d, minor = %d", *major, *minor);
+       dbg("found major = %d, minor = %d", udev->major, udev->minor);
 
        retval = 0;
 exit:
@@ -70,55 +67,107 @@ exit:
 }
 
 /*
- * We also want to add some permissions here, and possibly some symlinks
+ * we possibly want to add some symlinks here
+ * only numeric owner/group id's are supported
  */
-static int create_node(char *name, char type, int major, int minor, int mode)
+static int create_node(struct udevice *dev)
 {
-       char *argv[7];
-       char mode_string[100];
-       char type_string[3];
-       char major_string[20];
-       char minor_string[20];
        char filename[255];
        int retval = 0;
+       uid_t uid = 0;
+       gid_t gid = 0;
+       dev_t res;
+
+       strncpy(filename, udev_root, sizeof(filename));
+       strncat(filename, dev->name, sizeof(filename));
+
+#ifdef __KLIBC__
+       res = (dev->major << 8) | (dev->minor);
+#else
+       res = makedev(dev->major, dev->minor);
+#endif
+
+       switch (dev->type) {
+       case 'b':
+               dev->mode |= S_IFBLK;
+               break;
+       case 'c':
+       case 'u':
+               dev->mode |= S_IFCHR;
+               break;
+       case 'p':
+               dev->mode |= S_IFIFO;
+               break;
+       default:
+               dbg("unknown node type %c\n", dev->type);
+               return -EINVAL;
+       }
+
+       /* create subdirectories if requested */
+       if (strchr(dev->name, '/')) {
+               char path[255];
+               char *pos;
+               struct stat stats;
+
+               strncpy(path, filename, sizeof(path));
+               pos = strchr(path+1, '/');
+               while (1) {
+                       pos = strchr(pos+1, '/');
+                       if (pos == NULL)
+                               break;
+                       *pos = 0x00;
+                       if (stat(path, &stats)) {
+                               retval = mkdir(path, 0755);
+                               if (retval) {
+                                       dbg("mkdir(%s) failed with error '%s'",
+                                           path, strerror(errno));
+                                       return retval;
+                               }
+                               dbg("created %s", path);
+                       }
+                       *pos = '/';
+               }
+       }
+
+       dbg("mknod(%s, %#o, %u, %u)", filename, dev->mode, dev->major, dev->minor);
+       retval = mknod(filename, dev->mode, res);
+       if (retval)
+               dbg("mknod(%s, %#o, %u, %u) failed with error '%s'",
+                   filename, dev->mode, dev->major, dev->minor, strerror(errno));
+
+       if (*dev->owner) {
+               char *endptr;
+               unsigned long id = strtoul(dev->owner, &endptr, 10);
+               if (*endptr == 0x00)
+                       uid = (uid_t) id;
+               else
+                       dbg("only numeric owner id supported: %s", dev->owner);
+       }
 
-       strncpy(filename, UDEV_ROOT, sizeof(filename));
-       strncat(filename, name, sizeof(filename));
-
-       snprintf(mode_string, sizeof(mode_string), "--mode=%#o", mode);
-       snprintf(type_string, sizeof(type_string), "%c", type);
-       snprintf(major_string, sizeof(major_string), "%d", major);
-       snprintf(minor_string, sizeof(minor_string), "%d", minor);
-       
-       argv[0] = MKNOD;
-       argv[1] = mode_string;
-       argv[2] = filename;
-       argv[3] = type_string;
-       argv[4] = major_string;
-       argv[5] = minor_string;
-       argv[6] = NULL;
-       dbg ("executing %s %s %s %s %s %s",
-               argv[0], argv[1], argv[2], argv[3], argv[4], argv[5]);
-       switch (fork()) {
-               case 0:
-                       /* we are the child, so lets run the program */
-                       execv (MKNOD, argv);
-                       exit(0);
-                       break;
-               case (-1):
-                       dbg ("fork failed.");
-                       retval = -EFAULT;
-                       break;
-               default:
-                       break;
+       if (*dev->group) {
+               char *endptr;
+               unsigned long id = strtoul(dev->group, &endptr, 10);
+               if (*endptr == 0x00)
+                       gid = (gid_t) id;
+               else
+                       dbg("only numeric group id supported: %s", dev->group);
        }
+
+       if (uid || gid) {
+               dbg("chown(%s, %u, %u)", filename, uid, gid);
+               retval = chown(filename, uid, gid);
+               if (retval)
+                       dbg("chown(%s, %u, %u) failed with error '%s'", filename,
+                           uid, gid, strerror(errno));
+       }
+
        return retval;
 }
 
-struct sysfs_class_device *get_class_dev(char *device_name)
+static struct sysfs_class_device *get_class_dev(char *device_name)
 {
        char dev_path[SYSFS_PATH_MAX];
-       struct sysfs_class_device *class_dev;
+       struct sysfs_class_device *class_dev = NULL;
 
        strcpy(dev_path, sysfs_path);
        strcat(dev_path, device_name);
@@ -129,65 +178,87 @@ struct sysfs_class_device *get_class_dev(char *device_name)
        class_dev = sysfs_open_class_device(dev_path);
        if (class_dev == NULL) {
                dbg ("sysfs_open_class_device failed");
-               return NULL;
+               goto exit;
        }
        dbg("class_dev->name = %s", class_dev->name);
 
+exit:
        return class_dev;
 }
 
-static int udev_init(void)
+/* wait for the "dev" file to show up in the directory in sysfs.
+ * If it doesn't happen in about 10 seconds, give up.
+ */
+#define SECONDS_TO_WAIT_FOR_DEV                10
+static int sleep_for_dev(char *path)
 {
+       char filename[SYSFS_PATH_MAX + 6];
+       int loop = SECONDS_TO_WAIT_FOR_DEV;
        int retval;
 
-       retval = sysfs_get_mnt_path(sysfs_path, SYSFS_PATH_MAX);
-       dbg("sysfs_path = %s", sysfs_path);
+       strcpy(filename, sysfs_path);
+       strcat(filename, path);
+       strcat(filename, "/dev");
+
+       while (loop--) {
+               struct stat buf;
+
+               dbg("looking for %s", filename);
+               retval = stat(filename, &buf);
+               if (!retval)
+                       goto exit;
+
+               /* sleep for a second or two to give the kernel a chance to
+                * create the dev file */
+               sleep(1);
+       }
+       retval = -ENODEV;
+exit:
        return retval;
 }
 
-int udev_add_device(char *device, char *subsystem)
+int udev_add_device(char *path, char *subsystem)
 {
-       struct sysfs_class_device *class_dev;
-       struct device_attr attr;
-       //char *name;
-       int major;
-       int minor;
-       char type;
-       //int mode;
+       struct sysfs_class_device *class_dev = NULL;
+       struct udevice dev;
        int retval = -EINVAL;
 
-       /* sleep for a second or two to give the kernel a chance to
-        * create the dev file
-        */
-       sleep(1);
-
-       udev_init();
-
        /* for now, the block layer is the only place where block devices are */
        if (strcmp(subsystem, "block") == 0)
-               type = 'b';
+               dev.type = 'b';
        else
-               type = 'c';
+               dev.type = 'c';
 
-       class_dev = get_class_dev(device);
-       if (class_dev == NULL)
+       retval = sleep_for_dev(path);
+       if (retval)
                goto exit;
 
-       retval = namedev_name_device(class_dev, &attr);
-       if (retval)
-               return retval;
+       class_dev = get_class_dev(path);
+       if (class_dev == NULL)
+               goto exit;
 
-       retval = get_major_minor(class_dev, &major, &minor);
+       retval = get_major_minor(class_dev, &dev);
        if (retval) {
-               dbg ("get_major_minor failed");
+               dbg("get_major_minor failed");
                goto exit;
        }
 
-       sysfs_close_class_device(class_dev);
+       retval = namedev_name_device(class_dev, &dev);
+       if (retval)
+               goto exit;
+
+       retval = udevdb_add_dev(path, &dev);
+       if (retval != 0)
+               dbg("udevdb_add_dev failed, but we are going to try to create the node anyway. "
+                   "But remove might not work properly for this device.");
 
-       return create_node(attr.name, type, major, minor, attr.mode);
+       dbg("name = %s", dev.name);
+       retval = create_node(&dev);
 
 exit:
+       if (class_dev)
+               sysfs_close_class_device(class_dev);
+
        return retval;
 }