service: add minimal access control logic for notifcation socket

[elogind.git] / src / service.c

diff --git a/src/service.c b/src/service.c
index a767c34f58b89a1af3c69f7d7cb25ce9bbfbb930..abd2a6d7c202182f46e1b917d8260bdb8ded1f2d 100644 (file)
--- a/src/service.c
+++ b/src/service.c
@@ -127,6 +127,8 @@ static void service_unwatch_main_pid(Service *s) {
 }
 
 static int service_set_main_pid(Service *s, pid_t pid) {
+        pid_t ppid;
+
         assert(s);
 
         if (pid <= 1)
@@ -135,26 +137,16 @@ static int service_set_main_pid(Service *s, pid_t pid) {
         if (pid == getpid())
                 return -EINVAL;
 
+        if (get_parent_of_pid(pid, &ppid) >= 0 && ppid != getpid())
+                log_warning("%s: Supervising process %lu which is not our child. We'll most likely not notice when it exits.",
+                            s->meta.id, (unsigned long) pid);
+
         s->main_pid = pid;
         s->main_pid_known = true;
 
         return 0;
 }
 
-static int service_set_control_pid(Service *s, pid_t pid) {
-        assert(s);
-
-        if (pid <= 1)
-                return -EINVAL;
-
-        if (pid == getpid())
-                return -EINVAL;
-
-        s->control_pid = pid;
-
-        return 0;
-}
-
 static void service_close_socket_fd(Service *s) {
         assert(s);
 
@@ -858,6 +850,9 @@ static int service_load(Unit *u) {
                         if ((r = unit_watch_bus_name(u, s->bus_name)) < 0)
                             return r;
                 }
+
+                if (s->type == SERVICE_NOTIFY && s->notify_access == NOTIFY_NONE)
+                        s->notify_access = NOTIFY_MAIN;
         }
 
         return service_verify(s);
@@ -881,13 +876,15 @@ static void service_dump(Unit *u, FILE *f, const char *prefix) {
                 "%sRootDirectoryStartOnly: %s\n"
                 "%sValidNoProcess: %s\n"
                 "%sKillMode: %s\n"
-                "%sType: %s\n",
+                "%sType: %s\n"
+                "%sNotifyAccess: %s\n",
                 prefix, service_state_to_string(s->state),
                 prefix, yes_no(s->permissions_start_only),
                 prefix, yes_no(s->root_directory_start_only),
                 prefix, yes_no(s->valid_no_process),
                 prefix, kill_mode_to_string(s->kill_mode),
-                prefix, service_type_to_string(s->type));
+                prefix, service_type_to_string(s->type),
+                prefix, notify_access_to_string(s->notify_access));
 
         if (s->control_pid > 0)
                 fprintf(f,
@@ -1253,13 +1250,14 @@ static int service_spawn(
                 bool pass_fds,
                 bool apply_permissions,
                 bool apply_chroot,
+                bool set_notify_socket,
                 pid_t *_pid) {
 
         pid_t pid;
         int r;
         int *fds = NULL;
         unsigned n_fds = 0;
-        char **argv;
+        char **argv = NULL, **env = NULL;
 
         assert(s);
         assert(c);
@@ -1284,11 +1282,29 @@ static int service_spawn(
                 goto fail;
         }
 
+        if (set_notify_socket) {
+                char *t;
+
+                if (asprintf(&t, "NOTIFY_SOCKET=@%s", s->meta.manager->notify_socket) < 0) {
+                        r = -ENOMEM;
+                        goto fail;
+                }
+
+                env = strv_env_set(s->meta.manager->environment, t);
+                free(t);
+
+                if (!env) {
+                        r = -ENOMEM;
+                        goto fail;
+                }
+        } else
+                env = s->meta.manager->environment;
+
         r = exec_spawn(c,
                        argv,
                        &s->exec_context,
                        fds, n_fds,
-                       s->meta.manager->environment,
+                       env,
                        apply_permissions,
                        apply_chroot,
                        UNIT(s)->meta.manager->confirm_spawn,
@@ -1296,6 +1312,12 @@ static int service_spawn(
                        &pid);
 
         strv_free(argv);
+        argv = NULL;
+
+        if (set_notify_socket)
+                strv_free(env);
+        env = NULL;
+
         if (r < 0)
                 goto fail;
 
@@ -1317,6 +1339,11 @@ static int service_spawn(
 fail:
         free(fds);
 
+        strv_free(argv);
+
+        if (set_notify_socket)
+                strv_free(env);
+
         if (timeout)
                 unit_unwatch_timer(UNIT(s), &s->timer_watch);
 
@@ -1403,6 +1430,7 @@ static void service_enter_stop_post(Service *s, bool success) {
                                        false,
                                        !s->permissions_start_only,
                                        !s->root_directory_start_only,
+                                       false,
                                        &s->control_pid)) < 0)
                         goto fail;
 
@@ -1485,7 +1513,6 @@ fail:
 
 static void service_enter_stop(Service *s, bool success) {
         int r;
-        pid_t pid;
 
         assert(s);
 
@@ -1502,10 +1529,10 @@ static void service_enter_stop(Service *s, bool success) {
                                        false,
                                        !s->permissions_start_only,
                                        !s->root_directory_start_only,
-                                       &pid)) < 0)
+                                       false,
+                                       &s->control_pid)) < 0)
                         goto fail;
 
-                service_set_control_pid(s, pid);
                 service_set_state(s, SERVICE_STOP);
         } else
                 service_enter_signal(s, SERVICE_STOP_SIGTERM, true);
@@ -1535,7 +1562,6 @@ static void service_enter_running(Service *s, bool success) {
 
 static void service_enter_start_post(Service *s) {
         int r;
-        pid_t pid;
         assert(s);
 
         service_unwatch_control_pid(s);
@@ -1548,10 +1574,10 @@ static void service_enter_start_post(Service *s) {
                                        false,
                                        !s->permissions_start_only,
                                        !s->root_directory_start_only,
-                                       &pid)) < 0)
+                                       false,
+                                       &s->control_pid)) < 0)
                         goto fail;
 
-                service_set_control_pid(s, pid);
                 service_set_state(s, SERVICE_START_POST);
         } else
                 service_enter_running(s, true);
@@ -1583,6 +1609,7 @@ static void service_enter_start(Service *s) {
                                true,
                                true,
                                true,
+                               s->notify_access != NOTIFY_NONE,
                                &pid)) < 0)
                 goto fail;
 
@@ -1601,7 +1628,7 @@ static void service_enter_start(Service *s) {
                 s->control_command_id = SERVICE_EXEC_START;
                 s->control_command = s->exec_command[SERVICE_EXEC_START];
 
-                service_set_control_pid(s, pid);
+                s->control_pid = pid;
                 service_set_state(s, SERVICE_START);
 
         } else if (s->type == SERVICE_FINISH ||
@@ -1629,7 +1656,6 @@ fail:
 
 static void service_enter_start_pre(Service *s) {
         int r;
-        pid_t pid;
 
         assert(s);
 
@@ -1643,10 +1669,10 @@ static void service_enter_start_pre(Service *s) {
                                        false,
                                        !s->permissions_start_only,
                                        !s->root_directory_start_only,
-                                       &pid)) < 0)
+                                       false,
+                                       &s->control_pid)) < 0)
                         goto fail;
 
-                service_set_control_pid(s, pid);
                 service_set_state(s, SERVICE_START_PRE);
         } else
                 service_enter_start(s);
@@ -1678,7 +1704,6 @@ fail:
 
 static void service_enter_reload(Service *s) {
         int r;
-        pid_t pid;
 
         assert(s);
 
@@ -1692,10 +1717,10 @@ static void service_enter_reload(Service *s) {
                                        false,
                                        !s->permissions_start_only,
                                        !s->root_directory_start_only,
-                                       &pid)) < 0)
+                                       false,
+                                       &s->control_pid)) < 0)
                         goto fail;
 
-                service_set_control_pid(s, pid);
                 service_set_state(s, SERVICE_RELOAD);
         } else
                 service_enter_running(s, true);
@@ -1709,7 +1734,6 @@ fail:
 
 static void service_run_next(Service *s, bool success) {
         int r;
-        pid_t pid;
 
         assert(s);
         assert(s->control_command);
@@ -1728,10 +1752,10 @@ static void service_run_next(Service *s, bool success) {
                                false,
                                !s->permissions_start_only,
                                !s->root_directory_start_only,
-                               &pid)) < 0)
+                               false,
+                               &s->control_pid)) < 0)
                 goto fail;
 
-        service_set_control_pid(s, pid);
         return;
 
 fail:
@@ -1904,7 +1928,7 @@ static int service_deserialize_item(Unit *u, const char *key, const char *value,
                 if ((r = parse_pid(value, &pid)) < 0)
                         log_debug("Failed to parse control-pid value %s", value);
                 else
-                        service_set_control_pid(s, pid);
+                        s->control_pid = pid;
         } else if (streq(key, "main-pid")) {
                 pid_t pid;
 
@@ -2236,12 +2260,24 @@ static void service_cgroup_notify_event(Unit *u) {
         }
 }
 
-static void service_notify_message(Unit *u, char **tags) {
+static void service_notify_message(Unit *u, pid_t pid, char **tags) {
         Service *s = SERVICE(u);
         const char *e;
 
         assert(u);
 
+        if (s->notify_access == NOTIFY_NONE) {
+                log_warning("%s: Got notification message from PID %lu, but reception is disabled.",
+                            u->meta.id, (unsigned long) pid);
+                return;
+        }
+
+        if (s->notify_access == NOTIFY_MAIN && pid != s->main_pid) {
+                log_warning("%s: Got notification message from PID %lu, but reception only permitted for PID %lu",
+                            u->meta.id, (unsigned long) pid, (unsigned long) s->main_pid);
+                return;
+        }
+
         log_debug("%s: Got message", u->meta.id);
 
         /* Interpret MAINPID= */
@@ -2250,7 +2286,6 @@ static void service_notify_message(Unit *u, char **tags) {
              s->state == SERVICE_START_POST ||
              s->state == SERVICE_RUNNING ||
              s->state == SERVICE_RELOAD)) {
-                pid_t pid;
 
                 if (parse_pid(e + 8, &pid) < 0)
                         log_warning("Failed to parse %s", e);
@@ -2563,6 +2598,14 @@ static const char* const service_exec_command_table[_SERVICE_EXEC_COMMAND_MAX] =
 
 DEFINE_STRING_TABLE_LOOKUP(service_exec_command, ServiceExecCommand);
 
+static const char* const notify_access_table[_NOTIFY_ACCESS_MAX] = {
+        [NOTIFY_NONE] = "none",
+        [NOTIFY_MAIN] = "main",
+        [NOTIFY_ALL] = "all"
+};
+
+DEFINE_STRING_TABLE_LOOKUP(notify_access, NotifyAccess);
+
 const UnitVTable service_vtable = {
         .suffix = ".service",