networkd: fix use-after-free

[elogind.git] / src / network / networkd-manager.c

diff --git a/src/network/networkd-manager.c b/src/network/networkd-manager.c
index b2cb0fab4d00cabe13b18e0e76b316baf933006b..ddbdabbff903ece3bbecde8fb76b87dbc09c243c 100644 (file)
--- a/src/network/networkd-manager.c
+++ b/src/network/networkd-manager.c
@@ -145,13 +145,13 @@ void manager_free(Manager *m) {
         sd_event_source_unref(m->sigint_event_source);
         sd_event_unref(m->event);
 
         sd_event_source_unref(m->sigint_event_source);
         sd_event_unref(m->event);
 

-        while ((network = m->networks))
-                network_free(network);
-

         while ((link = hashmap_first(m->links)))
                 link_free(link);
         hashmap_free(m->links);
 
         while ((link = hashmap_first(m->links)))
                 link_free(link);
         hashmap_free(m->links);
 

+        while ((network = m->networks))
+                network_free(network);
+

         while ((netdev = hashmap_first(m->netdevs)))
                 netdev_free(netdev);
         hashmap_free(m->netdevs);
         while ((netdev = hashmap_first(m->netdevs)))
                 netdev_free(netdev);
         hashmap_free(m->netdevs);