kmod: automatically load a few kernel modules we need for normal operation before...

[elogind.git] / src / load-fragment.c

diff --git a/src/load-fragment.c b/src/load-fragment.c
index 148a579d99244127d123b08888eddb48a82a54e6..70b69233c7f5bb5ec19081c81e6c2d080fdab895 100644 (file)
--- a/src/load-fragment.c
+++ b/src/load-fragment.c
@@ -252,8 +252,8 @@ static int config_parse_socket_bind(
                 void *data,
                 void *userdata) {
 
-        int r;
         Socket *s;
+        SocketAddressBindIPv6Only b;
 
         assert(filename);
         assert(lvalue);
@@ -262,12 +262,17 @@ static int config_parse_socket_bind(
 
         s = (Socket*) data;
 
-        if ((r = parse_boolean(rvalue)) < 0) {
-                log_error("[%s:%u] Failed to parse bind IPv6 only value: %s", filename, line, rvalue);
-                return r;
-        }
+        if ((b = socket_address_bind_ipv6_only_from_string(rvalue)) < 0) {
+                int r;
 
-        s->bind_ipv6_only = r ? SOCKET_ADDRESS_IPV6_ONLY : SOCKET_ADDRESS_BOTH;
+                if ((r = parse_boolean(rvalue)) < 0) {
+                        log_error("[%s:%u] Failed to parse bind IPv6 only value: %s", filename, line, rvalue);
+                        return -EBADMSG;
+                }
+
+                s->bind_ipv6_only = r ? SOCKET_ADDRESS_IPV6_ONLY : SOCKET_ADDRESS_BOTH;
+        } else
+                s->bind_ipv6_only = b;
 
         return 0;
 }
@@ -386,49 +391,73 @@ static int config_parse_exec(
         char *w;
         unsigned k;
         size_t l;
-        char *state;
+        char *state, *path = NULL;
+        bool honour_argv0, write_to_path;
 
         assert(filename);
         assert(lvalue);
         assert(rvalue);
         assert(data);
 
+        /* We accept an absolute path as first argument, or
+         * alternatively an absolute prefixed with @ to allow
+         * overriding of argv[0]. */
+
+        honour_argv0 = rvalue[0] == '@';
+
+        if (rvalue[honour_argv0 ? 1 : 0] != '/') {
+                log_error("[%s:%u] Invalid executable path in command line: %s", filename, line, rvalue);
+                return -EINVAL;
+        }
+
         k = 0;
         FOREACH_WORD_QUOTED(w, l, rvalue, state)
                 k++;
 
-        if (!(n = new(char*, k+1)))
+        if (!(n = new(char*, k + (honour_argv0 ? 0 : 1))))
                 return -ENOMEM;
 
         k = 0;
-        FOREACH_WORD_QUOTED(w, l, rvalue, state)
-                if (!(n[k++] = strndup(w, l)))
-                        goto fail;
+        write_to_path = honour_argv0;
+        FOREACH_WORD_QUOTED(w, l, rvalue, state) {
+                if (write_to_path) {
+                        if (!(path = strndup(w+1, l-1)))
+                                goto fail;
+                        write_to_path = false;
+                } else {
+                        if (!(n[k++] = strndup(w, l)))
+                                goto fail;
+                }
+        }
 
         n[k] = NULL;
 
-        if (!n[0] || !path_is_absolute(n[0])) {
-                log_error("[%s:%u] Invalid executable path in command line: %s", filename, line, rvalue);
+        if (!n[0]) {
+                log_error("[%s:%u] Invalid command line: %s", filename, line, rvalue);
                 strv_free(n);
                 return -EINVAL;
         }
 
+        if (!path)
+                if (!(path = strdup(n[0])))
+                        goto fail;
+
+        assert(path_is_absolute(path));
+
         if (!(nce = new0(ExecCommand, 1)))
                 goto fail;
 
         nce->argv = n;
-        if (!(nce->path = strdup(n[0])))
-                goto fail;
+        nce->path = path;
 
         exec_command_append_list(e, nce);
 
         return 0;
 
 fail:
-        for (; k > 0; k--)
-                free(n[k-1]);
-        free(n);
-
+        n[k] = NULL;
+        strv_free(n);
+        free(path);
         free(nce);
 
         return -ENOMEM;
@@ -1239,6 +1268,7 @@ static int load_from_path(Unit *u, const char *path) {
                 { "After",                  config_parse_deps,            UINT_TO_PTR(UNIT_AFTER),                         "Unit"    },
                 { "RecursiveStop",          config_parse_bool,            &u->meta.recursive_stop,                         "Unit"    },
                 { "StopWhenUnneeded",       config_parse_bool,            &u->meta.stop_when_unneeded,                     "Unit"    },
+                { "OnlyByDependency",       config_parse_bool,            &u->meta.only_by_dependency,                     "Unit"    },
 
                 { "PIDFile",                config_parse_path,            &u->service.pid_file,                            "Service" },
                 { "ExecStartPre",           config_parse_exec,            u->service.exec_command+SERVICE_EXEC_START_PRE,  "Service" },