chiark / gitweb /
bus: generate a nice error when attempting to add a NULL string
[elogind.git] / src / libsystemd-bus / bus-message.c
index 4c5588cf8a6653f8d0f2167daad5ef747d07e3f2..524f17eb9f952707ebdbc91da3c98121a4c14e1c 100644 (file)
 #include <errno.h>
 
 #include "util.h"
+#include "utf8.h"
+#include "strv.h"
 
-#include "bus-message.h"
 #include "sd-bus.h"
+#include "bus-message.h"
 #include "bus-internal.h"
 #include "bus-type.h"
 #include "bus-signature.h"
 
-int message_append_basic(sd_bus_message *m, char type, const void *p, const void **stored);
+static int message_parse_fields(sd_bus_message *m);
+static int message_append_basic(sd_bus_message *m, char type, const void *p, const void **stored);
+
+static void reset_containers(sd_bus_message *m) {
+        unsigned i;
+
+        assert(m);
+
+        for (i = 0; i < m->n_containers; i++)
+                free(m->containers[i].signature);
+
+        free(m->containers);
+        m->containers = NULL;
+
+        m->n_containers = 0;
+        m->root_container.index = 0;
+}
 
 static void message_free(sd_bus_message *m) {
         unsigned i;
@@ -48,10 +66,10 @@ static void message_free(sd_bus_message *m) {
         for (i = 0; i < m->n_fds; i++)
                 close_nointr_nofail(m->fds[i]);
 
-        for (i = 0; i < m->n_containers; i++)
-                free(m->sub_containers[i].signature);
+        reset_containers(m);
+        free(m->root_container.signature);
 
-        free(m->sub_containers);
+        free(m->peeked_signature);
         free(m);
 }
 
@@ -109,8 +127,6 @@ static void *message_extend_fields(sd_bus_message *m, size_t align, size_t sz) {
                         m->destination = (const char*) m->fields + (m->destination - (const char*) o);
                 if (m->sender)
                         m->sender = (const char*) m->fields + (m->sender - (const char*) o);
-                if (m->signature)
-                        m->signature = (const char*) m->fields + (m->signature - (const char*) o);
                 if (m->error.name)
                         m->error.name = (const char*) m->fields + (m->error.name - (const char*) o);
         }
@@ -208,21 +224,76 @@ static int message_append_field_uint32(sd_bus_message *m, uint8_t h, uint32_t x)
         return 0;
 }
 
+int bus_message_from_malloc(void *buffer, size_t length, sd_bus_message **ret) {
+        sd_bus_message *m;
+        struct bus_header *h;
+        size_t total, fs, bs;
+        int r;
+
+        assert(buffer || length <= 0);
+        assert(ret);
+
+        if (length < sizeof(struct bus_header))
+                return -EBADMSG;
+
+        h = buffer;
+        if (h->version != 1)
+                return -EBADMSG;
+
+        if (h->serial == 0)
+                return -EBADMSG;
+
+        if (h->type == _SD_BUS_MESSAGE_TYPE_INVALID)
+                return -EBADMSG;
+
+        if (h->endian == SD_BUS_NATIVE_ENDIAN) {
+                fs = h->fields_size;
+                bs = h->body_size;
+        } else if (h->endian == SD_BUS_REVERSE_ENDIAN) {
+                fs = bswap_32(h->fields_size);
+                bs = bswap_32(h->body_size);
+        } else
+                return -EBADMSG;
+
+        total = sizeof(struct bus_header) + ALIGN_TO(fs, 8) + bs;
+        if (length != total)
+                return -EBADMSG;
+
+        m = new0(sd_bus_message, 1);
+        if (!m)
+                return -ENOMEM;
+
+        m->n_ref = 1;
+        m->header = h;
+        m->free_header = true;
+        m->fields = (uint8_t*) buffer + sizeof(struct bus_header);
+        m->body = (uint8_t*) buffer + sizeof(struct bus_header) + ALIGN_TO(fs, 8);
+        m->sealed = true;
+
+        m->n_iovec = 1;
+        m->iovec[0].iov_base = buffer;
+        m->iovec[0].iov_len = length;
+
+        r = message_parse_fields(m);
+        if (r < 0) {
+                message_free(m);
+                return r;
+        }
+
+        *ret = m;
+        return 0;
+}
+
 static sd_bus_message *message_new(sd_bus *bus, uint8_t type) {
         sd_bus_message *m;
 
-        m = malloc0(ALIGN(sizeof(struct sd_bus_message)) + sizeof(struct bus_header));
+        m = malloc0(ALIGN(sizeof(sd_bus_message)) + sizeof(struct bus_header));
         if (!m)
                 return NULL;
 
         m->n_ref = 1;
         m->header = (struct bus_header*) ((uint8_t*) m + ALIGN(sizeof(struct sd_bus_message)));
-
-#if __BYTE_ORDER == __BIG_ENDIAN
-        m->header->endian = SD_BUS_BIG_ENDIAN;
-#else
-        m->header->endian = SD_BUS_LITTLE_ENDIAN;
-#endif
+        m->header->endian = SD_BUS_NATIVE_ENDIAN;
         m->header->type = type;
         m->header->version = bus ? bus->message_version : 1;
 
@@ -245,11 +316,15 @@ int sd_bus_message_new_signal(
                 return -EINVAL;
         if (!member)
                 return -EINVAL;
+        if (!m)
+                return -EINVAL;
 
         t = message_new(bus, SD_BUS_MESSAGE_TYPE_SIGNAL);
         if (!t)
                 return -ENOMEM;
 
+        t->header->flags |= SD_BUS_MESSAGE_NO_REPLY_EXPECTED;
+
         r = message_append_field_string(t, SD_BUS_MESSAGE_HEADER_PATH, SD_BUS_TYPE_OBJECT_PATH, path, &t->path);
         if (r < 0)
                 goto fail;
@@ -283,6 +358,8 @@ int sd_bus_message_new_method_call(
                 return -EINVAL;
         if (!member)
                 return -EINVAL;
+        if (!m)
+                return -EINVAL;
 
         t = message_new(bus, SD_BUS_MESSAGE_TYPE_METHOD_CALL);
         if (!t)
@@ -315,9 +392,10 @@ fail:
         return r;
 }
 
-int sd_bus_message_new_method_return(
+static int message_new_reply(
                 sd_bus *bus,
                 sd_bus_message *call,
+                uint8_t type,
                 sd_bus_message **m) {
 
         sd_bus_message *t;
@@ -325,14 +403,20 @@ int sd_bus_message_new_method_return(
 
         if (!call)
                 return -EINVAL;
+        if (!call->sealed)
+                return -EPERM;
         if (call->header->type != SD_BUS_MESSAGE_TYPE_METHOD_CALL)
                 return -EINVAL;
+        if (!m)
+                return -EINVAL;
 
-        t = message_new(bus, SD_BUS_MESSAGE_TYPE_METHOD_RETURN);
+        t = message_new(bus, type);
         if (!t)
                 return -ENOMEM;
 
+        t->header->flags |= SD_BUS_MESSAGE_NO_REPLY_EXPECTED;
         t->reply_serial = BUS_MESSAGE_SERIAL(call);
+
         r = message_append_field_uint32(t, SD_BUS_MESSAGE_HEADER_REPLY_SERIAL, t->reply_serial);
         if (r < 0)
                 goto fail;
@@ -343,6 +427,8 @@ int sd_bus_message_new_method_return(
                         goto fail;
         }
 
+        t->dont_send = !!(call->header->flags & SD_BUS_MESSAGE_NO_REPLY_EXPECTED);
+
         *m = t;
         return 0;
 
@@ -351,6 +437,14 @@ fail:
         return r;
 }
 
+int sd_bus_message_new_method_return(
+                sd_bus *bus,
+                sd_bus_message *call,
+                sd_bus_message **m) {
+
+        return message_new_reply(bus, call, SD_BUS_MESSAGE_TYPE_METHOD_RETURN, m);
+}
+
 int sd_bus_message_new_method_error(
                 sd_bus *bus,
                 sd_bus_message *call,
@@ -360,29 +454,14 @@ int sd_bus_message_new_method_error(
         sd_bus_message *t;
         int r;
 
-        if (!call)
+        if (!sd_bus_error_is_set(e))
                 return -EINVAL;
-        if (call->header->type != SD_BUS_MESSAGE_TYPE_METHOD_CALL)
-                return -EINVAL;
-        if (!e)
-                return -EINVAL;
-        if (!e->name)
+        if (!m)
                 return -EINVAL;
 
-        t = message_new(bus, SD_BUS_MESSAGE_TYPE_METHOD_ERROR);
-        if (!t)
-                return -ENOMEM;
-
-        t->reply_serial = BUS_MESSAGE_SERIAL(call);
-        r = message_append_field_uint32(t, SD_BUS_MESSAGE_HEADER_REPLY_SERIAL, t->reply_serial);
+        r = message_new_reply(bus, call, SD_BUS_MESSAGE_TYPE_METHOD_ERROR, &t);
         if (r < 0)
-                goto fail;
-
-        if (call->sender) {
-                r = message_append_field_string(t, SD_BUS_MESSAGE_HEADER_DESTINATION, SD_BUS_TYPE_STRING, call->sender, &t->sender);
-                if (r < 0)
-                        goto fail;
-        }
+                return r;
 
         r = message_append_field_string(t, SD_BUS_MESSAGE_HEADER_ERROR_NAME, SD_BUS_TYPE_STRING, e->name, &t->error.name);
         if (r < 0)
@@ -617,8 +696,8 @@ static struct bus_container *message_get_container(sd_bus_message *m) {
         if (m->n_containers == 0)
                 return &m->root_container;
 
-        assert(m->sub_containers);
-        return m->sub_containers + m->n_containers - 1;
+        assert(m->containers);
+        return m->containers + m->n_containers - 1;
 }
 
 static void *message_extend_body(sd_bus_message *m, size_t align, size_t sz) {
@@ -627,6 +706,7 @@ static void *message_extend_body(sd_bus_message *m, size_t align, size_t sz) {
         struct bus_container *c;
 
         assert(m);
+        assert(align > 0);
 
         o = m->body;
         added = m->header->body_size;
@@ -637,7 +717,7 @@ static void *message_extend_body(sd_bus_message *m, size_t align, size_t sz) {
 
         added = m->header->body_size - added;
 
-        for (c = m->sub_containers; c < m->sub_containers + m->n_containers; c++)
+        for (c = m->containers; c < m->containers + m->n_containers; c++)
                 if (c->array_size) {
                         c->array_size = (uint32_t*) ((uint8_t*) m->body + ((uint8_t*) c->array_size - (uint8_t*) o));
                         *c->array_size += added;
@@ -655,7 +735,7 @@ static void *message_extend_body(sd_bus_message *m, size_t align, size_t sz) {
 
 int message_append_basic(sd_bus_message *m, char type, const void *p, const void **stored) {
         struct bus_container *c;
-        size_t sz, align, nindex;
+        size_t sz, align;
         uint32_t k;
         void *a;
         char *e = NULL;
@@ -673,28 +753,42 @@ int message_append_basic(sd_bus_message *m, char type, const void *p, const void
                 /* Container signature is already set */
 
                 if (c->signature[c->index] != type)
-                        return -EINVAL;
+                        return -ENXIO;
         } else {
                 /* Maybe we can append to the signature? But only if this is the top-level container*/
                 if (c->enclosing != 0)
-                        return -EINVAL;
+                        return -ENXIO;
 
                 e = strextend(&c->signature, CHAR_TO_STR(type), NULL);
                 if (!e)
                         return -ENOMEM;
         }
 
-        nindex = c->index + 1;
-
         switch (type) {
 
         case SD_BUS_TYPE_STRING:
         case SD_BUS_TYPE_OBJECT_PATH:
+
+                if (!p) {
+                        if (e)
+                                c->signature[c->index] = 0;
+
+                        return -EINVAL;
+                }
+
                 align = 4;
                 sz = 4 + strlen(p) + 1;
                 break;
 
         case SD_BUS_TYPE_SIGNATURE:
+
+                if (!p) {
+                        if (e)
+                                c->signature[c->index] = 0;
+
+                        return -EINVAL;
+                }
+
                 align = 1;
                 sz = 1 + strlen(p) + 1;
                 break;
@@ -748,7 +842,7 @@ int message_append_basic(sd_bus_message *m, char type, const void *p, const void
         }
 
         if (c->enclosing != SD_BUS_TYPE_ARRAY)
-                c->index = nindex;
+                c->index++;
 
         return 0;
 }
@@ -763,8 +857,8 @@ static int bus_message_open_array(
                 const char *contents,
                 uint32_t **array_size) {
 
+        unsigned nindex;
         char *e = NULL;
-        size_t nindex;
         void *a, *b;
         int alignment;
         size_t saved;
@@ -786,15 +880,15 @@ static int bus_message_open_array(
                 /* Verify the existing signature */
 
                 if (c->signature[c->index] != SD_BUS_TYPE_ARRAY)
-                        return -EINVAL;
+                        return -ENXIO;
 
                 if (!startswith(c->signature + c->index + 1, contents))
-                        return -EINVAL;
+                        return -ENXIO;
 
                 nindex = c->index + 1 + strlen(contents);
         } else {
                 if (c->enclosing != 0)
-                        return -EINVAL;
+                        return -ENXIO;
 
                 /* Extend the existing signature */
 
@@ -842,7 +936,7 @@ static int bus_message_open_variant(
                 const char *contents) {
 
         char *e = NULL;
-        size_t l, nindex;
+        size_t l;
         void *a;
 
         assert(m);
@@ -858,19 +952,17 @@ static int bus_message_open_variant(
         if (c->signature && c->signature[c->index]) {
 
                 if (c->signature[c->index] != SD_BUS_TYPE_VARIANT)
-                        return -EINVAL;
+                        return -ENXIO;
 
         } else {
                 if (c->enclosing != 0)
-                        return -EINVAL;
+                        return -ENXIO;
 
                 e = strextend(&c->signature, CHAR_TO_STR(SD_BUS_TYPE_VARIANT), NULL);
                 if (!e)
                         return -ENOMEM;
         }
 
-        nindex = c->index + 1;
-
         l = strlen(contents);
         a = message_extend_body(m, 1, 1 + l + 1);
         if (!a) {
@@ -885,7 +977,7 @@ static int bus_message_open_variant(
         memcpy((uint8_t*) a + 1, contents, l + 1);
 
         if (c->enclosing != SD_BUS_TYPE_ARRAY)
-                c->index = nindex;
+                c->index++;
 
         return 0;
 }
@@ -913,12 +1005,12 @@ static int bus_message_open_struct(
                 if (c->signature[c->index] != SD_BUS_TYPE_STRUCT_BEGIN ||
                     !startswith(c->signature + c->index + 1, contents) ||
                     c->signature[c->index + 1 + l] != SD_BUS_TYPE_STRUCT_END)
-                        return -EINVAL;
+                        return -ENXIO;
 
                 nindex = c->index + 1 + l + 1;
         } else {
                 if (c->enclosing != 0)
-                        return -EINVAL;
+                        return -ENXIO;
 
                 e = strextend(&c->signature, CHAR_TO_STR(SD_BUS_TYPE_STRUCT_BEGIN), contents, CHAR_TO_STR(SD_BUS_TYPE_STRUCT_END), NULL);
                 if (!e)
@@ -956,7 +1048,7 @@ static int bus_message_open_dict_entry(
                 return -EINVAL;
 
         if (c->enclosing != SD_BUS_TYPE_ARRAY)
-                return -EINVAL;
+                return -ENXIO;
 
         if (c->signature && c->signature[c->index]) {
                 size_t l;
@@ -966,11 +1058,11 @@ static int bus_message_open_dict_entry(
                 if (c->signature[c->index] != SD_BUS_TYPE_DICT_ENTRY_BEGIN ||
                     !startswith(c->signature + c->index + 1, contents) ||
                     c->signature[c->index + 1 + l] != SD_BUS_TYPE_DICT_ENTRY_END)
-                        return -EINVAL;
+                        return -ENXIO;
 
                 nindex = c->index + 1 + l + 1;
         } else
-                return -EINVAL;
+                return -ENXIO;
 
         /* Align contents to 8 byte boundary */
         if (!message_extend_body(m, 8, 0))
@@ -987,9 +1079,9 @@ int sd_bus_message_open_container(
                 char type,
                 const char *contents) {
 
-        struct bus_container *c, *sub;
-        char *signature;
+        struct bus_container *c, *w;
         uint32_t *array_size = NULL;
+        char *signature;
         int r;
 
         if (!m)
@@ -1000,11 +1092,10 @@ int sd_bus_message_open_container(
                 return -EINVAL;
 
         /* Make sure we have space for one more container */
-        sub = realloc(m->sub_containers, sizeof(struct bus_container) * (m->n_containers + 1));
-        if (!sub)
+        w = realloc(m->containers, sizeof(struct bus_container) * (m->n_containers + 1));
+        if (!w)
                 return -ENOMEM;
-
-        m->sub_containers = sub;
+        m->containers = w;
 
         c = message_get_container(m);
 
@@ -1029,12 +1120,12 @@ int sd_bus_message_open_container(
         }
 
         /* OK, let's fill it in */
-        sub += m->n_containers++;
-
-        sub->enclosing = type;
-        sub->signature = signature;
-        sub->index = 0;
-        sub->array_size = array_size;
+        w += m->n_containers++;
+        w->enclosing = type;
+        w->signature = signature;
+        w->index = 0;
+        w->array_size = array_size;
+        w->begin = 0;
 
         return 0;
 }
@@ -1050,12 +1141,8 @@ int sd_bus_message_close_container(sd_bus_message *m) {
                 return -EINVAL;
 
         c = message_get_container(m);
-
-        if (!c->signature)
-                return -EINVAL;
-
         if (c->enclosing != SD_BUS_TYPE_ARRAY)
-                if (c->signature[c->index] != 0)
+                if (c->signature && c->signature[c->index] != 0)
                         return -EINVAL;
 
         free(c->signature);
@@ -1088,9 +1175,13 @@ static int message_append_ap(
 
                 case SD_BUS_TYPE_BOOLEAN:
                 case SD_BUS_TYPE_INT32:
-                case SD_BUS_TYPE_UINT32: {
+                case SD_BUS_TYPE_UINT32:
+                case SD_BUS_TYPE_UNIX_FD: {
                         uint32_t x;
 
+                        /* We assume a boolean is the same as int32_t */
+                        assert_cc(sizeof(int32_t) == sizeof(int));
+
                         x = va_arg(ap, uint32_t);
                         r = sd_bus_message_append_basic(m, *t, &x);
                         break;
@@ -1125,16 +1216,7 @@ static int message_append_ap(
                         break;
                 }
 
-                case SD_BUS_TYPE_UNIX_FD: {
-                        int x;
-
-                        x = va_arg(ap, int);
-                        r = sd_bus_message_append_basic(m, *t, &x);
-                        break;
-                }
-
                 case SD_BUS_TYPE_ARRAY: {
-                        unsigned i, n;
                         size_t k;
 
                         r = signature_element_length(t + 1, &k);
@@ -1142,6 +1224,7 @@ static int message_append_ap(
                                 return r;
 
                         {
+                                unsigned i, n;
                                 char s[k + 1];
 
                                 memcpy(s, t + 1, k);
@@ -1153,7 +1236,6 @@ static int message_append_ap(
                                         return r;
 
                                 n = va_arg(ap, unsigned);
-
                                 for (i = 0; i < n; i++) {
                                         r = message_append_ap(m, s, ap);
                                         if (r < 0)
@@ -1244,170 +1326,1464 @@ int sd_bus_message_append(sd_bus_message *m, const char *types, ...) {
         return r;
 }
 
-int sd_bus_message_read_type(sd_bus_message *m, char *type, char *element, size_t *length) {
-        return -ENOTSUP;
-}
+static int buffer_peek(const void *p, uint32_t sz, size_t *rindex, size_t align, size_t nbytes, void **r) {
+        size_t k, start, n;
 
-int sd_bus_message_read_basic(sd_bus_message *m, char type, char element, const void **p, size_t *length) {
-        return -ENOTSUP;
-}
+        assert(rindex);
+        assert(align > 0);
 
-int sd_bus_message_read(sd_bus_message *m, const char *types, ...) {
-        return -ENOTSUP;
+        start = ALIGN_TO((size_t) *rindex, align);
+        n = start + nbytes;
+
+        if (n > sz)
+                return -EBADMSG;
+
+        /* Verify that padding is 0 */
+        for (k = *rindex; k < start; k++)
+                if (((const uint8_t*) p)[k] != 0)
+                        return -EBADMSG;
+
+        if (r)
+                *r = (uint8_t*) p + start;
+
+        *rindex = n;
+
+        return 1;
 }
 
-int message_parse(sd_bus_message *m) {
-        assert(m);
+static bool message_end_of_array(sd_bus_message *m, size_t index) {
+        struct bus_container *c;
 
-        if (m->header->version != 1)
-                return -EIO;
+        assert(m);
 
-        if (m->header->endian != SD_BUS_BIG_ENDIAN &&
-            m->header->endian != SD_BUS_LITTLE_ENDIAN)
-                return -EIO;
+        c = message_get_container(m);
+        if (!c->array_size)
+                return false;
 
-        return 0;
+        return index >= c->begin + BUS_MESSAGE_BSWAP32(m, *c->array_size);
 }
 
-static void setup_iovec(sd_bus_message *m) {
+static int message_peek_body(sd_bus_message *m, size_t *rindex, size_t align, size_t nbytes, void **ret) {
         assert(m);
-        assert(m->sealed);
+        assert(rindex);
+        assert(align > 0);
 
-        m->n_iovec = 0;
+        if (message_end_of_array(m, *rindex))
+                return 0;
 
-        m->iovec[m->n_iovec].iov_base = m->header;
-        m->iovec[m->n_iovec].iov_len = sizeof(*m->header);
-        m->n_iovec++;
+        return buffer_peek(m->body, BUS_MESSAGE_BODY_SIZE(m), rindex, align, nbytes, ret);
+}
 
-        if (m->fields) {
-                m->iovec[m->n_iovec].iov_base = m->fields;
-                m->iovec[m->n_iovec].iov_len = m->header->fields_size;
-                m->n_iovec++;
+static bool validate_string(const char *s, size_t l) {
+        assert(s);
 
-                if (m->header->fields_size % 8 != 0) {
-                        static const uint8_t padding[7] = { 0, 0, 0, 0, 0, 0, 0 };
+        /* Check for NUL chars in the string */
+        if (memchr(s, 0, l))
+                return false;
 
-                        m->iovec[m->n_iovec].iov_base = (void*) padding;
-                        m->iovec[m->n_iovec].iov_len = 8 - m->header->fields_size % 8;
-                        m->n_iovec++;
-                }
-        }
+        /* Check for NUL termination */
+        if (s[l] != 0)
+                return false;
 
-        if (m->body) {
-                m->iovec[m->n_iovec].iov_base = m->body;
-                m->iovec[m->n_iovec].iov_len = m->header->body_size;
-                m->n_iovec++;
-        }
+        /* Check if valid UTF8 */
+        if (!utf8_is_valid(s))
+                return false;
+
+        return true;
 }
 
-int message_seal(sd_bus_message *m, uint64_t serial) {
-        int r;
+static bool validate_signature(const char *s, size_t l) {
+        /* Check for NUL chars in the signature */
+        if (memchr(s, 0, l))
+                return false;
 
-        assert(m);
+        /* Check for NUL termination */
+        if (s[l] != 0)
+                return false;
 
-        if (m->sealed)
+        /* Check if valid signature */
+        if (!signature_is_valid(s, true))
+                return false;
+
+        return true;
+}
+
+int sd_bus_message_read_basic(sd_bus_message *m, char type, void *p) {
+        struct bus_container *c;
+        int r;
+        void *q;
+
+        if (!m)
+                return -EINVAL;
+        if (!m->sealed)
                 return -EPERM;
+        if (!bus_type_is_basic(type))
+                return -EINVAL;
 
-        if (m->n_containers > 0)
-                return -EBADMSG;
+        c = message_get_container(m);
 
-        /* If there's a non-trivial signature set, then add it in here */
-        if (!isempty(m->root_container.signature)) {
-                r = message_append_field_signature(m, SD_BUS_MESSAGE_HEADER_SIGNATURE, m->root_container.signature, &m->signature);
+        if (!c->signature || c->signature[c->index] == 0)
+                return 0;
+
+        if (c->signature[c->index] != type)
+                return -ENXIO;
+
+        switch (type) {
+
+        case SD_BUS_TYPE_STRING:
+        case SD_BUS_TYPE_OBJECT_PATH: {
+                uint32_t l;
+                size_t rindex;
+
+                rindex = m->rindex;
+                r = message_peek_body(m, &rindex, 4, 4, &q);
+                if (r <= 0)
+                        return r;
+
+                l = BUS_MESSAGE_BSWAP32(m, *(uint32_t*) q);
+                r = message_peek_body(m, &rindex, 1, l+1, &q);
                 if (r < 0)
                         return r;
+                if (r == 0)
+                        return -EBADMSG;
+
+                if (!validate_string(q, l))
+                        return -EBADMSG;
+
+                m->rindex = rindex;
+                *(const char**) p = q;
+                break;
         }
 
-        if (m->n_fds > 0) {
-                r = message_append_field_uint32(m, SD_BUS_MESSAGE_HEADER_UNIX_FDS, m->n_fds);
+        case SD_BUS_TYPE_SIGNATURE: {
+                uint8_t l;
+                size_t rindex;
+
+                rindex = m->rindex;
+                r = message_peek_body(m, &rindex, 1, 1, &q);
+                if (r <= 0)
+                        return r;
+
+                l = *(uint8_t*) q;
+                r = message_peek_body(m, &rindex, 1, l+1, &q);
                 if (r < 0)
                         return r;
+                if (r == 0)
+                        return -EBADMSG;
+
+                if (!validate_signature(q, l))
+                        return -EBADMSG;
+
+                m->rindex = rindex;
+                *(const char**) p = q;
+                break;
         }
 
-        m->header->serial = serial;
-        m->sealed = true;
+        default: {
+                size_t sz, align;
 
-        setup_iovec(m);
+                align = bus_type_get_alignment(type);
+                sz = bus_type_get_size(type);
 
-        return 0;
-}
+                r = message_peek_body(m, &m->rindex, align, sz, &q);
+                if (r <= 0)
+                        return r;
 
-int sd_bus_message_set_destination(sd_bus_message *m, const char *destination) {
-        if (!m)
-                return -EINVAL;
-        if (!destination)
-                return -EINVAL;
-        if (m->sealed)
-                return -EPERM;
-        if (m->destination)
-                return -EEXIST;
+                switch (type) {
 
-        return message_append_field_string(m, SD_BUS_MESSAGE_HEADER_DESTINATION, SD_BUS_TYPE_STRING, destination, &m->destination);
-}
+                case SD_BUS_TYPE_BYTE:
+                        *(uint8_t*) p = *(uint8_t*) q;
+                        break;
 
-void message_dump(sd_bus_message *m) {
-
-        log_info("Message %p\n"
-                 "\tn_ref=%u\n"
-                 "\tendian=%c\n"
-                 "\ttype=%i\n"
-                 "\tflags=%u\n"
-                 "\tversion=%u\n"
-                 "\tserial=%u\n"
-                 "\tfields_size=%u\n"
-                 "\tbody_size=%u\n"
-                 "\tpath=%s\n"
-                 "\tinterface=%s\n"
-                 "\tmember=%s\n"
-                 "\tdestination=%s\n"
-                 "\tsender=%s\n"
-                 "\tsignature=%s\n"
-                 "\treply_serial=%u\n"
-                 "\terror.name=%s\n"
-                 "\terror.message=%s\n"
-                 "\tsealed=%s\n",
-                 m,
-                 m->n_ref,
-                 m->header->endian,
-                 m->header->type,
-                 m->header->flags,
-                 m->header->version,
-                 BUS_MESSAGE_SERIAL(m),
-                 BUS_MESSAGE_FIELDS_SIZE(m),
-                 BUS_MESSAGE_BODY_SIZE(m),
-                 strna(m->path),
-                 strna(m->interface),
-                 strna(m->member),
-                 strna(m->destination),
-                 strna(m->sender),
-                 strna(m->signature),
-                 m->reply_serial,
-                 strna(m->error.name),
-                 strna(m->error.message),
-                 yes_no(m->sealed));
-}
+                case SD_BUS_TYPE_BOOLEAN:
+                        *(int*) p = !!*(uint32_t*) q;
+                        break;
 
-int bus_message_get_blob(sd_bus_message *m, void **buffer, size_t *sz) {
-        size_t total;
-        unsigned i;
-        void *p, *e;
+                case SD_BUS_TYPE_INT16:
+                case SD_BUS_TYPE_UINT16:
+                        *(uint16_t*) p = BUS_MESSAGE_BSWAP16(m, *(uint16_t*) q);
+                        break;
 
-        assert(m);
-        assert(buffer);
-        assert(sz);
+                case SD_BUS_TYPE_INT32:
+                case SD_BUS_TYPE_UINT32:
+                        *(uint32_t*) p = BUS_MESSAGE_BSWAP32(m, *(uint32_t*) q);
+                        break;
 
-        for (i = 0, total = 0; i < m->n_iovec; i++)
-                total += m->iovec[i].iov_len;
+                case SD_BUS_TYPE_INT64:
+                case SD_BUS_TYPE_UINT64:
+                case SD_BUS_TYPE_DOUBLE:
+                        *(uint64_t*) p = BUS_MESSAGE_BSWAP64(m, *(uint64_t*) q);
+                        break;
 
-        p = malloc(total);
-        if (!p)
-                return -ENOMEM;
+                default:
+                        assert_not_reached("Unknown basic type...");
+                }
 
-        for (i = 0, e = p; i < m->n_iovec; i++)
-                e = mempcpy(e, m->iovec[i].iov_base, m->iovec[i].iov_len);
+                break;
+        }
+        }
 
-        *buffer = p;
+        if (c->enclosing != SD_BUS_TYPE_ARRAY)
+                c->index++;
+
+        return 1;
+}
+
+static int bus_message_enter_array(
+                sd_bus_message *m,
+                struct bus_container *c,
+                const char *contents,
+                uint32_t **array_size) {
+
+        size_t rindex;
+        void *q;
+        int r, alignment;
+
+        assert(m);
+        assert(c);
+        assert(contents);
+        assert(array_size);
+
+        if (!signature_is_single(contents))
+                return -EINVAL;
+
+        alignment = bus_type_get_alignment(contents[0]);
+        if (alignment < 0)
+                return alignment;
+
+        if (!c->signature || c->signature[c->index] == 0)
+                return 0;
+
+        if (c->signature[c->index] != SD_BUS_TYPE_ARRAY)
+                return -ENXIO;
+
+        if (!startswith(c->signature + c->index + 1, contents))
+                return -ENXIO;
+
+        rindex = m->rindex;
+        r = message_peek_body(m, &rindex, 4, 4, &q);
+        if (r <= 0)
+                return r;
+
+        if (BUS_MESSAGE_BSWAP32(m, *(uint32_t*) q) > 67108864)
+                return -EBADMSG;
+
+        r = message_peek_body(m, &rindex, alignment, 0, NULL);
+        if (r < 0)
+                return r;
+        if (r == 0)
+                return -EBADMSG;
+
+        if (c->enclosing != SD_BUS_TYPE_ARRAY)
+                c->index += 1 + strlen(contents);
+
+        m->rindex = rindex;
+
+        *array_size = (uint32_t*) q;
+
+        return 1;
+}
+
+static int bus_message_enter_variant(
+                sd_bus_message *m,
+                struct bus_container *c,
+                const char *contents) {
+
+        size_t rindex;
+        uint8_t l;
+        void *q;
+        int r;
+
+        assert(m);
+        assert(c);
+        assert(contents);
+
+        if (!signature_is_single(contents))
+                return -EINVAL;
+
+        if (*contents == SD_BUS_TYPE_DICT_ENTRY_BEGIN)
+                return -EINVAL;
+
+        if (!c->signature || c->signature[c->index] == 0)
+                return 0;
+
+        if (c->signature[c->index] != SD_BUS_TYPE_VARIANT)
+                return -ENXIO;
+
+        rindex = m->rindex;
+        r = message_peek_body(m, &rindex, 1, 1, &q);
+        if (r <= 0)
+                return r;
+
+        l = *(uint8_t*) q;
+        r = message_peek_body(m, &rindex, 1, l+1, &q);
+        if (r < 0)
+                return r;
+        if (r == 0)
+                return -EBADMSG;
+
+        if (!validate_signature(q, l))
+                return -EBADMSG;
+
+        if (!streq(q, contents))
+                return -ENXIO;
+
+        if (c->enclosing != SD_BUS_TYPE_ARRAY)
+                c->index++;
+
+        m->rindex = rindex;
+
+        return 1;
+}
+
+static int bus_message_enter_struct(
+                sd_bus_message *m,
+                struct bus_container *c,
+                const char *contents) {
+
+        size_t l;
+        int r;
+
+        assert(m);
+        assert(c);
+        assert(contents);
+
+        if (!signature_is_valid(contents, false))
+                return -EINVAL;
+
+        if (!c->signature || c->signature[c->index] == 0)
+                return 0;
+
+        l = strlen(contents);
+
+        if (c->signature[c->index] != SD_BUS_TYPE_STRUCT_BEGIN ||
+            !startswith(c->signature + c->index + 1, contents) ||
+            c->signature[c->index + 1 + l] != SD_BUS_TYPE_STRUCT_END)
+                return -ENXIO;
+
+        r = message_peek_body(m, &m->rindex, 8, 0, NULL);
+        if (r <= 0)
+                return r;
+
+        if (c->enclosing != SD_BUS_TYPE_ARRAY)
+                c->index += 1 + l + 1;
+
+        return 1;
+}
+
+static int bus_message_enter_dict_entry(
+                sd_bus_message *m,
+                struct bus_container *c,
+                const char *contents) {
+
+        size_t l;
+        int r;
+
+        assert(m);
+        assert(c);
+        assert(contents);
+
+        if (!signature_is_pair(contents))
+                return -EINVAL;
+
+        if (c->enclosing != SD_BUS_TYPE_ARRAY)
+                return -ENXIO;
+
+        if (!c->signature || c->signature[c->index] == 0)
+                return 0;
+
+        l = strlen(contents);
+
+        if (c->signature[c->index] != SD_BUS_TYPE_DICT_ENTRY_BEGIN ||
+            !startswith(c->signature + c->index + 1, contents) ||
+            c->signature[c->index + 1 + l] != SD_BUS_TYPE_DICT_ENTRY_END)
+                return -ENXIO;
+
+        r = message_peek_body(m, &m->rindex, 8, 0, NULL);
+        if (r <= 0)
+                return r;
+
+        if (c->enclosing != SD_BUS_TYPE_ARRAY)
+                c->index += 1 + l + 1;
+
+        return 1;
+}
+
+int sd_bus_message_enter_container(sd_bus_message *m, char type, const char *contents) {
+        struct bus_container *c, *w;
+        uint32_t *array_size = NULL;
+        char *signature;
+        int r;
+
+        if (!m)
+                return -EINVAL;
+        if (!m->sealed)
+                return -EPERM;
+        if (!contents)
+                return -EINVAL;
+
+        w = realloc(m->containers, sizeof(struct bus_container) * (m->n_containers + 1));
+        if (!w)
+                return -ENOMEM;
+        m->containers = w;
+
+        c = message_get_container(m);
+
+        if (!c->signature || c->signature[c->index] == 0)
+                return 0;
+
+        signature = strdup(contents);
+        if (!signature)
+                return -ENOMEM;
+
+        if (type == SD_BUS_TYPE_ARRAY)
+                r = bus_message_enter_array(m, c, contents, &array_size);
+        else if (type == SD_BUS_TYPE_VARIANT)
+                r = bus_message_enter_variant(m, c, contents);
+        else if (type == SD_BUS_TYPE_STRUCT)
+                r = bus_message_enter_struct(m, c, contents);
+        else if (type == SD_BUS_TYPE_DICT_ENTRY)
+                r = bus_message_enter_dict_entry(m, c, contents);
+        else
+                r = -EINVAL;
+
+        if (r <= 0) {
+                free(signature);
+                return r;
+        }
+
+        /* OK, let's fill it in */
+        w += m->n_containers++;
+        w->enclosing = type;
+        w->signature = signature;
+        w->index = 0;
+        w->array_size = array_size;
+        w->begin = m->rindex;
+
+        return 1;
+}
+
+int sd_bus_message_exit_container(sd_bus_message *m) {
+        struct bus_container *c;
+
+        if (!m)
+                return -EINVAL;
+        if (!m->sealed)
+                return -EPERM;
+        if (m->n_containers <= 0)
+                return -EINVAL;
+
+        c = message_get_container(m);
+        if (c->enclosing == SD_BUS_TYPE_ARRAY) {
+                uint32_t l;
+
+                l = BUS_MESSAGE_BSWAP32(m, *c->array_size);
+                if (c->begin + l != m->rindex)
+                        return -EBUSY;
+
+        } else {
+                if (c->signature && c->signature[c->index] != 0)
+                        return -EINVAL;
+        }
+
+        free(c->signature);
+        m->n_containers--;
+
+        return 1;
+}
+
+int sd_bus_message_peek_type(sd_bus_message *m, char *type, const char **contents) {
+        struct bus_container *c;
+        int r;
+
+        if (!m)
+                return -EINVAL;
+        if (!m->sealed)
+                return -EPERM;
+
+        c = message_get_container(m);
+
+        if (!c->signature || c->signature[c->index] == 0)
+                goto eof;
+
+        if (message_end_of_array(m, m->rindex))
+                goto eof;
+
+        if (bus_type_is_basic(c->signature[c->index])) {
+                if (contents)
+                        *contents = NULL;
+                if (type)
+                        *type = c->signature[c->index];
+                return 1;
+        }
+
+        if (c->signature[c->index] == SD_BUS_TYPE_ARRAY) {
+
+                if (contents) {
+                        size_t l;
+                        char *sig;
+
+                        r = signature_element_length(c->signature+c->index+1, &l);
+                        if (r < 0)
+                                return r;
+
+                        assert(l >= 1);
+
+                        sig = strndup(c->signature + c->index + 1, l);
+                        if (!sig)
+                                return -ENOMEM;
+
+                        free(m->peeked_signature);
+                        m->peeked_signature = sig;
+
+                        *contents = sig;
+                }
+
+                if (type)
+                        *type = SD_BUS_TYPE_ARRAY;
+
+                return 1;
+        }
+
+        if (c->signature[c->index] == SD_BUS_TYPE_STRUCT_BEGIN ||
+            c->signature[c->index] == SD_BUS_TYPE_DICT_ENTRY_BEGIN) {
+
+                if (contents) {
+                        size_t l;
+                        char *sig;
+
+                        r = signature_element_length(c->signature+c->index, &l);
+                        if (r < 0)
+                                return r;
+
+                        assert(l >= 2);
+                        sig = strndup(c->signature + c->index + 1, l - 2);
+                        if (!sig)
+                                return -ENOMEM;
+
+                        free(m->peeked_signature);
+                        m->peeked_signature = sig;
+
+                        *contents = sig;
+                }
+
+                if (type)
+                        *type = c->signature[c->index] == SD_BUS_TYPE_STRUCT_BEGIN ? SD_BUS_TYPE_STRUCT : SD_BUS_TYPE_DICT_ENTRY;
+
+                return 1;
+        }
+
+        if (c->signature[c->index] == SD_BUS_TYPE_VARIANT) {
+                if (contents) {
+                        size_t rindex, l;
+                        void *q;
+
+                        rindex = m->rindex;
+                        r = message_peek_body(m, &rindex, 1, 1, &q);
+                        if (r < 0)
+                                return r;
+                        if (r == 0)
+                                goto eof;
+
+                        l = *(uint8_t*) q;
+                        r = message_peek_body(m, &rindex, 1, l+1, &q);
+                        if (r < 0)
+                                return r;
+                        if (r == 0)
+                                return -EBADMSG;
+
+                        if (!validate_signature(q, l))
+                                return -EBADMSG;
+
+                        *contents = q;
+                }
+
+                if (type)
+                        *type = SD_BUS_TYPE_VARIANT;
+
+                return 1;
+        }
+
+        return -EINVAL;
+
+eof:
+        if (type)
+                *type = c->enclosing;
+        if (contents)
+                *contents = NULL;
+        return 0;
+}
+
+int sd_bus_message_rewind(sd_bus_message *m, int complete) {
+        struct bus_container *c;
+
+        if (!m)
+                return -EINVAL;
+        if (!m->sealed)
+                return -EPERM;
+
+        if (complete) {
+                reset_containers(m);
+                m->rindex = 0;
+                m->root_container.index = 0;
+
+                c = message_get_container(m);
+        } else {
+                c = message_get_container(m);
+
+                c->index = 0;
+                m->rindex = c->begin;
+        }
+
+        return !isempty(c->signature);
+}
+
+static int message_read_ap(sd_bus_message *m, const char *types, va_list ap) {
+        const char *t;
+        int r;
+
+        assert(m);
+        assert(types);
+
+        for (t = types; *t; t++) {
+                switch (*t) {
+
+                case SD_BUS_TYPE_BYTE:
+                case SD_BUS_TYPE_BOOLEAN:
+                case SD_BUS_TYPE_INT16:
+                case SD_BUS_TYPE_UINT16:
+                case SD_BUS_TYPE_INT32:
+                case SD_BUS_TYPE_UINT32:
+                case SD_BUS_TYPE_INT64:
+                case SD_BUS_TYPE_UINT64:
+                case SD_BUS_TYPE_DOUBLE:
+                case SD_BUS_TYPE_STRING:
+                case SD_BUS_TYPE_OBJECT_PATH:
+                case SD_BUS_TYPE_SIGNATURE: {
+                        void *p;
+
+                        p = va_arg(ap, void*);
+                        r = sd_bus_message_read_basic(m, *t, p);
+                        break;
+                }
+
+                case SD_BUS_TYPE_ARRAY: {
+                        size_t k;
+
+                        r = signature_element_length(t + 1, &k);
+                        if (r < 0)
+                                return r;
+
+                        {
+                                unsigned i, n;
+                                char s[k + 1];
+
+                                memcpy(s, t + 1, k);
+                                s[k] = 0;
+                                t += k;
+
+                                r = sd_bus_message_enter_container(m, SD_BUS_TYPE_ARRAY, s);
+                                if (r < 0)
+                                        return r;
+                                if (r == 0)
+                                        return -ENXIO;
+
+                                n = va_arg(ap, unsigned);
+                                for (i = 0; i < n; i++) {
+                                        r = message_read_ap(m, s, ap);
+                                        if (r < 0)
+                                                return r;
+                                }
+
+                                r = sd_bus_message_exit_container(m);
+                        }
+
+                        break;
+                }
+
+                case SD_BUS_TYPE_VARIANT: {
+                        const char *s;
+
+                        s = va_arg(ap, const char *);
+                        if (!s)
+                                return -EINVAL;
+
+                        r = sd_bus_message_enter_container(m, SD_BUS_TYPE_VARIANT, s);
+                        if (r < 0)
+                                return r;
+                        if (r == 0)
+                                return -ENXIO;
+
+                        r = message_read_ap(m, s, ap);
+                        if (r < 0)
+                                return r;
+                        if (r == 0)
+                                return -ENXIO;
+
+                        r = sd_bus_message_exit_container(m);
+                        break;
+                }
+
+                case SD_BUS_TYPE_STRUCT_BEGIN:
+                case SD_BUS_TYPE_DICT_ENTRY_BEGIN: {
+                        size_t k;
+
+                        r = signature_element_length(t, &k);
+                        if (r < 0)
+                                return r;
+
+                        {
+                                char s[k - 1];
+                                memcpy(s, t + 1, k - 2);
+                                s[k - 2] = 0;
+
+                                r = sd_bus_message_enter_container(m, *t == SD_BUS_TYPE_STRUCT_BEGIN ? SD_BUS_TYPE_STRUCT : SD_BUS_TYPE_DICT_ENTRY, s);
+                                if (r < 0)
+                                        return r;
+                                if (r == 0)
+                                        return -ENXIO;
+
+                                t += k - 1;
+
+                                r = message_read_ap(m, s, ap);
+                                if (r < 0)
+                                        return r;
+                                if (r == 0)
+                                        return -ENXIO;
+
+                                r = sd_bus_message_exit_container(m);
+                        }
+
+                        break;
+                }
+
+                default:
+                        r = -EINVAL;
+                }
+
+                if (r < 0)
+                        return r;
+                if (r == 0)
+                        return -ENXIO;
+        }
+
+        return 1;
+}
+
+int sd_bus_message_read(sd_bus_message *m, const char *types, ...) {
+        va_list ap;
+        int r;
+
+        if (!m)
+                return -EINVAL;
+        if (!m->sealed)
+                return -EPERM;
+        if (!types)
+                return -EINVAL;
+
+        va_start(ap, types);
+        r = message_read_ap(m, types, ap);
+        va_end(ap);
+
+        return r;
+}
+
+static int message_peek_fields(
+                sd_bus_message *m,
+                size_t *rindex,
+                size_t align,
+                size_t nbytes,
+                void **ret) {
+
+        assert(m);
+        assert(rindex);
+        assert(align > 0);
+
+        return buffer_peek(m->fields, BUS_MESSAGE_FIELDS_SIZE(m), rindex, align, nbytes, ret);
+}
+
+static int message_peek_field_string(
+                sd_bus_message *m,
+                size_t *ri,
+                const char **ret) {
+
+        size_t l;
+        int r;
+        void *q;
+
+        assert(m);
+        assert(ri);
+
+        r = message_peek_fields(m, ri, 4, 4, &q);
+        if (r < 0)
+                return r;
+
+        l = BUS_MESSAGE_BSWAP32(m, *(uint32_t*) q);
+        r = message_peek_fields(m, ri, 1, l+1, &q);
+        if (r < 0)
+                return r;
+
+        if (!validate_string(q, l))
+                return -EBADMSG;
+
+        if (ret)
+                *ret = q;
+
+        return 0;
+}
+
+static int message_peek_field_signature(
+                sd_bus_message *m,
+                size_t *ri,
+                const char **ret) {
+
+        size_t l;
+        int r;
+        void *q;
+
+        assert(m);
+        assert(ri);
+
+        r = message_peek_fields(m, ri, 1, 1, &q);
+        if (r < 0)
+                return r;
+
+        l = *(uint8_t*) q;
+        r = message_peek_fields(m, ri, 1, l+1, &q);
+        if (r < 0)
+                return r;
+
+        if (!validate_signature(q, l))
+                return -EBADMSG;
+
+        if (ret)
+                *ret = q;
+
+        return 0;
+}
+
+static int message_peek_field_uint32(
+                sd_bus_message *m,
+                size_t *ri,
+                uint32_t *ret) {
+
+        int r;
+        void *q;
+
+        assert(m);
+        assert(ri);
+
+        r = message_peek_fields(m, ri, 4, 4, &q);
+        if (r < 0)
+                return r;
+
+        if (ret)
+                *ret = BUS_MESSAGE_BSWAP32(m, *(uint32_t*) q);
+
+        return 0;
+}
+
+static int message_skip_fields(
+                sd_bus_message *m,
+                size_t *ri,
+                uint32_t array_size,
+                const char **signature) {
+
+        size_t original_index;
+        int r;
+
+        assert(m);
+        assert(ri);
+        assert(signature);
+
+        original_index = *ri;
+
+        for (;;) {
+                char t;
+                void *q;
+                size_t l;
+
+                if (array_size != (uint32_t) -1 &&
+                    array_size <= *ri - original_index)
+                        return 0;
+
+                t = **signature;
+                if (!t)
+                        return 0;
+
+                if (t == SD_BUS_TYPE_STRING ||
+                    t == SD_BUS_TYPE_OBJECT_PATH) {
+
+                        r = message_peek_field_string(m, ri, NULL);
+                        if (r < 0)
+                                return r;
+
+                        (*signature)++;
+
+                } else if (t == SD_BUS_TYPE_SIGNATURE) {
+
+                        r = message_peek_field_signature(m, ri, NULL);
+                        if (r < 0)
+                                return r;
+
+                        (*signature)++;
+
+                } else if (bus_type_is_basic(t)) {
+                        size_t align, k;
+
+                        align = bus_type_get_alignment(t);
+                        k = bus_type_get_size(t);
+
+                        r = message_peek_fields(m, ri, align, k, NULL);
+                        if (r < 0)
+                                return r;
+
+                        (*signature)++;
+
+                } else if (t == SD_BUS_TYPE_ARRAY) {
+
+                        r = signature_element_length(*signature+1, &l);
+                        if (r < 0)
+                                return r;
+
+                        assert(l >= 1);
+                        {
+                                char sig[l-1], *s;
+                                size_t nas;
+                                int alignment;
+
+                                strncpy(sig, *signature + 1, l-1);
+                                s = sig;
+
+                                alignment = bus_type_get_alignment(sig[0]);
+                                if (alignment < 0)
+                                        return alignment;
+
+                                r = message_peek_fields(m, ri, 4, 4, &q);
+                                if (r < 0)
+                                        return r;
+
+                                nas = BUS_MESSAGE_BSWAP32(m, *(uint32_t*) q);
+                                if (nas > 67108864)
+                                        return -EBADMSG;
+
+                                r = message_peek_fields(m, ri, alignment, 0, NULL);
+                                if (r < 0)
+                                        return r;
+
+                                r = message_skip_fields(m, ri, nas, (const char**) &s);
+                                if (r < 0)
+                                        return r;
+                        }
+
+                        (*signature) += 1 + l;
+
+                } else if (t == SD_BUS_TYPE_VARIANT) {
+                        const char *s;
+
+                        r = message_peek_field_signature(m, ri, &s);
+                        if (r < 0)
+                                return r;
+
+                        r = message_skip_fields(m, ri, (uint32_t) -1, (const char**) &s);
+                        if (r < 0)
+                                return r;
+
+                        (*signature)++;
+
+                } else if (t == SD_BUS_TYPE_STRUCT ||
+                           t == SD_BUS_TYPE_DICT_ENTRY) {
+
+                        r = signature_element_length(*signature, &l);
+                        if (r < 0)
+                                return r;
+
+                        assert(l >= 2);
+                        {
+                                char sig[l-1], *s;
+                                strncpy(sig, *signature + 1, l-1);
+                                s = sig;
+
+                                r = message_skip_fields(m, ri, (uint32_t) -1, (const char**) &s);
+                                if (r < 0)
+                                        return r;
+                        }
+
+                        *signature += l;
+                } else
+                        return -EINVAL;
+        }
+}
+
+static int message_parse_fields(sd_bus_message *m) {
+        size_t ri;
+        int r;
+
+        assert(m);
+
+        for (ri = 0; ri < BUS_MESSAGE_FIELDS_SIZE(m); ) {
+                const char *signature;
+                uint8_t *header;
+
+                r = message_peek_fields(m, &ri, 8, 1, (void**) &header);
+                if (r < 0)
+                        return r;
+
+                r = message_peek_field_signature(m, &ri, &signature);
+                if (r < 0)
+                        return r;
+
+                switch (*header) {
+                case _SD_BUS_MESSAGE_HEADER_INVALID:
+                        return -EBADMSG;
+
+                case SD_BUS_MESSAGE_HEADER_PATH:
+                        if (!streq(signature, "o"))
+                                return -EBADMSG;
+
+                        r = message_peek_field_string(m, &ri, &m->path);
+                        break;
+
+                case SD_BUS_MESSAGE_HEADER_INTERFACE:
+                        if (!streq(signature, "s"))
+                                return -EBADMSG;
+
+                        r = message_peek_field_string(m, &ri, &m->interface);
+                        break;
+
+                case SD_BUS_MESSAGE_HEADER_MEMBER:
+                        if (!streq(signature, "s"))
+                                return -EBADMSG;
+
+                        r = message_peek_field_string(m, &ri, &m->member);
+                        break;
+
+                case SD_BUS_MESSAGE_HEADER_ERROR_NAME:
+                        if (!streq(signature, "s"))
+                                return -EBADMSG;
+
+                        r = message_peek_field_string(m, &ri, &m->error.name);
+                        break;
+
+                case SD_BUS_MESSAGE_HEADER_DESTINATION:
+                        if (!streq(signature, "s"))
+                                return -EBADMSG;
+
+                        r = message_peek_field_string(m, &ri, &m->destination);
+                        break;
+
+                case SD_BUS_MESSAGE_HEADER_SENDER:
+                        if (!streq(signature, "s"))
+                                return -EBADMSG;
+
+                        r = message_peek_field_string(m, &ri, &m->sender);
+                        break;
+
+
+                case SD_BUS_MESSAGE_HEADER_SIGNATURE: {
+                        const char *s;
+                        char *c;
+
+                        if (!streq(signature, "g"))
+                                return -EBADMSG;
+
+                        r = message_peek_field_signature(m, &ri, &s);
+                        if (r < 0)
+                                return r;
+
+                        c = strdup(s);
+                        if (!c)
+                                return -ENOMEM;
+
+                        free(m->root_container.signature);
+                        m->root_container.signature = c;
+
+                        r = 0;
+                        break;
+                }
+
+                case SD_BUS_MESSAGE_HEADER_REPLY_SERIAL:
+                        if (!streq(signature, "u"))
+                                return -EBADMSG;
+
+                        r = message_peek_field_uint32(m, &ri, &m->reply_serial);
+                        break;
+
+                default:
+                        r = message_skip_fields(m, &ri, (uint32_t) -1, (const char **) &signature);
+                }
+
+                if (r < 0)
+                        return r;
+        }
+
+        if (isempty(m->root_container.signature) != (BUS_MESSAGE_BODY_SIZE(m) == 0))
+                return -EBADMSG;
+
+        switch (m->header->type) {
+
+        case SD_BUS_MESSAGE_TYPE_SIGNAL:
+                if (!m->path || !m->interface || !m->member)
+                        return -EBADMSG;
+                break;
+
+        case SD_BUS_MESSAGE_TYPE_METHOD_CALL:
+
+                if (!m->path || !m->member)
+                        return -EBADMSG;
+
+                break;
+
+        case SD_BUS_MESSAGE_TYPE_METHOD_RETURN:
+
+                if (m->reply_serial == 0)
+                        return -EBADMSG;
+                break;
+
+        case SD_BUS_MESSAGE_TYPE_METHOD_ERROR:
+
+                if (m->reply_serial == 0 || !m->error.name)
+                        return -EBADMSG;
+                break;
+        }
+
+        /* Try to read the error message, but if we can't it's a non-issue */
+        if (m->header->type == SD_BUS_MESSAGE_TYPE_METHOD_ERROR)
+                sd_bus_message_read(m, "s", &m->error.message);
+
+        return 0;
+}
+
+static void setup_iovec(sd_bus_message *m) {
+        assert(m);
+        assert(m->sealed);
+
+        m->n_iovec = 0;
+        m->size = 0;
+
+        m->iovec[m->n_iovec].iov_base = m->header;
+        m->iovec[m->n_iovec].iov_len = sizeof(*m->header);
+        m->size += m->iovec[m->n_iovec].iov_len;
+        m->n_iovec++;
+
+        if (m->fields) {
+                m->iovec[m->n_iovec].iov_base = m->fields;
+                m->iovec[m->n_iovec].iov_len = m->header->fields_size;
+                m->size += m->iovec[m->n_iovec].iov_len;
+                m->n_iovec++;
+
+                if (m->header->fields_size % 8 != 0) {
+                        static const uint8_t padding[7] = { 0, 0, 0, 0, 0, 0, 0 };
+
+                        m->iovec[m->n_iovec].iov_base = (void*) padding;
+                        m->iovec[m->n_iovec].iov_len = 8 - m->header->fields_size % 8;
+                        m->size += m->iovec[m->n_iovec].iov_len;
+                        m->n_iovec++;
+                }
+        }
+
+        if (m->body) {
+                m->iovec[m->n_iovec].iov_base = m->body;
+                m->iovec[m->n_iovec].iov_len = m->header->body_size;
+                m->size += m->iovec[m->n_iovec].iov_len;
+                m->n_iovec++;
+        }
+}
+
+int bus_message_seal(sd_bus_message *m, uint64_t serial) {
+        int r;
+
+        assert(m);
+
+        if (m->sealed)
+                return -EPERM;
+
+        if (m->n_containers > 0)
+                return -EBADMSG;
+
+        /* If there's a non-trivial signature set, then add it in here */
+        if (!isempty(m->root_container.signature)) {
+                r = message_append_field_signature(m, SD_BUS_MESSAGE_HEADER_SIGNATURE, m->root_container.signature, NULL);
+                if (r < 0)
+                        return r;
+        }
+
+        if (m->n_fds > 0) {
+                r = message_append_field_uint32(m, SD_BUS_MESSAGE_HEADER_UNIX_FDS, m->n_fds);
+                if (r < 0)
+                        return r;
+        }
+
+        m->header->serial = serial;
+        m->sealed = true;
+
+        setup_iovec(m);
+
+        return 0;
+}
+
+int sd_bus_message_set_destination(sd_bus_message *m, const char *destination) {
+        if (!m)
+                return -EINVAL;
+        if (!destination)
+                return -EINVAL;
+        if (m->sealed)
+                return -EPERM;
+        if (m->destination)
+                return -EEXIST;
+
+        return message_append_field_string(m, SD_BUS_MESSAGE_HEADER_DESTINATION, SD_BUS_TYPE_STRING, destination, &m->destination);
+}
+
+int bus_message_dump(sd_bus_message *m) {
+        unsigned level = 1;
+        int r;
+
+        assert(m);
+
+        printf("Message %p\n"
+               "\tn_ref=%u\n"
+               "\tendian=%c\n"
+               "\ttype=%i\n"
+               "\tflags=%u\n"
+               "\tversion=%u\n"
+               "\tserial=%u\n"
+               "\tfields_size=%u\n"
+               "\tbody_size=%u\n"
+               "\tpath=%s\n"
+               "\tinterface=%s\n"
+               "\tmember=%s\n"
+               "\tdestination=%s\n"
+               "\tsender=%s\n"
+               "\tsignature=%s\n"
+               "\treply_serial=%u\n"
+               "\terror.name=%s\n"
+               "\terror.message=%s\n"
+               "\tsealed=%s\n",
+               m,
+               m->n_ref,
+               m->header->endian,
+               m->header->type,
+               m->header->flags,
+               m->header->version,
+               BUS_MESSAGE_SERIAL(m),
+               BUS_MESSAGE_FIELDS_SIZE(m),
+               BUS_MESSAGE_BODY_SIZE(m),
+               strna(m->path),
+               strna(m->interface),
+               strna(m->member),
+               strna(m->destination),
+               strna(m->sender),
+               strna(m->root_container.signature),
+               m->reply_serial,
+               strna(m->error.name),
+               strna(m->error.message),
+               yes_no(m->sealed));
+
+        r = sd_bus_message_rewind(m, true);
+        if (r < 0) {
+                log_error("Failed to rewind: %s", strerror(-r));
+                return r;
+        }
+
+        printf("BEGIN_MESSAGE \"%s\" {\n", strempty(m->root_container.signature));
+
+        for(;;) {
+                _cleanup_free_ char *prefix = NULL;
+                const char *contents = NULL;
+                char type;
+                union {
+                        uint8_t u8;
+                        uint16_t u16;
+                        int16_t s16;
+                        uint32_t u32;
+                        int32_t s32;
+                        uint64_t u64;
+                        int64_t s64;
+                        double d64;
+                        const char *string;
+                        int i;
+                } basic;
+
+                r = sd_bus_message_peek_type(m, &type, &contents);
+                if (r < 0) {
+                        log_error("Failed to peek type: %s", strerror(-r));
+                        return r;
+                }
+                if (r == 0) {
+                        if (level <= 1)
+                                break;
+
+                        r = sd_bus_message_exit_container(m);
+                        if (r < 0) {
+                                log_error("Failed to exit container: %s", strerror(-r));
+                                return r;
+                        }
+
+                        level--;
+
+                        prefix = strrep("\t", level);
+                        if (!prefix)
+                                return log_oom();
+
+                        if (type == SD_BUS_TYPE_ARRAY)
+                                printf("%s} END_ARRAY \n", prefix);
+                        else if (type == SD_BUS_TYPE_VARIANT)
+                                printf("%s} END_VARIANT\n", prefix);
+                        else if (type == SD_BUS_TYPE_STRUCT)
+                                printf("%s} END_STRUCT\n", prefix);
+                        else if (type == SD_BUS_TYPE_DICT_ENTRY)
+                                printf("%s} END_DICT_ENTRY\n", prefix);
+
+                        continue;
+                }
+
+                prefix = strrep("\t", level);
+                if (!prefix)
+                        return log_oom();
+
+                if (bus_type_is_container(type) > 0) {
+                        r = sd_bus_message_enter_container(m, type, contents);
+                        if (r < 0) {
+                                log_error("Failed to enter container: %s", strerror(-r));
+                                return r;
+                        }
+
+                        if (type == SD_BUS_TYPE_ARRAY)
+                                printf("%sBEGIN_ARRAY \"%s\" {\n", prefix, contents);
+                        else if (type == SD_BUS_TYPE_VARIANT)
+                                printf("%sBEGIN_VARIANT \"%s\" {\n", prefix, contents);
+                        else if (type == SD_BUS_TYPE_STRUCT)
+                                printf("%sBEGIN_STRUCT \"%s\" {\n", prefix, contents);
+                        else if (type == SD_BUS_TYPE_DICT_ENTRY)
+                                printf("%sBEGIN_DICT_ENTRY \"%s\" {\n", prefix, contents);
+
+                        level ++;
+
+                        continue;
+                }
+
+                r = sd_bus_message_read_basic(m, type, &basic);
+                if (r < 0) {
+                        log_error("Failed to get basic: %s", strerror(-r));
+                        return r;
+                }
+
+                switch (type) {
+
+                case SD_BUS_TYPE_BYTE:
+                        printf("%sBYTE: %u\n", prefix, basic.u8);
+                        break;
+
+                case SD_BUS_TYPE_BOOLEAN:
+                        printf("%sBOOLEAN: %s\n", prefix, yes_no(basic.i));
+                        break;
+
+                case SD_BUS_TYPE_INT16:
+                        printf("%sINT16: %i\n", prefix, basic.s16);
+                        break;
+
+                case SD_BUS_TYPE_UINT16:
+                        printf("%sUINT16: %u\n", prefix, basic.u16);
+                        break;
+
+                case SD_BUS_TYPE_INT32:
+                        printf("%sINT32: %i\n", prefix, basic.s32);
+                        break;
+
+                case SD_BUS_TYPE_UINT32:
+                        printf("%sUINT32: %u\n", prefix, basic.u32);
+                        break;
+
+                case SD_BUS_TYPE_INT64:
+                        printf("%sINT64: %lli\n", prefix, (long long) basic.s64);
+                        break;
+
+                case SD_BUS_TYPE_UINT64:
+                        printf("%sUINT64: %llu\n", prefix, (unsigned long long) basic.u64);
+                        break;
+
+                case SD_BUS_TYPE_DOUBLE:
+                        printf("%sDOUBLE: %g\n", prefix, basic.d64);
+                        break;
+
+                case SD_BUS_TYPE_STRING:
+                        printf("%sSTRING: \"%s\"\n", prefix, basic.string);
+                        break;
+
+                case SD_BUS_TYPE_OBJECT_PATH:
+                        printf("%sOBJECT_PATH: \"%s\"\n", prefix, basic.string);
+                        break;
+
+                case SD_BUS_TYPE_SIGNATURE:
+                        printf("%sSIGNATURE: \"%s\"\n", prefix, basic.string);
+                        break;
+
+                case SD_BUS_TYPE_UNIX_FD:
+                        printf("%sUNIX_FD: %i\n", prefix, basic.i);
+                        break;
+
+                default:
+                        assert_not_reached("Unknown basic type.");
+                }
+        }
+
+        printf("} END_MESSAGE\n");
+        return 0;
+}
+
+int bus_message_get_blob(sd_bus_message *m, void **buffer, size_t *sz) {
+        size_t total;
+        unsigned i;
+        void *p, *e;
+
+        assert(m);
+        assert(buffer);
+        assert(sz);
+
+        for (i = 0, total = 0; i < m->n_iovec; i++)
+                total += m->iovec[i].iov_len;
+
+        p = malloc(total);
+        if (!p)
+                return -ENOMEM;
+
+        for (i = 0, e = p; i < m->n_iovec; i++)
+                e = mempcpy(e, m->iovec[i].iov_base, m->iovec[i].iov_len);
+
+        *buffer = p;
         *sz = total;
 
         return 0;
 }
+
+int bus_message_read_strv_extend(sd_bus_message *m, char ***l) {
+        int r;
+
+        assert(m);
+        assert(l);
+
+        r = sd_bus_message_enter_container(m, 'a', "s");
+        if (r < 0)
+                return r;
+
+        for (;;) {
+                const char *s;
+
+                r = sd_bus_message_read_basic(m, 's', &s);
+                if (r < 0)
+                        return r;
+                if (r == 0)
+                        break;
+
+                r = strv_extend(l, s);
+                if (r < 0)
+                        return r;
+        }
+
+        r = sd_bus_message_exit_container(m);
+        if (r < 0)
+                return r;
+
+        return 0;
+}