Fix memory leak in stdout journal streams

[elogind.git] / src / journal / journald-stream.c

diff --git a/src/journal/journald-stream.c b/src/journal/journald-stream.c
index 3e4022ad6942cb4e086ed70c4d49ec24ffa20948..091f59de17c020daa3392e6a906414da2b1cb00a 100644 (file)
--- a/src/journal/journald-stream.c
+++ b/src/journal/journald-stream.c
@@ -21,6 +21,7 @@
 
 #include <fcntl.h>
 #include <unistd.h>
 
 #include <fcntl.h>
 #include <unistd.h>

+#include <stddef.h>

 #include <sys/epoll.h>
 
 #ifdef HAVE_SELINUX
 #include <sys/epoll.h>
 
 #ifdef HAVE_SELINUX


@@ -28,7 +29,8 @@
 #endif
 
 #include "socket-util.h"
 #endif
 
 #include "socket-util.h"

-#include "journald.h"
+#include "selinux-util.h"
+#include "journald-server.h"

 #include "journald-stream.h"
 #include "journald-syslog.h"
 #include "journald-kmsg.h"
 #include "journald-stream.h"
 #include "journald-syslog.h"
 #include "journald-kmsg.h"


@@ -89,7 +91,7 @@ static int stdout_stream_log(StdoutStream *s, const char *p) {
         priority = s->priority;
 
         if (s->level_prefix)
         priority = s->priority;
 
         if (s->level_prefix)

-                syslog_parse_priority((char**) &p, &priority);
+                syslog_parse_priority((char**) &p, &priority, false);

 
         if (s->forward_to_syslog || s->server->forward_to_syslog)
                 server_forward_syslog(s->server, syslog_fixup_facility(priority), s->identifier, p, &s->ucred, NULL);
 
         if (s->forward_to_syslog || s->server->forward_to_syslog)
                 server_forward_syslog(s->server, syslog_fixup_facility(priority), s->identifier, p, &s->ucred, NULL);


@@ -126,7 +128,7 @@ static int stdout_stream_log(StdoutStream *s, const char *p) {
         }
 #endif
 
         }
 #endif
 

-        server_dispatch_message(s->server, iovec, n, ELEMENTSOF(iovec), &s->ucred, NULL, label, label_len, s->unit_id, priority);
+        server_dispatch_message(s->server, iovec, n, ELEMENTSOF(iovec), &s->ucred, NULL, label, label_len, s->unit_id, priority, 0);

 
         free(message);
         free(syslog_priority);
 
         free(message);
         free(syslog_priority);


@@ -174,7 +176,7 @@ static int stdout_stream_line(StdoutStream *s, char *p) {
 
         case STDOUT_STREAM_PRIORITY:
                 r = safe_atoi(p, &s->priority);
 
         case STDOUT_STREAM_PRIORITY:
                 r = safe_atoi(p, &s->priority);

-                if (r < 0 || s->priority <= 0 || s->priority >= 999) {
+                if (r < 0 || s->priority < 0 || s->priority > 999) {

                         log_warning("Failed to parse log priority line.");
                         return -EINVAL;
                 }
                         log_warning("Failed to parse log priority line.");
                         return -EINVAL;
                 }


@@ -322,7 +324,7 @@ void stdout_stream_free(StdoutStream *s) {
         if (s->server) {
                 assert(s->server->n_stdout_streams > 0);
                 s->server->n_stdout_streams --;
         if (s->server) {
                 assert(s->server->n_stdout_streams > 0);
                 s->server->n_stdout_streams --;

-                LIST_REMOVE(StdoutStream, stdout_stream, s->server->stdout_streams, s);
+                LIST_REMOVE(stdout_stream, s->server->stdout_streams, s);

         }
 
         if (s->fd >= 0) {
         }
 
         if (s->fd >= 0) {


@@ -338,6 +340,7 @@ void stdout_stream_free(StdoutStream *s) {
 #endif
 
         free(s->identifier);
 #endif
 
         free(s->identifier);

+        free(s->unit_id);

         free(s);
 }
 
         free(s);
 }
 


@@ -380,8 +383,10 @@ int stdout_stream_new(Server *s) {
         }
 
 #ifdef HAVE_SELINUX
         }
 
 #ifdef HAVE_SELINUX

-        if (getpeercon(fd, &stream->security_context) < 0 && errno != ENOPROTOOPT)
-                log_error("Failed to determine peer security context: %m");
+        if (use_selinux()) {
+                if (getpeercon(fd, &stream->security_context) < 0 && errno != ENOPROTOOPT)
+                        log_error("Failed to determine peer security context: %m");
+        }

 #endif
 
         if (shutdown(fd, SHUT_WR) < 0) {
 #endif
 
         if (shutdown(fd, SHUT_WR) < 0) {


@@ -400,7 +405,7 @@ int stdout_stream_new(Server *s) {
         }
 
         stream->server = s;
         }
 
         stream->server = s;

-        LIST_PREPEND(StdoutStream, stdout_stream, s->stdout_streams, stream);
+        LIST_PREPEND(stdout_stream, s->stdout_streams, stream);

         s->n_stdout_streams ++;
 
         return 0;
         s->n_stdout_streams ++;
 
         return 0;


@@ -411,13 +416,16 @@ fail:
 }
 
 int server_open_stdout_socket(Server *s) {
 }
 
 int server_open_stdout_socket(Server *s) {

-        union sockaddr_union sa;

         int r;
         struct epoll_event ev;
 
         assert(s);
 
         if (s->stdout_fd < 0) {
         int r;
         struct epoll_event ev;
 
         assert(s);
 
         if (s->stdout_fd < 0) {

+                union sockaddr_union sa = {
+                        .un.sun_family = AF_UNIX,
+                        .un.sun_path = "/run/systemd/journal/stdout",
+                };

 
                 s->stdout_fd = socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, 0);
                 if (s->stdout_fd < 0) {
 
                 s->stdout_fd = socket(AF_UNIX, SOCK_STREAM|SOCK_CLOEXEC|SOCK_NONBLOCK, 0);
                 if (s->stdout_fd < 0) {


@@ -425,10 +433,6 @@ int server_open_stdout_socket(Server *s) {
                         return -errno;
                 }
 
                         return -errno;
                 }
 

-                zero(sa);
-                sa.un.sun_family = AF_UNIX;
-                strncpy(sa.un.sun_path, "/run/systemd/journal/stdout", sizeof(sa.un.sun_path));
-

                 unlink(sa.un.sun_path);
 
                 r = bind(s->stdout_fd, &sa.sa, offsetof(union sockaddr_union, un.sun_path) + strlen(sa.un.sun_path));
                 unlink(sa.un.sun_path);
 
                 r = bind(s->stdout_fd, &sa.sa, offsetof(union sockaddr_union, un.sun_path) + strlen(sa.un.sun_path));


@@ -440,7 +444,7 @@ int server_open_stdout_socket(Server *s) {
                 chmod(sa.un.sun_path, 0666);
 
                 if (listen(s->stdout_fd, SOMAXCONN) < 0) {
                 chmod(sa.un.sun_path, 0666);
 
                 if (listen(s->stdout_fd, SOMAXCONN) < 0) {

-                        log_error("liste() failed: %m");
+                        log_error("listen() failed: %m");

                         return -errno;
                 }
         } else
                         return -errno;
                 }
         } else