basic: parse_timestamp UTC and fractional seconds support

[elogind.git] / src / basic / time-util.c

diff --git a/src/basic/time-util.c b/src/basic/time-util.c
index 15185a2bb3e565222777e0e84a050c82cb00ca70..95b837a85ba9313a1cd47b39a97b145979088ea3 100644 (file)
--- a/src/basic/time-util.c
+++ b/src/basic/time-util.c
@@ -37,6 +37,8 @@ usec_t now(clockid_t clock_id) {
         return timespec_load(&ts);
 }
 
         return timespec_load(&ts);
 }
 

+/// UNNEEDED by elogind
+#if 0

 nsec_t now_nsec(clockid_t clock_id) {
         struct timespec ts;
 
 nsec_t now_nsec(clockid_t clock_id) {
         struct timespec ts;
 


@@ -44,6 +46,7 @@ nsec_t now_nsec(clockid_t clock_id) {
 
         return timespec_load_nsec(&ts);
 }
 
         return timespec_load_nsec(&ts);
 }

+#endif // 0

 
 dual_timestamp* dual_timestamp_get(dual_timestamp *ts) {
         assert(ts);
 
 dual_timestamp* dual_timestamp_get(dual_timestamp *ts) {
         assert(ts);


@@ -98,7 +101,6 @@ dual_timestamp* dual_timestamp_from_monotonic(dual_timestamp *ts, usec_t u) {
 
         return ts;
 }
 
         return ts;
 }

-#endif // 0

 
 dual_timestamp* dual_timestamp_from_boottime_or_monotonic(dual_timestamp *ts, usec_t u) {
         int64_t delta;
 
 dual_timestamp* dual_timestamp_from_boottime_or_monotonic(dual_timestamp *ts, usec_t u) {
         int64_t delta;


@@ -124,7 +126,7 @@ dual_timestamp* dual_timestamp_from_boottime_or_monotonic(dual_timestamp *ts, us
 
         return ts;
 }
 
         return ts;
 }

-
+#endif // 0

 
 usec_t timespec_load(const struct timespec *ts) {
         assert(ts);
 
 usec_t timespec_load(const struct timespec *ts) {
         assert(ts);


@@ -495,9 +497,10 @@ int parse_timestamp(const char *t, usec_t *usec) {
         };
 
         const char *k;
         };
 
         const char *k;

+        bool utc;

         struct tm tm, copy;
         time_t x;
         struct tm tm, copy;
         time_t x;

-        usec_t plus = 0, minus = 0, ret;
+        usec_t x_usec, plus = 0, minus = 0, ret;

         int r, weekday = -1;
         unsigned i;
 
         int r, weekday = -1;
         unsigned i;
 


@@ -522,28 +525,15 @@ int parse_timestamp(const char *t, usec_t *usec) {
         assert(t);
         assert(usec);
 
         assert(t);
         assert(usec);
 

-        x = time(NULL);
-        assert_se(localtime_r(&x, &tm));
-        tm.tm_isdst = -1;
-
-        if (streq(t, "now"))
-                goto finish;
+        if (t[0] == '@')
+                return parse_sec(t + 1, usec);

 
 

-        else if (streq(t, "today")) {
-                tm.tm_sec = tm.tm_min = tm.tm_hour = 0;
-                goto finish;
+        ret = now(CLOCK_REALTIME);

 
 

-        } else if (streq(t, "yesterday")) {
-                tm.tm_mday --;
-                tm.tm_sec = tm.tm_min = tm.tm_hour = 0;
-                goto finish;
-
-        } else if (streq(t, "tomorrow")) {
-                tm.tm_mday ++;
-                tm.tm_sec = tm.tm_min = tm.tm_hour = 0;
+        if (streq(t, "now"))

                 goto finish;
 
                 goto finish;
 

-        } else if (t[0] == '+') {
+        else if (t[0] == '+') {

                 r = parse_sec(t+1, &plus);
                 if (r < 0)
                         return r;
                 r = parse_sec(t+1, &plus);
                 if (r < 0)
                         return r;


@@ -557,35 +547,51 @@ int parse_timestamp(const char *t, usec_t *usec) {
 
                 goto finish;
 
 
                 goto finish;
 

-        } else if (t[0] == '@')
-                return parse_sec(t + 1, usec);
-
-        else if (endswith(t, " ago")) {
-                _cleanup_free_ char *z;
+        } else if (endswith(t, " ago")) {
+                t = strndupa(t, strlen(t) - strlen(" ago"));

 
 

-                z = strndup(t, strlen(t) - 4);
-                if (!z)
-                        return -ENOMEM;
-
-                r = parse_sec(z, &minus);
+                r = parse_sec(t, &minus);

                 if (r < 0)
                         return r;
 
                 goto finish;
                 if (r < 0)
                         return r;
 
                 goto finish;

-        } else if (endswith(t, " left")) {
-                _cleanup_free_ char *z;

 
 

-                z = strndup(t, strlen(t) - 4);
-                if (!z)
-                        return -ENOMEM;
+        } else if (endswith(t, " left")) {
+                t = strndupa(t, strlen(t) - strlen(" left"));

 
 

-                r = parse_sec(z, &plus);
+                r = parse_sec(t, &plus);

                 if (r < 0)
                         return r;
 
                 goto finish;
         }
 
                 if (r < 0)
                         return r;
 
                 goto finish;
         }
 

+        utc = endswith_no_case(t, " UTC");
+        if (utc)
+                t = strndupa(t, strlen(t) - strlen(" UTC"));
+
+        x = ret / USEC_PER_SEC;
+        x_usec = 0;
+
+        assert_se(localtime_or_gmtime_r(&x, &tm, utc));
+        tm.tm_isdst = -1;
+
+        if (streq(t, "today")) {
+                tm.tm_sec = tm.tm_min = tm.tm_hour = 0;
+                goto from_tm;
+
+        } else if (streq(t, "yesterday")) {
+                tm.tm_mday --;
+                tm.tm_sec = tm.tm_min = tm.tm_hour = 0;
+                goto from_tm;
+
+        } else if (streq(t, "tomorrow")) {
+                tm.tm_mday ++;
+                tm.tm_sec = tm.tm_min = tm.tm_hour = 0;
+                goto from_tm;
+        }
+
+

         for (i = 0; i < ELEMENTSOF(day_nr); i++) {
                 size_t skip;
 
         for (i = 0; i < ELEMENTSOF(day_nr); i++) {
                 size_t skip;
 


@@ -603,66 +609,106 @@ int parse_timestamp(const char *t, usec_t *usec) {
 
         copy = tm;
         k = strptime(t, "%y-%m-%d %H:%M:%S", &tm);
 
         copy = tm;
         k = strptime(t, "%y-%m-%d %H:%M:%S", &tm);

-        if (k && *k == 0)
-                goto finish;
+        if (k) {
+                if (*k == '.')
+                        goto parse_usec;
+                else if (*k == 0)
+                        goto from_tm;
+        }

 
         tm = copy;
         k = strptime(t, "%Y-%m-%d %H:%M:%S", &tm);
 
         tm = copy;
         k = strptime(t, "%Y-%m-%d %H:%M:%S", &tm);

-        if (k && *k == 0)
-                goto finish;
+        if (k) {
+                if (*k == '.')
+                        goto parse_usec;
+                else if (*k == 0)
+                        goto from_tm;
+        }

 
         tm = copy;
         k = strptime(t, "%y-%m-%d %H:%M", &tm);
         if (k && *k == 0) {
                 tm.tm_sec = 0;
 
         tm = copy;
         k = strptime(t, "%y-%m-%d %H:%M", &tm);
         if (k && *k == 0) {
                 tm.tm_sec = 0;

-                goto finish;
+                goto from_tm;

         }
 
         tm = copy;
         k = strptime(t, "%Y-%m-%d %H:%M", &tm);
         if (k && *k == 0) {
                 tm.tm_sec = 0;
         }
 
         tm = copy;
         k = strptime(t, "%Y-%m-%d %H:%M", &tm);
         if (k && *k == 0) {
                 tm.tm_sec = 0;

-                goto finish;
+                goto from_tm;

         }
 
         tm = copy;
         k = strptime(t, "%y-%m-%d", &tm);
         if (k && *k == 0) {
                 tm.tm_sec = tm.tm_min = tm.tm_hour = 0;
         }
 
         tm = copy;
         k = strptime(t, "%y-%m-%d", &tm);
         if (k && *k == 0) {
                 tm.tm_sec = tm.tm_min = tm.tm_hour = 0;

-                goto finish;
+                goto from_tm;

         }
 
         tm = copy;
         k = strptime(t, "%Y-%m-%d", &tm);
         if (k && *k == 0) {
                 tm.tm_sec = tm.tm_min = tm.tm_hour = 0;
         }
 
         tm = copy;
         k = strptime(t, "%Y-%m-%d", &tm);
         if (k && *k == 0) {
                 tm.tm_sec = tm.tm_min = tm.tm_hour = 0;

-                goto finish;
+                goto from_tm;

         }
 
         tm = copy;
         k = strptime(t, "%H:%M:%S", &tm);
         }
 
         tm = copy;
         k = strptime(t, "%H:%M:%S", &tm);

-        if (k && *k == 0)
-                goto finish;
+        if (k) {
+                if (*k == '.')
+                        goto parse_usec;
+                else if (*k == 0)
+                        goto from_tm;
+        }

 
         tm = copy;
         k = strptime(t, "%H:%M", &tm);
         if (k && *k == 0) {
                 tm.tm_sec = 0;
 
         tm = copy;
         k = strptime(t, "%H:%M", &tm);
         if (k && *k == 0) {
                 tm.tm_sec = 0;

-                goto finish;
+                goto from_tm;

         }
 
         return -EINVAL;
 
         }
 
         return -EINVAL;
 

-finish:
-        x = mktime(&tm);
+parse_usec:
+        {
+                char *end;
+                unsigned long long val;
+                size_t l;
+
+                k++;
+                if (*k < '0' || *k > '9')
+                        return -EINVAL;
+
+                /* base 10 instead of base 0, .09 is not base 8 */
+                errno = 0;
+                val = strtoull(k, &end, 10);
+                if (*end || errno)
+                        return -EINVAL;
+
+                l = end-k;
+
+                /* val has l digits, make them 6 */
+                for (; l < 6; l++)
+                        val *= 10;
+                for (; l > 6; l--)
+                        val /= 10;
+
+                x_usec = val;
+        }
+
+from_tm:
+        x = mktime_or_timegm(&tm, utc);

         if (x == (time_t) -1)
                 return -EINVAL;
 
         if (weekday >= 0 && tm.tm_wday != weekday)
                 return -EINVAL;
 
         if (x == (time_t) -1)
                 return -EINVAL;
 
         if (weekday >= 0 && tm.tm_wday != weekday)
                 return -EINVAL;
 

-        ret = (usec_t) x * USEC_PER_SEC;
+        ret = (usec_t) x * USEC_PER_SEC + x_usec;

 
 

+finish:

         ret += plus;
         if (ret > minus)
                 ret -= minus;
         ret += plus;
         if (ret > minus)
                 ret -= minus;


@@ -798,6 +844,8 @@ int parse_sec(const char *t, usec_t *usec) {
         return 0;
 }
 
         return 0;
 }
 

+/// UNNEEDED by elogind
+#if 0

 int parse_nsec(const char *t, nsec_t *nsec) {
         static const struct {
                 const char *suffix;
 int parse_nsec(const char *t, nsec_t *nsec) {
         static const struct {
                 const char *suffix;


@@ -923,8 +971,6 @@ int parse_nsec(const char *t, nsec_t *nsec) {
         return 0;
 }
 
         return 0;
 }
 

-/// UNNEEDED by elogind
-#if 0

 bool ntp_synced(void) {
         struct timex txc = {};
 
 bool ntp_synced(void) {
         struct timex txc = {};
 


@@ -1041,7 +1087,6 @@ bool timezone_is_valid(const char *name) {
 
         return true;
 }
 
         return true;
 }

-#endif // 0

 
 clockid_t clock_boottime_or_monotonic(void) {
         static clockid_t clock = -1;
 
 clockid_t clock_boottime_or_monotonic(void) {
         static clockid_t clock = -1;


@@ -1087,3 +1132,4 @@ int get_timezone(char **tz) {
         *tz = z;
         return 0;
 }
         *tz = z;
         return 0;
 }

+#endif // 0