chiark / gitweb /
[PATCH] remove PLACE key match
[elogind.git] / namedev.c
index 90d988311e2bbf3af044271390d5becb80e51fa8..cd1f2de989ea1036319479c3e7374a33d3270e4e 100644 (file)
--- a/namedev.c
+++ b/namedev.c
@@ -4,6 +4,7 @@
  * Userspace devfs
  *
  * Copyright (C) 2003 Greg Kroah-Hartman <greg@kroah.com>
+ * Copyright (C) 2003-2005 Kay Sievers <kay.sievers@vrfy.org>
  *
  *
  *     This program is free software; you can redistribute it and/or modify it
@@ -34,6 +35,7 @@
 
 #include "libsysfs/sysfs/libsysfs.h"
 #include "list.h"
+#include "udev_libc_wrapper.h"
 #include "udev.h"
 #include "udev_utils.h"
 #include "udev_version.h"
@@ -143,15 +145,14 @@ static int get_format_len(char **str)
  */
 static int find_free_number(struct udevice *udev, const char *name)
 {
-       char filename[NAME_SIZE];
+       char devpath[PATH_SIZE];
+       char filename[PATH_SIZE];
        int num = 0;
-       struct udevice db_udev;
 
-       strfieldcpy(filename, name);
+       strlcpy(filename, name, sizeof(filename));
        while (1) {
                dbg("look for existing node '%s'", filename);
-               memset(&db_udev, 0x00, sizeof(struct udevice));
-               if (udev_db_get_device_byname(&db_udev, filename) != 0) {
+               if (udev_db_search_name(devpath, sizeof(devpath), filename) != 0) {
                        dbg("free num=%d", num);
                        return num;
                }
@@ -161,26 +162,20 @@ static int find_free_number(struct udevice *udev, const char *name)
                        info("find_free_number gone crazy (num=%d), aborted", num);
                        return -1;
                }
-               snprintf(filename, NAME_SIZE, "%s%d", name, num);
-               filename[NAME_SIZE-1] = '\0';
+               snprintf(filename, sizeof(filename), "%s%d", name, num);
+               filename[sizeof(filename)-1] = '\0';
        }
 }
 
 static void apply_format(struct udevice *udev, char *string, size_t maxsize,
-                        struct sysfs_class_device *class_dev,
-                        struct sysfs_device *sysfs_device)
+                        struct sysfs_class_device *class_dev, struct sysfs_device *sysfs_device)
 {
-       char temp[NAME_SIZE];
-       char temp2[NAME_SIZE];
-       char *tail;
-       char *pos;
-       char *attr;
+       char temp[PATH_SIZE];
+       char temp2[PATH_SIZE];
+       char *tail, *pos, *cpos, *attr, *rest;
        int len;
        int i;
        char c;
-       char *spos;
-       char *rest;
-       int slen;
        struct sysfs_attribute *tmpattr;
        unsigned int next_free_number;
        struct sysfs_class_device *class_dev_parent;
@@ -195,135 +190,140 @@ static void apply_format(struct udevice *udev, char *string, size_t maxsize,
                tail = pos+1;
                len = get_format_len(&tail);
                c = tail[0];
-               strfieldcpy(temp, tail+1);
+               strlcpy(temp, tail+1, sizeof(temp));
                tail = temp;
                dbg("format=%c, string='%s', tail='%s'",c , string, tail);
                attr = get_format_attribute(&tail);
 
-
                switch (c) {
                case 'p':
-                       if (strlen(udev->devpath) == 0)
-                               break;
-                       strfieldcatmax(string, udev->devpath, maxsize);
+                       strlcat(string, udev->devpath, maxsize);
                        dbg("substitute kernel name '%s'", udev->kernel_name);
                        break;
                case 'b':
-                       if (strlen(udev->bus_id) == 0)
-                               break;
-                       strfieldcatmax(string, udev->bus_id, maxsize);
+                       strlcat(string, udev->bus_id, maxsize);
                        dbg("substitute bus_id '%s'", udev->bus_id);
                        break;
                case 'k':
-                       if (strlen(udev->kernel_name) == 0)
-                               break;
-                       strfieldcatmax(string, udev->kernel_name, maxsize);
+                       strlcat(string, udev->kernel_name, maxsize);
                        dbg("substitute kernel name '%s'", udev->kernel_name);
                        break;
                case 'n':
-                       if (strlen(udev->kernel_number) == 0)
-                               break;
-                       strfieldcatmax(string, udev->kernel_number, maxsize);
+                       strlcat(string, udev->kernel_number, maxsize);
                        dbg("substitute kernel number '%s'", udev->kernel_number);
                                break;
                case 'm':
-                       strintcatmax(string, udev->minor, maxsize);
-                       dbg("substitute minor number '%u'", udev->minor);
+                       sprintf(temp2, "%d", minor(udev->devt));
+                       strlcat(string, temp2, maxsize);
+                       dbg("substitute minor number '%s'", temp2);
                        break;
                case 'M':
-                       strintcatmax(string, udev->major, maxsize);
-                       dbg("substitute major number '%u'", udev->major);
+                       sprintf(temp2, "%d", major(udev->devt));
+                       strlcat(string, temp2, maxsize);
+                       dbg("substitute major number '%s'", temp2);
                        break;
                case 'c':
-                       if (strlen(udev->program_result) == 0)
+                       if (udev->program_result[0] == '\0')
                                break;
                        /* get part part of the result string */
                        i = 0;
                        if (attr != NULL)
                                i = strtoul(attr, &rest, 10);
                        if (i > 0) {
-                               foreach_strpart(udev->program_result, " \n\r", spos, slen) {
-                                       i--;
-                                       if (i == 0)
-                                               break;
+                               dbg("request part #%d of result string", i);
+                               cpos = udev->program_result;
+                               while (--i) {
+                                       while (cpos[0] != '\0' && !isspace(cpos[0]))
+                                               cpos++;
+                                       while (isspace(cpos[0]))
+                                               cpos++;
                                }
                                if (i > 0) {
                                        dbg("requested part of result string not found");
                                        break;
                                }
-                               if (rest[0] == '+')
-                                       strfieldcpy(temp2, spos);
-                               else
-                                       strfieldcpymax(temp2, spos, slen+1);
-                               strfieldcatmax(string, temp2, maxsize);
+                               strlcpy(temp2, cpos, sizeof(temp2));
+                               /* %{2+}c copies the whole string from the second part on */
+                               if (rest[0] != '+') {
+                                       cpos = strchr(temp2, ' ');
+                                       if (cpos)
+                                               cpos[0] = '\0';
+                               }
+                               strlcat(string, temp2, maxsize);
                                dbg("substitute part of result string '%s'", temp2);
                        } else {
-                               strfieldcatmax(string, udev->program_result, maxsize);
+                               strlcat(string, udev->program_result, maxsize);
                                dbg("substitute result string '%s'", udev->program_result);
                        }
                        break;
                case 's':
-                       if (attr != NULL) {
-                               tmpattr = find_sysfs_attribute(class_dev, sysfs_device, attr);
-                               if (tmpattr == NULL) {
-                                       dbg("sysfa attribute '%s' not found", attr);
-                                       break;
-                               }
-                               /* strip trailing whitespace of matching value */
-                               if (isspace(tmpattr->value[strlen(tmpattr->value)-1])) {
-                                       i = len = strlen(tmpattr->value);
-                                       while (i > 0 &&  isspace(tmpattr->value[i-1]))
-                                               i--;
-                                       if (i < len) {
-                                               tmpattr->value[i] = '\0';
-                                               dbg("remove %i trailing whitespace chars from '%s'",
-                                                        len - i, tmpattr->value);
-                                       }
-                               }
-                               strfieldcatmax(string, tmpattr->value, maxsize);
-                               dbg("substitute sysfs value '%s'", tmpattr->value);
-                       } else {
+                       if (!class_dev)
+                               break;
+                       if (attr == NULL) {
                                dbg("missing attribute");
+                               break;
+                       }
+                       tmpattr = find_sysfs_attribute(class_dev, sysfs_device, attr);
+                       if (tmpattr == NULL) {
+                               dbg("sysfa attribute '%s' not found", attr);
+                               break;
                        }
+                       /* strip trailing whitespace of matching value */
+                       if (isspace(tmpattr->value[strlen(tmpattr->value)-1])) {
+                               i = len = strlen(tmpattr->value);
+                               while (i > 0 &&  isspace(tmpattr->value[i-1]))
+                                       i--;
+                               if (i < len) {
+                                       tmpattr->value[i] = '\0';
+                                       dbg("remove %i trailing whitespace chars from '%s'",
+                                                len - i, tmpattr->value);
+                               }
+                       }
+                       strlcat(string, tmpattr->value, maxsize);
+                       dbg("substitute sysfs value '%s'", tmpattr->value);
                        break;
                case '%':
-                       strfieldcatmax(string, "%", maxsize);
+                       strlcat(string, "%", maxsize);
                        pos++;
                        break;
                case 'e':
                        next_free_number = find_free_number(udev, string);
                        if (next_free_number > 0) {
                                sprintf(temp2, "%d", next_free_number);
-                               strfieldcatmax(string, temp2, maxsize);
+                               strlcat(string, temp2, maxsize);
                        }
                        break;
                case 'P':
+                       if (!class_dev)
+                               break;
                        class_dev_parent = sysfs_get_classdev_parent(class_dev);
                        if (class_dev_parent != NULL) {
                                struct udevice udev_parent;
 
                                dbg("found parent '%s', get the node name", class_dev_parent->path);
-                               memset(&udev_parent, 0x00, sizeof(struct udevice));
+                               udev_init_device(&udev_parent, NULL, NULL);
                                /* lookup the name in the udev_db with the DEVPATH of the parent */
-                               strfieldcpy(udev_parent.devpath, &class_dev_parent->path[strlen(sysfs_path)]);
-                               if (udev_db_get_device(&udev_parent) == 0) {
-                                       strfieldcatmax(string, udev_parent.name, maxsize);
+                               if (udev_db_get_device(&udev_parent, &class_dev_parent->path[strlen(sysfs_path)]) == 0) {
+                                       strlcat(string, udev_parent.name, maxsize);
                                        dbg("substitute parent node name'%s'", udev_parent.name);
                                } else
                                        dbg("parent not found in database");
+                               udev_cleanup_device(&udev_parent);
                        }
                        break;
                case 'N':
                        if (udev->tmp_node[0] == '\0') {
                                dbg("create temporary device node for callout");
-                               snprintf(udev->tmp_node, NAME_SIZE-1, "%s/.tmp-%u-%u", udev_root, udev->major, udev->minor);
-                               udev_make_node(udev, udev->tmp_node, udev->major, udev->minor, 0600, 0, 0);
+                               snprintf(udev->tmp_node, sizeof(udev->tmp_node), "%s/.tmp-%u-%u",
+                                        udev_root, major(udev->devt), minor(udev->devt));
+                               udev->tmp_node[sizeof(udev->tmp_node)-1] = '\0';
+                               udev_make_node(udev, udev->tmp_node, udev->devt, 0600, 0, 0);
                        }
-                       strfieldcatmax(string, udev->tmp_node, maxsize);
+                       strlcat(string, udev->tmp_node, maxsize);
                        dbg("substitute temporary device node name '%s'", udev->tmp_node);
                        break;
                case 'r':
-                       strfieldcatmax(string, udev_root, maxsize);
+                       strlcat(string, udev_root, maxsize);
                        dbg("substitute udev_root '%s'", udev_root);
                        break;
                default:
@@ -334,20 +334,7 @@ static void apply_format(struct udevice *udev, char *string, size_t maxsize,
                if (len > 0)
                        pos[len] = '\0';
 
-               strfieldcatmax(string, tail, maxsize);
-       }
-}
-
-static void fix_kernel_name(struct udevice *udev)
-{
-       char *temp = udev->kernel_name;
-
-       while (*temp != 0x00) {
-               /* Some block devices have a ! in their name, 
-                * we need to change that to / */
-               if (*temp == '!')
-                       *temp = '/';
-               ++temp;
+               strlcat(string, tail, maxsize);
        }
 }
 
@@ -359,11 +346,11 @@ static int execute_program(struct udevice *udev, const char *path, char *value,
        int fds[2];
        pid_t pid;
        char *pos;
-       char arg[PROGRAM_SIZE];
-       char *argv[(PROGRAM_SIZE / 2) + 1];
+       char arg[PATH_SIZE];
+       char *argv[(sizeof(arg) / 2) + 1];
        int i;
 
-       strfieldcpy(arg, path);
+       strlcpy(arg, path, sizeof(arg));
        i = 0;
        if (strchr(path, ' ')) {
                pos = arg;
@@ -529,52 +516,17 @@ static int match_sysfs_pairs(struct config_device *dev, struct sysfs_class_devic
        return 0;
 }
 
-static int match_id(struct config_device *dev, struct sysfs_class_device *class_dev, struct sysfs_device *sysfs_device)
+static int match_id(struct config_device *dev, struct sysfs_device *sysfs_device)
 {
-       char path[SYSFS_PATH_MAX];
-       char *temp = NULL;
+       char path[PATH_SIZE];
+       char *temp;
 
-       /* we have to have a sysfs device for ID to work */
-       if (!sysfs_device)
-               return -ENODEV;
-
-       strfieldcpy(path, sysfs_device->path);
+       strlcpy(path, sysfs_device->path, sizeof(path));
        temp = strrchr(path, '/');
        temp++;
        dbg("search '%s' in '%s', path='%s'", dev->id, temp, path);
        if (strcmp_pattern(dev->id, temp) != 0)
                return -ENODEV;
-       else
-               return 0;
-}
-
-static int match_place(struct config_device *dev, struct sysfs_class_device *class_dev, struct sysfs_device *sysfs_device)
-{
-       char path[SYSFS_PATH_MAX];
-       int found;
-       char *temp = NULL;
-
-       /* we have to have a sysfs device for PLACE to work */
-       if (!sysfs_device)
-               return -ENODEV;
-
-       found = 0;
-       strfieldcpy(path, sysfs_device->path);
-       temp = strrchr(path, '/');
-       dbg("search '%s' in '%s', path='%s'", dev->place, temp, path);
-       if (strstr(temp, dev->place) != NULL) {
-               found = 1;
-       } else {
-               *temp = 0x00;
-               temp = strrchr(path, '/');
-               dbg("search '%s' in '%s', path='%s'", dev->place, temp, path);
-               if (strstr(temp, dev->place) != NULL)
-                       found = 1;
-       }
-       if (!found) {
-               dbg("place doesn't match");
-               return -ENODEV;
-       }
 
        return 0;
 }
@@ -582,79 +534,70 @@ static int match_place(struct config_device *dev, struct sysfs_class_device *cla
 static int match_rule(struct udevice *udev, struct config_device *dev,
                      struct sysfs_class_device *class_dev, struct sysfs_device *sysfs_device)
 {
-       while (1) {
-               /* check for matching bus value */
-               if (dev->bus[0] != '\0') {
-                       if (sysfs_device == NULL) {
-                               dbg("device has no bus");
-                               goto try_parent;
-                       }
-                       dbg("check for " FIELD_BUS " dev->bus='%s' sysfs_device->bus='%s'",
-                           dev->bus, sysfs_device->bus);
-                       if (strcmp_pattern(dev->bus, sysfs_device->bus) != 0) {
-                               dbg(FIELD_BUS " is not matching");
-                               goto try_parent;
-                       } else {
-                               dbg(FIELD_BUS " matches");
-                       }
-               }
-
-               /* check for matching kernel name */
-               if (dev->kernel[0] != '\0') {
-                       dbg("check for " FIELD_KERNEL " dev->kernel='%s' class_dev->name='%s'",
-                           dev->kernel, class_dev->name);
-                       if (strcmp_pattern(dev->kernel, class_dev->name) != 0) {
-                               dbg(FIELD_KERNEL " is not matching");
-                               goto try_parent;
-                       } else {
-                               dbg(FIELD_KERNEL " matches");
-                       }
+       if (dev->kernel[0] != '\0') {
+               dbg("check for " FIELD_KERNEL " dev->kernel='%s' class_dev->name='%s'",
+                   dev->kernel, class_dev->name);
+               if (strcmp_pattern(dev->kernel, class_dev->name) != 0) {
+                       dbg(FIELD_KERNEL " is not matching");
+                       goto exit;
                }
+               dbg(FIELD_KERNEL " matches");
+       }
 
-               /* check for matching subsystem */
-               if (dev->subsystem[0] != '\0') {
-                       dbg("check for " FIELD_SUBSYSTEM " dev->subsystem='%s' class_dev->name='%s'",
-                           dev->subsystem, class_dev->name);
-                       if (strcmp_pattern(dev->subsystem, udev->subsystem) != 0) {
-                               dbg(FIELD_SUBSYSTEM " is not matching");
-                               goto try_parent;
-                       } else {
-                               dbg(FIELD_SUBSYSTEM " matches");
-                       }
+       if (dev->subsystem[0] != '\0') {
+               dbg("check for " FIELD_SUBSYSTEM " dev->subsystem='%s' class_dev->name='%s'",
+                   dev->subsystem, class_dev->name);
+               if (strcmp_pattern(dev->subsystem, udev->subsystem) != 0) {
+                       dbg(FIELD_SUBSYSTEM " is not matching");
+                       goto exit;
                }
+               dbg(FIELD_SUBSYSTEM " matches");
+       }
 
+       /* walk up the chain of physical devices and find a match */
+       while (1) {
                /* check for matching driver */
                if (dev->driver[0] != '\0') {
+                       if (sysfs_device == NULL) {
+                               dbg("device has no sysfs_device");
+                               goto try_parent;
+                       }
                        dbg("check for " FIELD_DRIVER " dev->driver='%s' sysfs_device->driver_name='%s'",
                            dev->driver, sysfs_device->driver_name);
                        if (strcmp_pattern(dev->driver, sysfs_device->driver_name) != 0) {
                                dbg(FIELD_DRIVER " is not matching");
                                goto try_parent;
-                       } else {
-                               dbg(FIELD_DRIVER " matches");
                        }
+                       dbg(FIELD_DRIVER " matches");
                }
 
-               /* check for matching bus id */
-               if (dev->id[0] != '\0') {
-                       dbg("check " FIELD_ID);
-                       if (match_id(dev, class_dev, sysfs_device) != 0) {
-                               dbg(FIELD_ID " is not matching");
+               /* check for matching bus value */
+               if (dev->bus[0] != '\0') {
+                       if (sysfs_device == NULL) {
+                               dbg("device has no sysfs_device");
                                goto try_parent;
-                       } else {
-                               dbg(FIELD_ID " matches");
                        }
+                       dbg("check for " FIELD_BUS " dev->bus='%s' sysfs_device->bus='%s'",
+                           dev->bus, sysfs_device->bus);
+                       if (strcmp_pattern(dev->bus, sysfs_device->bus) != 0) {
+                               dbg(FIELD_BUS " is not matching");
+                               goto try_parent;
+                       }
+                       dbg(FIELD_BUS " matches");
                }
 
-               /* check for matching place of device */
-               if (dev->place[0] != '\0') {
-                       dbg("check " FIELD_PLACE);
-                       if (match_place(dev, class_dev, sysfs_device) != 0) {
-                               dbg(FIELD_PLACE " is not matching");
+               /* check for matching bus id */
+               if (dev->id[0] != '\0') {
+                       if (sysfs_device == NULL) {
+                               dbg("device has no sysfs_device");
+                               goto try_parent;
+                       }
+                       dbg("check " FIELD_ID);
+                       if (match_id(dev, sysfs_device) != 0) {
+                               dbg(FIELD_ID " is not matching");
                                goto try_parent;
-                       } else {
-                               dbg(FIELD_PLACE " matches");
                        }
+                       dbg(FIELD_ID " matches");
                }
 
                /* check for matching sysfs pairs */
@@ -663,49 +606,51 @@ static int match_rule(struct udevice *udev, struct config_device *dev,
                        if (match_sysfs_pairs(dev, class_dev, sysfs_device) != 0) {
                                dbg(FIELD_SYSFS " is not matching");
                                goto try_parent;
-                       } else {
-                               dbg(FIELD_SYSFS " matches");
-                       }
-               }
-
-               /* execute external program */
-               if (dev->program[0] != '\0') {
-                       char program[PROGRAM_SIZE];
-
-                       dbg("check " FIELD_PROGRAM);
-                       strfieldcpy(program, dev->program);
-                       apply_format(udev, program, sizeof(program), class_dev, sysfs_device);
-                       if (execute_program(udev, program, udev->program_result, NAME_SIZE) != 0) {
-                               dbg(FIELD_PROGRAM " returned nonzero");
-                               goto try_parent;
-                       } else {
-                               dbg(FIELD_PROGRAM " returned successful");
                        }
+                       dbg(FIELD_SYSFS " matches");
                }
 
-               /* check for matching result of external program */
-               if (dev->result[0] != '\0') {
-                       dbg("check for " FIELD_RESULT " dev->result='%s', udev->program_result='%s'",
-                           dev->result, udev->program_result);
-                       if (strcmp_pattern(dev->result, udev->program_result) != 0) {
-                               dbg(FIELD_RESULT " is not matching");
-                               goto try_parent;
-                       } else {
-                               dbg(FIELD_RESULT " matches");
-                       }
-               }
-
-               /* Yeah, we matched! */
-               return 0;
-
+               /* found matching physical device  */
+               break;
 try_parent:
                dbg("try parent sysfs device");
                sysfs_device = sysfs_get_device_parent(sysfs_device);
                if (sysfs_device == NULL)
-                       return -ENODEV;
+                       goto exit;
                dbg("sysfs_device->path='%s'", sysfs_device->path);
                dbg("sysfs_device->bus_id='%s'", sysfs_device->bus_id);
        }
+
+       /* execute external program */
+       if (dev->program[0] != '\0') {
+               char program[PATH_SIZE];
+
+               dbg("check " FIELD_PROGRAM);
+               strlcpy(program, dev->program, sizeof(program));
+               apply_format(udev, program, sizeof(program), class_dev, sysfs_device);
+               if (execute_program(udev, program, udev->program_result, sizeof(udev->program_result)) != 0) {
+                       dbg(FIELD_PROGRAM " returned nonzero");
+                       goto try_parent;
+               }
+               dbg(FIELD_PROGRAM " returned successful");
+       }
+
+       /* check for matching result of external program */
+       if (dev->result[0] != '\0') {
+               dbg("check for " FIELD_RESULT " dev->result='%s', udev->program_result='%s'",
+                   dev->result, udev->program_result);
+               if (strcmp_pattern(dev->result, udev->program_result) != 0) {
+                       dbg(FIELD_RESULT " is not matching");
+                       goto try_parent;
+               }
+               dbg(FIELD_RESULT " matches");
+       }
+
+       /* rule matches */
+       return 0;
+
+exit:
+       return -1;
 }
 
 int namedev_name_device(struct udevice *udev, struct sysfs_class_device *class_dev)
@@ -713,7 +658,6 @@ int namedev_name_device(struct udevice *udev, struct sysfs_class_device *class_d
        struct sysfs_class_device *class_dev_parent;
        struct sysfs_device *sysfs_device = NULL;
        struct config_device *dev;
-       char *pos;
 
        dbg("class_dev->name='%s'", class_dev->name);
 
@@ -733,32 +677,31 @@ int namedev_name_device(struct udevice *udev, struct sysfs_class_device *class_d
        if (sysfs_device) {
                dbg("found devices device: path='%s', bus_id='%s', bus='%s'",
                    sysfs_device->path, sysfs_device->bus_id, sysfs_device->bus);
-               strfieldcpy(udev->bus_id, sysfs_device->bus_id);
+               strlcpy(udev->bus_id, sysfs_device->bus_id, sizeof(udev->bus_id));
        }
 
-       strfieldcpy(udev->kernel_name, class_dev->name);
-       fix_kernel_name(udev);
-       dbg("udev->kernel_name = '%s'", udev->kernel_name);
-
-       /* get kernel number */
-       pos = class_dev->name + strlen(class_dev->name);
-       while (isdigit(*(pos-1)))
-               pos--;
-       strfieldcpy(udev->kernel_number, pos);
-       dbg("kernel_number='%s'", udev->kernel_number);
+       dbg("udev->kernel_name='%s'", udev->kernel_name);
 
        /* look for a matching rule to apply */
        list_for_each_entry(dev, &config_device_list, node) {
                dbg("process rule");
                if (match_rule(udev, dev, class_dev, sysfs_device) == 0) {
 
-                       /* empty name, symlink and perms will not create any node */
-                       if (dev->name[0] == '\0' && dev->symlink[0] == '\0' &&
-                           dev->mode == 0000 && dev->owner[0] == '\0' && dev->group[0] == '\0') {
+                       /* apply options */
+                       if (dev->ignore_device) {
                                info("configured rule in '%s[%i]' applied, '%s' is ignored",
                                     dev->config_file, dev->config_line, udev->kernel_name);
                                return -1;
                        }
+                       if (dev->ignore_remove) {
+                               udev->ignore_remove = 1;
+                               dbg_parse("remove event should be ignored");
+                       }
+                       /* apply all_partitions option only at a main block device */
+                       if (dev->partitions && udev->type == BLOCK && udev->kernel_number[0] == '\0') {
+                               udev->partitions = dev->partitions;
+                               dbg("creation of partition nodes requested");
+                       }
 
                        /* apply permissions */
                        if (dev->mode != 0000) {
@@ -766,63 +709,65 @@ int namedev_name_device(struct udevice *udev, struct sysfs_class_device *class_d
                                dbg("applied mode=%#o to '%s'", udev->mode, udev->kernel_name);
                        }
                        if (dev->owner[0] != '\0') {
-                               strfieldcpy(udev->owner, dev->owner);
+                               strlcpy(udev->owner, dev->owner, sizeof(udev->owner));
                                apply_format(udev, udev->owner, sizeof(udev->owner), class_dev, sysfs_device);
                                dbg("applied owner='%s' to '%s'", udev->owner, udev->kernel_name);
                        }
                        if (dev->group[0] != '\0') {
-                               strfieldcpy(udev->group, dev->group);
+                               strlcpy(udev->group, dev->group, sizeof(udev->group));
                                apply_format(udev, udev->group, sizeof(udev->group), class_dev, sysfs_device);
                                dbg("applied group='%s' to '%s'", udev->group, udev->kernel_name);
                        }
 
-                       /* collect symlinks for this or the final matching rule */
+                       /* collect symlinks */
                        if (dev->symlink[0] != '\0') {
-                               char temp[NAME_SIZE];
+                               char temp[PATH_SIZE];
+                               char *pos, *next;
 
                                info("configured rule in '%s[%i]' applied, added symlink '%s'",
                                     dev->config_file, dev->config_line, dev->symlink);
-                               strfieldcpy(temp, dev->symlink);
+                               strlcpy(temp, dev->symlink, sizeof(temp));
                                apply_format(udev, temp, sizeof(temp), class_dev, sysfs_device);
-                               if (udev->symlink[0] != '\0')
-                                       strfieldcat(udev->symlink, " ");
-                               strfieldcat(udev->symlink, temp);
+
+                               /* add multiple symlinks separated by spaces */
+                               pos = temp;
+                               next = strchr(temp, ' ');
+                               while (next) {
+                                       next[0] = '\0';
+                                       dbg("add symlink '%s'", pos);
+                                       name_list_add(&udev->symlink_list, pos, 0);
+                                       pos = &next[1];
+                                       next = strchr(pos, ' ');
+                               }
+                               dbg("add symlink '%s'", pos);
+                               name_list_add(&udev->symlink_list, pos, 0);
                        }
 
                        /* rule matches */
                        if (dev->name[0] != '\0') {
-                               /* apply all_partitions flag only at a main block device */
-                               if (dev->partitions > 0 &&
-                                   (udev->type != 'b' || udev->kernel_number[0] != '\0'))
-                                       continue;
-
                                info("configured rule in '%s[%i]' applied, '%s' becomes '%s'",
                                     dev->config_file, dev->config_line, udev->kernel_name, dev->name);
 
-                               strfieldcpy(udev->name, dev->name);
+                               strlcpy(udev->name, dev->name, sizeof(udev->name));
                                apply_format(udev, udev->name, sizeof(udev->name), class_dev, sysfs_device);
-                               strfieldcpy(udev->config_file, dev->config_file);
+                               strlcpy(udev->config_file, dev->config_file, sizeof(udev->config_file));
                                udev->config_line = dev->config_line;
-                               udev->ignore_remove = dev->ignore_remove;
-
-                               if (udev->type == 'n')
-                                       goto exit;
-
-                               udev->partitions = dev->partitions;
 
-                               dbg("name, '%s' is going to have owner='%s', group='%s', mode=%#o partitions=%i",
-                                   udev->name, udev->owner, udev->group, udev->mode, udev->partitions);
+                               if (udev->type != NET)
+                                       dbg("name, '%s' is going to have owner='%s', group='%s', mode=%#o partitions=%i",
+                                           udev->name, udev->owner, udev->group, udev->mode, udev->partitions);
 
-                               goto exit;
+                               break;
                        }
                }
        }
 
-       /* no rule matched, so we use the kernel name */
-       strfieldcpy(udev->name, udev->kernel_name);
-       dbg("no rule found, use kernel name '%s'", udev->name);
+       if (udev->name[0] == '\0') {
+               /* no rule matched, so we use the kernel name */
+               strlcpy(udev->name, udev->kernel_name, sizeof(udev->name));
+               dbg("no rule found, use kernel name '%s'", udev->name);
+       }
 
-exit:
        if (udev->tmp_node[0] != '\0') {
                dbg("removing temporary device node");
                unlink_secure(udev->tmp_node);