chiark / gitweb /
[PATCH] fix permission handling logic
[elogind.git] / namedev.c
index a81721a9cf4378cd45f2517e8701ebde98f211f7..4e0476c6e3823335e60886c314205d815481c7d6 100644 (file)
--- a/namedev.c
+++ b/namedev.c
 #include "klibc_fixups.h"
 
 LIST_HEAD(config_device_list);
+LIST_HEAD(perm_device_list);
 
-/* s2 may end with '*' to match everything */
-static int strncmp_wildcard(char *s1, char *s2, int max)
+/* compare string with pattern (supports * ? [0-9] [!A-Z]) */
+static int strcmp_pattern(const char *p, const char *s)
 {
-       int len = strlen(s2);
-       if (len > max)
-               len = max;
-       if (s2[len-1] == '*')
-               len--;
-       else
-               len = max;
-       return strncmp(s1, s2, len);
+       if (*s == '\0') {
+               while (*p == '*')
+                       p++;
+               return (*p != '\0');
+       }
+       switch (*p) {
+       case '[':
+               {
+                       int not = 0;
+                       p++;
+                       if (*p == '!') {
+                               not = 1;
+                               p++;
+                       }
+                       while (*p && (*p != ']')) {
+                               int match = 0;
+                               if (p[1] == '-') {
+                                       if ((*s >= *p) && (*s <= p[2]))
+                                               match = 1;
+                                       p += 3;
+                               } else {
+                                       match = (*p == *s);
+                                       p++;
+                               }
+                               if (match ^ not) {
+                                       while (*p && (*p != ']'))
+                                               p++;
+                                       return strcmp_pattern(p+1, s+1);
+                               }
+                       }
+               }
+               break;
+       case '*':
+               if (strcmp_pattern(p, s+1))
+                       return strcmp_pattern(p+1, s);
+               return 0;
+       case '\0':
+               if (*s == '\0') {
+                       return 0;
+               }
+               break;
+       default:
+               if ((*p == *s) || (*p == '?'))
+                       return strcmp_pattern(p+1, s+1);
+               break;
+       }
+       return 1;
 }
 
 #define copy_var(a, b, var)            \
@@ -69,12 +109,11 @@ int add_config_dev(struct config_device *new_dev)
        /* update the values if we already have the device */
        list_for_each(tmp, &config_device_list) {
                struct config_device *dev = list_entry(tmp, struct config_device, node);
-               if (strncmp_wildcard(dev->name, new_dev->name, sizeof(dev->name)))
+               if (strcmp_pattern(new_dev->name, dev->name))
                        continue;
                if (strncmp(dev->bus, new_dev->bus, sizeof(dev->name)))
                        continue;
                copy_var(dev, new_dev, type);
-               copy_var(dev, new_dev, mode);
                copy_string(dev, new_dev, bus);
                copy_string(dev, new_dev, sysfs_file);
                copy_string(dev, new_dev, sysfs_value);
@@ -82,8 +121,6 @@ int add_config_dev(struct config_device *new_dev)
                copy_string(dev, new_dev, place);
                copy_string(dev, new_dev, kernel_name);
                copy_string(dev, new_dev, exec_program);
-               copy_string(dev, new_dev, owner);
-               copy_string(dev, new_dev, group);
                return 0;
        }
 
@@ -97,10 +134,54 @@ int add_config_dev(struct config_device *new_dev)
        return 0;
 }
 
+int add_perm_dev(struct perm_device *new_dev)
+{
+       struct list_head *tmp;
+       struct perm_device *tmp_dev;
+
+       /* update the values if we already have the device */
+       list_for_each(tmp, &perm_device_list) {
+               struct perm_device *dev = list_entry(tmp, struct perm_device, node);
+               if (strcmp_pattern(new_dev->name, dev->name))
+                       continue;
+               copy_var(dev, new_dev, mode);
+               copy_string(dev, new_dev, owner);
+               copy_string(dev, new_dev, group);
+               return 0;
+       }
+
+       /* not found, add new structure to the perm list */
+       tmp_dev = malloc(sizeof(*tmp_dev));
+       if (!tmp_dev)
+               return -ENOMEM;
+       memcpy(tmp_dev, new_dev, sizeof(*tmp_dev));
+       list_add_tail(&tmp_dev->node, &perm_device_list);
+       //dump_perm_dev(tmp_dev);
+       return 0;
+}
+
+static struct perm_device *find_perm(char *name)
+{
+       struct list_head *tmp;
+       struct perm_device *perm = NULL;
+
+       list_for_each(tmp, &perm_device_list) {
+               perm = list_entry(tmp, struct perm_device, node);
+               if (strcmp_pattern(perm->name, name))
+                       continue;
+               return perm;
+       }
+       return NULL;
+}
+
 static mode_t get_default_mode(struct sysfs_class_device *class_dev)
 {
-       /* just default everyone to rw for the world! */
-       return 0666;
+       mode_t mode = 0600;     /* default to owner rw only */
+
+       if (strlen(default_mode_str) != 0) {
+               mode = strtol(default_mode_str, NULL, 8);
+       }
+       return mode;
 }
 
 static void build_kernel_number(struct sysfs_class_device *class_dev, struct udevice *udev)
@@ -282,18 +363,11 @@ static int do_callout(struct sysfs_class_device *class_dev, struct udevice *udev
                apply_format(udev, dev->exec_program);
                if (exec_callout(dev, udev->callout_value, NAME_SIZE))
                        continue;
-               if (strncmp_wildcard(udev->callout_value, dev->id, NAME_SIZE) != 0)
+               if (strcmp_pattern(dev->id, udev->callout_value) != 0)
                        continue;
                strfieldcpy(udev->name, dev->name);
-               if (dev->mode != 0) {
-                       udev->mode = dev->mode;
-                       strfieldcpy(udev->owner, dev->owner);
-                       strfieldcpy(udev->group, dev->group);
-               }
-               dbg("callout returned matching value '%s', '%s' becomes '%s'"
-                   " - owner='%s', group='%s', mode=%#o",
-                   dev->id, class_dev->name, udev->name,
-                   dev->owner, dev->group, dev->mode);
+               dbg("callout returned matching value '%s', '%s' becomes '%s'",
+                   dev->id, class_dev->name, udev->name);
                return 0;
        }
        return -ENODEV;
@@ -339,15 +413,8 @@ label_found:
                        continue;
 
                strfieldcpy(udev->name, dev->name);
-               if (dev->mode != 0) {
-                       udev->mode = dev->mode;
-                       strfieldcpy(udev->owner, dev->owner);
-                       strfieldcpy(udev->group, dev->group);
-               }
-               dbg("found matching attribute '%s', '%s' becomes '%s' "
-                         "- owner='%s', group='%s', mode=%#o",
-                         dev->sysfs_file, class_dev->name, udev->name,
-                         dev->owner, dev->group, dev->mode);
+               dbg("found matching attribute '%s', '%s' becomes '%s' ",
+                   dev->sysfs_file, class_dev->name, udev->name);
 
                return 0;
        }
@@ -391,15 +458,8 @@ static int do_number(struct sysfs_class_device *class_dev, struct udevice *udev,
                if (!found)
                        continue;
                strfieldcpy(udev->name, dev->name);
-               if (dev->mode != 0) {
-                       udev->mode = dev->mode;
-                       strfieldcpy(udev->owner, dev->owner);
-                       strfieldcpy(udev->group, dev->group);
-               }
-               dbg("found matching id '%s', '%s' becomes '%s'"
-                   " - owner='%s', group ='%s', mode=%#o",
-                   dev->id, class_dev->name, udev->name,
-                   dev->owner, dev->group, dev->mode);
+               dbg("found matching id '%s', '%s' becomes '%s'",
+                   dev->id, class_dev->name, udev->name);
                return 0;
        }
        return -ENODEV;
@@ -443,15 +503,8 @@ static int do_topology(struct sysfs_class_device *class_dev, struct udevice *ude
                        continue;
 
                strfieldcpy(udev->name, dev->name);
-               if (dev->mode != 0) {
-                       udev->mode = dev->mode;
-                       strfieldcpy(udev->owner, dev->owner);
-                       strfieldcpy(udev->group, dev->group);
-               }
-               dbg("found matching place '%s', '%s' becomes '%s'"
-                   " - owner='%s', group ='%s', mode=%#o",
-                   dev->place, class_dev->name, udev->name,
-                   dev->owner, dev->group, dev->mode);
+               dbg("found matching place '%s', '%s' becomes '%s'",
+                   dev->place, class_dev->name, udev->name);
                return 0;
        }
        return -ENODEV;
@@ -468,19 +521,11 @@ static int do_replace(struct sysfs_class_device *class_dev, struct udevice *udev
                        continue;
 
                dbg("compare name '%s' with '%s'", dev->kernel_name, class_dev->name);
-               if (strncmp_wildcard(class_dev->name, dev->kernel_name, NAME_SIZE) != 0)
+               if (strcmp_pattern(dev->kernel_name, class_dev->name) != 0)
                        continue;
 
                strfieldcpy(udev->name, dev->name);
-               if (dev->mode != 0) {
-                       udev->mode = dev->mode;
-                       strfieldcpy(udev->owner, dev->owner);
-                       strfieldcpy(udev->group, dev->group);
-               }
-               dbg("found name, '%s' becomes '%s'"
-                   " - owner='%s', group='%s', mode = %#o",
-                   dev->kernel_name, udev->name,
-                   dev->owner, dev->group, dev->mode);
+               dbg("found name, '%s' becomes '%s'", dev->kernel_name, udev->name);
                
                return 0;
        }
@@ -489,24 +534,8 @@ static int do_replace(struct sysfs_class_device *class_dev, struct udevice *udev
 
 static void do_kernelname(struct sysfs_class_device *class_dev, struct udevice *udev)
 {
-       struct config_device *dev;
-       struct list_head *tmp;
-       int len;
-
+       /* heh, this is pretty simple... */
        strfieldcpy(udev->name, class_dev->name);
-       /* look for permissions */
-       list_for_each(tmp, &config_device_list) {
-               dev = list_entry(tmp, struct config_device, node);
-               len = strlen(dev->name);
-               if (strncmp_wildcard(class_dev->name, dev->name, sizeof(dev->name)))
-                       continue;
-               if (dev->mode != 0) {
-                       dbg("found permissions for '%s'", class_dev->name);
-                       udev->mode = dev->mode;
-                       strfieldcpy(udev->owner, dev->owner);
-                       strfieldcpy(udev->group, dev->group);
-               }
-       }
 }
 
 int namedev_name_device(struct sysfs_class_device *class_dev, struct udevice *udev)
@@ -515,6 +544,7 @@ int namedev_name_device(struct sysfs_class_device *class_dev, struct udevice *ud
        struct sysfs_class_device *class_dev_parent = NULL;
        int retval = 0;
        char *temp = NULL;
+       struct perm_device *perm;
 
        udev->mode = 0;
 
@@ -589,12 +619,19 @@ found:
        apply_format(udev, udev->name);
 
 done:
-       /* mode was never set above */
-       if (!udev->mode) {
+       perm = find_perm(udev->name);
+       if (perm) {
+               udev->mode = perm->mode;
+               strfieldcpy(udev->owner, perm->owner);
+               strfieldcpy(udev->group, perm->group);
+       } else {
+               /* no matching perms found :( */
                udev->mode = get_default_mode(class_dev);
                udev->owner[0] = 0x00;
                udev->group[0] = 0x00;
        }
+       dbg("name, '%s' is going to have owner='%s', group='%s', mode = %#o",
+           udev->name, udev->owner, udev->group, udev->mode);
 
        if (class_dev_parent)
                sysfs_close_class_device(class_dev_parent);
@@ -615,5 +652,6 @@ int namedev_init(void)
                return retval;
 
        dump_config_dev_list();
+       dump_perm_dev_list();
        return retval;
 }