chiark / gitweb /
rework merging/loading logic
[elogind.git] / load-fragment.c
index 64e66f314ef44e576114cb9bccb5bffe82867ccd..c0972d04fb6010a6f803933f6197bea2188dcf91 100644 (file)
@@ -56,7 +56,7 @@ static int config_parse_deps(
         assert(lvalue);
         assert(rvalue);
 
-        FOREACH_WORD(w, &l, rvalue, state) {
+        FOREACH_WORD(w, l, rvalue, state) {
                 char *t;
                 int r;
 
@@ -92,39 +92,18 @@ static int config_parse_names(
         assert(rvalue);
         assert(data);
 
-        FOREACH_WORD(w, &l, rvalue, state) {
+        FOREACH_WORD(w, l, rvalue, state) {
                 char *t;
                 int r;
-                Unit *other;
 
                 if (!(t = strndup(w, l)))
                         return -ENOMEM;
 
-                other = manager_get_unit(u->meta.manager, t);
-
-                if (other) {
-
-                        if (other != u) {
-
-                                if (other->meta.load_state != UNIT_STUB) {
-                                        free(t);
-                                        return -EEXIST;
-                                }
-
-                                if ((r = unit_merge(u, other)) < 0) {
-                                        free(t);
-                                        return r;
-                                }
-                        }
-
-                } else {
-                        if ((r = unit_add_name(u, t)) < 0) {
-                                free(t);
-                                return r;
-                        }
-                }
-
+                r = unit_merge_by_name(u, t);
                 free(t);
+
+                if (r < 0)
+                        return r;
         }
 
         return 0;
@@ -328,7 +307,7 @@ static int config_parse_exec(
                 void *data,
                 void *userdata) {
 
-        ExecCommand **e = data, *ee, *nce = NULL;
+        ExecCommand **e = data, *nce = NULL;
         char **n;
         char *w;
         unsigned k;
@@ -367,12 +346,7 @@ static int config_parse_exec(
         if (!(nce->path = strdup(n[0])))
                 goto fail;
 
-        if (*e) {
-                /* It's kinda important that we keep the order here */
-                LIST_FIND_TAIL(ExecCommand, command, *e, ee);
-                LIST_INSERT_AFTER(ExecCommand, command, *e, ee, nce);
-        } else
-                *e = nce;
+        exec_command_append_list(e, nce);
 
         return 0;
 
@@ -751,7 +725,7 @@ static int config_parse_cpu_affinity(
         assert(rvalue);
         assert(data);
 
-        FOREACH_WORD(w, &l, rvalue, state) {
+        FOREACH_WORD(w, l, rvalue, state) {
                 char *t;
                 int r;
                 unsigned cpu;
@@ -826,7 +800,7 @@ static int config_parse_secure_bits(
         assert(rvalue);
         assert(data);
 
-        FOREACH_WORD(w, &l, rvalue, state) {
+        FOREACH_WORD(w, l, rvalue, state) {
                 if (first_word(w, "keep-caps"))
                         c->secure_bits |= SECURE_KEEP_CAPS;
                 else if (first_word(w, "keep-caps-locked"))
@@ -867,7 +841,7 @@ static int config_parse_bounding_set(
         assert(rvalue);
         assert(data);
 
-        FOREACH_WORD(w, &l, rvalue, state) {
+        FOREACH_WORD(w, l, rvalue, state) {
                 char *t;
                 int r;
                 cap_value_t cap;
@@ -948,6 +922,63 @@ static int config_parse_limit(
         return 0;
 }
 
+static int config_parse_cgroup(
+                const char *filename,
+                unsigned line,
+                const char *section,
+                const char *lvalue,
+                const char *rvalue,
+                void *data,
+                void *userdata) {
+
+        Unit *u = userdata;
+        char *w;
+        size_t l;
+        char *state;
+
+        FOREACH_WORD(w, l, rvalue, state) {
+                char *t;
+                int r;
+
+                if (!(t = strndup(w, l)))
+                        return -ENOMEM;
+
+                r = unit_add_cgroup_from_text(u, t);
+                free(t);
+
+                if (r < 0)
+                        return r;
+        }
+
+        return 0;
+}
+
+static int config_parse_sysv_priority(
+                const char *filename,
+                unsigned line,
+                const char *section,
+                const char *lvalue,
+                const char *rvalue,
+                void *data,
+                void *userdata) {
+
+        int *priority = data;
+        int r, i;
+
+        assert(filename);
+        assert(lvalue);
+        assert(rvalue);
+        assert(data);
+
+        if ((r = safe_atoi(rvalue, &i)) < 0 || i < 0) {
+                log_error("[%s:%u] Failed to parse SysV start priority: %s", filename, line, rvalue);
+                return r;
+        }
+
+        *priority = (int) i;
+        return 0;
+}
+
 #define FOLLOW_MAX 8
 
 static int open_follow(char **filename, FILE **_f, Set *names, char **_id) {
@@ -1018,7 +1049,48 @@ static int open_follow(char **filename, FILE **_f, Set *names, char **_id) {
         return 0;
 }
 
-static int load_from_path(Unit *u, const char *path) {
+static int merge_by_names(Unit **u, Set *names, const char *id) {
+        char *k;
+        int r;
+
+        assert(u);
+        assert(*u);
+        assert(names);
+
+        /* Let's try to add in all symlink names we found */
+        while ((k = set_steal_first(names))) {
+
+                /* First try to merge in the other name into our
+                 * unit */
+                if ((r = unit_merge_by_name(*u, k)) < 0) {
+                        Unit *other;
+
+                        /* Hmm, we couldn't merge the other unit into
+                         * ours? Then let's try it the other way
+                         * round */
+
+                        other = manager_get_unit((*u)->meta.manager, k);
+                        free(k);
+
+                        if (other)
+                                if ((r = unit_merge(other, *u)) >= 0) {
+                                        *u = other;
+                                        return merge_by_names(u, names, NULL);
+                                }
+
+                        return r;
+                }
+
+                if (id == k)
+                        unit_choose_id(*u, id);
+
+                free(k);
+        }
+
+        return 0;
+}
+
+static int load_from_path(Unit *u, const char *path, UnitLoadState *new_state) {
 
         static const char* const section_table[_UNIT_TYPE_MAX] = {
                 [UNIT_SERVICE]   = "Service",
@@ -1072,7 +1144,8 @@ static int load_from_path(Unit *u, const char *path) {
                 { "LimitNICE",              config_parse_limit,           &(context).rlimit[RLIMIT_NICE],                  section   }, \
                 { "LimitRTPRIO",            config_parse_limit,           &(context).rlimit[RLIMIT_RTPRIO],                section   }, \
                 { "LimitRTTIME",            config_parse_limit,           &(context).rlimit[RLIMIT_RTTIME],                section   }, \
-                { "NonBlocking",            config_parse_bool,            &(context).non_blocking,                         section   }
+                { "NonBlocking",            config_parse_bool,            &(context).non_blocking,                         section   }, \
+                { "ControlGroup",           config_parse_cgroup,          u,                                               section   }  \
 
         const ConfigItem items[] = {
                 { "Names",                  config_parse_names,           u,                                               "Meta"    },
@@ -1099,6 +1172,10 @@ static int load_from_path(Unit *u, const char *path) {
                 { "TimeoutSec",             config_parse_usec,            &u->service.timeout_usec,                        "Service" },
                 { "Type",                   config_parse_service_type,    &u->service,                                     "Service" },
                 { "Restart",                config_parse_service_restart, &u->service,                                     "Service" },
+                { "PermissionsStartOnly",   config_parse_bool,            &u->service.permissions_start_only,              "Service" },
+                { "RootDirectoryStartOnly", config_parse_bool,            &u->service.root_directory_start_only,           "Service" },
+                { "ValidNoProcess",         config_parse_bool,            &u->service.valid_no_process,                    "Service" },
+                { "SysVStartPriority",      config_parse_sysv_priority,   &u->service.sysv_start_priority,                 "Service" },
                 EXEC_CONTEXT_CONFIG_ITEMS(u->service.exec_context, "Service"),
 
                 { "ListenStream",           config_parse_listen,          &u->socket,                                      "Socket"  },
@@ -1127,8 +1204,12 @@ static int load_from_path(Unit *u, const char *path) {
         char *k;
         int r;
         Set *symlink_names;
-        FILE *f;
-        char *filename = NULL, *id;
+        FILE *f = NULL;
+        char *filename = NULL, *id = NULL;
+        Unit *merged;
+
+        assert(u);
+        assert(new_state);
 
         sections[0] = "Meta";
         sections[1] = section_table[u->meta.type];
@@ -1186,81 +1267,79 @@ static int load_from_path(Unit *u, const char *path) {
         }
 
         if (!filename) {
-                r = 0; /* returning 0 means: no suitable config file found */
+                r = 0;
                 goto finish;
         }
 
-        /* Now, parse the file contents */
-        r = config_parse(filename, f, sections, items, u);
-        if (r < 0)
+        merged = u;
+        if ((r = merge_by_names(&merged, symlink_names, id)) < 0)
                 goto finish;
 
-        /* Let's try to add in all symlink names we found */
-        while ((k = set_steal_first(symlink_names))) {
-                if ((r = unit_add_name(u, k)) < 0)
-                        goto finish;
-
-
-                if (id == k)
-                        unit_choose_id(u, id);
-                free(k);
+        if (merged != u) {
+                *new_state = UNIT_MERGED;
+                r = 0;
+                goto finish;
         }
 
+        /* Now, parse the file contents */
+        if ((r = config_parse(filename, f, sections, items, u)) < 0)
+                goto finish;
 
-        free(u->meta.load_path);
-        u->meta.load_path = filename;
+        free(u->meta.fragment_path);
+        u->meta.fragment_path = filename;
         filename = NULL;
 
-        r = 1; /* returning 1 means: suitable config file found and loaded */
+        *new_state = UNIT_LOADED;
+        r = 0;
 
 finish:
         while ((k = set_steal_first(symlink_names)))
                 free(k);
+
         set_free(symlink_names);
         free(filename);
 
+        if (f)
+                fclose(f);
+
         return r;
 }
 
-int unit_load_fragment(Unit *u) {
-        int r = 0;
-        ExecContext *c;
+int unit_load_fragment(Unit *u, UnitLoadState *new_state) {
+        int r;
 
         assert(u);
-        assert(u->meta.load_state == UNIT_STUB);
+        assert(new_state);
+        assert(*new_state == UNIT_STUB);
+
+        if (u->meta.fragment_path) {
 
-        if (u->meta.load_path)
-                r = load_from_path(u, u->meta.load_path);
-        else {
+                if ((r = load_from_path(u, u->meta.fragment_path, new_state)) < 0)
+                        return r;
+
+        } else {
                 Iterator i;
-                char *t;
+                const char *t;
 
-                /* Try to find a name we can load this with */
-                SET_FOREACH(t, u->meta.names, i)
-                        if ((r = load_from_path(u, t)) != 0)
+                /* Try to find the unit under its id */
+                if ((t = unit_id(u)))
+                        if ((r = load_from_path(u, t, new_state)) < 0)
                                 return r;
-        }
 
-        if (u->meta.type == UNIT_SOCKET)
-                c = &u->socket.exec_context;
-        else if (u->meta.type == UNIT_SERVICE)
-                c = &u->service.exec_context;
-        else
-                c = NULL;
+                /* Try to find an alias we can load this with */
+                if (*new_state == UNIT_STUB)
+                        SET_FOREACH(t, u->meta.names, i) {
 
-        if (r >= 0 && c &&
-            (c->output == EXEC_OUTPUT_KERNEL || c->output == EXEC_OUTPUT_SYSLOG)) {
-                int k;
+                                if (unit_id(u) == t)
+                                        continue;
 
-                /* If syslog or kernel logging is requested, make sure
-                 * our own logging daemon is run first. */
-
-                if ((k = unit_add_dependency_by_name(u, UNIT_AFTER, SPECIAL_LOGGER_SOCKET)) < 0)
-                        return k;
+                                if ((r = load_from_path(u, t, new_state)) < 0)
+                                        return r;
 
-                if ((k = unit_add_dependency_by_name(u, UNIT_REQUIRES, SPECIAL_LOGGER_SOCKET)) < 0)
-                        return k;
+                                if (*new_state != UNIT_STUB)
+                                        break;
+                        }
         }
 
-        return r;
+        return 0;
 }