while (1) -> for (;;)

[elogind.git] / libudev / libudev-util-private.c

diff --git a/libudev/libudev-util-private.c b/libudev/libudev-util-private.c
index 3641b3630f8e4ef1fef56c905937cbb3daf043d7..7d28b23b389e6d3c6fc11dba6d75678a5760ba79 100644 (file)
--- a/libudev/libudev-util-private.c
+++ b/libudev/libudev-util-private.c
@@ -30,35 +30,44 @@ int util_create_path(struct udev *udev, const char *path)
        char p[UTIL_PATH_SIZE];
        char *pos;
        struct stat stats;
-       int ret;
+       int err;
 
        util_strscpy(p, sizeof(p), path);
        pos = strrchr(p, '/');
-       if (pos == p || pos == NULL)
+       if (pos == NULL)
                return 0;
-
-       while (pos[-1] == '/')
+       while (pos != p && pos[-1] == '/')
                pos--;
+       if (pos == p)
+               return 0;
        pos[0] = '\0';
 
        dbg(udev, "stat '%s'\n", p);
-       if (stat(p, &stats) == 0 && (stats.st_mode & S_IFMT) == S_IFDIR)
-               return 0;
+       if (stat(p, &stats) == 0) {
+               if ((stats.st_mode & S_IFMT) == S_IFDIR)
+                       return 0;
+               else
+                       return -ENOTDIR;
+       }
 
-       if (util_create_path(udev, p) != 0)
-               return -1;
+       err = util_create_path(udev, p);
+       if (err != 0)
+               return err;
 
        dbg(udev, "mkdir '%s'\n", p);
        udev_selinux_setfscreatecon(udev, p, S_IFDIR|0755);
-       ret = mkdir(p, 0755);
+       err = mkdir(p, 0755);
+       if (err != 0) {
+               err = -errno;
+               if (err == -EEXIST && stat(p, &stats) == 0) {
+                       if ((stats.st_mode & S_IFMT) == S_IFDIR)
+                               err = 0;
+                       else
+                               err = -ENOTDIR;
+               }
+       }
        udev_selinux_resetfscreatecon(udev);
-       if (ret == 0)
-               return 0;
-
-       if (errno == EEXIST)
-               if (stat(p, &stats) == 0 && (stats.st_mode & S_IFMT) == S_IFDIR)
-                       return 0;
-       return -1;
+       return err;
 }
 
 int util_delete_path(struct udev *udev, const char *path)
@@ -67,12 +76,15 @@ int util_delete_path(struct udev *udev, const char *path)
        char *pos;
        int retval;
 
-       strcpy (p, path);
+       if (path[0] == '/')
+               while(path[1] == '/')
+                       path++;
+       util_strscpy(p, sizeof(p), path);
        pos = strrchr(p, '/');
        if (pos == p || pos == NULL)
                return 0;
 
-       while (1) {
+       for (;;) {
                *pos = '\0';
                pos = strrchr(p, '/');
 
@@ -100,24 +112,16 @@ int util_delete_path(struct udev *udev, const char *path)
  */
 int util_unlink_secure(struct udev *udev, const char *filename)
 {
-       int retval;
-
-       retval = chown(filename, 0, 0);
-       if (retval)
-               err(udev, "chown(%s, 0, 0) failed: %m\n", filename);
-
-       retval = chmod(filename, 0000);
-       if (retval)
-               err(udev, "chmod(%s, 0000) failed: %m\n", filename);
+       int err;
 
-       retval = unlink(filename);
+       chown(filename, 0, 0);
+       chmod(filename, 0000);
+       err = unlink(filename);
        if (errno == ENOENT)
-               retval = 0;
-
-       if (retval)
+               err = 0;
+       if (err)
                err(udev, "unlink(%s) failed: %m\n", filename);
-
-       return retval;
+       return err;
 }
 
 uid_t util_lookup_user(struct udev *udev, const char *user)
@@ -135,8 +139,7 @@ uid_t util_lookup_user(struct udev *udev, const char *user)
        if (endptr[0] == '\0')
                return uid;
 
-       errno = 0;
-       getpwnam_r(user, &pwbuf, buf, buflen, &pw);
+       errno = getpwnam_r(user, &pwbuf, buf, buflen, &pw);
        if (pw != NULL)
                return pw->pw_uid;
        if (errno == 0 || errno == ENOENT || errno == ESRCH)
@@ -149,7 +152,7 @@ uid_t util_lookup_user(struct udev *udev, const char *user)
 gid_t util_lookup_group(struct udev *udev, const char *group)
 {
        char *endptr;
-       int buflen;
+       int buflen = sysconf(_SC_GETGR_R_SIZE_MAX);
        char *buf;
        struct group grbuf;
        struct group *gr;
@@ -160,28 +163,26 @@ gid_t util_lookup_group(struct udev *udev, const char *group)
        gid = strtoul(group, &endptr, 10);
        if (endptr[0] == '\0')
                return gid;
-
-       buflen = sysconf(_SC_GETGR_R_SIZE_MAX);
-       if (buflen < 0)
-               buflen = 1000;
        buf = NULL;
        gid = 0;
        for (;;) {
-               buf = realloc(buf, buflen);
-               if (!buf)
+               char *newbuf;
+
+               newbuf = realloc(buf, buflen);
+               if (!newbuf)
                        break;
-               errno = 0;
-               getgrnam_r(group, &grbuf, buf, buflen, &gr);
-               if (gr != NULL)
+               buf = newbuf;
+               errno = getgrnam_r(group, &grbuf, buf, buflen, &gr);
+               if (gr != NULL) {
                        gid = gr->gr_gid;
-               else if (errno == ERANGE) {
+               } else if (errno == ERANGE) {
                        buflen *= 2;
                        continue;
-               }
-               else if (errno == 0 || errno == ENOENT || errno == ESRCH)
+               } else if (errno == 0 || errno == ENOENT || errno == ESRCH) {
                        err(udev, "specified group '%s' unknown\n", group);
-               else
+               } else {
                        err(udev, "error resolving group '%s': %m\n", group);
+               }
                break;
        }
        free(buf);
@@ -252,7 +253,8 @@ int util_resolve_subsys_kernel(struct udev *udev, const char *string,
 }
 
 int util_run_program(struct udev *udev, const char *command, char **envp,
-                    char *result, size_t ressize, size_t *reslen)
+                    char *result, size_t ressize, size_t *reslen,
+                    const sigset_t *sigmask, bool reset_prio)
 {
        int status;
        int outpipe[2] = {-1, -1};
@@ -260,7 +262,7 @@ int util_run_program(struct udev *udev, const char *command, char **envp,
        pid_t pid;
        char arg[UTIL_PATH_SIZE];
        char program[UTIL_PATH_SIZE];
-       char *argv[(sizeof(arg) / 2) + 1];
+       char *argv[((sizeof(arg) + 1) / 2) + 1];
        int devnull;
        int i;
        int err = 0;
@@ -278,10 +280,14 @@ int util_run_program(struct udev *udev, const char *command, char **envp,
                                /* do not separate quotes */
                                pos++;
                                argv[i] = strsep(&pos, "\'");
-                               while (pos != NULL && pos[0] == ' ')
-                                       pos++;
+                               if (pos != NULL)
+                                       while (pos[0] == ' ')
+                                               pos++;
                        } else {
                                argv[i] = strsep(&pos, " ");
+                               if (pos != NULL)
+                                       while (pos[0] == ' ')
+                                               pos++;
                        }
                        dbg(udev, "arg[%i] '%s'\n", i, argv[i]);
                        i++;
@@ -340,6 +346,12 @@ int util_run_program(struct udev *udev, const char *command, char **envp,
                        dup2(errpipe[WRITE_END], STDERR_FILENO);
                        close(errpipe[WRITE_END]);
                }
+
+               if (sigmask)
+                       sigprocmask(SIG_SETMASK, sigmask, NULL);
+               if (reset_prio)
+                       setpriority(PRIO_PROCESS, 0, 0);
+
                execve(argv[0], argv, envp);
                if (errno == ENOENT || errno == ENOTDIR) {
                        /* may be on a filesystem which is not mounted right now */