libudev: allow to store negative values in the udev database

[elogind.git] / libudev / libudev-device-private.c

diff --git a/libudev/libudev-device-private.c b/libudev/libudev-device-private.c
index 68dc0a5b986c2a45a6c8a829aa9ddfbfed110925..66f0328eb3e7c2d158e42c4fe484cdabe2adba61 100644 (file)
--- a/libudev/libudev-device-private.c
+++ b/libudev/libudev-device-private.c
@@ -21,16 +21,6 @@
 #include "libudev.h"
 #include "libudev-private.h"
 
-static size_t devpath_to_db_path(struct udev *udev, const char *devpath, char *filename, size_t len)
-{
-       char *s;
-       size_t l;
-
-       s = filename;
-       l = util_strpcpyl(&s, len, udev_get_dev_path(udev), "/.udev/db/", NULL);
-       return util_path_encode(devpath, s, l);
-}
-
 int udev_device_update_db(struct udev_device *udev_device)
 {
        struct udev *udev = udev_device_get_udev(udev_device);
@@ -43,8 +33,8 @@ int udev_device_update_db(struct udev_device *udev_device)
        struct udev_list_entry *list_entry;
        int ret;
 
-       devpath_to_db_path(udev, udev_device_get_devpath(udev_device), filename, sizeof(filename));
-       util_create_path(udev, filename);
+       util_strscpyl(filename, sizeof(filename), udev_get_dev_path(udev), "/.udev/db/",
+                     udev_device_get_subsystem(udev_device), ":", udev_device_get_sysname(udev_device), NULL);
        unlink(filename);
 
        udev_list_entry_foreach(list_entry, udev_device_get_properties_list_entry(udev_device))
@@ -78,11 +68,13 @@ int udev_device_update_db(struct udev_device *udev_device)
        }
        info(udev, "create db link (%s)\n", target);
        udev_selinux_setfscreatecon(udev, filename, S_IFLNK);
+       util_create_path(udev, filename);
        ret = symlink(target, filename);
        udev_selinux_resetfscreatecon(udev);
        if (ret == 0)
                goto out;
 file:
+       util_create_path(udev, filename);
        f = fopen(filename, "w");
        if (f == NULL) {
                err(udev, "unable to create db file '%s': %m\n", filename);
@@ -96,15 +88,15 @@ file:
                        fprintf(f, "S:%s\n", &udev_list_entry_get_name(list_entry)[devlen]);
        }
        if (udev_device_get_devlink_priority(udev_device) != 0)
-               fprintf(f, "L:%u\n", udev_device_get_devlink_priority(udev_device));
+               fprintf(f, "L:%i\n", udev_device_get_devlink_priority(udev_device));
        if (udev_device_get_event_timeout(udev_device) >= 0)
-               fprintf(f, "T:%u\n", udev_device_get_event_timeout(udev_device));
+               fprintf(f, "T:%i\n", udev_device_get_event_timeout(udev_device));
        if (udev_device_get_num_fake_partitions(udev_device) != 0)
-               fprintf(f, "A:%u\n", udev_device_get_num_fake_partitions(udev_device));
+               fprintf(f, "A:%i\n", udev_device_get_num_fake_partitions(udev_device));
        if (udev_device_get_ignore_remove(udev_device))
-               fprintf(f, "R:%u\n", udev_device_get_ignore_remove(udev_device));
+               fprintf(f, "R:%i\n", udev_device_get_ignore_remove(udev_device));
        if (udev_device_get_watch_handle(udev_device) >= 0)
-               fprintf(f, "W:%u\n", udev_device_get_watch_handle(udev_device));
+               fprintf(f, "W:%i\n", udev_device_get_watch_handle(udev_device));
        udev_list_entry_foreach(list_entry, udev_device_get_properties_list_entry(udev_device)) {
                if (!udev_list_entry_get_flag(list_entry))
                        continue;
@@ -122,18 +114,21 @@ int udev_device_delete_db(struct udev_device *udev_device)
        struct udev *udev = udev_device_get_udev(udev_device);
        char filename[UTIL_PATH_SIZE];
 
-       devpath_to_db_path(udev, udev_device_get_devpath(udev_device), filename, sizeof(filename));
+       util_strscpyl(filename, sizeof(filename), udev_get_dev_path(udev), "/.udev/db/",
+                     udev_device_get_subsystem(udev_device), ":", udev_device_get_sysname(udev_device), NULL);
        unlink(filename);
        return 0;
 }
 
-int udev_device_rename_db(struct udev_device *udev_device, const char *devpath_old)
+int udev_device_rename_db(struct udev_device *udev_device)
 {
        struct udev *udev = udev_device_get_udev(udev_device);
        char filename_old[UTIL_PATH_SIZE];
        char filename[UTIL_PATH_SIZE];
 
-       devpath_to_db_path(udev, devpath_old, filename_old, sizeof(filename_old));
-       devpath_to_db_path(udev, udev_device_get_devpath(udev_device), filename, sizeof(filename));
+       util_strscpyl(filename_old, sizeof(filename_old), udev_get_dev_path(udev), "/.udev/db/",
+                     udev_device_get_subsystem(udev_device), ":", udev_device_get_sysname_old(udev_device), NULL);
+       util_strscpyl(filename, sizeof(filename), udev_get_dev_path(udev), "/.udev/db/",
+                     udev_device_get_subsystem(udev_device), ":", udev_device_get_sysname(udev_device), NULL);
        return rename(filename_old, filename);
 }