From 831a6e07cc5599fdd616dc1eddbabb6d6b5a87a9 Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Wed, 20 Jun 2018 18:30:50 +0100 Subject: [PATCH] dgit build: Better message when network is offline. When build fails because the archive access fails, mention that this was tried because --since-version was not specified. Closes:#883340. Signed-off-by: Ian Jackson --- debian/changelog | 5 +++++ dgit | 22 +++++++++++++++------- 2 files changed, 20 insertions(+), 7 deletions(-) diff --git a/debian/changelog b/debian/changelog index 4be989d8..68ec24e7 100644 --- a/debian/changelog +++ b/debian/changelog @@ -2,6 +2,11 @@ dgit (5.2~) unstable; urgency=medium * dgit(1): Mention under `dgit build' that it uses the network. + dgit: + * When build fails because the network is offline, mention + that this is because --since-version was not specified. + Closes:#883340. + -- dgit (5.1) unstable; urgency=medium diff --git a/dgit b/dgit index 2cf78ec7..9084eaf2 100755 --- a/dgit +++ b/dgit @@ -6018,13 +6018,21 @@ sub changesopts_initial () { sub changesopts_version () { if (!defined $changes_since_version) { - my @vsns = archive_query('archive_query'); - my @quirk = access_quirk(); - if ($quirk[0] eq 'backports') { - local $isuite = $quirk[2]; - local $csuite; - canonicalise_suite(); - push @vsns, archive_query('archive_query'); + my @vsns; + unless (eval { + @vsns = archive_query('archive_query'); + my @quirk = access_quirk(); + if ($quirk[0] eq 'backports') { + local $isuite = $quirk[2]; + local $csuite; + canonicalise_suite(); + push @vsns, archive_query('archive_query'); + } + 1; + }) { + print STDERR $@; + fail + "archive query failed (queried because --since-version not specified)"; } if (@vsns) { @vsns = map { $_->[0] } @vsns; -- 2.30.2