From 4455e483399bb622093aac0ff1cbb93795669859 Mon Sep 17 00:00:00 2001
From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Thu, 6 Mar 2014 00:46:48 +0000
Subject: [PATCH] dgit-repos-server: some better error msgs, more tests

---
 dgit-repos-server            |  6 +++---
 tests/tests/drs-push-rejects | 14 ++++++++++++++
 2 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/dgit-repos-server b/dgit-repos-server
index add54245..49fa795d 100755
--- a/dgit-repos-server
+++ b/dgit-repos-server
@@ -464,9 +464,9 @@ sub tagh1 ($) {
 sub checks () {
     debug "checks";
     checksuite();
-    tagh1('type') eq 'commit' or die;
-    tagh1('object') eq $commit or die;
-    tagh1('tag') eq $tagname or die;
+    tagh1('type') eq 'commit' or reject "tag refers to wrong kind of object";
+    tagh1('object') eq $commit or reject "tag refers to wrong commit";
+    tagh1('tag') eq $tagname or reject "tag name in tag is wrong";
 
     my $v = $version;
     $v =~ y/~:/_%/;
diff --git a/tests/tests/drs-push-rejects b/tests/tests/drs-push-rejects
index fa3b5304..aa092bc8 100755
--- a/tests/tests/drs-push-rejects
+++ b/tests/tests/drs-push-rejects
@@ -97,7 +97,17 @@ cp $tmp/dm.gpg $tmp/dd.gpg
 mustfail 'key not found in keyrings' $push_spec
 
 prep unstable sid
+mktag HEAD~
+mustfail 'tag refers to wrong commit' $push_spec
+
+prep unstable sid
+mktag HEAD~:
+mustfail 'tag refers to wrong kind of object' $push_spec
+
+prep unstable sid
+mktag
 mustsucceed $push_spec # succeeds
+
 mktag
 mustfail 'not replacing previously-pushed version' $push_spec
 
@@ -113,6 +123,10 @@ prep_dm_mangle () {
 git checkout v2
 version=3-2_dummy2
 
+prep_dm_mangle ''
+perl -i.bak -ne 'print if 1..s/(pari-extra).*\n/$1/' $tmp/dm.txt
+mustfail '' $push_spec # malformed (truncated) dm.txt; don't care about msg
+
 prep_dm_mangle 's/allow:/asponge:/i'
 mustfail 'missing Allow section in permission' $push_spec
 
-- 
2.30.2