From 343532497ca085d0ed5a56982953cb4edcd151bc Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Sat, 11 Aug 2018 18:55:04 +0100 Subject: [PATCH] git-debrebase: merge: Defeat evals which might try to trap merge_failed That would be dangerous because we're in the wrong directory and other things may be wrong. For example, if we continue we might overwrite wreckage with other wreckage. Signed-off-by: Ian Jackson --- git-debrebase | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/git-debrebase b/git-debrebase index 21372802..c3bd7ff2 100755 --- a/git-debrebase +++ b/git-debrebase @@ -396,8 +396,12 @@ sub merge_failed ($$) { push @m, "Wreckage left in $wrecknoteprefix/*."; push @m, "See git-debrebase(1) section FAILED MERGES for suggestions."; - # ^ xxx this section does not yet exist - fail join '', map { "$_\n" } @m; + + # use finish rather than fail, in case we are within an eval + # (that can happen inside walk!) + print STDERR "\n"; + print STDERR "$us: $_\n" foreach @m; + finish 15; } sub mwrecknote ($$$) { -- 2.30.2