From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Sun, 31 Jul 2016 18:02:32 +0000 (+0100)
Subject: Split brain: TODOs
X-Git-Tag: archive/debian/2.0~220
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=dgit.git;a=commitdiff_plain;h=5a25026a936fed50c4ad1dd06b5fc57f3fe9c2c0

Split brain: TODOs

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/TODO.BRANCH b/TODO.BRANCH
index 74514768..b526d213 100644
--- a/TODO.BRANCH
+++ b/TODO.BRANCH
@@ -13,6 +13,15 @@ Tag rename unfinished business
 
  - other tag should be [dgit Maintainer-Tag quilt=$quilt-mode]
 
+ - in dopush (?), we need to sort out synthetic fast forard
+    this should not depend entirely on quilt mode
+    but will always be needed if quiltmode_splitbrain
+
+ - there is some confusion between $split_brain (did we actually
+   generate any commits) and quiltmode_splitbrain (might we have done,
+   including in previous pushes); search for $split_brain and check
+   that use sites are correct
+
 
 Want tests for
  - start repo with old tag, push with new tag, run
diff --git a/dgit b/dgit
index 288fc78d..53ccd724 100755
--- a/dgit
+++ b/dgit
@@ -2148,8 +2148,6 @@ END
 	}
     }
 
-    die 'xxx fast forward (should not depend on quilt mode, but will always be needed if we did $split_brain)' if $split_brain;
-
     check_not_dirty();
     changedir $ud;
     progress "checking that $dscfn corresponds to HEAD";
diff --git a/tests/tests/quilt-gbp b/tests/tests/quilt-gbp
index d3624e9e..da27d144 100755
--- a/tests/tests/quilt-gbp
+++ b/tests/tests/quilt-gbp
@@ -30,7 +30,8 @@ exit 0
 want to
 
  do push
- t-pushed-good
+ t-pushed-good XXX need to do something more subtle than check our branch is in repo now
+
  check that
    - we didn't update caller's branch
 
@@ -44,3 +45,8 @@ want to
   - has patches applied (reuse rules build magic)
   - has .gitignore edited
 
+make a new change
+
+push it
+
+check that the synthetic fast forward worked