X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=dgit.git;a=blobdiff_plain;f=infra%2Fdgit-repos-policy-debian;h=4ba3e8e144432071193092f6fd61223d265f01ff;hp=db15310314234c90bc67f39f44b4504f258f2d15;hb=f94881cfca1e725248ffed399f46b7c9128dc8e8;hpb=379f4be6fc6ce15641bd7412dce3e71ca11ece00 diff --git a/infra/dgit-repos-policy-debian b/infra/dgit-repos-policy-debian index db153103..4ba3e8e1 100755 --- a/infra/dgit-repos-policy-debian +++ b/infra/dgit-repos-policy-debian @@ -4,17 +4,11 @@ # usages: # dgit-repos-policy-debian DISTRO DGIT-REPOS-DIR ACTION... # ie. -# dgit-repos-policy-debian ... check-list -# dgit-repos-policy-debian ... check-package PACKAGE +# dgit-repos-policy-debian ... check-list [...] +# dgit-repos-policy-debian ... check-package PACKAGE [...] # dgit-repos-policy-debian ... push PACKAGE \ # VERSION SUITE TAGNAME DELIBERATELIES [...] # -# exit status is bitmap; bit weights (values) as follows -# 1 failure; operation must be rejected; other bits will be ignored -# 2 suppress dgit-repos-server's ff check ("push" only) -# 4 blow away repo away right away (ie before push or fetch) -# ("check-package" only) -# # cwd for push is a temporary repo where the to-be-pushed objects have # been received; TAGNAME is the version-based tag # @@ -24,13 +18,22 @@ use strict; use POSIX; use JSON; +use File::Temp; -use Debian::Dgit; +use Debian::Dgit qw(:DEFAULT :policyflags); our $distro = shift @ARGV // die "need DISTRO"; our $repos = shift @ARGV // die "need DGIT-REPOS-DIR"; our $action = shift @ARGV // die "need ACTION"; -our $pkg = shift @ARGV; + +our $publicmode = 02775; +our $policydb = "dbi:SQLite:$repos/policy"; +our $new_upload_propagation_slop = 3600*4 + 100; + +our $poldbh; +our $pkg; +our $pkgdir; +our ($pkg_exists,$pkg_secret); # We assume that it is not possible for NEW to have a version older # than sid. @@ -60,6 +63,51 @@ our $pkg = shift @ARGV; # # [1] looking for the relevant git tag for the version number and not # caring what that tag refers to. +# +# A wrinkle: if we approved a push recently, we treat NEW as having +# a version which is in our history. This is because the package may +# still be being uploaded. (We record this using the timestamp of the +# package's git repo directory.) + + +sub poldb_setup () { + $poldbh = DBI->connect($policydb,'','', { + RaiseError=>1, PrintError=>1, AutoCommit=>0 + }); + $poldbh->do("PRAGMA foreign_keys = ON"); + + $poldbh->do(<do(<do(<commit; +} sub apiquery ($) { my ($subpath) = @_; @@ -69,8 +117,9 @@ sub apiquery ($) { return decode_json $json; } -sub new_has_vsn_in_our_history () { - my $in_new = apiquery "/dsc_in_suite/new/$pkg"; +sub specific_suite_has_vsn_in_our_history ($) { + my ($suite) = @_; + my $in_new = apiquery "/dsc_in_suite/$suite/$pkg"; foreach my $entry (@$in_new) { my $vsn = $entry->{version}; die "$pkg ?" unless defined $vsn; @@ -83,29 +132,130 @@ sub new_has_vsn_in_our_history () { return 0; } -sub selectpackage () { - die if $pkg =~ m#^-#; +sub new_has_vsn_in_our_history () { + stat $pkgdir or die "$pkgdir $!"; + my $mtime = ((stat _)[9]); + my $age = time - $mtime; + return 1 if $age < $new_upload_propagation_slop; + return specific_suite_has_vsn_in_our_history('new'); +} + +sub good_suite_has_vsn_in_our_history () { + my $suites = apiquery "/suites"; + foreach my $suitei (@$suites) { + my $suite = $suitei->{name}; + die unless defined $suite; + next if $suite =~ m/\bnew$/; + return 1 if specific_suite_has_vsn_in_our_history($suite); + } + return 0; +} + +sub getpackage () { + die unless @ARGV > 1; + $pkg = shift @ARGV; die if $pkg =~ m#[^-+.0-9a-z]#; + die unless $pkg =~ m#^[^-]#; - if (!chdir "$repos/$pkg") { - die "$pkg $!" unless $!==ENOENT; - # something + $pkgdir = "$repos/$pkg"; + if (!stat $pkgdir) { + die "$pkgdir $!" unless $!==ENOENT; + $pkg_exists = 0; } - stat "." or die $!; - if (~(stat _)[2] & 05) { - # secret history + $pkg_exists = 1; + $pkg_secret = !!(~(stat _)[2] & 05); +} + +sub add_taint ($$) { + my ($gitobjid, $gitobjtype, $reason) = @_; + + my $tf = new File::Temp or die $!; + print $tf "$gitobjid\n" or die $!; + + my $gcfpid = open GCF, "-|"; + defined $gcfpid or die $!; + if (!$gcfpid) { + open STDIN, "<&", $tf or die $!; + exec 'git', 'cat-file'; + die $!; } - + + close $tf or die $!; + $_ = ; + m/^(\w+) (\w+) (\d+)\n/ or die "$objline ?"; + $1 eq $gitobjid or die "$! $gitobjid ?"; + $2 eq $gitobjtype or die "$! $gitobjtype ?"; + my $bytes = $3; + + my $gitobjdata; + $!=0; read GCF, $gitobjdata, $bytes == $bytes or die "$gitobjid $bytes $!"; + close GCF; + + $poldbh->do("INSERT INTO taints". + " (package, gitobjid, gitobjtype, gitobjdata, time, comment)", + " VALUES (?,?,?,?,?,?)", {}, + $pkg, $gitobjid, $gitobjtype, $gitobjdata, time, $reason); + + my $taint_id = $poldbh->last_insert_id(undef,undef,"taints","taint_id"); + die unless defined $taint_id; + + $poldbh->do("INSERT INTO taintoverrides". + " (taint_id, 'include-questionable-history')", + " VALUES (?)", {}, + $taint_id); } -if (defined $pkg) { - selectpackage; + +sub action__check_package () { + getpackage(); + return 0 unless $pkg_exists; + return 0 unless $pkg_secret; + + chdir $pkgdir or die "$pkgdir $!"; + return if new_has_vsn_in_our_history(); + + if (good_suite_has_vsn_in_our_history) { + chmod $publicmode, "." or die $!; + return 0; + } + + open TAGL, "git for-each-ref '[r]efs/tags/*' |" or die $!; + while () { + m#^(\w+) (\w+) (refs/tags/\S+)\s# or die "$_ ?"; + add_taint($1,$2, + "tag $3 referred to this object in git tree but all". + " previously pushed versions were found to have been". + " removed from NEW (ie, rejected) (or never arrived)"); + } + $?=0; $!=0; close TAGL or die "git for-each-ref $? $!"; + + return FRESHREPO; } sub action_push () { - + # we suppose that NEW has a version which is already in our + # history, as otherwise the repo would have been blown away + + getpackage(); + return 0 unless $pkg_exists; + return 0 unless $pkg_secret; + + xxx up to here } -my $fn = ${*::}{"action_$cmd"}; + + +if (defined $pkg) { + selectpackage; +} + +my $fn = ${*::}{"action__$cmd"}; $fn or die "unknown ACTION"; -$fn->(); + +poldb_setup(); + +my $rcode = $fn->(); +die unless defined $rcode; + +poldb_commit(); +exit $rcode;