X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=dgit.git;a=blobdiff_plain;f=dgit;h=909ac95f75ceaef2fd5c05a226416ce785d9d750;hp=c66c7a63a19162c86ccf71cc59513707d23e045e;hb=b0bc4d204e5900c7888e681404e2638ce7347cf9;hpb=71437159c44af0328fc4bbc1826be18e4f057444

diff --git a/dgit b/dgit
index c66c7a63..909ac95f 100755
--- a/dgit
+++ b/dgit
@@ -48,7 +48,7 @@ our $absurdity = undef; ###substituted###
 our @rpushprotovsn_support = qw(4 3 2); # 4 is new tag format
 our $protovsn;
 
-our $isuite = 'unstable';
+our $isuite;
 our $idistro;
 our $package;
 our @ropts;
@@ -78,6 +78,7 @@ our $patches_applied_dirtily = 00;
 our $tagformat_want;
 our $tagformat;
 our $tagformatfn;
+our $chase_dsc_distro=1;
 
 our %forceopts = map { $_=>0 }
     qw(unrepresentable unsupported-source-format
@@ -564,6 +565,8 @@ sub cmd_help () {
 our $td = $ENV{DGIT_TEST_DUMMY_DIR} || "DGIT_TEST_DUMMY_DIR-unset";
 
 our %defcfg = ('dgit.default.distro' => 'debian',
+	       'dgit.default.default-suite' => 'unstable',
+	       'dgit.default.old-dsc-distro' => 'debian',
 	       'dgit-suite.*-security.distro' => 'debian-security',
 	       'dgit.default.username' => '',
 	       'dgit.default.archive-query-default-component' => 'main',
@@ -572,6 +575,10 @@ our %defcfg = ('dgit.default.distro' => 'debian',
 	       'dgit.default.sshpsql-dbname' => 'service=projectb',
 	       'dgit.default.aptget-components' => 'main',
 	       'dgit.default.dgit-tag-format' => 'new,old,maint',
+	       'dgit.dsc-url-proto-ok.http'    => 'true',
+	       'dgit.dsc-url-proto-ok.https'   => 'true',
+	       'dgit.dsc-url-proto-ok.git'     => 'true',
+	       'dgit.default.dsc-url-proto-ok' => 'false',
 	       # old means "repo server accepts pushes with old dgit tags"
 	       # new means "repo server accepts pushes with new dgit tags"
 	       # maint means "repo server accepts split brain pushes"
@@ -659,6 +666,7 @@ sub git_get_config ($) {
     my ($c) = @_;
     foreach my $src (@gitcfgsources) {
 	my $l = $gitcfgs{$src}{$c};
+	croak "$l $c" if $l && !ref $l;
 	printdebug"C $c ".(defined $l ?
 			   join " ", map { messagequote "'$_'" } @$l :
 			   "undef")."\n"
@@ -674,6 +682,7 @@ sub git_get_config ($) {
 sub cfg {
     foreach my $c (@_) {
 	return undef if $c =~ /RETURN-UNDEF/;
+	printdebug "C? $c\n" if $debuglevel >= 5;
 	my $v = git_get_config($c);
 	return $v if defined $v;
 	my $dv = $defcfg{$c};
@@ -686,7 +695,7 @@ sub cfg {
 	"$us: distro or suite appears not to be (properly) supported";
 }
 
-sub access_basedistro () {
+sub access_basedistro__noalias () {
     if (defined $idistro) {
 	return $idistro;
     } else {	
@@ -706,6 +715,12 @@ sub access_basedistro () {
     }
 }
 
+sub access_basedistro () {
+    my $noalias = access_basedistro__noalias();
+    my $canon = cfg("dgit-distro.$noalias.alias-canon",'RETURN-UNDEF');
+    return $canon // $noalias;
+}
+
 sub access_nomdistro () {
     my $base = access_basedistro();
     my $r = cfg("dgit-distro.$base.nominal-distro",'RETURN-UNDEF') // $base;
@@ -2659,6 +2674,16 @@ END
 	}
 	last;
     }
+
+    if (defined $csuite) {
+	printdebug "git_lrfetch_sane: tidying any old suite lrfetchrefs\n";
+	git_for_each_ref("refs/dgit-fetch/$csuite", sub {
+	    my ($objid,$objtype,$lrefname,$reftail) = @_;
+	    next if $lrfetchrefs_f{$lrefname}; # $csuite eq $distro ?
+	    runcmd_ordryrun_local @git, qw(update-ref -d), $lrefname;
+	});
+    }
+
     printdebug "git_lrfetch_sane: git fetch --no-insane emulation complete\n",
 	Dumper(\%lrfetchrefs_f);
 }
@@ -2744,12 +2769,13 @@ sub parse_dsc_field ($$) {
     if (!defined $f) {
 	progress "$what: NO git hash";
     } elsif (($dsc_hash, $dsc_distro, $dsc_hint_tag, $dsc_hint_url)
-	     = $f =~ m/^(\w+) ($distro_re) ($versiontag_re) (\S+)(?:\s|$)/) {
+	     = $f =~ m/^(\w+)\s+($distro_re)\s+($versiontag_re)\s+(\S+)(?:\s|$)/) {
 	progress "$what: specified git info ($dsc_distro)";
 	$dsc_hint_tag = [ $dsc_hint_tag ];
     } elsif ($f =~ m/^\w+\s*$/) {
 	$dsc_hash = $&;
-	$dsc_distro //= 'debian';
+	$dsc_distro //= cfg qw(dgit.default.old-dsc-distro
+			       dgit.default.distro);
 	$dsc_hint_tag = [ debiantags +(getfield $dsc, 'Version'),
 			  $dsc_distro ];
 	progress "$what: specified git hash";
@@ -2763,16 +2789,90 @@ sub resolve_dsc_field_commit ($$) {
 
     return unless defined $dsc_hash;
 
-    my $rewritemapdata = git_cat_file $already_mapref.':map';
-    if (defined $rewritemapdata
-	&& $rewritemapdata =~ m/^$dsc_hash(?:[ \t](\w+))/m) {
-	progress "server's git history rewrite map contains a relevant entry!";
+    my $mapref =
+	defined $already_mapref &&
+	($already_distro eq $dsc_distro || !$chase_dsc_distro)
+	? $already_mapref : undef;
 
-	$dsc_hash = $1;
-	if (defined $dsc_hash) {
-	    progress "using rewritten git hash in place of .dsc value";
-	} else {
-	    progress "server data says .dsc hash is to be disregarded";
+    my $do_fetch;
+    $do_fetch = sub {
+	my ($what, @fetch) = @_;
+
+	local $idistro = $dsc_distro;
+	my $lrf = lrfetchrefs;
+
+	if (!$chase_dsc_distro) {
+	    progress
+		"not chasing .dsc distro $dsc_distro: not fetching $what";
+	    return 0;
+	}
+
+	progress
+	    ".dsc names distro $dsc_distro: fetching $what";
+
+	my $url = access_giturl();
+	if (!defined $url) {
+	    defined $dsc_hint_url or fail <<END;
+.dsc Dgit metadata is in context of distro $dsc_distro
+for which we have no configured url and .dsc provides no hint
+END
+	    my $proto =
+		$dsc_hint_url =~ m#^([-+0-9a-zA-Z]+):# ? $1 :
+		$dsc_hint_url =~ m#^/# ? 'file' : 'bad-syntax';
+	    parse_cfg_bool "dsc-url-proto-ok", 'false',
+		cfg("dgit.dsc-url-proto-ok.$proto",
+		    "dgit.default.dsc-url-proto-ok")
+		or fail <<END;
+.dsc Dgit metadata is in context of distro $dsc_distro
+for which we have no configured url;
+.dsc provices hinted url with protocol $proto which is unsafe.
+(can be overridden by config - consult documentation)
+END
+	    $url = $dsc_hint_url;
+	}
+
+	git_lrfetch_sane 1, @fetch;
+
+	return $lrf;
+    };
+
+    my $rewrite_enable = do {
+	local $idistro = $dsc_distro;
+	access_cfg('rewrite-map-enable', 'RETURN-UNDEF');
+    };
+
+    if (parse_cfg_bool 'rewrite-map-enable', 'true', $rewrite_enable) {
+	my $lrf = $do_fetch->("rewrite map", $rewritemap) or return;
+	$mapref = $lrf.'/'.$rewritemap;
+	my $rewritemapdata = git_cat_file $mapref.':map';
+	if (defined $rewritemapdata
+	    && $rewritemapdata =~ m/^$dsc_hash(?:[ \t](\w+))/m) {
+	    progress
+		"server's git history rewrite map contains a relevant entry!";
+
+	    $dsc_hash = $1;
+	    if (defined $dsc_hash) {
+		progress "using rewritten git hash in place of .dsc value";
+	    } else {
+		progress "server data says .dsc hash is to be disregarded";
+	    }
+	}
+    }
+
+    if (!defined git_cat_file $dsc_hash) {
+	my @tags = map { "tags/".$_ } @$dsc_hint_tag;
+	my $lrf = $do_fetch->("additional commits", @tags) &&
+	    defined git_cat_file $dsc_hash
+	    or fail <<END;
+.dsc Dgit metadata requires commit $dsc_hash
+but we could not obtain that object anywhere.
+END
+	foreach my $t (@tags) {
+	    my $fullrefname = $lrf.'/'.$t;
+	    print STDERR "CHK $t $fullrefname ".Dumper(\%lrfetchrefs_f);
+	    next unless $lrfetchrefs_f{$fullrefname};
+	    next unless is_fast_fwd "$fullrefname~0", $dsc_hash;
+	    lrfetchref_used $fullrefname;
 	}
     }
 }
@@ -4199,7 +4299,8 @@ sub fetchpullargs () {
 	$isuite = branchsuite();
 	if (!$isuite) {
 	    my $clogp = parsechangelog();
-	    $isuite = getfield $clogp, 'Distribution';
+	    my $clogsuite = getfield $clogp, 'Distribution';
+	    $isuite= $clogsuite if $clogsuite ne 'UNRELEASED';
 	}
     } elsif (@ARGV==1) {
 	($isuite) = @ARGV;
@@ -5948,11 +6049,16 @@ sub cmd_import_dsc {
 
     parse_dscdata();
 
-    parse_dsc_field($dsc, "Dgit metadata in .dsc");
+    $package = getfield $dsc, 'Source';
+
+    parse_dsc_field($dsc, "Dgit metadata in .dsc")
+	unless forceing [qw(import-dsc-with-dgit-field)];
 
-    if (defined $dsc_hash
-	&& !forceing [qw(import-dsc-with-dgit-field)]) {
+    if (defined $dsc_hash) {
 	progress "dgit: import-dsc of .dsc with Dgit field, using git hash";
+	resolve_dsc_field_commit undef, undef;
+    }
+    if (defined $dsc_hash) {
 	my @cmd = (qw(sh -ec),
 		   "echo $dsc_hash | git cat-file --batch-check");
 	my $objgot = cmdoutput @cmd;
@@ -5984,7 +6090,6 @@ Specify  +$specbranch to overwrite, discarding existing history
 END
 	if $oldhash && !$force;
 
-    $package = getfield $dsc, 'Source';
     my @dfi = dsc_files_info();
     foreach my $fi (@dfi) {
 	my $f = $fi->{Filename};
@@ -6053,18 +6158,28 @@ sub cmd_clone_dgit_repos_server {
     badusage "need destination argument" unless @ARGV==1;
     my ($destdir) = @ARGV;
     $package = '_dgit-repos-server';
+    local $access_forpush = 0;
     my @cmd = (@git, qw(clone), access_giturl(), $destdir);
     debugcmd ">",@cmd;
     exec @cmd or fail "exec git clone: $!\n";
 }
 
+sub cmd_print_dgit_repos_server_source_url {
+    badusage "no arguments allowed to dgit print-dgit-repos-server-source-url"
+	if @ARGV;
+    $package = '_dgit-repos-server';
+    local $access_forpush = 0;
+    my $url = access_giturl();
+    print $url, "\n" or die $!;
+}
+
 sub cmd_setup_mergechangelogs {
     badusage "no arguments allowed to dgit setup-mergechangelogs" if @ARGV;
     setup_mergechangelogs(1);
 }
 
 sub cmd_setup_useremail {
-    badusage "no arguments allowed to dgit setup-mergechangelogs" if @ARGV;
+    badusage "no arguments allowed to dgit setup-useremail" if @ARGV;
     setup_useremail(1);
 }
 
@@ -6190,6 +6305,9 @@ sub parseopts () {
 	    } elsif (m/^--no-rm-on-error$/s) {
 		push @ropts, $_;
 		$rmonerror = 0;
+	    } elsif (m/^--no-chase-dsc-distro$/s) {
+		push @ropts, $_;
+		$chase_dsc_distro = 0;
 	    } elsif (m/^--overwrite$/s) {
 		push @ropts, $_;
 		$overwrite_version = '';
@@ -6235,6 +6353,11 @@ sub parseopts () {
 		# undocumented, for testing
 		push @ropts, $_;
 		$need_split_build_invocation = 1;
+	    } elsif (m/^--config-lookup-explode=(.+)$/s) {
+		# undocumented, for testing
+		push @ropts, $_;
+		$gitcfgs{cmdline}{$1} = 'CONFIG-LOOKUP-EXPLODE';
+		# ^ it's supposed to be an array ref
 	    } elsif (m/^(--[-0-9a-z]+)(=|$)/ && ($oi = $valopts_long{$1})) {
 		$val = $2 ? $' : undef; #';
 		$valopt->($oi->{Long});
@@ -6324,6 +6447,10 @@ END
 
 
 sub parseopts_late_defaults () {
+    $isuite //= cfg("dgit-distro.$idistro.default-suite", 'RETURN-UNDEF')
+	if defined $idistro;
+    $isuite //= cfg('dgit.default.default-suite');
+
     foreach my $k (keys %opts_opt_map) {
 	my $om = $opts_opt_map{$k};