dgit-repos-server: some better error msgs, more tests

[dgit.git] / tests / tests / drs-push-rejects

diff --git a/tests/tests/drs-push-rejects b/tests/tests/drs-push-rejects
index 10c10bf60b402c70a0aad68686639ae8161ecbac..aa092bc81ee7eb73f05cc22a87af78f762d066a6 100755 (executable)
--- a/tests/tests/drs-push-rejects
+++ b/tests/tests/drs-push-rejects
@@ -10,58 +10,133 @@ t-worktree drs
 
 cd $p
 
+reporefs () {
+       (set -e
+       if test -d $tmp/git/$p.git; then
+               cd $tmp/git/$p.git
+               git show-ref
+       fi)
+}
+
 mustfail () {
        local wantmsg="$1"; shift
+       reporefs >$tmp/show-refs.pre-push
        set +e
        git push origin "$@" 2>&1 |tee $tmp/mustfail.txt
        ps="${PIPESTATUS[*]}"
        set -e
        case $ps in
-       "0 0")  fail "push unexpectedly succeeded: $*" ;;
+       "0 0")  fail "push unexpectedly succeeded (instead of: $wantmsg)" ;;
        *" 0")  ;;
        *)      fail "tee failed"  ;;
        esac
        if ! fgrep "$wantmsg" $tmp/mustfail.txt >/dev/null; then
                fail "error message not found"
        fi
+       reporefs >$tmp/show-refs.post-push
+       diff $tmp/show-refs.{pre,post}-push
+}
+
+mustsucceed () {
+       reporefs >$tmp/show-refs.pre-push
+       git push origin "$@"
+       reporefs >$tmp/show-refs.post-push
+       if diff $tmp/show-refs.{pre,post}-push >$tmp/show-refs.diff; then
+               fail "no refs updated"
+       fi
 }
 
-mktag1 () {
+prep () {
        local suite=$1
        local csuite=$2
+       cp $tmp/masters/* $tmp/.
        tag_signer='-u Senatus'
        tag_message="$p release $version for $suite ($csuite) [dgit]"
-       tag_name=debian/3-2_dummy1
+       tag_name=debian/$version
        push_spec1="HEAD:refs/dgit/$csuite"
        push_spec2="refs/tags/$tag_name"
        push_spec="$push_spec1 $push_spec2"
 }
-mktag2 () {
+mktag () {
        git tag -f $tag_signer -m "$tag_message" $tag_name "$@"
 }
 
+mkdir $tmp/masters
+cp $tmp/d[dm].* $tmp/masters
 
 version=3-2_dummy1
 
-mktag1 unstable sid
+prep unstable sid
 tag_signer='-a'
-mktag2
+mktag
 mustfail 'missing signature' $push_spec
 
-mktag1 unstable sid
+prep unstable sid
 tag_message='something'
-mktag2
+mktag
 mustfail 'tag message not in expected format' $push_spec
 
-mktag1 unstable sid
-mktag2
-
+prep unstable sid
+mktag
 mustfail 'sid != sponge' HEAD:refs/dgit/sponge $push_spec2
 
-git push origin $push_spec
+# fixme test --sig-policy-url string
+# fixme cannot test   reject "signature is not of type 00!";
+
+prep unstable sid
+mktag
+mustfail 'push is missing tag ref update' $push_spec1
+mustfail 'push is missing head ref update' $push_spec2
+mustfail 'pushing unexpected ref' $push_spec HEAD:refs/wombat
+mustfail 'pushing multiple heads' $push_spec HEAD:refs/dgit/wombat
+mustfail 'pushing multiple tags' $push_spec HEAD:refs/tags/debian/wombat
+
+prep unstable sid
+mktag
+cp $tmp/dm.gpg $tmp/dd.gpg
+mustfail 'key not found in keyrings' $push_spec
+
+prep unstable sid
+mktag HEAD~
+mustfail 'tag refers to wrong commit' $push_spec
 
-mktag2
+prep unstable sid
+mktag HEAD~:
+mustfail 'tag refers to wrong kind of object' $push_spec
 
+prep unstable sid
+mktag
+mustsucceed $push_spec # succeeds
+
+mktag
 mustfail 'not replacing previously-pushed version' $push_spec
 
+prep_dm_mangle () {
+       prep unstable sid
+       perl -i.bak -pe '
+               next unless m/^fingerprint: 3A82860837A0CD32/i../^$/;
+       ' -e "$1" $tmp/dm.txt
+       tag_signer='-u Populus'
+       mktag
+}
+
+git checkout v2
+version=3-2_dummy2
+
+prep_dm_mangle ''
+perl -i.bak -ne 'print if 1..s/(pari-extra).*\n/$1/' $tmp/dm.txt
+mustfail '' $push_spec # malformed (truncated) dm.txt; don't care about msg
+
+prep_dm_mangle 's/allow:/asponge:/i'
+mustfail 'missing Allow section in permission' $push_spec
+
+prep_dm_mangle 's/\bpari-extra\b/sponge/i'
+mustfail "package $p not allowed for key" $push_spec
+
+prep_dm_mangle 'y/0-9/5-90-4/ if m/^fingerprint:/i'
+mustfail "not in permissions list although in keyring" $push_spec
+
+prep_dm_mangle ''
+mustsucceed $push_spec # succeeds
+
 echo ok.