dgit-repos-server: do drs-error and recorderror, not just for reject

[dgit.git] / dgit-repos-server

diff --git a/dgit-repos-server b/dgit-repos-server
index 2cc650d03f61dca4f8633401bd3eb77929103898..6acd6894f0eae552b82dbb542761c712612a2f05 100755 (executable)
--- a/dgit-repos-server
+++ b/dgit-repos-server
@@ -149,9 +149,21 @@ sub mkrepotmp () {
     die $!;
 }
 
+sub recorderror ($) {
+    my ($why) = @_;
+    my $w = $ENV{'DGIT_DRS_WORK'}; # we are in stunthook
+    if (defined $w) {
+       open ERR, ">", "$w/drs-error" or die $!;
+       print ERR $why, "\n" or die $!;
+       close ERR or die $!;
+       return 1;
+    }
+    return 0;
+}
+
 sub reject ($) {
     my ($why) = @_;
-    debug " rejecting $why";
+    recorderror "reject: $why";
     die "dgit-repos-server: reject: $why\n";
 }
 
@@ -208,6 +220,16 @@ END
 sub maybeinstallprospective () {
     return if $destrepo eq $realdestrepo;
 
+    if (open REJ, "<", "$workrepo/drs-error") {
+       local $/ = undef;
+       my $msg = <REJ>;
+       REJ->error and die $!;
+       print STDERR $msg;
+       exit 1;
+    } else {
+       $!==&ENOENT or die $!;
+    }
+
     debug " show-ref ($destrepo) ...";
 
     my $child = open SR, "-|";
@@ -228,9 +250,11 @@ sub maybeinstallprospective () {
            die;
        die if $got{$wh}++;
     }
+    $!=0; $?=0; close SR or $?==256 or die "$? $!";
+
     debug "installprospective ?";
-    die if grep { !$_ } values %got;
-    $!=0; $?=0; close SR or die "$? $!";
+    die Dumper(\%got)." -- missing refs in new repo"
+       if grep { !$_ } values %got;
 
     debug "install $destrepo => $realdestrepo";
     rename $destrepo, $realdestrepo or die $!;
@@ -296,7 +320,7 @@ sub parsetag () {
        }
     }
     $!=0; $_=<T>; defined or die $!;
-    m/^($package_re) release (\S+) for (\S+) \[dgit\]$/ or
+    m/^($package_re) release (\S+) for \S+ \((\S+)\) \[dgit\]$/ or
        reject "tag message not in expected format";
 
     die unless $1 eq $package;
@@ -329,13 +353,16 @@ sub checksig_keyring ($) {
 
     debug " checksig keyring $keyringfile...";
 
-    open P, "-|", (qw(gpgv --status-fd=1 --keyring),
+    our @cmd = (qw(gpgv --status-fd=1 --keyring),
                   $keyringfile,
-                  qw(dgit-tmp/plaintext.asc dgit-tmp/plaintext))
+                  qw(dgit-tmp/plaintext.asc dgit-tmp/plaintext));
+    debugcmd @cmd;
+
+    open P, "-|", @cmd
        or die $!;
 
     while (<P>) {
-       next unless s/^\[GNUPG:\]: //;
+       next unless s/^\[GNUPG:\] //;
        chomp or die;
        debug " checksig| $_";
        my @l = split / /, $_;
@@ -410,7 +437,7 @@ sub verifytag () {
 }
 
 sub checksuite () {
-    debug "checksuite";
+    debug "checksuite ($suitesfile)";
     open SUITES, "<", $suitesfile or die $!;
     while (<SUITES>) {
        chomp;
@@ -499,6 +526,9 @@ sub argval () {
 sub parseargsdispatch () {
     die unless @ARGV;
 
+    delete $ENV{'GIT_DIR'}; # if not run via ssh, our parent git process
+    delete $ENV{'GIT_PREFIX'}; # sets these and they mess things up
+
     if ($ENV{'DGIT_DRS_DEBUG'}) {
        $debug='=';
        open DEBUG, ">&STDERR" or die $!;