From 626f869531a241dd8f187afb392a3151caf9a728 Mon Sep 17 00:00:00 2001 From: ian Date: Sun, 7 May 2000 22:11:41 +0000 Subject: [PATCH] - * bug_if_query_done feature for debugging (SHOULD BE TAKEN OUT FOR RELEASE) @@ -1,6 +1,4 @@ -uadns (0.8) BETA; urgency=medium - - * bug_if_query_done feature for debugging (SHOULD BE TAKEN OUT FOR RELEASE) +adns (0.8) BETA; urgency=medium Bugfixes: * Race near adns_beforeselect which could cause infinite timeout fixed --- changelog | 4 +--- src/event.c | 2 -- src/internal.h | 1 - src/query.c | 2 -- src/setup.c | 1 - 5 files changed, 1 insertion(+), 9 deletions(-) diff --git a/changelog b/changelog index ecc6ae2..1de9d36 100644 --- a/changelog +++ b/changelog @@ -1,6 +1,4 @@ -uadns (0.8) BETA; urgency=medium - - * bug_if_query_done feature for debugging (SHOULD BE TAKEN OUT FOR RELEASE) +adns (0.8) BETA; urgency=medium Bugfixes: * Race near adns_beforeselect which could cause infinite timeout fixed diff --git a/src/event.c b/src/event.c index bd53255..7e71a33 100644 --- a/src/event.c +++ b/src/event.c @@ -674,9 +674,7 @@ int adns_wait(adns_state ads, if (r != EAGAIN) break; maxfd= 0; tvp= 0; FD_ZERO(&readfds); FD_ZERO(&writefds); FD_ZERO(&exceptfds); - ads->bug_if_query_done_now= 1; adns_beforeselect(ads,&maxfd,&readfds,&writefds,&exceptfds,&tvp,&tvbuf,0); - ads->bug_if_query_done_now= 0; assert(tvp); rsel= select(maxfd,&readfds,&writefds,&exceptfds,tvp); if (rsel==-1) { diff --git a/src/internal.h b/src/internal.h index 719a592..c766738 100644 --- a/src/internal.h +++ b/src/internal.h @@ -282,7 +282,6 @@ struct adns__state { struct query_queue udpw, tcpw, childw, output; adns_query forallnext; int nextid, udpsocket, tcpsocket; - int bug_if_query_done_now; vbuf tcpsend, tcprecv; int nservers, nsortlist, nsearchlist, searchndots, tcpserver, tcprecv_skip; enum adns__tcpstate { diff --git a/src/query.c b/src/query.c index 1fa26f8..aaadb21 100644 --- a/src/query.c +++ b/src/query.c @@ -501,7 +501,6 @@ void adns__query_done(adns_query qu) { adns_answer *ans; adns_query parent; - assert(!qu->ads->bug_if_query_done_now); cancel_children(qu); qu->id= -1; @@ -543,7 +542,6 @@ void adns__query_done(adns_query qu) { } void adns__query_fail(adns_query qu, adns_status stat) { - assert(!qu->ads->bug_if_query_done_now); adns__reset_preserved(qu); qu->answer->status= stat; adns__query_done(qu); diff --git a/src/setup.c b/src/setup.c index 211f425..ac88c33 100644 --- a/src/setup.c +++ b/src/setup.c @@ -474,7 +474,6 @@ static int init_begin(adns_state *ads_r, adns_initflags flags, FILE *diagfile) { ads->forallnext= 0; ads->nextid= 0x311f; ads->udpsocket= ads->tcpsocket= -1; - ads->bug_if_query_done_now= 0; adns__vbuf_init(&ads->tcpsend); adns__vbuf_init(&ads->tcprecv); ads->tcprecv_skip= 0; -- 2.30.2