From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Thu, 8 Dec 2016 17:59:40 +0000 (+0000)
Subject: Control flow: Document restrictions on globalsystemfailure
X-Git-Tag: adns-1.5.2~12
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?p=adns.git;a=commitdiff_plain;h=51d963e7dbd34c579a242161ad1eecccd7fdc529

Control flow: Document restrictions on globalsystemfailure

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/src/event.c b/src/event.c
index 95386f4..81766c5 100644
--- a/src/event.c
+++ b/src/event.c
@@ -624,6 +624,9 @@ xit:
 /* General helpful functions. */
 
 void adns_globalsystemfailure(adns_state ads) {
+  /* Must not be called by adns during actual processing of a
+   * particular query, since it reenters adns.  Only safe to call in
+   * situations where it would be safe to call adns_returning. */
   adns__consistency(ads,0,cc_entex);
 
   for (;;) {