From a8ec149cd47fee125c1e64a9b7dcf33bd7eec0b1 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20Mart=C3=AD?= Date: Fri, 5 Jun 2015 17:04:05 +0200 Subject: [PATCH] lint: Improve UCM:Tags warning If the vercode is higher than CVC, then we're probably only following stable versions or something like that --- fdroidserver/lint.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py index ec4373dd..90c5221e 100644 --- a/fdroidserver/lint.py +++ b/fdroidserver/lint.py @@ -141,7 +141,8 @@ def main(): # Potentially incorrect UCM if (curbuild and curbuild['commit'] and app['Update Check Mode'] == 'RepoManifest' - and curbuild['commit'] != 'unknown - see disabled' + and not curbuild['commit'].startswith('unknown') + and curbuild['vercode'] == app['Current Version Code'] and any(s in curbuild['commit'] for s in '.,_-/')): pwarn("Last used commit '%s' looks like a tag, but Update Check Mode is '%s'" % ( curbuild['commit'], app['Update Check Mode'])) -- 2.30.2