From 96f49f2a9ecad4ae5d44f78d289f0befc3470e02 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20Mart=C3=AD?= Date: Mon, 25 Aug 2014 00:41:25 +0200 Subject: [PATCH] lint: Also warn about descriptions that are just the summary --- fdroidserver/lint.py | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/fdroidserver/lint.py b/fdroidserver/lint.py index 192da1a6..30a1807c 100644 --- a/fdroidserver/lint.py +++ b/fdroidserver/lint.py @@ -184,17 +184,15 @@ def main(): warn("Summary of length %s is over the %i char limit" % ( summ_chars, config['char_limits']['Summary'])) - # Redundant summaries - summary = app['Summary'] + # Redundant summaries or descriptions name = app['Name'] or app['Auto Name'] - if summary and name: - summary_l = summary.lower() - name_l = name.lower() - if summary_l == name_l: - warn("Summary '%s' is just the app's name" % summary) - elif (summary_l in name_l or name_l in summary_l): - pwarn("Summary '%s' probably contains redundant info already in app name '%s'" % ( - summary, name)) + if app['Summary'] and name: + if app['Summary'].lower() == name.lower(): + warn("Summary '%s' is just the app's name" % app['Summary']) + + if app['Summary'] and app['Description']: + if app['Summary'].lower() == app['Description'][0].lower(): + warn("Description '%s' is just the app's summary" % app['Summary']) # Description size limit desc_chars = sum(len(l) for l in app['Description']) -- 2.30.2