From 4b50a3d0048d13f6e37126f20f96e8bef262cbe2 Mon Sep 17 00:00:00 2001 From: Kay Sievers Date: Wed, 14 Mar 2012 01:01:16 +0100 Subject: [PATCH 1/1] extras: ata_id - do not log error if HDIO_GET_IDENTITY fails kay: is this a valid issue: https://bugs.archlinux.org/task/27060 ? tomegun: udev does not really care if that fails kay: the suggestion there is to treat EINVAL the same way we treat ENOTTY (i.e. as an info only) if it really does not matter it might make sense to avoid bogus bug reports tomegun: done --- src/ata_id/ata_id.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/ata_id/ata_id.c b/src/ata_id/ata_id.c index 257f49449..846a73b54 100644 --- a/src/ata_id/ata_id.c +++ b/src/ata_id/ata_id.c @@ -532,13 +532,8 @@ int main(int argc, char *argv[]) } else { /* If this fails, then try HDIO_GET_IDENTITY */ if (ioctl(fd, HDIO_GET_IDENTITY, &id) != 0) { - if (errno == ENOTTY) { - info(udev, "HDIO_GET_IDENTITY unsupported for '%s'\n", node); - rc = 2; - } else { - err(udev, "HDIO_GET_IDENTITY failed for '%s': %m\n", node); - rc = 3; - } + info(udev, "HDIO_GET_IDENTITY failed for '%s': %m\n", node); + rc = 2; goto close; } } -- 2.30.2