From 4483aba233fa4ea47ea1b1b28c9eb0664f2d5fdb Mon Sep 17 00:00:00 2001 From: Ian Jackson Date: Tue, 21 Jun 2022 22:10:19 +0100 Subject: [PATCH] script: on insert, call piece_modify, implying _image Previously, we ad-hoc open-coded: delem.innerHTML = info.svg p.pelem = pelem, p.uos = info.uos; piece_resolve_special(piece, p); but this forgot: p.bbox = info.bbox; p.desc = info.desc; Signed-off-by: Ian Jackson --- templates/script.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/templates/script.ts b/templates/script.ts index a01b19df..f63cd01f 100644 --- a/templates/script.ts +++ b/templates/script.ts @@ -1914,7 +1914,6 @@ function insert_piece(piece: PieceId, xp: any, console.log('PIECE UPDATE INSERT ',piece,info) let delem = document.createElementNS(svg_ns,'defs'); delem.setAttributeNS(null,'id','defs'+piece); - delem.innerHTML = info.svg; defs_marker.insertAdjacentElement('afterend', delem); let pelem = piece_element('piece',piece); let uelem = document.createElementNS(svg_ns,'use'); @@ -1923,14 +1922,11 @@ function insert_piece(piece: PieceId, xp: any, uelem.setAttributeNS(null,'data-piece',piece); let p = { uelem: uelem, - pelem: pelem, delem: delem, } as any as PieceInfo; // fudge this, piece_modify_core will fix it pieces[piece] = p; - p.uos = info.uos; p.queued_moves = 0; - piece_resolve_special(piece, p); - piece_modify_core(piece, p, info); + piece_modify(piece, p, info); return p; } -- 2.30.2