From 3a4efbff2e729194d286f483bd8e122c52ff1129 Mon Sep 17 00:00:00 2001 From: Thomas Hindoe Paaboel Andersen Date: Wed, 25 Feb 2015 23:10:35 +0100 Subject: [PATCH] bootctl: check that partition uuid is valid It probably is but check anyway to make coverity happy. CID#1271354 --- src/boot/bootctl.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/boot/bootctl.c b/src/boot/bootctl.c index fb568bebb..bd55fa95b 100644 --- a/src/boot/bootctl.c +++ b/src/boot/bootctl.c @@ -177,7 +177,13 @@ static int verify_esp(const char *p, uint32_t *part, uint64_t *pstart, uint64_t fprintf(stderr, "Failed to probe partition entry UUID %s: %s\n", p, strerror(-r)); goto fail; } - sd_id128_from_string(v, uuid); + + r = sd_id128_from_string(v, uuid); + if (r < 0) { + fprintf(stderr, "Partition %s has invalid UUID: %s\n", p, v); + r = -EIO; + goto fail; + } errno = 0; r = blkid_probe_lookup_value(b, "PART_ENTRY_NUMBER", &v, NULL); -- 2.30.2