From 34a34052085498680b9a0a9f21faf2d54d893962 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Daniel=20Mart=C3=AD?= <mvdan@mvdan.cc>
Date: Sat, 13 Sep 2014 13:04:24 +0200
Subject: [PATCH] Centralise handling of default gradle flavours

---
 fdroidserver/build.py        |  3 ---
 fdroidserver/checkupdates.py |  2 --
 fdroidserver/common.py       | 11 ++++-------
 fdroidserver/metadata.py     |  6 +++++-
 4 files changed, 9 insertions(+), 13 deletions(-)

diff --git a/fdroidserver/build.py b/fdroidserver/build.py
index 836835de..bee4280b 100644
--- a/fdroidserver/build.py
+++ b/fdroidserver/build.py
@@ -682,9 +682,6 @@ def build_local(app, thisbuild, vcs, build_dir, output_dir, srclib_dir, extlib_d
         logging.info("Building Gradle project...")
         flavours = thisbuild['gradle']
 
-        if len(flavours) == 1 and flavours[0] in ['main', 'yes', '']:
-            flavours[0] = ''
-
         commands = [config['gradle']]
         if thisbuild['preassemble']:
             commands += thisbuild['preassemble'].split()
diff --git a/fdroidserver/checkupdates.py b/fdroidserver/checkupdates.py
index 9bfd1151..2f92b51f 100644
--- a/fdroidserver/checkupdates.py
+++ b/fdroidserver/checkupdates.py
@@ -358,8 +358,6 @@ def fetch_autoname(app, tag):
             app_dir = os.path.join(app_dir, app['builds'][-1]['subdir'])
         if app['builds'][-1]['gradle']:
             flavours = app['builds'][-1]['gradle']
-    if len(flavours) == 1 and flavours[0] in ['main', 'yes', '']:
-        flavours = None
 
     logging.debug("...fetch auto name from " + app_dir)
     new_name = common.fetch_real_name(app_dir, flavours)
diff --git a/fdroidserver/common.py b/fdroidserver/common.py
index 6e6dfbc0..b18b0ef1 100644
--- a/fdroidserver/common.py
+++ b/fdroidserver/common.py
@@ -833,10 +833,9 @@ def manifest_paths(app_dir, flavours):
          os.path.join(app_dir, 'src', 'AndroidManifest.xml'),
          os.path.join(app_dir, 'build.gradle')]
 
-    if flavours:
-        for flavour in flavours:
-            possible_manifests.append(
-                os.path.join(app_dir, 'src', flavour, 'AndroidManifest.xml'))
+    for flavour in flavours:
+        possible_manifests.append(
+            os.path.join(app_dir, 'src', flavour, 'AndroidManifest.xml'))
 
     return [path for path in possible_manifests if os.path.isfile(path)]
 
@@ -1210,11 +1209,9 @@ def prepare_source(vcs, app, build, build_dir, srclib_dir, extlib_dir, onserver=
         f.write(props)
         f.close()
 
-    flavours = None
+    flavours = []
     if build['type'] == 'gradle':
         flavours = build['gradle']
-        if len(flavours) == 1 and flavours[0] in ['main', 'yes', '']:
-            flavours = None
 
         version_regex = re.compile(r".*'com\.android\.tools\.build:gradle:([^\.]+\.[^\.]+).*'.*")
         gradlepluginver = None
diff --git a/fdroidserver/metadata.py b/fdroidserver/metadata.py
index 0b0106d0..7ac589df 100644
--- a/fdroidserver/metadata.py
+++ b/fdroidserver/metadata.py
@@ -601,7 +601,11 @@ def parse_metadata(metafile):
         t = flagtype(pk)
         if t == 'list':
             # Port legacy ';' separators
-            thisbuild[pk] = [v.strip() for v in pv.replace(';', ',').split(',')]
+            pv = [v.strip() for v in pv.replace(';', ',').split(',')]
+            if pk == 'gradle':
+                if len(pv) == 1 and pv[0] in ['main', 'yes', '']:
+                    pv = []
+            thisbuild[pk] = pv
         elif t == 'string' or t == 'script':
             thisbuild[pk] = pv
         elif t == 'bool':
-- 
2.30.2