svg size handling: Rename and move svg_parse_size

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

utils: Drop EmptyType

It turns out that there already weren't any use sites.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

utils: Drop some unused bits

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

utils: Tidy up and move DigestRead and DigestWrite

Now this file is more navigable.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

svg size handling: Introduce new size parser

We want to get the size out of the svg on load, to make the library
spec size attribute optional (and to make things less confusing).
So start by add code to parse size out of an SVG.

But in fact it turns out we have one of these in bundle processing
already.  The need to be combined.  But for now, commit what we have.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Fix an error message typo

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

usvg-processor: Be a bit more verbose in error messages

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

currency: Example

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

currency: Document

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

dice: Document

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

at-currency: Test merging properly

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: handle Delete

We blank out the info in the slot.  That's probably the best we can do
with the current data model.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

at-currency: Rename variables

This was getting quite confusing.  I think this scheme is less so.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

at-currency: More test

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: Recorded: Do not overwrite with nulls

Some of these fields are Option, and if None, should nto overwrite
existing data.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

at-currency: Add spaces in desc patterns

We don't want to match numbers which happen to end with our pattern!

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

at-currency: Break out PieceInfo::assert_desc_contains

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

at-currency: rename bn to bn1

These are being taken in sequence.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Replace make_svg_defs with render

This now demonstrates that there aren't any more svg generation sites
that forget to propagate a possibly-changed desc.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

at-currency: Check that descriptions (ie, qts) change

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Properly update desc in Recorded updates

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

at-currency: Use find_by_desc_glob

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

at-currency: Use currency symbol to find in desc

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

script: Demonstrate that we can use the desc in a log message

We can now improve many more messages, but I have other fish to fry ATM.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Correct sense of pin/unpin log message

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Provide desc even in piece updates, and note in script.ts

This has always been provided, properly occulted, during session load,
but not provided in updates.  And all this time I have been writing
JS-generated log messages under the assumption that the JS can't
describe pieces.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

at-currency: Use synchu to synchronise, to update a_pieces

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: implement MoveQuiet

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: implement Insert

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: move p unwraps

So that we can do Insert

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: drop a dbg and the parameter it uses

I'm not sure why nick is passed here.  Whatever.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: reorder generics to match argument order

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: panic on unknown updates

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: explicitly ignore Log

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: explicitly ignore various other updates

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: explicitly ignore SetTable*

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: handle RecordedUnpredictable

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: explicitly ignore MoveHist*

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: handle Image

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: Introduce and use JsV extension extend

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: Always call findp

This makes the code smaller.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updates: Refactor findp again

I keep shilly-shallying.  I think I want this to be called all the time.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: Add a comment about what PieceInfo<JsV> means

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updatess: Implement Recorded

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: updatess: Expect to find the pieces we are updating

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: Break out findp

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: Introduce and use JsV extension set

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: fold lines longer

Mostly they don't fold now.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: Refactor to make room for handling more piece ops

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

apitest: Add a bit of logging

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

at-currency: wip

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

currency: Fix the log message

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

fastsplit_delete: Implement, and use in currency

Amazingly, this seems to work at least in my basic ad-hoc test.
The log message needs a little work.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

held_change_hook: Pass some more arguments

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

ToReculculate: Slightly improve docs and formatting of with

This was a bit confusing at first.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

ToRecalculate: Refactor implement methods

These are more convenient now, and the authorisation trickery is
now where we can more clearly justify it.

Acked-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

delete_piece: Plumb PieceUpdateOp, and document re log

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

delete_piece: Break out into global.rs

fastsplit deletion is going to want this.  This may not be in its
final form, particularly because of ToRecalculate, which fastsplit
doesn't have one of yet.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

rename GOccults from GameOccults

Tried to refer to it as GOccults (without looking it up) and obviously
that's what it ought to be.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Remove a pointless function

This seems to just recurse to itself.  Deleting it leaves everything
still compiling.  How odd.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Change many .drain(..) into into_iter()

In Rust 2021 this is more convenient to write.  We retain one.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Miscellaneous cleanups prompted by clippy

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

OpOutcomeThunk: replace the other open-coded resolution site

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

OpOutcomeThunk: change resolve to be method on thunk

The other call site (which will come in a moment) doesn't have a
Result.  And this was a bit too cooked anyway.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Introduce OpOutcomeThunkGeneric resolve on Result

On the way to getting rid of the other ad-hoc resolution site.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Genericise OpOutcomeThunk

So that we can centralise resolution.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

OpOutcomeThunk: Fix typo in comment

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Replace an open-coded into_unprepared call

Found this will looking at this code.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Optimise into_unprepared slightly

Prompted by seeing this optimisation at what ought to be a call site
of this method.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Introduce OpHookThunk

Currency merge needs this so that it can reborrow ipieces to delete
one of the merged notes.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

OpOutcomeThunk: Rationalise doc comment

Most of this comment is from earlier thoughts about how to solve the
problme that fastsplit now solves, and much of it wasn't really right.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Fix a tiny whitespace error

Noticed in passing.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

script: Allow multiselect of large numbers

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

script: In error handler, use piece_checkconflict_nrda

This arranges that we stop drag if our grab failed for reasons other
than a conflict which is obvious to us.  Eg, insufficient currency.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

script: piece_checkconflict_nrda: abolish unused return value

This was always false, and no longer used apparently.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Introduce and use PieceTraitDowncastFailed error

We want this to be cheap to make - not InternalError which contains a
stack trace - so that we can use downcast_piece in contexts where it's
not an error.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Introduce and use downcast_piece_fastsplit

Currency wants this.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Introduce and use PiceTrait downcaste_piece extension methoc

This is more convenient.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

gamestate: Add divider comment

We're going to add more above here, and it's getting big.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

fastsplit: Move Z check from multigrab into fastsplit impl

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

fastsplit: Correct z order

This was back to front.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Reorganise Z setting into two phases

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Move op_do_set_z to gamestate

This is preparatory, to reduce diff noise.  We're going to change the
way this works in a moment.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

fastsplit: Move a comment to its right place

Some time in the development of this, pre-squash, kthe modperm was
acquired within the infallible closure.  But when it was moved,
evidently the comment didn't move with it.  Fix that.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

fastsplit: Fix recovery

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

currency: Fix and improve multigrab (splitting) log message

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

multigrab/fastsplit: Plumb ShowUnocculted and &PieceTrait

The implementation doesn't really want PieceRenderingInstructions,
just permission to get at trait objects.

The currency fastsplit implementation callback is going to want to
look at its Banknote so that it can make a nice log message.  I think
fastsplit piece impls are entitled access to their concret piece type.
So downcast it, and pass it down the layers.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

PieceTrait: impl Downcast

We're going to want this in a moment.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

currency: Many fixes to splitting

This was quite broken.

* Actually set the value of the new (change) piece.
* Set the value of tghe taken piece correctly.
* Set the WRC so that clients see the taken piece value.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

currency: Move some assignments about

Tidying up.  No functional change.
(Was originally part of the next, bugfix, commit.)

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

currency: Rename value

Having the two pieces here is confusing.  All the variables should say
which piece they are.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

currency: wip test

So far we test that splitting appears to succeed, but not what the
results look like.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

currency: Implement op_multigrab and therefore splitting

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
ng

fastsplit: Implement splitting

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

currency: Make currency pieces be fastsplit

The actual machinery does all the hard work.

This shouldn't have any overall visible functional change.  It just
engages new contraptions during piece creation and load/save, but
right now they shouldn't have any work to do because we don't actually
ever split (or merge) currency.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

fastsplit: Add some imprecations about not dropping FastSplitId

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

fastsplit: Introduce fastsplit concept

This has all the relevant data structures and support code, but does
not yet implemnet the actual splitting and deleting/merging
operations which will be needed for the piece api op impls.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

Drop an unneeded lifetime argument

This is not needed.  (I'm not sure whether I did this because
ambassador didn't like the lifetime argument, or just because I saw it
in passing.)

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

ambassador: Introduce dependency and make some traits delegatiable

fastsplit pieces are going to want to delegate everything.  Not only
is this a lot of typing, open-coding it risks bugs when new trait
methods are added.

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>

multigrab: Set the z coordinate

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>