chiark / gitweb /
Ian Jackson [Wed, 14 Jul 2021 23:26:39 +0000 (00:26 +0100)]
CHANGELOG: Documentation of changes, formatting
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 23:14:28 +0000 (00:14 +0100)]
CHANGELOG: Documentation of changes (wip)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 22:52:47 +0000 (23:52 +0100)]
CHANGELOG: Documentation of changes (wip)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 22:21:38 +0000 (23:21 +0100)]
script: Fix handling of mixed actions (clashing keystrokes)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 18:49:21 +0000 (19:49 +0100)]
player labels: Do not print pointless ???
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 5 Apr 2021 11:37:45 +0000 (12:37 +0100)]
wdt-hand: Clean up after regrab-race
This will help when we add another test case here.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 5 Apr 2021 11:37:41 +0000 (12:37 +0100)]
wdt-hand: New test case for ungrab-then-regrab (2)
Check that the piece is now held by alice.
This fails without the grab/regrab fix.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 16:50:45 +0000 (17:50 +0100)]
wdt-hand: Do checks for both players
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 5 Apr 2021 11:27:29 +0000 (12:27 +0100)]
wdt-hand: New test case for ungrab-then-regrab (1)
Check that we don't get a conflict.
This fails without the grab/regrab fix.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 17:02:12 +0000 (18:02 +0100)]
regrab: Enable regrab (when not wresting)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 18:30:02 +0000 (19:30 +0100)]
wdt-simple: Allow "piece held by another player" as if it were conflict
Regrab will allow us to try to grab the thing, not mind that it
doesn't work, and then get this conflict.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 15:32:46 +0000 (16:32 +0100)]
loose: Track and honour cseq_loose in client
Not used yet
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 18:41:04 +0000 (19:41 +0100)]
wdt-hand: Do release mouse after alice click
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 16:31:53 +0000 (17:31 +0100)]
api: Loose ops: Make a loose conflicted op generate a Server update
As according to the PROTOCOL.md. This is no longer a client update,
and the client can't really reconcile it.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 15:34:49 +0000 (16:34 +0100)]
script: Abolish conflict_expected
This was always false. It was a bad attempt at conflict/error
handling, which is now done according to a properly thought-out
scheme.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 15:27:12 +0000 (16:27 +0100)]
script: Introduce plumbing for loose parameter (3)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 15:26:33 +0000 (16:26 +0100)]
script: Introduce plumbing for loose parameter (2)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 15:25:09 +0000 (16:25 +0100)]
script: Introduce plumbing for loose parameter
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 15:24:02 +0000 (16:24 +0100)]
script: Fix a formatting glitch
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 15:17:45 +0000 (16:17 +0100)]
api: Support loose grab op
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 15:17:24 +0000 (16:17 +0100)]
gamestate: Track last_released client
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 15:17:01 +0000 (16:17 +0100)]
api: Skeleton support for loose ops, pass ClientId
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 14 Jul 2021 15:03:44 +0000 (16:03 +0100)]
api: Skeleton support for loose ops
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 13:44:42 +0000 (14:44 +0100)]
PROTOCOL: Document regrab plan
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 18:20:28 +0000 (19:20 +0100)]
tests: wdt-bundles: Actually check for expected error report
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 15:41:35 +0000 (16:41 +0100)]
tests: wdt-bundles: Test overlapping occultations
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 18:20:08 +0000 (19:20 +0100)]
tests: wdt-bundles: Fix release in test
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 17:57:09 +0000 (18:57 +0100)]
errors: Handle Inapplicable errors in the client
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 18:20:45 +0000 (19:20 +0100)]
errors: Fix a message
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 17:39:16 +0000 (18:39 +0100)]
errors: Slightly better log message
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 17:38:59 +0000 (18:38 +0100)]
errors: Provide cseq in transmitted piece update errors
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 17:33:06 +0000 (18:33 +0100)]
errors: Make TUE::Error contain a bespoke TUE_P
This will make space for a cseq there too.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 15:33:13 +0000 (16:33 +0100)]
tests: wdt-bundles: Prepare for overlap (impossible) test
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 15:37:19 +0000 (16:37 +0100)]
tests: wdt-bundles: Drop explicit shift keys for uppercase letters
Empirically, it works without this.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 16:47:57 +0000 (17:47 +0100)]
tests: wdt-bundles: Synch after reset
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 15:24:01 +0000 (16:24 +0100)]
tests: wdt-bundles: Break out vatikan_with_deck
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 15:17:27 +0000 (16:17 +0100)]
tests: wdt-bundles: Break out VATIKAN_DECK and VATIKAN_HAND
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 15:08:15 +0000 (16:08 +0100)]
errors: Include error_msg in ESVU::PieceOpError
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 15:02:28 +0000 (16:02 +0100)]
errors: No longer impl Error for ESVU
Not sure why this was ever needed but it isn't any more.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 14:36:34 +0000 (15:36 +0100)]
errors: Rename FER alias for FatalErrorResponse
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 14:32:57 +0000 (15:32 +0100)]
errors: Abolish alias OE for Fatal
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 14:29:48 +0000 (15:29 +0100)]
errors: Abolish now-unused Fatal::PieceHeld
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 14:34:48 +0000 (15:34 +0100)]
errors: Fix some PieceHeld's
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 14:29:33 +0000 (15:29 +0100)]
errors: hand, deck: Use BadUiOperation for confusing conflicts
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 14:27:22 +0000 (15:27 +0100)]
errors: Abolish now-unused Fatal::PieceImmoveable
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 14:26:20 +0000 (15:26 +0100)]
errors: Make Ia::BadUiOperation
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 14:25:56 +0000 (15:25 +0100)]
errors: ui operation prevented by occultation gives Ia::Occultation
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 14:23:13 +0000 (15:23 +0100)]
errors: Make create_occultation return APOE, and change Overlapping
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 14:21:52 +0000 (15:21 +0100)]
errors: Abolish Fatal::Occultation
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 14:19:52 +0000 (15:19 +0100)]
errors: Make BadStateForOperation be Ia
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 14:17:34 +0000 (15:17 +0100)]
errors: Make check_held return Ia not Fatal
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 14:13:36 +0000 (15:13 +0100)]
errors: Provide custom Display impls for Inapplicable errors
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 14:10:23 +0000 (15:10 +0100)]
errors: Rename POE type alias to Ia
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 14:07:43 +0000 (15:07 +0100)]
errors: Rename error types according to new scheme
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 13:53:19 +0000 (14:53 +0100)]
PROTOCOL: Rename "impossible" to "inapplicable"
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 13:48:47 +0000 (14:48 +0100)]
errors: Abolish unused OnlineError::InvalidZCoord
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 13:47:11 +0000 (14:47 +0100)]
PROTOCOL: Document plan to treat some errors as bogus
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 13:44:29 +0000 (14:44 +0100)]
PROTOCOL: Some slight markup
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 12:23:17 +0000 (13:23 +0100)]
PROTOCOL: Document error handling (plans)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 12:08:46 +0000 (13:08 +0100)]
PROTOCOL: Formatting fix
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 12:08:27 +0000 (13:08 +0100)]
PROTOCOL: Fix a typo
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 13 Jul 2021 11:32:14 +0000 (12:32 +0100)]
PROTOCOL: Fix wrong ref to zcoord being an f64
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 17:13:52 +0000 (18:13 +0100)]
jst-lower: Increase amount of exhaustive testing
This is still very fast. I think it's doing around 2^(5*2) tests.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 12:23:04 +0000 (13:23 +0100)]
jst-lower: exhaustive: Use 1 for vpid vsn
This is clearer for the human reader.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 12:22:20 +0000 (13:22 +0100)]
jst-lower: exhaustive: Make no vpid have 0 as slot num
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 10:57:23 +0000 (11:57 +0100)]
jst-lower: Test cases exhaustive inputs autogenerator
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 18:10:02 +0000 (19:10 +0100)]
wdt-bundles: hidden: Have alice send a card to bottom
This generated a JS error until recent fixes.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 17:12:29 +0000 (18:12 +0100)]
script lower: Fix ordering of partP and partQ
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 16:54:52 +0000 (17:54 +0100)]
script lower: Fix handling of heavy targets
We need to keep walking if there are any, or they won't end up moved.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 16:59:18 +0000 (17:59 +0100)]
script lower: Fix a debug print for bottom -> heavy rename
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 12:37:02 +0000 (13:37 +0100)]
script lower: Rework and fix walk algorithm
We need to keep track whether we're in state B. bottommost_light is
not really good for that. Nor is it any use for figuring out what
starting z coordinate to select.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 17:24:41 +0000 (18:24 +0100)]
zccord: Add some more test cases
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 17:36:07 +0000 (18:36 +0100)]
zccord: Fix a panic in some iteration cases
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 18:08:11 +0000 (19:08 +0100)]
wdt-bundles: hidden: Have alice reselect a card just played
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 17:56:57 +0000 (18:56 +0100)]
wdt-bundles: hidden: Have alice play some cards
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 17:12:26 +0000 (18:12 +0100)]
script lower: Improve debug output
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 16:54:48 +0000 (17:54 +0100)]
jst-lower: Improve debug output
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 17:36:15 +0000 (18:36 +0100)]
zcoord: Add some commented-out debug
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 18:19:23 +0000 (19:19 +0100)]
wdt: Do not tolerate JS errors
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 17:30:32 +0000 (18:30 +0100)]
Make dbgc macro actually useable in base
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 17:29:06 +0000 (18:29 +0100)]
Move dbgc macro into base
We want it there for hacking about, at least.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 16:22:07 +0000 (17:22 +0100)]
lower: Change terminology, introduce "heavy" vs "light"
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 16:16:43 +0000 (17:16 +0100)]
lower: Change terminology, introduce "heavy" vs "light"
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 16:10:02 +0000 (17:10 +0100)]
script: lower: Improve debug slightly
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 15:44:28 +0000 (16:44 +0100)]
jst-lower: Make input debug output be in the same order as output
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 12:36:36 +0000 (13:36 +0100)]
script: lower: Bail early if no targets
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 15:24:28 +0000 (16:24 +0100)]
zcoord: Test bad ranges
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 15:19:33 +0000 (16:19 +0100)]
zcoord: Reject attempt to make range [X,X>
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 15:19:14 +0000 (16:19 +0100)]
zcoord: Make RangeImpossible into an enum
Preparing for rejecting empty ranges.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 15:07:16 +0000 (16:07 +0100)]
zcoord: document (and test a bit more) range_upto()
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 14:47:40 +0000 (15:47 +0100)]
zcoord: document iter()
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 14:53:35 +0000 (15:53 +0100)]
zcoord: test iter()
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 14:49:49 +0000 (15:49 +0100)]
zcoord: promote mk() into mod test
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 14:46:42 +0000 (15:46 +0100)]
internal docs: Fix some bogus links
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 12:20:27 +0000 (13:20 +0100)]
jstest: Better visibility of env vars to control logging etc.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 12:47:28 +0000 (13:47 +0100)]
jst-lower: Add a check that we do not duplicate z coordinates
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 12:17:24 +0000 (13:17 +0100)]
jstest: Improve debugging
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 12:11:03 +0000 (13:11 +0100)]
jstest: lower: comment out byhand version, for clutter reasons
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 12:11:19 +0000 (13:11 +0100)]
jstest: lower: Honour OTTER_JST_LOWER_ONLY
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 10 Jul 2021 12:00:52 +0000 (13:00 +0100)]
jstest: improve debugging output
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
~ianmdlvl / otter.git / log