chiark / gitweb /
Ian Jackson [Thu, 31 Mar 2022 19:56:12 +0000 (20:56 +0100)]
clippy: Miscellaneous minor changes, and allow lints
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 19:44:50 +0000 (20:44 +0100)]
clippy: Miscellaneous minor changes
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 19:39:56 +0000 (20:39 +0100)]
apitest: Fix a write() call that should be write_all()
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 19:39:47 +0000 (20:39 +0100)]
clippy: Miscellaneous minor changes, and allow lints
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 19:39:07 +0000 (20:39 +0100)]
Update TODOs
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 19:31:27 +0000 (20:31 +0100)]
Use Educe to impl Default on a couple of types in clisupport
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 19:25:30 +0000 (20:25 +0100)]
clippy: Miscellaneous minor changes, and allow lints
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 19:17:01 +0000 (20:17 +0100)]
clippy: Miscellaneous minor changes, and allow lints
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 19:12:40 +0000 (20:12 +0100)]
clippy: Miscellaneous minor changes, and allow lints
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 19:09:35 +0000 (20:09 +0100)]
parse_slice_hex: Fix to properly handle odd-length slices
Previously it would accept some of them, and parse them in a weird
way. I don't think this is actually important.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 19:09:22 +0000 (20:09 +0100)]
clippy: Miscellaneous minor changes
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 02:14:19 +0000 (03:14 +0100)]
clippy: Miscellaneous minor changes
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 02:11:09 +0000 (03:11 +0100)]
PlayerUpdates: Rename update log starting functions and types
Prompted by clippy complaining about the old weird new() function.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 02:00:56 +0000 (03:00 +0100)]
clippy: Miscellaneous minor changes, and allow lints
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 01:56:46 +0000 (02:56 +0100)]
termprogress: Rename reporter() functions returning Box<dyn>
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 01:52:58 +0000 (02:52 +0100)]
clippy: Miscellaneous minor changes
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 01:50:40 +0000 (02:50 +0100)]
clippy: Miscellaneous minor changes, and allow lints
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 01:46:07 +0000 (02:46 +0100)]
clippy: Miscellaneous minor changes, and allow lints
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 01:44:19 +0000 (02:44 +0100)]
packetframe: Fix a write() call that should be write_all()
I think this was probably a bug.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 01:43:49 +0000 (02:43 +0100)]
clippy: Miscellaneous minor changes
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 01:31:04 +0000 (02:31 +0100)]
clippy: Miscellaneous minor changes
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 01:25:56 +0000 (02:25 +0100)]
clippy: Suppress a buggy lint
This fires on process_all_players_for_account, but the collect
*is* needed and the suggestion doesn't compile.
I wasn't able to make a minimal repro, but there is what looks like a
report of the same thing (and many other issues with this lint).
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 01:17:03 +0000 (02:17 +0100)]
clippy: Miscellaneous minor changes
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 00:34:37 +0000 (01:34 +0100)]
RawToken: Replace constructor with a From impl
No functional change.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 00:34:27 +0000 (01:34 +0100)]
clippy: Miscellaneous minor changes
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 00:27:10 +0000 (01:27 +0100)]
clippy: Miscellaneous minor changes
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 00:21:33 +0000 (01:21 +0100)]
clippy: Prefer .len() > 0 to ! .is_empty()
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 00:21:24 +0000 (01:21 +0100)]
clippy: Miscellaneous minor changes, and allow lints
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 00:18:22 +0000 (01:18 +0100)]
clippy: Miscellaneous minor changes, and allow lints
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 00:13:22 +0000 (01:13 +0100)]
InstanceBundles: impl Default and use that for new()
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 00:13:16 +0000 (01:13 +0100)]
clippy: Miscellaneous minor changes, and allow lints
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 00:10:19 +0000 (01:10 +0100)]
asseturl: Fix a wrong call to write, to be write_all
In practice this bug is latent, buecause DigestWrite will take the
whole thing.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 00:06:54 +0000 (01:06 +0100)]
clippy: Miscellaneous minor changes, and allow lints
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Thu, 31 Mar 2022 00:03:04 +0000 (01:03 +0100)]
clippy: Miscellaneous minor changes
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 23:57:24 +0000 (00:57 +0100)]
zcoord: Move from_str impl for Mutable to be FromStr impl
Suggested by clippy.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 23:55:41 +0000 (00:55 +0100)]
zcoord: Move from_str impl to be (only) in FromStr impl
Suggested by clippy.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 23:54:35 +0000 (00:54 +0100)]
zcoord: Remove redundant to_string method
This is the same as the Display impl. Suggested by clippy.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 23:53:47 +0000 (00:53 +0100)]
clippy: allow some lints
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 23:53:40 +0000 (00:53 +0100)]
clippy: Miscellaneous minor changes
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 23:38:13 +0000 (00:38 +0100)]
clippy: Miscellaneous minor changes
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 23:36:09 +0000 (00:36 +0100)]
Html type: impl Default and derive new()
Default suggested by clippy.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 23:35:32 +0000 (00:35 +0100)]
Makefile: Support for controlling the Rust version
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 23:28:37 +0000 (00:28 +0100)]
clippy: allow some lints
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 23:26:41 +0000 (00:26 +0100)]
clippy: wip machinery, and transfer the one allowed lint so far
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 22:58:15 +0000 (23:58 +0100)]
actix: Drop a leftover dbg
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 22:55:57 +0000 (23:55 +0100)]
Drop remaining feature enablements.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 22:55:41 +0000 (23:55 +0100)]
Remove one use of TAIT
This is our remaining usntable feature.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 22:54:36 +0000 (23:54 +0100)]
Drop IteratorExt extension trait
We used this once. Not a successful experiment I think.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 22:43:02 +0000 (23:43 +0100)]
actix: Document the situation with HEAD etc.
This is not very good really, but I guess it will do for now.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 22:22:07 +0000 (23:22 +0100)]
daemon: Remove a stray commented-out import thing.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 21:26:30 +0000 (22:26 +0100)]
actix Files: Work around content-type breakage
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 21:45:23 +0000 (22:45 +0100)]
actix Files: Do our content-type mangling first
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 20:59:25 +0000 (21:59 +0100)]
actix Files: Break out FILES_PATH
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 20:57:52 +0000 (21:57 +0100)]
actix Files: change error handling for middleware fixup fn
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 20:39:11 +0000 (21:39 +0100)]
actix files content-type fixup: wip, call fn middlware
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 30 Mar 2022 19:46:54 +0000 (20:46 +0100)]
daemon: Fix whitespace error
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 29 Mar 2022 23:52:06 +0000 (00:52 +0100)]
Abolish JsonLen and json_len
This was for SSE buffer management, but we don't need it now.
And it was quite fiddly!
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 29 Mar 2022 23:46:41 +0000 (00:46 +0100)]
SSE: Adjust error handling somewhat
Have UpdateReader::read throw a bespoke error.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Tue, 29 Mar 2022 20:45:29 +0000 (21:45 +0100)]
SSE: Redo buffer handling
Now we just write into a Vec. This is rather simpler.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 28 Mar 2022 01:40:10 +0000 (02:40 +0100)]
Refine a TODO
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 28 Mar 2022 01:19:09 +0000 (02:19 +0100)]
server: Support explicit specification of addresses to listen on
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 28 Mar 2022 01:08:22 +0000 (02:08 +0100)]
server: Move listening address config resolution to config
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 28 Mar 2022 01:04:07 +0000 (02:04 +0100)]
server: Listen on localhost only by default, regardless of debug
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 28 Mar 2022 01:01:53 +0000 (02:01 +0100)]
server: Listen on port 8000 by default, regardless of debug
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 28 Mar 2022 01:09:19 +0000 (02:09 +0100)]
Note a TODO
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 28 Mar 2022 01:00:22 +0000 (02:00 +0100)]
actix routing: Use a conventional prefix for route "function" names
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 28 Mar 2022 00:56:06 +0000 (01:56 +0100)]
resource leaf routing: Document why we're leaving it order-sensitive
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 28 Mar 2022 00:52:11 +0000 (01:52 +0100)]
Revert "resource leaf routing: Attempt via impl FromRequest"
This reverts commit
383fab0156489a705901ba06580c60215dc313c6.
Ian Jackson [Mon, 28 Mar 2022 00:40:58 +0000 (01:40 +0100)]
resource leaf routing: Attempt via impl FromRequest
I wrote this thinking that implementing FromRequest, so that we can
return Status::NOT_FOUND would work to pass on to the next route.
But, no.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 28 Mar 2022 00:41:47 +0000 (01:41 +0100)]
Tidying: Simplify a unit error struct
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 28 Mar 2022 00:36:56 +0000 (01:36 +0100)]
actix cleanup: import futures::future
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 28 Mar 2022 00:36:20 +0000 (01:36 +0100)]
actix cleanup: Minor reformattint
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 28 Mar 2022 00:11:38 +0000 (01:11 +0100)]
Cargo.nail: Drop our own directory
We aren't nailing anything right now.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 28 Mar 2022 00:12:17 +0000 (01:12 +0100)]
web templates: Use stem for template names (without .tera extension)
This moves a bit of code to startup, and makes the macro use a bit
cleaner again.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Mon, 28 Mar 2022 00:07:37 +0000 (01:07 +0100)]
web templates: Provide our own directory scanner
We don't know exactly what Tera::new() does, but in any case we want
to do something it doesn't support: have template names which do not
contain the .tera file extension.
No functional change in this commit.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 22:54:10 +0000 (23:54 +0100)]
Rocket cleanup: Call our tera tera
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 22:41:35 +0000 (23:41 +0100)]
actix cleanup: Note a done todo
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 22:41:12 +0000 (23:41 +0100)]
actix cleanup: Remove actix test programs
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 22:40:14 +0000 (23:40 +0100)]
Revert "Mutex debug: Enable it (for demo and testing)"
This reverts commit
7456a32426e6b4a487adcc279db4547639a0ffba.
Ian Jackson [Sun, 27 Mar 2022 12:54:15 +0000 (13:54 +0100)]
Mutex debug: Actually add some debug messages.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 12:54:01 +0000 (13:54 +0100)]
Mutex debug: Use Debug for DebugIdentify, not Display
This will make the types useable with dbg!.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 12:32:24 +0000 (13:32 +0100)]
Mutex debug: Introduce DebugIdentify trait
And implement it for many of our types.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 22:31:03 +0000 (23:31 +0100)]
Mutex debug: Enable it (for demo and testing)
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 11:47:08 +0000 (12:47 +0100)]
Mutex debug: Add example (commented out) of engaging it
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 11:46:54 +0000 (12:46 +0100)]
Mutex debug: Introduce Mutex and guard types
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 21:54:34 +0000 (22:54 +0100)]
actix: add Debug bound to Deserialize trait for Parse
We don't actually use this but it makes some dbg!() work if in case we
need them.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 26 Mar 2022 14:14:05 +0000 (14:14 +0000)]
actix conversion: Update docs
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 26 Mar 2022 14:13:51 +0000 (14:13 +0000)]
Rocket cleanup: Remove some workarounds from config templates
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Wed, 23 Mar 2022 22:11:58 +0000 (22:11 +0000)]
Rocket cleanup: Remove Rocket dependencies
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 21:52:55 +0000 (22:52 +0100)]
Rocket cleanup: Remove rocket_workers config variable
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 26 Mar 2022 22:53:57 +0000 (22:53 +0000)]
actix: Log an error if we have an internal server error
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 19:14:28 +0000 (20:14 +0100)]
actix: Add logging
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 19:11:30 +0000 (20:11 +0100)]
actix: Reorder calls on App to put the neader middleware last etc.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 23:50:10 +0000 (00:50 +0100)]
actix: Replace Rocket
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 14:58:31 +0000 (15:58 +0100)]
actix: Final dependencies for conversion
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 26 Mar 2022 13:43:52 +0000 (13:43 +0000)]
actix: experiments: Test program: CORS
Partially C&P from Actix docs.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 19 Mar 2022 19:09:54 +0000 (19:09 +0000)]
actix: experiments: Test program: nosniff header
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 19 Mar 2022 18:54:20 +0000 (18:54 +0000)]
actix: experiments: Files test with not found handler
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sun, 27 Mar 2022 20:18:24 +0000 (21:18 +0100)]
actix: experiments: Files test example program
More C&P from Actix docs.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Ian Jackson [Sat, 19 Mar 2022 17:01:24 +0000 (17:01 +0000)]
actix: experiments: More test example program, with not found handler
Partially C&P from Actix docs.
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
~ianmdlvl / otter.git / log