From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Tue, 7 Jul 2020 20:08:25 +0000 (+0100)
Subject: gardening todos
X-Git-Tag: otter-0.2.0~1416
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=fd6b0b126b5ba400df4a6be4f03b9903f53e32a0;p=otter.git

gardening todos
---

diff --git a/src/bin/server.rs b/src/bin/server.rs
index 560ec360..285ce9fb 100644
--- a/src/bin/server.rs
+++ b/src/bin/server.rs
@@ -1,5 +1,6 @@
 
 // xxx need button(s) to kill old clients
+// and/or cause players to release grabs
 // ? need expiry of old clients?  limit of client count?
 
 #![feature(proc_macro_hygiene, decl_macro)]
@@ -333,7 +334,7 @@ fn updates(ctoken : InstanceAccess<ClientId>, gen: u64)
   let gen = Generation(gen);
   let iad = ctoken.i;
   let content = sse::content(iad, gen)?;
-  let content = response::Stream::chunked(content, 4096 /* xxx */);
+  let content = response::Stream::chunked(content, 4096);
   const CTYPE : &str = "text/event-stream; charset=utf-8";
   let ctype = ContentType::parse_flexible(CTYPE).unwrap();
   // xxx set CORS allowed header
@@ -342,7 +343,7 @@ fn updates(ctoken : InstanceAccess<ClientId>, gen: u64)
 
 #[get("/_/<leaf>")]
 fn resource(leaf : CheckedResourceLeaf) -> io::Result<NamedFile> {
-  let template_dir = "templates"; // xxx
+  let template_dir = "templates";
   NamedFile::open(format!("{}/{}", template_dir, leaf.safe))
 }  
 
diff --git a/src/gamestate.rs b/src/gamestate.rs
index 25ab0af4..cdd4a3e4 100644
--- a/src/gamestate.rs
+++ b/src/gamestate.rs
@@ -83,12 +83,10 @@ impl PieceRecord {
       pos        : self.pos,
       held       : self.held,
       svg        : self.make_defs(pri),
-      // xxx want all piece's stuff in the same def
     }
   }
 
   pub fn describe_html(&self, pri : &PieceRenderInstructions) -> String {
-    // xxx want to be able to hide things
     self.p.describe_html(Some(pri.face))
   }
 }