From: Daniel Martí <mvdan@mvdan.cc>
Date: Sun, 24 Aug 2014 22:27:46 +0000 (+0200)
Subject: Fix "no such package" search logic
X-Git-Tag: 0.3.0~81
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=f7f8c800181a8d237bfdc061c4ab651ef3306366;p=fdroidserver.git

Fix "no such package" search logic
---

diff --git a/fdroidserver/common.py b/fdroidserver/common.py
index aeb4e6da..e5a18fc5 100644
--- a/fdroidserver/common.py
+++ b/fdroidserver/common.py
@@ -273,9 +273,8 @@ def read_app_args(args, allapps, allow_vercodes=False):
             apps[appid] = app
 
     if len(apps) != len(vercodes):
-        allids = [app["id"] for app in allapps]
         for p in vercodes:
-            if p not in allids:
+            if p not in allapps:
                 logging.critical("No such package: %s" % p)
         raise FDroidException("Found invalid app ids in arguments")
     if not apps: