From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Thu, 31 Mar 2022 01:25:56 +0000 (+0100)
Subject: clippy: Suppress a buggy lint
X-Git-Tag: otter-1.0.0~45
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=f1cde1493e124658bf90c03266f31fbdb5d7fed0;p=otter.git

clippy: Suppress a buggy lint

This fires on process_all_players_for_account, but the collect
*is* needed and the suggestion doesn't compile.

I wasn't able to make a minimal repro, but there is what looks like a
report of the same thing (and many other issues with this lint).

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/clippy-options b/clippy-options
index db2ad2d9..12f8a439 100644
--- a/clippy-options
+++ b/clippy-options
@@ -23,3 +23,4 @@
 -A clippy::len_zero
 -A clippy::len_without_is_empty # I prefer comparing .len() to 0, apparently
 -A clippy::blocks_in_if_conditions
+-A clippy::needless_collect # rust-clippy/issues/8046, since Nov 2021 at least