From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Wed, 23 Dec 2020 00:06:22 +0000 (+0000)
Subject: refactor nfc, fix
X-Git-Tag: otter-0.2.0~159
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=e1e7fa100ab3ae03e33b8a12c6e7ce46b97e939d;p=otter.git

refactor nfc, fix

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/wdriver.rs b/wdriver.rs
index a48824d9..10233c75 100644
--- a/wdriver.rs
+++ b/wdriver.rs
@@ -106,6 +106,7 @@ fn prepare_tmpdir(opts: &Opts, current_exe: &str) -> String {
 
 #[throws(AE)]
 fn fork_something_which_prints(mut cmd: Command) -> String {
+  cmd.stdout(Stdio::piped());
   let mut child = cmd.spawn().context("spawn")?;
   let mut report = BufReader::new(child.stdout.take().unwrap()).lines();
 
@@ -138,8 +139,7 @@ fn prepare_xserver() {
            -terminate \
            -wr \
            -displayfd 1".split(' '))
-    .arg(format!(":{}", DISPLAY))
-    .stdout(Stdio::piped());
+    .arg(format!(":{}", DISPLAY));
 
   let l = fork_something_which_prints(xcmd).context("Xvfb")?;