From: Daniel Martí <mvdan@mvdan.cc>
Date: Sun, 9 Nov 2014 13:36:58 +0000 (+0100)
Subject: Properly catch return codes since -x is no longer used
X-Git-Tag: 0.3.0~23
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=c91fca7bb4e75cbdcde892a0198d0954f2c35f6e;p=fdroidserver.git

Properly catch return codes since -x is no longer used
---

diff --git a/hooks/pre-commit b/hooks/pre-commit
index 9abcc0a2..e4457023 100755
--- a/hooks/pre-commit
+++ b/hooks/pre-commit
@@ -37,20 +37,22 @@ else
 fi
 
 # If there are python errors or warnings, print them and fail.
-$PYFLAKES $PY_FILES
-$PEP8 --ignore=E123,E501 $PY_FILES
+
+if ! $PYFLAKES $PY_FILES; then
+	err "pyflakes tests failed!"
+fi
+
+if ! $PEP8 --ignore=E123,E501 $PY_FILES; then
+	err "pep8 tests failed!"
+fi
 
 
-#------------------------------------------------------------------------------#
-# check the syntax of included shell scripts
+# check the syntax of included shell scripts with bash -n
 
-# use bash to check that the syntax is correct
 for f in $SH_FILES; do
-    if bash -n $f; then
-        : # success! do nothing
-    else
-        err "FAILED!"
-    fi
+	if ! bash -n $f; then
+		err "bash tests failed!"
+	fi
 done
 
 exit 0