From: Hans-Christoph Steiner <hans@eds.org>
Date: Tue, 3 Jun 2014 17:39:11 +0000 (-0400)
Subject: update: improve warning about APKs set to be debuggable
X-Git-Tag: 0.2~42^2~3
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=c81ff764a3286bb72b0d547e67ca044b97ed2d2e;p=fdroidserver.git

update: improve warning about APKs set to be debuggable

This uses the actual XML code used to set this flag making the warning
message easily searchable on the interwebs.
---

diff --git a/fdroidserver/update.py b/fdroidserver/update.py
index aca6b994..8cd6b0e3 100644
--- a/fdroidserver/update.py
+++ b/fdroidserver/update.py
@@ -452,7 +452,7 @@ def scan_apks(apps, apkcache, repodir, knownapks):
 
             # Check for debuggable apks...
             if common.isApkDebuggable(apkfile, config):
-                logging.warn("{0} is debuggable... {1}".format(apkfile, line))
+                logging.warn('{0} is set to android:debuggable="true"!'.format(apkfile))
 
             # Calculate the sha256...
             sha = hashlib.sha256()