From: Ian Jackson <ijackson@chiark.greenend.org.uk>
Date: Tue, 14 Apr 2020 00:27:14 +0000 (+0100)
Subject: camera-mount: refactor/fix l handling (nfc)
X-Git-Url: https://www.chiark.greenend.org.uk/ucgi/~ianmdlvl/git?a=commitdiff_plain;h=c7b81b34618040c154406e0012829da0b488c3b1;p=reprap-play.git

camera-mount: refactor/fix l handling (nfc)

Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
---

diff --git a/camera-mount.scad b/camera-mount.scad
index 38c1016..fec9096 100644
--- a/camera-mount.scad
+++ b/camera-mount.scad
@@ -12,20 +12,17 @@ negative_pitch = inch/negative_tpi;
 negative_chamfer = negative_pitch/2;
 
 module CameraMountThread(l){
-  translate([0,0, midsection]) {
+  rotate([0,180,0])
     english_thread(diameter=negative_dia/inch,
 		   threads_per_inch=negative_tpi,
 		   leadin=0, internal=true, test=$test,
 		   length= (l + inch/19) / inch);
-    translate([0,0, l]) {
-      hull(){
-	translate([0,0, negative_chamfer])
-	  cylinder(r= negative_dia/2 + negative_chamfer*2,
-		   h=1);
-	mirror([0,0,1])
-	  cylinder(r= negative_dia/2 - negative_chamfer*2,
+  hull(){
+    translate([0,0, negative_chamfer])
+      cylinder(r= negative_dia/2 + negative_chamfer*2,
+	       h=1);
+    mirror([0,0,1])
+      cylinder(r= negative_dia/2 - negative_chamfer*2,
 		   h= negative_chamfer*3);
-      }
-    }
   }
 }
diff --git a/mic-camera-adapter.scad b/mic-camera-adapter.scad
index 439f460..6c16d0f 100644
--- a/mic-camera-adapter.scad
+++ b/mic-camera-adapter.scad
@@ -45,7 +45,8 @@ module Adapter(){
 	  }
 	}
       }
-      CameraMountThread(negative_l);
+      translate([0,0, midsection + negative_l])
+	CameraMountThread(negative_l);
     }
   }
 }